@asteby/metacore-runtime-react 29.0.1 → 29.0.2

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # @asteby/metacore-runtime-react
 
+## 29.0.2
+
+### Patch Changes
+
+- c0c8cb2: fix(hotswap): al recibir `ADDON_MANIFEST_CHANGED`, si la invalidación scopeada
+  no elimina ninguna entrada (el caso real: la metadata se cachea por nombre de
+  TABLA — `purchase_order_items`, `suppliers` — que no lleva el prefijo del
+  addon), se limpia TODO el cache de metadata como fallback. Antes, actualizar un
+  addon dejaba el label/ref viejo en el store persistido y el usuario tenía que
+  borrar datos del sitio a mano para ver la metadata fresca. Un cambio de manifest
+  es infrecuente (install/upgrade), así que el refetch perezoso en el próximo
+  montaje es barato y correcto.
+
 ## 29.0.1
 
 ### Patch Changes

package/dist/manifest-hotswap-subscriber.d.ts

@@ -45,7 +45,9 @@ export interface WireHotSwapInvalidationOptions {
      * Useful for hosts that want to log/observe hot-swaps or trigger a
      * `window.location.reload()` when the running addon's bundle hash
      * changes (see the module-level comment above for the trade-off).
-     * `removed` is the number of cache entries flushed for this addon.
+     * `removed` is the number of cache entries flushed for this addon, or
+     * `-1` when the scoped matcher found nothing and the whole metadata
+     * cache was cleared as a fallback (see `wireHotSwapInvalidation`).
      */
     onSwap?: (msg: AddonManifestChangedMessage, removed: number) => void;
 }

package/dist/manifest-hotswap-subscriber.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"manifest-hotswap-subscriber.d.ts","sourceRoot":"","sources":["../src/manifest-hotswap-subscriber.ts"],"names":[],"mappings":"AA6CA,OAAO,EAAoB,KAAK,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAEzE;;;;GAIG;AACH,eAAO,MAAM,2BAA2B,EAAG,wBAAiC,CAAA;AAE5E;;;;GAIG;AACH,MAAM,WAAW,2BAA2B;IACxC,IAAI,EAAE,OAAO,2BAA2B,CAAA;IACxC,OAAO,EAAE;QACL,KAAK,CAAC,EAAE,MAAM,CAAA;QACd,QAAQ,EAAE,MAAM,CAAA;QAChB,OAAO,CAAC,EAAE,MAAM,CAAA;QAChB,OAAO,CAAC,EAAE,MAAM,CAAA;QAChB,OAAO,CAAC,EAAE,MAAM,CAAA;QAChB,SAAS,CAAC,EAAE,MAAM,CAAA;KACrB,CAAA;CACJ;AAED;;;;;;;GAOG;AACH,MAAM,WAAW,qBAAqB;IAClC,SAAS,EAAE,CACP,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,CAAC,OAAO,EAAE,2BAA2B,KAAK,IAAI,KACtD,MAAM,IAAI,CAAA;CAClB;AAED,MAAM,WAAW,8BAA8B;IAC3C;;;;;OAKG;IACH,OAAO,CAAC,EAAE,eAAe,CAAA;IACzB;;;;;;OAMG;IACH,MAAM,CAAC,EAAE,CAAC,GAAG,EAAE,2BAA2B,EAAE,OAAO,EAAE,MAAM,KAAK,IAAI,CAAA;CACvE;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,uBAAuB,CACnC,MAAM,EAAE,qBAAqB,GAAG,SAAS,GAAG,IAAI,EAChD,OAAO,GAAE,8BAAmC,GAC7C,MAAM,IAAI,CAeZ;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,4BAA4B,CACxC,MAAM,EAAE,qBAAqB,GAAG,SAAS,GAAG,IAAI,EAChD,OAAO,GAAE,8BAAmC,GAC7C,IAAI,CAON"}
+{"version":3,"file":"manifest-hotswap-subscriber.d.ts","sourceRoot":"","sources":["../src/manifest-hotswap-subscriber.ts"],"names":[],"mappings":"AA6CA,OAAO,EAAoB,KAAK,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAEzE;;;;GAIG;AACH,eAAO,MAAM,2BAA2B,EAAG,wBAAiC,CAAA;AAE5E;;;;GAIG;AACH,MAAM,WAAW,2BAA2B;IACxC,IAAI,EAAE,OAAO,2BAA2B,CAAA;IACxC,OAAO,EAAE;QACL,KAAK,CAAC,EAAE,MAAM,CAAA;QACd,QAAQ,EAAE,MAAM,CAAA;QAChB,OAAO,CAAC,EAAE,MAAM,CAAA;QAChB,OAAO,CAAC,EAAE,MAAM,CAAA;QAChB,OAAO,CAAC,EAAE,MAAM,CAAA;QAChB,SAAS,CAAC,EAAE,MAAM,CAAA;KACrB,CAAA;CACJ;AAED;;;;;;;GAOG;AACH,MAAM,WAAW,qBAAqB;IAClC,SAAS,EAAE,CACP,IAAI,EAAE,MAAM,EACZ,OAAO,EAAE,CAAC,OAAO,EAAE,2BAA2B,KAAK,IAAI,KACtD,MAAM,IAAI,CAAA;CAClB;AAED,MAAM,WAAW,8BAA8B;IAC3C;;;;;OAKG;IACH,OAAO,CAAC,EAAE,eAAe,CAAA;IACzB;;;;;;;;OAQG;IACH,MAAM,CAAC,EAAE,CAAC,GAAG,EAAE,2BAA2B,EAAE,OAAO,EAAE,MAAM,KAAK,IAAI,CAAA;CACvE;AAED;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,uBAAuB,CACnC,MAAM,EAAE,qBAAqB,GAAG,SAAS,GAAG,IAAI,EAChD,OAAO,GAAE,8BAAmC,GAC7C,MAAM,IAAI,CA+BZ;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,4BAA4B,CACxC,MAAM,EAAE,qBAAqB,GAAG,SAAS,GAAG,IAAI,EAChD,OAAO,GAAE,8BAAmC,GAC7C,IAAI,CAON"}

package/dist/manifest-hotswap-subscriber.js

@@ -72,9 +72,25 @@ export function wireHotSwapInvalidation(client, options = {}) {
         const addonKey = message?.payload?.addonKey;
         if (!addonKey)
             return;
-        const removed = useMetadataCache
-            .getState()
-            .invalidateAddon(addonKey, matcher);
+        const store = useMetadataCache.getState();
+        let removed = store.invalidateAddon(addonKey, matcher);
+        // Matcher-miss fallback. `invalidateAddon`'s default matcher only
+        // recognises cache keys that carry the addon prefix
+        // (`purchases`, `purchases.Model`, `purchases:Model`). But most
+        // hosts cache metadata under the model's TABLE name
+        // (`purchase_order_items`, `suppliers`) — which has no `purchases.`
+        // prefix — so a scoped invalidation removes 0 entries and the
+        // stale label/ref survives (the "why did I have to clear site
+        // data" bug). A manifest change is rare (addon install/upgrade),
+        // so when scoping matched nothing we drop the WHOLE metadata cache:
+        // correctness over a micro-optimisation. Entries refetch lazily on
+        // the next DynamicTable/relation mount, picking up the new
+        // fields/refs/labels. Hosts that DO namespace their keys keep the
+        // cheap scoped path (removed > 0).
+        if (removed === 0) {
+            store.clearAll();
+            removed = -1; // sentinel: "cleared all" (distinct from 0 = no-op)
+        }
         onSwap?.(message, removed);
     });
     return unsubscribe;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "29.0.1",
+  "version": "29.0.2",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",

package/src/__tests__/manifest-hotswap-subscriber.test.ts

@@ -118,6 +118,36 @@ describe('manifest-hotswap-subscriber', () => {
         expect(onSwap).toHaveBeenCalledWith(message, 2)
     })
 
+    it('clears the WHOLE cache when the scoped matcher finds nothing (table-named keys)', () => {
+        // Real-world case: metadata is cached under TABLE names, which carry no
+        // addon prefix. `invalidateAddon('purchases')` matches none of them, so
+        // without the fallback the stale label/ref would survive an upgrade.
+        const cache = useMetadataCache.getState()
+        cache.setMetadata('purchase_order_items', fakeMeta('items-old'))
+        cache.setMetadata('suppliers', fakeMeta('suppliers-old'))
+        cache.setModalMetadata('purchase_orders', fakeMeta('po-old'))
+
+        const onSwap = vi.fn()
+        const client = makeFakeClient()
+        wireHotSwapInvalidation(client, { onSwap })
+
+        const message: AddonManifestChangedMessage = {
+            type: 'ADDON_MANIFEST_CHANGED',
+            payload: { addonKey: 'purchases', newHash: 'sha256:new' },
+        }
+        client.emit(message)
+
+        const after = useMetadataCache.getState()
+        // Everything dropped — next mount refetches fresh metadata.
+        expect(after.cache).toEqual({})
+        expect(after.modalCache).toEqual({})
+        expect(after.prefetched).toBe(false)
+        // metadataVersion reset so prefetchAll re-seeds from the server.
+        expect(after.metadataVersion).toBe('')
+        // Sentinel -1 tells the host "cleared all" (vs 0 = genuine no-op).
+        expect(onSwap).toHaveBeenCalledWith(message, -1)
+    })
+
     it('honours a custom matcher when the host uses a different key convention', () => {
         const cache = useMetadataCache.getState()
         cache.setMetadata('addons/pos/cart', fakeMeta('cart'))

package/src/manifest-hotswap-subscriber.ts

@@ -97,7 +97,9 @@ export interface WireHotSwapInvalidationOptions {
      * Useful for hosts that want to log/observe hot-swaps or trigger a
      * `window.location.reload()` when the running addon's bundle hash
      * changes (see the module-level comment above for the trade-off).
-     * `removed` is the number of cache entries flushed for this addon.
+     * `removed` is the number of cache entries flushed for this addon, or
+     * `-1` when the scoped matcher found nothing and the whole metadata
+     * cache was cleared as a fallback (see `wireHotSwapInvalidation`).
      */
     onSwap?: (msg: AddonManifestChangedMessage, removed: number) => void
 }
@@ -128,9 +130,25 @@ export function wireHotSwapInvalidation(
         (message) => {
             const addonKey = message?.payload?.addonKey
             if (!addonKey) return
-            const removed = useMetadataCache
-                .getState()
-                .invalidateAddon(addonKey, matcher)
+            const store = useMetadataCache.getState()
+            let removed = store.invalidateAddon(addonKey, matcher)
+            // Matcher-miss fallback. `invalidateAddon`'s default matcher only
+            // recognises cache keys that carry the addon prefix
+            // (`purchases`, `purchases.Model`, `purchases:Model`). But most
+            // hosts cache metadata under the model's TABLE name
+            // (`purchase_order_items`, `suppliers`) — which has no `purchases.`
+            // prefix — so a scoped invalidation removes 0 entries and the
+            // stale label/ref survives (the "why did I have to clear site
+            // data" bug). A manifest change is rare (addon install/upgrade),
+            // so when scoping matched nothing we drop the WHOLE metadata cache:
+            // correctness over a micro-optimisation. Entries refetch lazily on
+            // the next DynamicTable/relation mount, picking up the new
+            // fields/refs/labels. Hosts that DO namespace their keys keep the
+            // cheap scoped path (removed > 0).
+            if (removed === 0) {
+                store.clearAll()
+                removed = -1 // sentinel: "cleared all" (distinct from 0 = no-op)
+            }
             onSwap?.(message, removed)
         },
     )