@asteby/metacore-runtime-react 23.2.0 → 23.3.0

package/dist/dynamic-row-actions.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dynamic-row-actions.d.ts","sourceRoot":"","sources":["../src/dynamic-row-actions.tsx"],"names":[],"mappings":"AAoCA,OAAO,KAAK,EAAE,aAAa,EAAkB,MAAM,SAAS,CAAA;AAE5D,MAAM,WAAW,0BAA0B;IACvC,6DAA6D;IAC7D,KAAK,EAAE,MAAM,CAAA;IACb;;;;OAIG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,2EAA2E;IAC3E,QAAQ,EAAE,aAAa,GAAG,IAAI,CAAA;IAC9B;;;;OAIG;IACH,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC7C,4EAA4E;IAC5E,SAAS,EAAE,MAAM,IAAI,CAAA;CACxB;AAED,MAAM,WAAW,iBAAiB;IAC9B,+CAA+C;IAC/C,oBAAoB,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;IACjE;;;OAGG;IACH,OAAO,EAAE,KAAK,CAAC,YAAY,CAAA;CAC9B;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,EACjC,KAAK,EACL,QAAQ,EACR,QAAQ,EACR,QAAQ,EACR,SAAS,GACZ,EAAE,0BAA0B,GAAG,iBAAiB,CAmHhD"}
+{"version":3,"file":"dynamic-row-actions.d.ts","sourceRoot":"","sources":["../src/dynamic-row-actions.tsx"],"names":[],"mappings":"AAoCA,OAAO,KAAK,EAAE,aAAa,EAAkB,MAAM,SAAS,CAAA;AAE5D,MAAM,WAAW,0BAA0B;IACvC,6DAA6D;IAC7D,KAAK,EAAE,MAAM,CAAA;IACb;;;;OAIG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,2EAA2E;IAC3E,QAAQ,EAAE,aAAa,GAAG,IAAI,CAAA;IAC9B;;;;OAIG;IACH,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC7C,4EAA4E;IAC5E,SAAS,EAAE,MAAM,IAAI,CAAA;CACxB;AAED,MAAM,WAAW,iBAAiB;IAC9B,+CAA+C;IAC/C,oBAAoB,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,OAAO,CAAC,IAAI,CAAC,CAAA;IACjE;;;OAGG;IACH,OAAO,EAAE,KAAK,CAAC,YAAY,CAAA;CAC9B;AAED;;;GAGG;AACH,wBAAgB,oBAAoB,CAAC,EACjC,KAAK,EACL,QAAQ,EACR,QAAQ,EACR,QAAQ,EACR,SAAS,GACZ,EAAE,0BAA0B,GAAG,iBAAiB,CAqHhD"}

package/dist/dynamic-row-actions.js

@@ -89,16 +89,18 @@ export function useDynamicRowActions({ model, endpoint, metadata, onAction, onRe
         try {
             const deleteEndpoint = endpoint ? `${endpoint}/${rowToDelete.id}` : `/data/${model}/${rowToDelete.id}`;
             const res = await api.delete(deleteEndpoint);
+            // CRUD estándar: no usar res.data.message (el endpoint dinámico
+            // devuelve texto en inglés que se filtraría al toast). String localizado.
             if (res.data.success) {
-                toast.success(res.data.message || 'Eliminado correctamente');
+                toast.success(t('dynamic.delete_success', { defaultValue: 'Registro eliminado correctamente' }));
                 onRefresh();
             }
             else
-                toast.error(res.data.message || 'Error al eliminar');
+                toast.error(t('dynamic.delete_error', { defaultValue: 'No se pudo eliminar el registro' }));
         }
         catch (error) {
             console.error('Error al eliminar', error);
-            toast.error('Error al eliminar el registro');
+            toast.error(t('dynamic.delete_error', { defaultValue: 'No se pudo eliminar el registro' }));
         }
         finally {
             setIsDeleting(false);

package/dist/dynamic-table.js

@@ -545,9 +545,9 @@ export function DynamicTable({ model, endpoint, enableUrlSync = true, hiddenColu
         setBulkDeleteTotal(0);
         setRowSelection({});
         if (successCount > 0)
-            toast.success(`${successCount} registro(s) eliminado(s) correctamente`);
+            toast.success(t('dynamic.bulk_delete_success', { count: successCount, defaultValue: '{{count}} registro(s) eliminado(s) correctamente' }));
         if (errorCount > 0)
-            toast.error(`${errorCount} registro(s) no pudieron ser eliminados`);
+            toast.error(t('dynamic.bulk_delete_error', { count: errorCount, defaultValue: '{{count}} registro(s) no pudieron ser eliminados' }));
         handleRefresh();
     };
     const handleDynamicFilterChange = useCallback((filterKey, values) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "23.2.0",
+  "version": "23.3.0",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",

package/src/__tests__/readonly-fields.test.tsx

@@ -0,0 +1,97 @@
+// @vitest-environment happy-dom
+//
+// `readonly` field handling in the generic record dialog + action modal.
+//
+// A `readonly` field is server/system-generated (e.g. the GitHub addon's
+// `number`/`github_url`, filled by the API after the outbound create). Kernel
+// v0.64.0 stamps `FieldDef.readonly` on such fields served by DeriveFormFields.
+// UI semantics:
+//   - CREATE: the field is excluded from the form entirely (`filterVisibleFields`)
+//     — the user can't set a value the server will overwrite.
+//   - EDIT:   the field is shown, but as a disabled/muted input
+//     (`ReadonlyEditField`) — the value is visible, not editable.
+//   - VIEW:   unchanged (rich read-only renderer).
+//
+// The last block covers action fields with a materialized `options_source`: ops
+// turns them into `type:'select'` with server-populated `options`, and the modal
+// must render a <Select> for them. That decision lives in `resolveWidget`.
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
+
+vi.mock('react-i18next', () => ({
+    useTranslation: () => ({
+        t: (k: string, o?: any) => o?.defaultValue ?? k,
+        i18n: { language: 'es' },
+    }),
+}))
+
+import { filterVisibleFields, ReadonlyEditField } from '../dialogs/dynamic-record'
+import { resolveWidget } from '../dynamic-form-schema'
+
+afterEach(cleanup)
+
+const fields = [
+    { key: 'name', label: 'Nombre', type: 'text' },
+    // System-generated: filled by the API after the outbound create.
+    { key: 'number', label: 'Número', type: 'text', readonly: true },
+    { key: 'secret', label: 'Secret', type: 'text', hidden: true },
+]
+
+describe('filterVisibleFields — readonly exclusion per mode', () => {
+    it('excludes a readonly field on CREATE (and always excludes hidden)', () => {
+        const keys = filterVisibleFields(fields as any, 'create').map(f => f.key)
+        expect(keys).toEqual(['name'])
+    })
+
+    it('keeps a readonly field visible on EDIT and VIEW (still drops hidden)', () => {
+        expect(filterVisibleFields(fields as any, 'edit').map(f => f.key)).toEqual(['name', 'number'])
+        expect(filterVisibleFields(fields as any, 'view').map(f => f.key)).toEqual(['name', 'number'])
+    })
+})
+
+describe('ReadonlyEditField — edit-mode rendering of a readonly field', () => {
+    it('renders a disabled, muted input with the value visible', () => {
+        render(
+            <ReadonlyEditField
+                field={{ key: 'number', label: 'Número', type: 'text', readonly: true }}
+                value="GH-42"
+            />,
+        )
+        const input = screen.getByDisplayValue('GH-42') as HTMLInputElement
+        expect(input).toBeTruthy()
+        expect(input.disabled).toBe(true)
+        expect(input.className).toContain('text-muted-foreground')
+    })
+
+    it('renders a boolean readonly field as a disabled switch', () => {
+        const { container } = render(
+            <ReadonlyEditField
+                field={{ key: 'active', label: 'Activo', type: 'boolean', readonly: true }}
+                value={true}
+            />,
+        )
+        const sw = container.querySelector('[role="switch"]') as HTMLElement
+        expect(sw).toBeTruthy()
+        expect(sw.getAttribute('data-disabled') != null || sw.hasAttribute('disabled')).toBe(true)
+        expect(screen.getByText('Sí')).toBeTruthy()
+    })
+})
+
+describe('action fields — options_source materialized to a select', () => {
+    it('resolves a select-typed field (server-populated options) to the select widget', () => {
+        // ops materializes an `options_source` action field into `type:'select'`
+        // with the options populated server-side; the modal's renderField keys off
+        // resolveWidget to render a <Select> for it.
+        expect(
+            resolveWidget({
+                key: 'status',
+                label: 'Estado',
+                type: 'select',
+                options: [
+                    { value: 'open', label: 'Abierto' },
+                    { value: 'closed', label: 'Cerrado' },
+                ],
+            } as any),
+        ).toBe('select')
+    })
+})

package/src/__tests__/record-detail-display.test.tsx

@@ -0,0 +1,113 @@
+// @vitest-environment happy-dom
+//
+// Detail-dialog display mapping: the read-only `ViewValue` must render values
+// with the SAME "pro" display logic as the table (shared `display-value.tsx`
+// primitives), keyed off the stamped display type (`cellStyle ?? type`):
+//   - served option → colored badge with the localized label,
+//   - `cellStyle:'url'` on a text column → clickable external link (new tab),
+//   - `cellStyle:'status'` bare token (kanban stage) → colored, translated pill,
+//   - a `labels`/`tags` array → a row of badges (never a raw mini-table / JSON).
+import { afterEach, describe, expect, it, vi } from 'vitest'
+import { cleanup, render, screen } from '@testing-library/react'
+
+// Identity-ish translator with a tiny stage dictionary, matching how the host
+// resolves an addon's i18n keys (t(token, { defaultValue })).
+vi.mock('react-i18next', () => ({
+    useTranslation: () => ({
+        t: (k: string, opts?: any) =>
+            k === 'backlog' ? 'Pendiente' : opts?.defaultValue ?? k,
+        i18n: { language: 'es' },
+    }),
+}))
+
+import { ViewValue } from '../dialogs/dynamic-record'
+
+afterEach(cleanup)
+
+describe('ViewValue — detail dialog display mapping', () => {
+    it('renders a served option as a colored badge with the localized label', () => {
+        render(
+            <ViewValue
+                field={{
+                    key: 'product_type',
+                    label: 'Tipo',
+                    type: 'select',
+                    options: [
+                        { value: 'storable', label: 'Almacenable', color: '#22c55e' },
+                    ],
+                }}
+                value="storable"
+                record={{}}
+            />
+        )
+        const badge = screen.getByText('Almacenable')
+        expect(badge).toBeTruthy()
+        // Never the raw enum token.
+        expect(screen.queryByText('storable')).toBeNull()
+    })
+
+    it('renders a cellStyle:url text column as a clickable external link', () => {
+        const { container } = render(
+            <ViewValue
+                field={{ key: 'github_url', label: 'GitHub', type: 'text', cellStyle: 'url' }}
+                value="https://github.com/asteby/x"
+                record={{}}
+            />
+        )
+        const link = container.querySelector('a') as HTMLAnchorElement
+        expect(link).toBeTruthy()
+        expect(link.getAttribute('href')).toBe('https://github.com/asteby/x')
+        expect(link.getAttribute('target')).toBe('_blank')
+    })
+
+    it('renders a bare stage token (cellStyle:status) as a translated colored pill', () => {
+        const { container } = render(
+            <ViewValue
+                field={{ key: 'stage', label: 'Etapa', type: 'text', cellStyle: 'status' }}
+                value="backlog"
+                record={{}}
+            />
+        )
+        // Localized via the manifest i18n key, not the raw "backlog".
+        expect(screen.getByText('Pendiente')).toBeTruthy()
+        expect(container.textContent).not.toContain('backlog')
+        // Colored: the badge carries an inline background style.
+        const styled = container.querySelector('[style*="background"]')
+        expect(styled).toBeTruthy()
+    })
+
+    it('renders a labels array (cellStyle:tags) as a row of badges', () => {
+        render(
+            <ViewValue
+                field={{ key: 'labels', label: 'Labels', type: 'json', cellStyle: 'tags' }}
+                value={['bug', 'urgent']}
+                record={{}}
+            />
+        )
+        expect(screen.getByText('bug')).toBeTruthy()
+        expect(screen.getByText('urgent')).toBeTruthy()
+    })
+
+    it('renders label objects with color as colored badges', () => {
+        render(
+            <ViewValue
+                field={{ key: 'labels', label: 'Labels', type: 'json', cellStyle: 'relation-badge-list' }}
+                value={[{ label: 'Bug', color: '#ef4444' }, { name: 'P1' }]}
+                record={{}}
+            />
+        )
+        expect(screen.getByText('Bug')).toBeTruthy()
+        expect(screen.getByText('P1')).toBeTruthy()
+    })
+
+    it('keeps the "—" empty marker for an empty labels array', () => {
+        const { container } = render(
+            <ViewValue
+                field={{ key: 'labels', label: 'Labels', type: 'json', cellStyle: 'tags' }}
+                value={[]}
+                record={{}}
+            />
+        )
+        expect(container.textContent).toContain('—')
+    })
+})

package/src/action-modal-dispatcher.tsx

@@ -225,11 +225,11 @@ function ConfirmActionDialog({ open, onOpenChange, action, model, record, endpoi
             const url = buildActionUrl(endpoint, model, record.id, action.key)
             const res = await api.post(url, {})
             if (res.data.success) {
-                toast.success(res.data.message || t('common.success'))
+                toast.success(res.data.message ? t(res.data.message, { defaultValue: res.data.message }) : t('common.success'))
                 onOpenChange(false)
                 onSuccess()
             } else {
-                toast.error(res.data.message || t('common.error'))
+                toast.error(res.data.message ? t(res.data.message, { defaultValue: res.data.message }) : t('common.error'))
             }
         } catch (err: any) {
             toast.error(err?.response?.data?.message || t('common.error'))
@@ -342,11 +342,11 @@ function GenericActionModal({ open, onOpenChange, action, model, record, endpoin
             const url = buildActionUrl(endpoint, model, record.id, action.key)
             const res = await api.post(url, formData)
             if (res.data.success) {
-                toast.success(res.data.message || t('common.success'))
+                toast.success(res.data.message ? t(res.data.message, { defaultValue: res.data.message }) : t('common.success'))
                 onOpenChange(false)
                 onSuccess()
             } else {
-                toast.error(res.data.message || t('common.error'))
+                toast.error(res.data.message ? t(res.data.message, { defaultValue: res.data.message }) : t('common.error'))
             }
         } catch (err: any) {
             toast.error(err?.response?.data?.message || t('common.error'))