@asteby/metacore-runtime-react 23.12.2 → 23.12.3

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @asteby/metacore-runtime-react
 
+## 23.12.3
+
+### Patch Changes
+
+- 5e46e61: fix(dynamic-table): don't strip a deep-linked filter on first mount (URL race)
+
+  The URL-write effect ran on the very first commit — when `initializedFromUrl`
+  (a ref) is already true but the init effect's `setDynamicFilters` hasn't
+  re-rendered yet — so it wrote a URL WITHOUT `f_status`, stripping a
+  deep-linked/reloaded filter and flickering the address bar until it settled
+  without the filter. Gate the write on a STATE flag (`urlSynced`) set once the
+  URL has been adopted, so the first write only happens on the render where
+  `dynamicFilters`/`pagination` already mirror the URL (a true no-op).
+
 ## 23.12.2
 
 ### Patch Changes

package/dist/dynamic-table.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"dynamic-table.d.ts","sourceRoot":"","sources":["../src/dynamic-table.tsx"],"names":[],"mappings":"AAgBA,OAAO,EAKH,KAAK,SAAS,EAajB,MAAM,uBAAuB,CAAA;AAgC9B,OAAO,KAAK,EAAsB,iBAAiB,EAAE,MAAM,wBAAwB,CAAA;AAanF,MAAM,WAAW,iBAAiB;IAC9B,KAAK,EAAE,MAAM,CAAA;IACb,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,aAAa,CAAC,EAAE,OAAO,CAAA;IACvB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAA;IACxB,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC7C;;;;;OAKG;IACH,UAAU,CAAC,EAAE,CAAC,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC/B,cAAc,CAAC,EAAE,GAAG,CAAA;IACpB,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;IACpC,YAAY,CAAC,EAAE,SAAS,CAAC,GAAG,CAAC,EAAE,CAAA;IAC/B;;;;;OAKG;IACH,iBAAiB,CAAC,EAAE,iBAAiB,CAAA;IACrC;;;;;OAKG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB;;;;OAIG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB;;;;;;OAMG;IACH,cAAc,CAAC,EAAE,OAAO,CAAA;CAC3B;AAED,wBAAgB,YAAY,CAAC,EACzB,KAAK,EACL,QAAQ,EACR,aAAoB,EACpB,aAAkB,EAClB,QAAQ,EACR,UAAU,EACV,cAAc,EACd,cAAc,EACd,YAAiB,EACjB,iBAA4C,EAC5C,QAAQ,EACR,QAAQ,EACR,cAAsB,GACzB,EAAE,iBAAiB,+BAwmCnB"}
+{"version":3,"file":"dynamic-table.d.ts","sourceRoot":"","sources":["../src/dynamic-table.tsx"],"names":[],"mappings":"AAgBA,OAAO,EAKH,KAAK,SAAS,EAajB,MAAM,uBAAuB,CAAA;AAgC9B,OAAO,KAAK,EAAsB,iBAAiB,EAAE,MAAM,wBAAwB,CAAA;AAanF,MAAM,WAAW,iBAAiB;IAC9B,KAAK,EAAE,MAAM,CAAA;IACb,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,aAAa,CAAC,EAAE,OAAO,CAAA;IACvB,aAAa,CAAC,EAAE,MAAM,EAAE,CAAA;IACxB,QAAQ,CAAC,EAAE,CAAC,MAAM,EAAE,MAAM,EAAE,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC7C;;;;;OAKG;IACH,UAAU,CAAC,EAAE,CAAC,GAAG,EAAE,GAAG,KAAK,IAAI,CAAA;IAC/B,cAAc,CAAC,EAAE,GAAG,CAAA;IACpB,cAAc,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;IACpC,YAAY,CAAC,EAAE,SAAS,CAAC,GAAG,CAAC,EAAE,CAAA;IAC/B;;;;;OAKG;IACH,iBAAiB,CAAC,EAAE,iBAAiB,CAAA;IACrC;;;;;OAKG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB;;;;OAIG;IACH,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB;;;;;;OAMG;IACH,cAAc,CAAC,EAAE,OAAO,CAAA;CAC3B;AAED,wBAAgB,YAAY,CAAC,EACzB,KAAK,EACL,QAAQ,EACR,aAAoB,EACpB,aAAkB,EAClB,QAAQ,EACR,UAAU,EACV,cAAc,EACd,cAAc,EACd,YAAiB,EACjB,iBAA4C,EAC5C,QAAQ,EACR,QAAQ,EACR,cAAsB,GACzB,EAAE,iBAAiB,+BAsnCnB"}

package/dist/dynamic-table.js

@@ -85,6 +85,17 @@ export function DynamicTable({ model, endpoint, enableUrlSync = true, hiddenColu
     // which reads as a URL flicker and fights the router's spelling. Starts at 10
     // to match the initial pagination state until metadata arrives.
     const defaultPerPage = useRef(10);
+    // Has the table finished adopting its state FROM the URL yet? The write
+    // effect must not run before this flips true. `initializedFromUrl` is a ref
+    // set synchronously at the top of the init effect, so on the very first
+    // commit the write effect (which runs right after, in the SAME commit) sees
+    // `initialized=true` but `dynamicFilters` still EMPTY — the init effect's
+    // setState hasn't re-rendered yet — and writes a URL WITHOUT `f_status`,
+    // stripping a deep-linked filter (the "recarga quita el filtro y parpadea"
+    // bug). A STATE flag defers the first write to the render AFTER the URL has
+    // been adopted, where `dynamicFilters`/`pagination` already mirror the URL,
+    // so the write is a no-op and the filter never gets stripped.
+    const [urlSynced, setUrlSynced] = useState(false);
     useEffect(() => {
         if (prevBranchId.current !== currentBranch?.id) {
             prevBranchId.current = currentBranch?.id;
@@ -181,13 +192,16 @@ export function DynamicTable({ model, endpoint, enableUrlSync = true, hiddenColu
         });
         if (Object.keys(filters).length > 0)
             setDynamicFilters(filters);
+        // Adopted everything the URL carries; the write effect may now run on the
+        // NEXT render (where the setState above has landed) without clobbering it.
+        setUrlSynced(true);
     }, []); // eslint-disable-line react-hooks/exhaustive-deps
     // The exact query string this table last wrote to the URL — lets the
     // resync effect below tell "our own replaceState" apart from an external
     // rewrite by the host router.
     const lastSelfSearch = useRef(null);
     useEffect(() => {
-        if (!enableUrlSync || !initializedFromUrl.current)
+        if (!enableUrlSync || !urlSynced)
             return;
         const params = new URLSearchParams();
         // Preserve the route-owned view params. The table rebuilds the query
@@ -241,7 +255,7 @@ export function DynamicTable({ model, endpoint, enableUrlSync = true, hiddenColu
         const newUrl = search ? `${window.location.pathname}?${search}` : window.location.pathname;
         lastSelfSearch.current = search ? `?${search}` : '';
         window.history.replaceState(null, '', newUrl);
-    }, [enableUrlSync, pagination, sorting, globalFilter, dynamicFilters, defaultFilters]);
+    }, [enableUrlSync, urlSynced, pagination, sorting, globalFilter, dynamicFilters, defaultFilters]);
     // The host router can rewrite the query string WITHOUT remounting the
     // table — e.g. sidebar sibling entries deep-link different `f_` filters
     // into the same model route. The mount-time init above never re-runs, so

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "23.12.2",
+  "version": "23.12.3",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",

package/src/dynamic-table.tsx

@@ -197,6 +197,17 @@ export function DynamicTable({
     // which reads as a URL flicker and fights the router's spelling. Starts at 10
     // to match the initial pagination state until metadata arrives.
     const defaultPerPage = useRef(10)
+    // Has the table finished adopting its state FROM the URL yet? The write
+    // effect must not run before this flips true. `initializedFromUrl` is a ref
+    // set synchronously at the top of the init effect, so on the very first
+    // commit the write effect (which runs right after, in the SAME commit) sees
+    // `initialized=true` but `dynamicFilters` still EMPTY — the init effect's
+    // setState hasn't re-rendered yet — and writes a URL WITHOUT `f_status`,
+    // stripping a deep-linked filter (the "recarga quita el filtro y parpadea"
+    // bug). A STATE flag defers the first write to the render AFTER the URL has
+    // been adopted, where `dynamicFilters`/`pagination` already mirror the URL,
+    // so the write is a no-op and the filter never gets stripped.
+    const [urlSynced, setUrlSynced] = useState(false)
 
     useEffect(() => {
         if (prevBranchId.current !== currentBranch?.id) {
@@ -289,6 +300,9 @@ export function DynamicTable({
             }
         })
         if (Object.keys(filters).length > 0) setDynamicFilters(filters)
+        // Adopted everything the URL carries; the write effect may now run on the
+        // NEXT render (where the setState above has landed) without clobbering it.
+        setUrlSynced(true)
     }, []) // eslint-disable-line react-hooks/exhaustive-deps
 
     // The exact query string this table last wrote to the URL — lets the
@@ -297,7 +311,7 @@ export function DynamicTable({
     const lastSelfSearch = useRef<string | null>(null)
 
     useEffect(() => {
-        if (!enableUrlSync || !initializedFromUrl.current) return
+        if (!enableUrlSync || !urlSynced) return
         const params = new URLSearchParams()
         // Preserve the route-owned view params. The table rebuilds the query
         // string from scratch (it only knows its own page/sort/filter keys), but
@@ -343,7 +357,7 @@ export function DynamicTable({
         const newUrl = search ? `${window.location.pathname}?${search}` : window.location.pathname
         lastSelfSearch.current = search ? `?${search}` : ''
         window.history.replaceState(null, '', newUrl)
-    }, [enableUrlSync, pagination, sorting, globalFilter, dynamicFilters, defaultFilters])
+    }, [enableUrlSync, urlSynced, pagination, sorting, globalFilter, dynamicFilters, defaultFilters])
 
     // The host router can rewrite the query string WITHOUT remounting the
     // table — e.g. sidebar sibling entries deep-link different `f_` filters