@asteby/metacore-runtime-react 22.0.0 → 23.1.0

package/src/dynamic-table.tsx

@@ -67,6 +67,7 @@ import { useApi, useCurrentBranch } from './api-context'
 import type { ColumnFilterConfig, GetDynamicColumns } from './dynamic-columns-shim'
 import { defaultGetDynamicColumns, DATE_CELL_TYPES, aggregateOf, formatAggregateTotal } from './dynamic-columns'
 import { useFacetLoaders, isLongTextColumn } from './use-facet-loaders'
+import { FilterChipsRow, translateOptionLabels, type FilterChipField } from './filter-chips'
 import { OptionsContext } from './options-context'
 import type { TableMetadata, ApiResponse } from './types'
 import { getSearchableColumnKeys } from './column-visibility'
@@ -536,11 +537,15 @@ export function DynamicTable({
     // getDynamicColumns forwards `loadOptions` into the column meta). Facets base
     // derived off the list endpoint exactly like the aggregate endpoint below.
     const facetsBase = endpoint ? `${endpoint}/facets` : model ? `/data/${model}/facets` : null
-    const getFacetLoader = useFacetLoaders(facetsBase)
+    const { getFacetLoader, prefetchFacets, facetOptions } = useFacetLoaders(facetsBase)
 
     const columnFilterConfigs = useMemo(() => {
         const map = new Map<string, ColumnFilterConfig>()
         if (!metadata) return map
+        // Option labels arrive as manifest i18n keys; translate them here (the ui
+        // package has no i18n) so header filters, chips and value summaries show
+        // localized text. A raw value with no key falls through via defaultValue.
+        const tr = (label: string) => t(label, { defaultValue: label })
         const stageOptions = (metadata.stages ?? []).map((s) => ({
             label: s.label,
             value: s.key,
@@ -574,18 +579,23 @@ export function DynamicTable({
                 if (loader) {
                     fType = 'facet'
                     loadOptions = loader
+                    // Prewarmed values (from prefetchFacets) → the header filter
+                    // opens with the list already there, no "Cargando…" flash.
+                    options = facetOptions.get(f.column || f.key) ?? []
                 }
             }
             if (fType === 'select' && options.length === 0 && !f.searchEndpoint) continue
             map.set(f.key, {
                 filterType: fType,
                 filterKey: f.column || f.key,
-                options,
+                options: translateOptionLabels(options, tr),
                 selectedValues: dynamicFilters[f.column || f.key] || [],
                 onFilterChange: handleDynamicFilterChange,
                 loading: f.searchEndpoint ? !filterOptionsMap.has(f.searchEndpoint) : false,
                 searchEndpoint: f.searchEndpoint,
-                loadOptions,
+                loadOptions: loadOptions
+                    ? (q?: string) => loadOptions!(q).then((o) => translateOptionLabels(o, tr))
+                    : undefined,
             })
         }
         for (const c of metadata.columns ?? []) {
@@ -635,22 +645,64 @@ export function DynamicTable({
                 if (loader) {
                     filterType = 'facet'
                     loadOptions = loader
+                    // Prewarmed values (from prefetchFacets) → instant open.
+                    options = facetOptions.get(c.key) ?? []
                 }
             }
 
             map.set(c.key, {
                 filterType,
                 filterKey: c.key,
-                options,
+                options: translateOptionLabels(options, tr),
                 selectedValues: dynamicFilters[c.key] || [],
                 onFilterChange: handleDynamicFilterChange,
                 loading: hasEndpoint && !filterOptionsMap.has(c.searchEndpoint!),
                 searchEndpoint: c.searchEndpoint,
-                loadOptions,
+                loadOptions: loadOptions
+                    ? (q?: string) => loadOptions!(q).then((o) => translateOptionLabels(o, tr))
+                    : undefined,
             })
         }
         return map
-    }, [metadata, filterOptionsMap, dynamicFilters, handleDynamicFilterChange, facetsBase, getFacetLoader])
+    }, [metadata, filterOptionsMap, dynamicFilters, handleDynamicFilterChange, facetsBase, getFacetLoader, facetOptions, t])
+
+    // Prewarm every facet field once the configs settle, so a text column's
+    // header filter opens instantly with values + counts (same as the kanban).
+    const facetFieldsSig = useMemo(() => {
+        const keys: string[] = []
+        for (const config of columnFilterConfigs.values()) {
+            if (config.filterType === 'facet') keys.push(config.filterKey)
+        }
+        return keys.join('|')
+    }, [columnFilterConfigs])
+    useEffect(() => {
+        if (!facetFieldsSig) return
+        prefetchFacets(facetFieldsSig.split('|'))
+    }, [facetFieldsSig, prefetchFacets])
+
+    // Active-filter chips (shared row with the kanban). One chip per field with a
+    // selection; the label is the translated filter/column label.
+    const activeFilterChips = useMemo<FilterChipField[]>(() => {
+        if (!metadata) return []
+        const out: FilterChipField[] = []
+        for (const [key, config] of columnFilterConfigs) {
+            if ((config.selectedValues?.length ?? 0) === 0) continue
+            const f = metadata.filters?.find((x) => x.key === key)
+            const c = metadata.columns?.find((x) => x.key === key)
+            const rawLabel = f?.label || c?.label || key
+            out.push({
+                key,
+                label: t(rawLabel, { defaultValue: rawLabel }),
+                config,
+            })
+        }
+        return out
+    }, [metadata, columnFilterConfigs, t])
+
+    const clearAllDynamicFilters = useCallback(() => {
+        setDynamicFilters({})
+        setPagination((prev: PaginationState) => ({ ...prev, pageIndex: 0 }))
+    }, [])
 
     const columns = useMemo(() => {
         if (!viewMetadata) return []
@@ -771,6 +823,17 @@ export function DynamicTable({
                             </>
                         }
                     />
+                    {/* Active-filter chips — shared with the kanban. Quick
+                        visibility + one-click removal of the header filters. */}
+                    {activeFilterChips.length > 0 && (
+                        <div className='pt-2'>
+                            <FilterChipsRow
+                                fields={activeFilterChips}
+                                onClearAll={clearAllDynamicFilters}
+                                data-testid='table-filter-chips'
+                            />
+                        </div>
+                    )}
                 </div>
                 {/* Desktop: classic horizontal-scroll table. Hidden on phones —
                     a 7-column table forces a wide horizontal scroll there, so we

package/src/filter-chips.tsx

@@ -0,0 +1,175 @@
+// Shared filter presentation: the removable active-filter chip row + the pure
+// helpers that summarize a filter's value and resolve its color. Used by BOTH
+// DynamicKanban and DynamicTable so the two surfaces render identical chips
+// (one component, no drift).
+import { useTranslation } from 'react-i18next'
+import { X } from 'lucide-react'
+import { Badge, Button } from '@asteby/metacore-ui/primitives'
+import { resolveColorCss } from '@asteby/metacore-ui/lib'
+
+/**
+ * Human-readable summary of a field's selected filter values for a chip / row.
+ * Resolves option labels, unwraps the wire operators
+ * (`IN:`/`ILIKE:`/`RANGE:`/`GTE:`/`LTE:`/date `from_to`), and caps the list at
+ * `maxShown` values with a `+n` overflow. Pure — exported for unit tests.
+ */
+export function summarizeFilterValues(
+    values: string[] | undefined,
+    options: { label: string; value: string }[] | undefined,
+    maxShown = 2,
+): string {
+    if (!values || values.length === 0) return ''
+    const opts = options ?? []
+    const labelFor = (v: string) => opts.find((o) => o.value === v)?.label ?? v
+    const first = values[0]
+    if (values.length === 1) {
+        if (first.startsWith('ILIKE:')) return `"${first.slice(6)}"`
+        if (first.startsWith('IN:')) {
+            return summarizeList(first.slice(3).split(','), labelFor, maxShown)
+        }
+        if (first.startsWith('RANGE:')) {
+            const [min, max] = first.slice(6).split(',')
+            return `${min || '…'} – ${max || '…'}`
+        }
+        if (/^\d{4}-\d{2}-\d{2}_/.test(first)) return first.replace('_', ' – ')
+    }
+    if (first.startsWith('GTE:') || first.startsWith('LTE:')) {
+        const min = values.find((v) => v.startsWith('GTE:'))?.slice(4) ?? ''
+        const max = values.find((v) => v.startsWith('LTE:'))?.slice(4) ?? ''
+        return `${min || '…'} – ${max || '…'}`
+    }
+    return summarizeList(values, labelFor, maxShown)
+}
+
+function summarizeList(
+    items: string[],
+    labelFor: (v: string) => string,
+    maxShown: number,
+): string {
+    const labels = items.map(labelFor)
+    if (labels.length <= maxShown) return labels.join(', ')
+    return `${labels.slice(0, maxShown).join(', ')} +${labels.length - maxShown}`
+}
+
+/**
+ * The color of a filter's first selected value (for the chip's dot) — e.g. a
+ * stage's palette color. Returns a resolved CSS color, or undefined for
+ * operator/range/free-text values that carry no option color.
+ */
+export function chipValueColor(config: {
+    selectedValues: string[]
+    options: { value: string; color?: string }[]
+}): string | undefined {
+    const sel = config.selectedValues
+    if (!sel || sel.length === 0) return undefined
+    const first = sel[0]
+    let value = first
+    if (first.startsWith('IN:')) value = first.slice(3).split(',')[0]
+    else if (/^(ILIKE|RANGE|GTE|LTE):/.test(first)) return undefined
+    else if (/^\d{4}-\d{2}-\d{2}_/.test(first)) return undefined
+    const opt = config.options.find((o) => o.value === value)
+    return opt?.color ? resolveColorCss(opt.color) : undefined
+}
+
+/**
+ * Translates option labels through the app translator (manifest i18n keys →
+ * localized text). A raw value with no matching key falls through to itself via
+ * `defaultValue`. Pure — exported for unit tests.
+ */
+export function translateOptionLabels<T extends { label: string }>(
+    options: T[],
+    translate: (key: string) => string,
+): T[] {
+    return options.map((o) => ({ ...o, label: translate(o.label) }))
+}
+
+export interface FilterChipField {
+    key: string
+    label: string
+    config: {
+        selectedValues: string[]
+        options: { label: string; value: string; color?: string }[]
+        filterKey: string
+        onFilterChange: (filterKey: string, values: string[]) => void
+    }
+}
+
+export interface FilterChipsRowProps {
+    /** Fields with an active selection (one chip each). */
+    fields: FilterChipField[]
+    /** Clears every filter (the trailing "Limpiar todo"). */
+    onClearAll: () => void
+    className?: string
+    'data-testid'?: string
+}
+
+/**
+ * The removable active-filter chip row shown under a board/table toolbar. Each
+ * chip: an optional value-color dot, "Campo: valor(es)" (capped + `+n`), and an
+ * X that clears that field; a trailing "Limpiar todo". Renders nothing when no
+ * field is active.
+ */
+export function FilterChipsRow({
+    fields,
+    onClearAll,
+    className,
+    'data-testid': testId,
+}: FilterChipsRowProps) {
+    const { t } = useTranslation()
+    if (fields.length === 0) return null
+    return (
+        <div
+            className={`flex flex-wrap items-center gap-1.5${className ? ` ${className}` : ''}`}
+            data-testid={testId}
+        >
+            {fields.map((field) => {
+                const summary = summarizeFilterValues(
+                    field.config.selectedValues,
+                    field.config.options,
+                )
+                const dot = chipValueColor(field.config)
+                return (
+                    <Badge
+                        key={field.key}
+                        variant="secondary"
+                        className="h-6 gap-1.5 rounded-md pl-2 pr-1 text-xs font-normal"
+                    >
+                        {dot && (
+                            <span
+                                className="size-2 shrink-0 rounded-full"
+                                style={{ backgroundColor: dot }}
+                            />
+                        )}
+                        <span className="font-medium">{field.label}:</span>
+                        <span className="max-w-[180px] truncate text-muted-foreground">
+                            {summary}
+                        </span>
+                        <button
+                            type="button"
+                            onClick={() =>
+                                field.config.onFilterChange(
+                                    field.config.filterKey,
+                                    [],
+                                )
+                            }
+                            className="ml-0.5 rounded-sm p-0.5 transition-colors hover:bg-muted-foreground/20"
+                            aria-label={t('filters.removeFilter', {
+                                defaultValue: 'Quitar filtro',
+                            })}
+                        >
+                            <X className="h-3 w-3" />
+                        </button>
+                    </Badge>
+                )
+            })}
+            <Button
+                variant="ghost"
+                size="sm"
+                className="h-6 gap-1 px-2 text-xs text-muted-foreground"
+                onClick={onClearAll}
+            >
+                {t('filters.clearAll', { defaultValue: 'Limpiar todo' })}
+            </Button>
+        </div>
+    )
+}

package/src/use-dynamic-filters.ts

@@ -96,7 +96,8 @@ export function useDynamicFilters(
       : model
         ? `/data/${model}/facets`
         : null)
-  const getFacetLoader = useFacetLoaders(facetsBase)
+  const { getFacetLoader, prefetchFacets, facetOptions } =
+    useFacetLoaders(facetsBase)
 
   // Prefetch the option lists for relation/select filters (once per model). The
   // combobox needs these before the user opens it; mirrors DynamicTable's
@@ -227,6 +228,9 @@ export function useDynamicFilters(
         if (loader) {
           fType = 'facet'
           loadOptions = loader
+          // Prewarmed values (from prefetchFacets) → the popover opens with the
+          // list already there, no "Cargando…" flash.
+          options = facetOptions.get(f.column || f.key) ?? []
         }
       }
       if (fType === 'select' && options.length === 0 && !f.searchEndpoint) continue
@@ -285,6 +289,8 @@ export function useDynamicFilters(
         if (loader) {
           filterType = 'facet'
           loadOptions = loader
+          // Prewarmed values (from prefetchFacets) → instant open.
+          options = facetOptions.get(c.key) ?? []
         }
       }
 
@@ -307,8 +313,27 @@ export function useDynamicFilters(
     handleDynamicFilterChange,
     facetsBase,
     getFacetLoader,
+    facetOptions,
   ])
 
+  // Prewarm every facet field in one burst once the configs settle, so the
+  // Sheet popover and the lane value-picker open instantly (values + counts)
+  // instead of flashing "Cargando…". Deduped inside prefetchFacets by field set.
+  const facetFieldsSig = useMemo(() => {
+    const keys: string[] = []
+    // Key on `filterKey` (the column the loader queries), not the config map key
+    // — they differ when an explicit filter sets a distinct `column`.
+    for (const config of columnFilterConfigs.values()) {
+      if (config.filterType === 'facet') keys.push(config.filterKey)
+    }
+    return keys.join('|')
+  }, [columnFilterConfigs])
+
+  useEffect(() => {
+    if (!facetFieldsSig) return
+    prefetchFacets(facetFieldsSig.split('|'))
+  }, [facetFieldsSig, prefetchFacets])
+
   const searchableKeys = useMemo(
     () => (metadata ? getSearchableColumnKeys(metadata) : null),
     [metadata],

package/src/use-facet-loaders.ts

@@ -4,10 +4,30 @@
 // per-field option loader + result cache lives here to guarantee they facet
 // identically (one board and its table sibling hit the same `/facets` endpoint
 // with the same caching).
-import { useCallback, useEffect, useRef } from 'react'
+import { useCallback, useEffect, useRef, useState } from 'react'
 import { useApi } from './api-context'
 import type { FilterOption } from './dynamic-columns-shim'
 
+export interface UseFacetLoadersResult {
+  /**
+   * Stable per-field loader → `<facetsBase>?field=&q=&limit=`. Cached per
+   * `field+query`. Null `facetsBase` → yields `undefined` (column stays text).
+   */
+  getFacetLoader: (
+    field: string,
+  ) => ((q?: string) => Promise<FilterOption[]>) | undefined
+  /**
+   * Warms the caches for a set of facet fields in ONE parallel burst (called
+   * when metadata resolves), so a popover opens instantly with values + counts
+   * instead of showing "Cargando…". Deduped by the field set; a field whose
+   * request fails is simply omitted (it degrades to lazy/text — the rest are
+   * unaffected). Resolved options also land in `facetOptions`.
+   */
+  prefetchFacets: (fields: string[]) => void
+  /** Prefetched options per field (empty until `prefetchFacets` resolves). */
+  facetOptions: Map<string, FilterOption[]>
+}
+
 /**
  * Long-text / body columns aren't worth faceting (thousands of unique values,
  * each a paragraph). Heuristic on the metadata, not a hardcoded name list:
@@ -29,26 +49,39 @@ export function isLongTextColumn(c: {
 }
 
 /**
- * Returns `getFacetLoader(field)` — a stable per-field loader that resolves the
- * column's distinct values + counts from `<facetsBase>?field=&q=&limit=`. Loader
- * identity is memoized per field (so it doesn't churn the config memo that
- * depends on it) and results are cached per `field+query`. Both caches reset
- * when `facetsBase` changes (model switch). A null `facetsBase` returns a
- * factory that yields `undefined` — the caller keeps the column as plain text.
+ * Facet option machinery: a stable per-field lazy loader (`getFacetLoader`, with
+ * a `field+query` result cache) plus `prefetchFacets` to warm every facet
+ * field's values up front and `facetOptions` holding those prewarmed results.
+ * Loader identity is memoized per field (so it doesn't churn the config memo
+ * that depends on it). Caches reset when `facetsBase` changes (model switch).
  */
-export function useFacetLoaders(facetsBase: string | null) {
+export function useFacetLoaders(facetsBase: string | null): UseFacetLoadersResult {
   const api = useApi()
   const loaderCache = useRef<
     Map<string, (q?: string) => Promise<FilterOption[]>>
   >(new Map())
   const resultCache = useRef<Map<string, FilterOption[]>>(new Map())
+  const prefetchSig = useRef<string | null>(null)
+  const mountedRef = useRef(true)
+  const [facetOptions, setFacetOptions] = useState<Map<string, FilterOption[]>>(
+    new Map(),
+  )
+
+  useEffect(() => {
+    mountedRef.current = true
+    return () => {
+      mountedRef.current = false
+    }
+  }, [])
 
   useEffect(() => {
     loaderCache.current.clear()
     resultCache.current.clear()
+    prefetchSig.current = null
+    setFacetOptions(new Map())
   }, [facetsBase])
 
-  return useCallback(
+  const getFacetLoader = useCallback(
     (field: string) => {
       if (!facetsBase) return undefined
       const existing = loaderCache.current.get(field)
@@ -76,4 +109,38 @@ export function useFacetLoaders(facetsBase: string | null) {
     },
     [api, facetsBase],
   )
+
+  const prefetchFacets = useCallback(
+    (fields: string[]) => {
+      if (!facetsBase || fields.length === 0) return
+      const sig = [...fields].sort().join('|')
+      if (prefetchSig.current === sig) return
+      prefetchSig.current = sig
+      // One parallel burst; the loader seeds its own `${field}::` cache so the
+      // subsequent lazy open (q === '') is a cache hit. allSettled so one bad
+      // field never blocks the others.
+      void Promise.allSettled(
+        fields.map(async (field) => {
+          const loader = getFacetLoader(field)
+          if (!loader) return null
+          const opts = await loader()
+          return { field, opts }
+        }),
+      ).then((results) => {
+        if (!mountedRef.current) return
+        setFacetOptions((prev) => {
+          const next = new Map(prev)
+          for (const r of results) {
+            if (r.status === 'fulfilled' && r.value) {
+              next.set(r.value.field, r.value.opts)
+            }
+          }
+          return next
+        })
+      })
+    },
+    [facetsBase, getFacetLoader],
+  )
+
+  return { getFacetLoader, prefetchFacets, facetOptions }
 }