@asteby/metacore-runtime-react 18.13.0 → 18.13.1

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @asteby/metacore-runtime-react
 
+## 18.13.1
+
+### Patch Changes
+
+- 6b8f7b2: ActivityDiff: drop noise rows from history diffs — raw FK keys (`created_by_id`) are hidden when their resolved sibling (`created_by: {name,…}`) is present in the same snapshot (covers before/after and the changes {from,to} shape), and `deleted_at` joins the meta-key filter alongside id/created_at/updated_at/organization_id.
+
 ## 18.13.0
 
 ### Minor Changes

package/dist/activity-diff.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"activity-diff.d.ts","sourceRoot":"","sources":["../src/activity-diff.tsx"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;GAeG;AAEH,OAAO,KAAK,KAAK,MAAM,OAAO,CAAA;AAI9B,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,SAAS,CAAA;AAO/C;;;GAGG;AACH,MAAM,WAAW,aAAa;IAC1B,EAAE,EAAE,MAAM,CAAA;IACV,cAAc,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IAC9B,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACxB,WAAW,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IAC3B,SAAS,EAAE,MAAM,CAAA;IACjB,KAAK,EAAE,MAAM,CAAA;IACb,SAAS,EAAE,MAAM,CAAA;IACjB,MAAM,EAAE,MAAM,CAAA;IACd,IAAI,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACpB,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAA;IACvC,KAAK,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAA;IACtC;;;OAGG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE;QAAE,IAAI,EAAE,OAAO,CAAC;QAAC,EAAE,EAAE,OAAO,CAAA;KAAE,CAAC,GAAG,IAAI,CAAA;IAC/D,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACvB,WAAW,EAAE,MAAM,CAAA;CACtB;AAED,MAAM,WAAW,iBAAiB;IAC9B,oCAAoC;IACpC,KAAK,EAAE,aAAa,CAAA;IACpB;;;;OAIG;IACH,OAAO,CAAC,EAAE,gBAAgB,EAAE,CAAA;IAC5B,qDAAqD;IACrD,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,sDAAsD;IACtD,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,uCAAuC;IACvC,MAAM,CAAC,EAAE,MAAM,CAAA;IACf,yCAAyC;IACzC,SAAS,CAAC,EAAE,MAAM,CAAA;CACrB;AAiFD;;;;GAIG;AACH,eAAO,MAAM,YAAY,EAAE,KAAK,CAAC,EAAE,CAAC,iBAAiB,CAmJpD,CAAA"}
+{"version":3,"file":"activity-diff.d.ts","sourceRoot":"","sources":["../src/activity-diff.tsx"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;GAeG;AAEH,OAAO,KAAK,KAAK,MAAM,OAAO,CAAA;AAI9B,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,SAAS,CAAA;AAO/C;;;GAGG;AACH,MAAM,WAAW,aAAa;IAC1B,EAAE,EAAE,MAAM,CAAA;IACV,cAAc,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IAC9B,QAAQ,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACxB,WAAW,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IAC3B,SAAS,EAAE,MAAM,CAAA;IACjB,KAAK,EAAE,MAAM,CAAA;IACb,SAAS,EAAE,MAAM,CAAA;IACjB,MAAM,EAAE,MAAM,CAAA;IACd,IAAI,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACpB,MAAM,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAA;IACvC,KAAK,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,GAAG,IAAI,CAAA;IACtC;;;OAGG;IACH,OAAO,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE;QAAE,IAAI,EAAE,OAAO,CAAC;QAAC,EAAE,EAAE,OAAO,CAAA;KAAE,CAAC,GAAG,IAAI,CAAA;IAC/D,OAAO,CAAC,EAAE,MAAM,GAAG,IAAI,CAAA;IACvB,WAAW,EAAE,MAAM,CAAA;CACtB;AAED,MAAM,WAAW,iBAAiB;IAC9B,oCAAoC;IACpC,KAAK,EAAE,aAAa,CAAA;IACpB;;;;OAIG;IACH,OAAO,CAAC,EAAE,gBAAgB,EAAE,CAAA;IAC5B,qDAAqD;IACrD,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,sDAAsD;IACtD,QAAQ,CAAC,EAAE,MAAM,CAAA;IACjB,uCAAuC;IACvC,MAAM,CAAC,EAAE,MAAM,CAAA;IACf,yCAAyC;IACzC,SAAS,CAAC,EAAE,MAAM,CAAA;CACrB;AAuGD;;;;GAIG;AACH,eAAO,MAAM,YAAY,EAAE,KAAK,CAAC,EAAE,CAAC,iBAAiB,CAmJpD,CAAA"}

package/dist/activity-diff.js

@@ -23,20 +23,42 @@ import { ActivityValueRenderer } from './activity-value-renderer';
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
+// Meta-level keys that are always present and never meaningful in a
+// human-readable diff.
+const META_KEYS = new Set(['id', 'created_at', 'updated_at', 'organization_id', 'org_id', 'deleted_at']);
+/** True when an object is a backend-resolved sibling ({value,label} relation, {name,…} user). */
+function isResolvedObject(v) {
+    if (!v || typeof v !== 'object' || Array.isArray(v))
+        return false;
+    const o = v;
+    return typeof o.label === 'string' || typeof o.name === 'string';
+}
 /** Returns all field keys that appear in the diff. */
 function diffKeys(event) {
-    if (event.changes && Object.keys(event.changes).length > 0) {
-        return Object.keys(event.changes);
-    }
     const before = event.before ?? {};
     const after = event.after ?? {};
-    const keys = new Set([...Object.keys(before), ...Object.keys(after)]);
-    // Filter out meta-level keys that are always present and rarely meaningful
-    // in a human-readable diff (id, created_at, updated_at, organization_id).
-    const META = new Set(['id', 'created_at', 'updated_at', 'organization_id', 'org_id']);
-    keys.forEach((k) => { if (META.has(k))
-        keys.delete(k); });
-    return Array.from(keys);
+    const source = event.changes && Object.keys(event.changes).length > 0
+        ? new Set(Object.keys(event.changes))
+        : new Set([...Object.keys(before), ...Object.keys(after)]);
+    META_KEYS.forEach((k) => source.delete(k));
+    // A resolved FK appears twice: the raw UUID key (created_by_id) and the
+    // resolved sibling (created_by: {name/label,…}). Drop the raw key — the
+    // sibling row already shows the human value. The sibling's value may live
+    // in before/after or inside changes[sibling] ({from,to}/{before,after}).
+    const siblingResolved = (sibling) => {
+        if (isResolvedObject(before[sibling]) || isResolvedObject(after[sibling]))
+            return true;
+        const ch = event.changes?.[sibling];
+        if (!ch || typeof ch !== 'object')
+            return false;
+        return isResolvedObject(ch.from) || isResolvedObject(ch.to) || isResolvedObject(ch.before) || isResolvedObject(ch.after);
+    };
+    return Array.from(source).filter((k) => {
+        if (!k.endsWith('_id'))
+            return true;
+        const sibling = k.slice(0, -3);
+        return !(source.has(sibling) && siblingResolved(sibling));
+    });
 }
 /** Returns the set of keys where the value actually changed. */
 function changedKeys(event) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "18.13.0",
+  "version": "18.13.1",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",

package/src/activity-diff.tsx

@@ -74,19 +74,41 @@ export interface ActivityDiffProps {
 // Helpers
 // ---------------------------------------------------------------------------
 
+// Meta-level keys that are always present and never meaningful in a
+// human-readable diff.
+const META_KEYS = new Set(['id', 'created_at', 'updated_at', 'organization_id', 'org_id', 'deleted_at'])
+
+/** True when an object is a backend-resolved sibling ({value,label} relation, {name,…} user). */
+function isResolvedObject(v: unknown): boolean {
+    if (!v || typeof v !== 'object' || Array.isArray(v)) return false
+    const o = v as Record<string, unknown>
+    return typeof o.label === 'string' || typeof o.name === 'string'
+}
+
 /** Returns all field keys that appear in the diff. */
 function diffKeys(event: ActivityEvent): string[] {
-    if (event.changes && Object.keys(event.changes).length > 0) {
-        return Object.keys(event.changes)
-    }
     const before = event.before ?? {}
     const after = event.after ?? {}
-    const keys = new Set([...Object.keys(before), ...Object.keys(after)])
-    // Filter out meta-level keys that are always present and rarely meaningful
-    // in a human-readable diff (id, created_at, updated_at, organization_id).
-    const META = new Set(['id', 'created_at', 'updated_at', 'organization_id', 'org_id'])
-    keys.forEach((k) => { if (META.has(k)) keys.delete(k) })
-    return Array.from(keys)
+    const source =
+        event.changes && Object.keys(event.changes).length > 0
+            ? new Set(Object.keys(event.changes))
+            : new Set([...Object.keys(before), ...Object.keys(after)])
+    META_KEYS.forEach((k) => source.delete(k))
+    // A resolved FK appears twice: the raw UUID key (created_by_id) and the
+    // resolved sibling (created_by: {name/label,…}). Drop the raw key — the
+    // sibling row already shows the human value. The sibling's value may live
+    // in before/after or inside changes[sibling] ({from,to}/{before,after}).
+    const siblingResolved = (sibling: string): boolean => {
+        if (isResolvedObject(before[sibling]) || isResolvedObject(after[sibling])) return true
+        const ch = (event.changes as Record<string, Record<string, unknown>> | undefined)?.[sibling]
+        if (!ch || typeof ch !== 'object') return false
+        return isResolvedObject(ch.from) || isResolvedObject(ch.to) || isResolvedObject(ch.before) || isResolvedObject(ch.after)
+    }
+    return Array.from(source).filter((k) => {
+        if (!k.endsWith('_id')) return true
+        const sibling = k.slice(0, -3)
+        return !(source.has(sibling) && siblingResolved(sibling))
+    })
 }
 
 /** Returns the set of keys where the value actually changed. */