@asteby/metacore-runtime-react 10.0.0 → 11.0.0

package/CHANGELOG.md

@@ -1,5 +1,28 @@
 # @asteby/metacore-runtime-react
 
+## 11.0.0
+
+### Patch Changes
+
+- 3a3ea4b: fix: unify slot priority ordering across SDK and runtime-react (was
+  inconsistent — DESC is now canonical, see `docs/slot-priority.md`).
+
+  `Registry.registerSlot` in `@asteby/metacore-sdk` sorted ascending
+  ("lower renders first") while `slotRegistry` in
+  `@asteby/metacore-runtime-react` sorted descending ("higher renders
+  first"). The runtime-react behaviour matches `docs/dynamic-ui.md`,
+  `mergeNavigation` and every other priority sort in the codebase, so the
+  SDK has been flipped to match. Addons that register a single
+  contribution per slot — i.e. every in-tree consumer we audited — are
+  unaffected. Addons relying on the inverted SDK order will need to swap
+  their priority values.
+
+- Updated dependencies [dee623a]
+- Updated dependencies [56d2013]
+- Updated dependencies [1c4a108]
+- Updated dependencies [3a3ea4b]
+  - @asteby/metacore-sdk@2.6.0
+
 ## 10.0.0
 
 ### Minor Changes

package/dist/slot.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"slot.d.ts","sourceRoot":"","sources":["../src/slot.tsx"],"names":[],"mappings":"AAGA,OAAO,KAA+B,MAAM,OAAO,CAAA;AAEnD,MAAM,MAAM,aAAa,CAAC,CAAC,GAAG,GAAG,IAAI,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC,CAAA;AAE3D,UAAU,SAAS;IACf,EAAE,EAAE,MAAM,CAAA;IACV,SAAS,EAAE,aAAa,CAAA;IACxB,QAAQ,EAAE,MAAM,CAAA;IAChB,MAAM,CAAC,EAAE,MAAM,CAAA;CAClB;AAED,KAAK,QAAQ,GAAG,MAAM,IAAI,CAAA;AAE1B,cAAM,gBAAgB;IAClB,OAAO,CAAC,KAAK,CAAiC;IAC9C,OAAO,CAAC,SAAS,CAAsB;IAEvC,QAAQ,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,aAAa,EAAE,IAAI,CAAC,EAAE;QAAE,QAAQ,CAAC,EAAE,MAAM,CAAC;QAAC,MAAM,CAAC,EAAE,MAAM,CAAA;KAAE,GAAG,MAAM,IAAI;IAkB7G,GAAG,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,EAAE;IAIhC,SAAS,CAAC,QAAQ,EAAE,QAAQ,GAAG,MAAM,IAAI;IAKzC,OAAO,CAAC,IAAI;CACf;AAED,eAAO,MAAM,YAAY,kBAAyB,CAAA;AAElD,MAAM,WAAW,SAAS;IACtB,eAAe;IACf,IAAI,EAAE,MAAM,CAAA;IACZ,sDAAsD;IACtD,KAAK,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;IAC3B,iEAAiE;IACjE,QAAQ,CAAC,EAAE,KAAK,CAAC,SAAS,CAAA;CAC7B;AAED,wBAAgB,IAAI,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,QAAe,EAAE,EAAE,SAAS,2CAe/D"}
+{"version":3,"file":"slot.d.ts","sourceRoot":"","sources":["../src/slot.tsx"],"names":[],"mappings":"AAGA,OAAO,KAA+B,MAAM,OAAO,CAAA;AAEnD,MAAM,MAAM,aAAa,CAAC,CAAC,GAAG,GAAG,IAAI,KAAK,CAAC,aAAa,CAAC,CAAC,CAAC,CAAA;AAE3D,UAAU,SAAS;IACf,EAAE,EAAE,MAAM,CAAA;IACV,SAAS,EAAE,aAAa,CAAA;IACxB,QAAQ,EAAE,MAAM,CAAA;IAChB,MAAM,CAAC,EAAE,MAAM,CAAA;CAClB;AAED,KAAK,QAAQ,GAAG,MAAM,IAAI,CAAA;AAE1B,cAAM,gBAAgB;IAClB,OAAO,CAAC,KAAK,CAAiC;IAC9C,OAAO,CAAC,SAAS,CAAsB;IAEvC,QAAQ,CAAC,MAAM,EAAE,MAAM,EAAE,SAAS,EAAE,aAAa,EAAE,IAAI,CAAC,EAAE;QAAE,QAAQ,CAAC,EAAE,MAAM,CAAC;QAAC,MAAM,CAAC,EAAE,MAAM,CAAA;KAAE,GAAG,MAAM,IAAI;IAoB7G,GAAG,CAAC,MAAM,EAAE,MAAM,GAAG,SAAS,EAAE;IAIhC,SAAS,CAAC,QAAQ,EAAE,QAAQ,GAAG,MAAM,IAAI;IAKzC,OAAO,CAAC,IAAI;CACf;AAED,eAAO,MAAM,YAAY,kBAAyB,CAAA;AAElD,MAAM,WAAW,SAAS;IACtB,eAAe;IACf,IAAI,EAAE,MAAM,CAAA;IACZ,sDAAsD;IACtD,KAAK,CAAC,EAAE,MAAM,CAAC,MAAM,EAAE,GAAG,CAAC,CAAA;IAC3B,iEAAiE;IACjE,QAAQ,CAAC,EAAE,KAAK,CAAC,SAAS,CAAA;CAC7B;AAED,wBAAgB,IAAI,CAAC,EAAE,IAAI,EAAE,KAAK,EAAE,QAAe,EAAE,EAAE,SAAS,2CAe/D"}

package/dist/slot.js

@@ -10,6 +10,8 @@ class SlotRegistryImpl {
         const entry = { id: slotId, component, priority: opts?.priority ?? 0, source: opts?.source };
         const list = this.slots.get(slotId) ?? [];
         list.push(entry);
+        // Higher priority renders first — canonical across SDK and runtime-react.
+        // See docs/slot-priority.md.
         list.sort((a, b) => b.priority - a.priority);
         this.slots.set(slotId, list);
         this.emit();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@asteby/metacore-runtime-react",
-  "version": "10.0.0",
+  "version": "11.0.0",
   "description": "React runtime for metacore hosts — renders addon contributions dynamically",
   "repository": {
     "type": "git",
@@ -32,7 +32,7 @@
     "lucide-react": ">=0.460",
     "date-fns": ">=3",
     "react-day-picker": ">=8",
-    "@asteby/metacore-sdk": "^2.5.0",
+    "@asteby/metacore-sdk": "^2.6.0",
     "@asteby/metacore-ui": "^2.0.0"
   },
   "peerDependenciesMeta": {
@@ -60,7 +60,7 @@
     "typescript": "^6.0.0",
     "vitest": "^4.0.0",
     "zustand": "^5.0.0",
-    "@asteby/metacore-sdk": "2.5.0",
+    "@asteby/metacore-sdk": "2.6.0",
     "@asteby/metacore-ui": "2.0.0"
   },
   "scripts": {

package/src/__tests__/slot.test.ts

@@ -0,0 +1,70 @@
+import { describe, expect, it } from 'vitest'
+import type { ComponentType } from 'react'
+import { slotRegistry } from '../slot'
+
+// Dummy components — slot registry stores+sorts, doesn't render.
+const A: ComponentType = () => null
+const B: ComponentType = () => null
+const C: ComponentType = () => null
+const D: ComponentType = () => null
+
+describe('slotRegistry priority ordering', () => {
+    it('renders higher priority first (DESC) — canonical contract', () => {
+        const slot = `test.desc.${Math.random()}`
+        const off1 = slotRegistry.register(slot, A, { priority: 1 })
+        const off2 = slotRegistry.register(slot, B, { priority: 5 })
+        const off3 = slotRegistry.register(slot, C, { priority: 3 })
+
+        const items = slotRegistry.get(slot)
+        expect(items.map((i) => i.priority)).toEqual([5, 3, 1])
+        expect(items.map((i) => i.component)).toEqual([B, C, A])
+
+        off1()
+        off2()
+        off3()
+    })
+
+    it('treats missing priority as 0', () => {
+        const slot = `test.zero.${Math.random()}`
+        const off1 = slotRegistry.register(slot, A)
+        const off2 = slotRegistry.register(slot, B, { priority: 10 })
+        const off3 = slotRegistry.register(slot, C, { priority: -5 })
+
+        const items = slotRegistry.get(slot)
+        expect(items.map((i) => i.component)).toEqual([B, A, C])
+
+        off1()
+        off2()
+        off3()
+    })
+
+    it('preserves insertion order on ties', () => {
+        const slot = `test.ties.${Math.random()}`
+        const off1 = slotRegistry.register(slot, A, { priority: 1 })
+        const off2 = slotRegistry.register(slot, B, { priority: 1 })
+        const off3 = slotRegistry.register(slot, C, { priority: 2 })
+        const off4 = slotRegistry.register(slot, D, { priority: 1 })
+
+        const items = slotRegistry.get(slot)
+        expect(items.map((i) => i.component)).toEqual([C, A, B, D])
+
+        off1()
+        off2()
+        off3()
+        off4()
+    })
+
+    it('unregister removes the entry and notifies subscribers', () => {
+        const slot = `test.unreg.${Math.random()}`
+        let notifications = 0
+        const unsubscribe = slotRegistry.subscribe(() => { notifications++ })
+        const off = slotRegistry.register(slot, A, { priority: 1 })
+        expect(slotRegistry.get(slot)).toHaveLength(1)
+        expect(notifications).toBeGreaterThanOrEqual(1)
+        const before = notifications
+        off()
+        expect(slotRegistry.get(slot)).toHaveLength(0)
+        expect(notifications).toBeGreaterThan(before)
+        unsubscribe()
+    })
+})

package/src/slot.tsx

@@ -22,6 +22,8 @@ class SlotRegistryImpl {
         const entry: SlotEntry = { id: slotId, component, priority: opts?.priority ?? 0, source: opts?.source }
         const list = this.slots.get(slotId) ?? []
         list.push(entry)
+        // Higher priority renders first — canonical across SDK and runtime-react.
+        // See docs/slot-priority.md.
         list.sort((a, b) => b.priority - a.priority)
         this.slots.set(slotId, list)
         this.emit()