@assistkick/create 1.7.0 → 1.9.0

package/templates/assistkick-product-system/packages/backend/src/services/agent_service.ts

@@ -0,0 +1,416 @@
+/**
+ * Agent service — CRUD operations for agents.
+ * Handles listing, creating, updating, deleting agents with deletion protection,
+ * and resetting default agents to original prompts.
+ */
+
+import { eq, isNull } from 'drizzle-orm';
+import { agents, workflows } from '@assistkick/shared/db/schema.js';
+import { randomUUID } from 'node:crypto';
+import { readFile } from 'node:fs/promises';
+
+interface AgentServiceDeps {
+  getDb: () => any;
+  log: (tag: string, ...args: any[]) => void;
+  skillPaths: {
+    developer: string;
+    reviewer: string;
+    debugger: string;
+    videoScriptWriter?: string;
+    videoCompositionAgent?: string;
+  };
+}
+
+export interface AgentRecord {
+  id: string;
+  name: string;
+  promptTemplate: string;
+  projectId: string | null;
+  isDefault: number;
+  createdAt: string;
+  updatedAt: string;
+}
+
+/** Maps stage identifiers to default agent display names. */
+const DEFAULT_AGENT_NAMES: Record<string, string> = {
+  developer: 'Default Developer',
+  reviewer: 'Default Reviewer',
+  debugger: 'Default Debugger',
+  videoScriptWriter: 'Default Video Script Writer',
+  videoCompositionAgent: 'Default Video Composition Agent',
+};
+
+export class AgentService {
+  private readonly getDb: () => any;
+  private readonly log: (tag: string, ...args: any[]) => void;
+  private readonly skillPaths: AgentServiceDeps['skillPaths'];
+
+  constructor({ getDb, log, skillPaths }: AgentServiceDeps) {
+    this.getDb = getDb;
+    this.log = log;
+    this.skillPaths = skillPaths;
+  }
+
+  /** List agents filtered by scope. */
+  listAgents = async (scope: 'global' | 'project', projectId?: string): Promise<AgentRecord[]> => {
+    const db = this.getDb();
+
+    if (scope === 'global') {
+      return db.select().from(agents).where(isNull(agents.projectId));
+    }
+
+    if (!projectId) {
+      throw new Error('projectId is required for project scope');
+    }
+
+    return db.select().from(agents).where(eq(agents.projectId, projectId));
+  };
+
+  /** Get a single agent by ID. */
+  getById = async (id: string): Promise<AgentRecord | null> => {
+    const db = this.getDb();
+    const [row] = await db.select().from(agents).where(eq(agents.id, id));
+    return row || null;
+  };
+
+  /** Create a new agent. */
+  create = async (data: { name: string; promptTemplate: string; projectId?: string | null }): Promise<AgentRecord> => {
+    const db = this.getDb();
+    const now = new Date().toISOString();
+    const id = randomUUID();
+
+    const record: AgentRecord = {
+      id,
+      name: data.name,
+      promptTemplate: data.promptTemplate,
+      projectId: data.projectId || null,
+      isDefault: 0,
+      createdAt: now,
+      updatedAt: now,
+    };
+
+    await db.insert(agents).values(record);
+    this.log('AGENTS', `Created agent: ${data.name} (${id})`);
+    return record;
+  };
+
+  /** Update an agent's name and/or prompt_template. */
+  update = async (id: string, data: { name?: string; promptTemplate?: string }): Promise<AgentRecord> => {
+    const db = this.getDb();
+    const existing = await this.getById(id);
+
+    if (!existing) {
+      throw new Error('Agent not found');
+    }
+
+    const now = new Date().toISOString();
+    const updates: Record<string, any> = { updatedAt: now };
+
+    if (data.name !== undefined) updates.name = data.name;
+    if (data.promptTemplate !== undefined) updates.promptTemplate = data.promptTemplate;
+
+    await db.update(agents).set(updates).where(eq(agents.id, id));
+
+    this.log('AGENTS', `Updated agent: ${existing.name} (${id})`);
+    return { ...existing, ...updates };
+  };
+
+  /** Delete an agent. Blocked if referenced in any workflow graph_data. */
+  delete = async (id: string): Promise<void> => {
+    const db = this.getDb();
+    const existing = await this.getById(id);
+
+    if (!existing) {
+      throw new Error('Agent not found');
+    }
+
+    if (existing.isDefault) {
+      throw new Error('Cannot delete a default agent');
+    }
+
+    // Check if agent is referenced in any workflow graph_data (RunAgent node configs)
+    const allWorkflows = await db.select().from(workflows);
+    const referencingWorkflow = allWorkflows.find((w: { graphData: string }) => w.graphData.includes(id));
+    if (referencingWorkflow) {
+      throw new Error('Cannot delete an agent that is referenced in a workflow');
+    }
+
+    await db.delete(agents).where(eq(agents.id, id));
+    this.log('AGENTS', `Deleted agent: ${existing.name} (${id})`);
+  };
+
+  /** Reset a default agent's prompt_template to the original system prompt. */
+  resetToDefault = async (id: string): Promise<AgentRecord> => {
+    const db = this.getDb();
+    const existing = await this.getById(id);
+
+    if (!existing) {
+      throw new Error('Agent not found');
+    }
+
+    if (!existing.isDefault) {
+      throw new Error('Only default agents can be reset');
+    }
+
+    // Determine the stage from the agent's name (e.g. "Default Developer" → "developer")
+    const stage = this.inferStageFromName(existing.name);
+    if (!stage) {
+      throw new Error('Cannot determine stage for this default agent');
+    }
+
+    const template = await this.buildDefaultTemplate(stage);
+    const now = new Date().toISOString();
+
+    await db
+      .update(agents)
+      .set({ promptTemplate: template, updatedAt: now })
+      .where(eq(agents.id, id));
+
+    this.log('AGENTS', `Reset default agent to original prompt: ${existing.name} (${id})`);
+    return { ...existing, promptTemplate: template, updatedAt: now };
+  };
+
+  /** Refresh all default agent prompt templates from SKILL.md + template sections.
+   *  Called on server startup to keep stored prompts in sync with code changes.
+   *  Also creates any missing default agents that have a skill path configured. */
+  syncDefaults = async (): Promise<void> => {
+    const db = this.getDb();
+    const allAgents = await db.select().from(agents).where(eq(agents.isDefault, 1));
+    const now = new Date().toISOString();
+
+    // Update existing default agents
+    for (const agent of allAgents) {
+      const stage = this.inferStageFromName(agent.name);
+      if (!stage) continue;
+      try {
+        const template = await this.buildDefaultTemplate(stage);
+        if (template !== agent.promptTemplate) {
+          await db.update(agents).set({ promptTemplate: template, updatedAt: now }).where(eq(agents.id, agent.id));
+          this.log('AGENTS', `Synced default agent prompt: ${agent.name} (${agent.id})`);
+        }
+      } catch { /* skip if skill file missing */ }
+    }
+
+    // Create missing default agents
+    for (const [stage, name] of Object.entries(DEFAULT_AGENT_NAMES)) {
+      const skillPath = this.skillPaths[stage as keyof typeof this.skillPaths];
+      if (!skillPath) continue;
+      const exists = allAgents.some((a: AgentRecord) => this.inferStageFromName(a.name) === stage);
+      if (exists) continue;
+      try {
+        const template = await this.buildDefaultTemplate(stage);
+        const id = randomUUID();
+        await db.insert(agents).values({
+          id,
+          name,
+          promptTemplate: template,
+          projectId: null,
+          isDefault: 1,
+          createdAt: now,
+          updatedAt: now,
+        });
+        this.log('AGENTS', `Created missing default agent: ${name} (${id})`);
+      } catch { /* skip if skill file missing or read error */ }
+    }
+  };
+
+  /** Infer the stage from a default agent's name. */
+  private inferStageFromName = (name: string): string | null => {
+    const lower = name.toLowerCase();
+    if (lower.includes('developer')) return 'developer';
+    if (lower.includes('reviewer')) return 'reviewer';
+    if (lower.includes('debugger')) return 'debugger';
+    if (lower.includes('video script')) return 'videoScriptWriter';
+    if (lower.includes('video composition')) return 'videoCompositionAgent';
+    return null;
+  };
+
+  /** Build the default prompt template for a stage by reading the SKILL.md file. */
+  private buildDefaultTemplate = async (stage: string): Promise<string> => {
+    const pathMap: Record<string, string | undefined> = {
+      developer: this.skillPaths.developer,
+      reviewer: this.skillPaths.reviewer,
+      debugger: this.skillPaths.debugger,
+      videoScriptWriter: this.skillPaths.videoScriptWriter,
+      videoCompositionAgent: this.skillPaths.videoCompositionAgent,
+    };
+
+    const skillPath = pathMap[stage];
+    if (!skillPath) {
+      throw new Error(`Unknown stage: ${stage}`);
+    }
+
+    const skillContent = await readFile(skillPath, 'utf-8');
+
+    // Append the dynamic template sections with {{placeholder}} syntax
+    // These match the format used in the seed data
+    let template = skillContent + '\n\n';
+
+    if (stage === 'developer') {
+      template += this.buildDeveloperTemplateSections();
+    } else if (stage === 'reviewer') {
+      template += this.buildReviewerTemplateSections();
+    } else if (stage === 'debugger') {
+      template += this.buildDebuggerTemplateSections();
+    } else if (stage === 'videoScriptWriter') {
+      template += this.buildVideoScriptWriterTemplateSections();
+    } else if (stage === 'videoCompositionAgent') {
+      template += this.buildVideoCompositionAgentTemplateSections();
+    }
+
+    return template;
+  };
+
+  private buildDeveloperTemplateSections = (): string => {
+    let s = '';
+    s += `## CRITICAL: Data Isolation\n`;
+    s += `You are working in a git worktree. The worktree is ONLY for code changes.\n`;
+    s += `All kanban, graph, and spec data lives in the MAIN REPO — never use the worktree copy.\n\n`;
+    s += `**All tool commands MUST use absolute paths to the main repo's tools:**\n`;
+    s += `- Tools directory: {{mainToolsDir}}\n`;
+    s += `- All tool commands MUST be run from: {{mainSkillDir}}\n`;
+    s += `- Example: cd {{mainSkillDir}} && npx tsx packages/shared/tools/get_node.ts {{featureId}}{{pidFlag}}\n`;
+    s += `- Example: cd {{mainSkillDir}} && npx tsx packages/shared/tools/move_card.ts {{featureId}} in_review{{pidFlag}}\n\n`;
+    s += `NEVER run tools from the worktree directory. NEVER use relative paths like \`assistkick-product-system/tools/\`.\n`;
+    s += `ALWAYS \`cd {{mainSkillDir}}\` before running any tool command.\n`;
+    s += `ALWAYS include --project-id {{projectId}} when running any tool command.\n\n`;
+    s += `## Development Guidelines\n`;
+    s += `Before writing any code, load the development guidelines:\n`;
+    s += `  cd {{mainSkillDir}} && npx tsx packages/shared/tools/get_node.ts nfr_001{{pidFlag}}\n`;
+    s += `These guidelines define mandatory coding standards (class-based architecture, arrow functions, constructor DI, naming conventions). All code you write MUST follow them.\n\n`;
+    s += `## Current Task\n`;
+    s += `Implement feature {{featureId}}. Read the feature spec using get_node, understand all related nodes, and implement it.\n\n`;
+    s += `{{debuggerFindings}}\n\n`;
+    s += `{{previousReviewNotes}}\n\n`;
+    s += `When done implementing, do NOT move the card yourself — the pipeline will handle card transitions.\n\n`;
+    s += `## REQUIRED: Work Summary Output\n`;
+    s += `After completing your implementation, you MUST output a structured work summary block as your final text output.\n`;
+    s += `The pipeline will parse this block to record what was done. Use this exact format:\n\n`;
+    s += '```\n';
+    s += `## Work Summary\n`;
+    s += `### Approach\n`;
+    s += `<A short paragraph explaining what you implemented and why you chose this approach.>\n`;
+    s += `### Decisions\n`;
+    s += `- <Key decision 1 you made during implementation>\n`;
+    s += `- <Key decision 2>\n`;
+    s += '```\n\n';
+    s += `This block MUST appear in your final output. Do not skip it.\n`;
+    return s;
+  };
+
+  private buildReviewerTemplateSections = (): string => {
+    let s = '';
+    s += `## CRITICAL: Data Isolation\n`;
+    s += `You are reviewing code in a git worktree. The worktree is ONLY for code changes.\n`;
+    s += `All kanban, graph, and spec data lives in the MAIN REPO — never use the worktree copy.\n\n`;
+    s += `**All tool commands MUST use absolute paths to the main repo's tools:**\n`;
+    s += `- Tools directory: {{mainToolsDir}}\n`;
+    s += `- All tool commands MUST be run from: {{mainSkillDir}}\n`;
+    s += `- Example: cd {{mainSkillDir}} && npx tsx packages/shared/tools/get_node.ts {{featureId}}{{pidFlag}}\n`;
+    s += `- Example: cd {{mainSkillDir}} && npx tsx packages/shared/tools/move_card.ts {{featureId}} qa{{pidFlag}}\n\n`;
+    s += `NEVER run tools from the worktree directory. NEVER use relative paths like \`assistkick-product-system/tools/\`.\n`;
+    s += `ALWAYS \`cd {{mainSkillDir}}\` before running any tool command.\n`;
+    s += `ALWAYS include --project-id {{projectId}} when running any tool command.\n\n`;
+    s += `## Current Task\n`;
+    s += `Review feature {{featureId}}. Read the feature spec using get_node, understand all related nodes, and review the implementation.\n`;
+    s += `If the implementation passes review, approve it by running: cd {{mainSkillDir}} && npx tsx packages/shared/tools/move_card.ts {{featureId}} qa{{pidFlag}}\n`;
+    s += `If it fails, reject it with a note: cd {{mainSkillDir}} && npx tsx packages/shared/tools/move_card.ts {{featureId}} todo{{pidFlag}} --note "description of issues"\n`;
+    return s;
+  };
+
+  private buildVideoScriptWriterTemplateSections = (): string => {
+    let s = '';
+    s += `## CRITICAL: Data Isolation\n`;
+    s += `You are working in a git worktree. The worktree is ONLY for code changes.\n`;
+    s += `All kanban, graph, and spec data lives in the MAIN REPO — never use the worktree copy.\n\n`;
+    s += `## Current Task\n`;
+    s += `Write a video script for the following feature brief:\n\n`;
+    s += `{{featureDescription}}\n\n`;
+    s += `Write the script to: {{worktreePath}}/assistkick-product-system/packages/video/scripts/{{compositionName}}-script.md\n\n`;
+    s += `The composition name is: {{compositionName}}\n\n`;
+    s += `## Iteration Handling\n`;
+    s += `When re-running on a feature that was moved back to TODO, you receive iteration\n`;
+    s += `comments from the previous review. Address all feedback in your revised script.\n\n`;
+    s += `{{iterationComments}}\n\n`;
+    s += `When done, do NOT move the card yourself — the pipeline will handle card transitions.\n\n`;
+    s += `## REQUIRED: Work Summary Output\n`;
+    s += `After completing your script, you MUST output a structured work summary block as your final text output.\n`;
+    s += `The pipeline will parse this block to record what was done. Use this exact format:\n\n`;
+    s += '```\n';
+    s += `## Work Summary\n`;
+    s += `### Approach\n`;
+    s += `<A short paragraph explaining the script structure and creative choices.>\n`;
+    s += `### Decisions\n`;
+    s += `- <Key decision 1 about scene structure or content>\n`;
+    s += `- <Key decision 2>\n`;
+    s += '```\n\n';
+    s += `This block MUST appear in your final output. Do not skip it.\n`;
+    return s;
+  };
+
+  private buildVideoCompositionAgentTemplateSections = (): string => {
+    let s = '';
+    s += `## CRITICAL: Data Isolation\n`;
+    s += `You are working in a git worktree. The worktree is ONLY for code changes.\n`;
+    s += `All kanban, graph, and spec data lives in the MAIN REPO — never use the worktree copy.\n\n`;
+    s += `## Current Task\n`;
+    s += `Read the video script and generate the Remotion composition code for the following feature:\n\n`;
+    s += `{{featureDescription}}\n\n`;
+    s += `Script file: {{worktreePath}}/assistkick-product-system/packages/video/scripts/{{compositionName}}-script.md\n\n`;
+    s += `The composition name is: {{compositionName}}\n`;
+    s += `Write the composition to: {{worktreePath}}/assistkick-product-system/packages/video/compositions/{{compositionName}}/index.tsx\n`;
+    s += `Register it in: {{worktreePath}}/assistkick-product-system/packages/video/Root.tsx\n\n`;
+    s += `## Component Reuse\n`;
+    s += `Before creating new components, list existing files in packages/video/components/ within the worktree.\n`;
+    s += `Import and reuse shared components (TitleScene, Scene, OutroScene, PartDivider, EmailScene, VideoSplitLayout, theme) rather than duplicating.\n`;
+    s += `Only create new components in packages/video/components/ when the script describes a scene type not covered by existing components.\n\n`;
+    s += `## Iteration Handling\n`;
+    s += `When re-running on a feature that was moved back to TODO, you receive iteration\n`;
+    s += `comments from the previous review. Address all feedback in your revised composition.\n\n`;
+    s += `{{iterationComments}}\n\n`;
+    s += `When done, do NOT move the card yourself — the pipeline will handle card transitions.\n\n`;
+    s += `## REQUIRED: Work Summary Output\n`;
+    s += `After completing your composition, you MUST output a structured work summary block as your final text output.\n`;
+    s += `The pipeline will parse this block to record what was done. Use this exact format:\n\n`;
+    s += '```\n';
+    s += `## Work Summary\n`;
+    s += `### Approach\n`;
+    s += `<A short paragraph explaining the composition structure and component choices.>\n`;
+    s += `### Decisions\n`;
+    s += `- <Key decision 1 about component reuse or scene implementation>\n`;
+    s += `- <Key decision 2>\n`;
+    s += '```\n\n';
+    s += `This block MUST appear in your final output. Do not skip it.\n`;
+    return s;
+  };
+
+  private buildDebuggerTemplateSections = (): string => {
+    let s = '';
+    s += `## CRITICAL: Data Isolation\n`;
+    s += `You are investigating bugs in a git worktree. The worktree is ONLY for code changes.\n`;
+    s += `All kanban, graph, and spec data lives in the MAIN REPO — never use the worktree copy.\n\n`;
+    s += `**All tool commands MUST use absolute paths to the main repo's tools:**\n`;
+    s += `- Tools directory: {{mainToolsDir}}\n`;
+    s += `- All tool commands MUST be run from: {{mainSkillDir}}\n`;
+    s += `- Example: cd {{mainSkillDir}} && npx tsx packages/shared/tools/get_node.ts {{featureId}}{{pidFlag}}\n\n`;
+    s += `NEVER run tools from the worktree directory. NEVER use relative paths.\n`;
+    s += `ALWAYS \`cd {{mainSkillDir}}\` before running any tool command.\n`;
+    s += `ALWAYS include --project-id {{projectId}} when running any tool command.\n\n`;
+    s += `## Current Task\n`;
+    s += `You are running as part of an automated pipeline. Do NOT create bugfix features or move kanban cards.\n`;
+    s += `Instead, investigate the QA rejection notes below and output your findings as a structured report.\n\n`;
+    s += `Feature: {{featureId}}\n\n`;
+    s += `{{unaddressedNotes}}\n\n`;
+    s += `## Instructions\n`;
+    s += `1. Read the feature spec using get_node to understand what the feature should do\n`;
+    s += `2. Read all related nodes to understand the full context\n`;
+    s += `3. Trace through the code to find the root cause of each reported issue\n`;
+    s += `4. Output a structured report with your findings. For each issue:\n`;
+    s += `   - The original QA note text\n`;
+    s += `   - Root cause analysis with specific file paths and line numbers\n`;
+    s += `   - Why the current code fails\n`;
+    s += `   - Specific guidance on what needs to change to fix it\n`;
+    s += `5. Do NOT create bugfix features, do NOT move kanban cards, do NOT write code fixes\n`;
+    return s;
+  };
+}

package/templates/assistkick-product-system/packages/backend/src/services/bundle_service.test.ts

@@ -0,0 +1,189 @@
+import { describe, it, beforeEach, afterEach } from 'node:test';
+import assert from 'node:assert/strict';
+import { mkdirSync, writeFileSync, rmSync } from 'node:fs';
+import { join } from 'node:path';
+import { tmpdir } from 'node:os';
+import { BundleService } from './bundle_service.js';
+
+describe('BundleService', () => {
+  let tempDir: string;
+  let videoPackageDir: string;
+  let bundleOutputDir: string;
+  let logs: string[];
+
+  const makeService = () => {
+    logs = [];
+    return new BundleService({
+      videoPackageDir,
+      bundleOutputDir,
+      log: (tag: string, ...args: any[]) => { logs.push(`[${tag}] ${args.join(' ')}`); },
+    });
+  };
+
+  beforeEach(() => {
+    tempDir = join(tmpdir(), `bundle-test-${Date.now()}-${Math.random().toString(36).slice(2)}`);
+    videoPackageDir = join(tempDir, 'video');
+    bundleOutputDir = join(tempDir, 'bundle-output');
+    mkdirSync(join(videoPackageDir, 'compositions'), { recursive: true });
+    mkdirSync(bundleOutputDir, { recursive: true });
+  });
+
+  afterEach(() => {
+    rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  describe('getStatus', () => {
+    it('reports not ready when no bundle exists', () => {
+      const svc = makeService();
+      const status = svc.getStatus();
+      assert.equal(status.ready, false);
+      assert.equal(status.building, false);
+      assert.equal(status.bundlePath, null);
+      assert.equal(status.lastBuiltAt, null);
+      assert.equal(status.error, null);
+    });
+
+    it('reports ready when bundle index.html exists', () => {
+      writeFileSync(join(bundleOutputDir, 'index.html'), '<html></html>');
+      const svc = makeService();
+      const status = svc.getStatus();
+      assert.equal(status.ready, true);
+      assert.equal(status.bundlePath, bundleOutputDir);
+    });
+  });
+
+  describe('isBundleReady', () => {
+    it('returns false when bundle directory is empty', () => {
+      const svc = makeService();
+      assert.equal(svc.isBundleReady(), false);
+    });
+
+    it('returns true when index.html exists in bundle dir', () => {
+      writeFileSync(join(bundleOutputDir, 'index.html'), '<html></html>');
+      const svc = makeService();
+      assert.equal(svc.isBundleReady(), true);
+    });
+  });
+
+  describe('getBundleDir', () => {
+    it('returns the configured bundle output directory', () => {
+      const svc = makeService();
+      assert.equal(svc.getBundleDir(), bundleOutputDir);
+    });
+  });
+
+  describe('listCompositions', () => {
+    it('returns empty array when compositions directory is empty', () => {
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.deepEqual(result, []);
+    });
+
+    it('returns empty array when compositions directory does not exist', () => {
+      rmSync(join(videoPackageDir, 'compositions'), { recursive: true });
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.deepEqual(result, []);
+    });
+
+    it('parses composition metadata from index.tsx', () => {
+      const compDir = join(videoPackageDir, 'compositions', 'my_video');
+      mkdirSync(compDir, { recursive: true });
+      writeFileSync(join(compDir, 'index.tsx'), `
+import { MyComponent } from '../../components/my_component';
+
+export const component = MyComponent;
+export const id = 'my-video';
+export const durationInFrames = 450;
+export const fps = 30;
+export const width = 1920;
+export const height = 1080;
+export const folder = 'Demos';
+`);
+
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.equal(result.length, 1);
+      assert.deepEqual(result[0], {
+        id: 'my-video',
+        durationInFrames: 450,
+        fps: 30,
+        width: 1920,
+        height: 1080,
+        folder: 'Demos',
+      });
+    });
+
+    it('uses defaults for missing optional fields', () => {
+      const compDir = join(videoPackageDir, 'compositions', 'simple');
+      mkdirSync(compDir, { recursive: true });
+      writeFileSync(join(compDir, 'index.tsx'), `
+export const component = () => null;
+export const id = 'simple-comp';
+export const durationInFrames = 600;
+`);
+
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.equal(result.length, 1);
+      assert.equal(result[0].id, 'simple-comp');
+      assert.equal(result[0].durationInFrames, 600);
+      assert.equal(result[0].fps, 30);
+      assert.equal(result[0].width, 1920);
+      assert.equal(result[0].height, 1080);
+      assert.equal(result[0].folder, undefined);
+    });
+
+    it('skips directories without index.tsx', () => {
+      const compDir = join(videoPackageDir, 'compositions', 'incomplete');
+      mkdirSync(compDir, { recursive: true });
+      writeFileSync(join(compDir, 'some_other_file.ts'), 'export const x = 1;');
+
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.deepEqual(result, []);
+    });
+
+    it('skips files without exported id', () => {
+      const compDir = join(videoPackageDir, 'compositions', 'no_id');
+      mkdirSync(compDir, { recursive: true });
+      writeFileSync(join(compDir, 'index.tsx'), `
+export const component = () => null;
+export const durationInFrames = 300;
+`);
+
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.deepEqual(result, []);
+    });
+
+    it('handles multiple compositions', () => {
+      for (const name of ['alpha', 'beta', 'gamma']) {
+        const compDir = join(videoPackageDir, 'compositions', name);
+        mkdirSync(compDir, { recursive: true });
+        writeFileSync(join(compDir, 'index.tsx'), `
+export const component = () => null;
+export const id = '${name}';
+export const durationInFrames = 300;
+export const fps = 24;
+export const width = 1280;
+export const height = 720;
+`);
+      }
+
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.equal(result.length, 3);
+      const ids = result.map(c => c.id).sort();
+      assert.deepEqual(ids, ['alpha', 'beta', 'gamma']);
+    });
+
+    it('ignores non-directory entries in compositions folder', () => {
+      writeFileSync(join(videoPackageDir, 'compositions', '.gitkeep'), '');
+
+      const svc = makeService();
+      const result = svc.listCompositions();
+      assert.deepEqual(result, []);
+    });
+  });
+});