@assistant-ui/tap 0.5.12 → 0.5.13
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/hooks/tap-callback.js.map +1 -1
- package/dist/hooks/tap-resource.js.map +1 -1
- package/dist/hooks/tap-resources.js.map +1 -1
- package/dist/react/use-resource.js.map +1 -1
- package/package.json +1 -1
- package/src/__tests__/basic/tapEffect.basic.test.ts +4 -1
- package/src/__tests__/errors/errors.effect-errors.test.ts +3 -4
- package/src/__tests__/lifecycle/lifecycle.dependencies.test.ts +1 -1
- package/src/__tests__/strictmode/react-strictmode-behavior.test.tsx +1 -0
- package/src/__tests__/strictmode/react-strictmode-rerender-sources.test.tsx +17 -5
- package/src/__tests__/strictmode/tap-strictmode-rerender-sources.test.ts +1 -0
- package/src/hooks/tap-callback.ts +1 -1
- package/src/hooks/tap-resource.ts +2 -2
- package/src/hooks/tap-resources.ts +1 -1
- package/src/react/use-resource.ts +2 -2
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"tap-callback.js","names":[],"sources":["../../src/hooks/tap-callback.ts"],"sourcesContent":["import { tapMemo } from \"./tap-memo\";\n\nexport const tapCallback = <T extends (...args: any[]) => any>(\n fn: T,\n deps: readonly unknown[],\n): T => {\n //
|
|
1
|
+
{"version":3,"file":"tap-callback.js","names":[],"sources":["../../src/hooks/tap-callback.ts"],"sourcesContent":["import { tapMemo } from \"./tap-memo\";\n\nexport const tapCallback = <T extends (...args: any[]) => any>(\n fn: T,\n deps: readonly unknown[],\n): T => {\n // oxlint-disable-next-line tap-hooks/exhaustive-deps -- user-provided dep array forwarded verbatim\n return tapMemo(() => fn, deps);\n};\n"],"mappings":";;AAEA,MAAa,eACX,IACA,SACM;CAEN,OAAO,cAAc,IAAI,IAAI;AAC/B"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"tap-resource.js","names":[],"sources":["../../src/hooks/tap-resource.ts"],"sourcesContent":["import type { ExtractResourceReturnType, ResourceElement } from \"../core/types\";\nimport { tapEffect } from \"./tap-effect\";\nimport {\n createResourceFiber,\n unmountResourceFiber,\n renderResourceFiber,\n commitResourceFiber,\n} from \"../core/ResourceFiber\";\nimport { tapMemo } from \"./tap-memo\";\nimport { tapRef } from \"./tap-ref\";\nimport { getCurrentResourceFiber } from \"../core/helpers/execution-context\";\n\nexport function tapResource<E extends ResourceElement<any, any>>(\n element: E,\n): ExtractResourceReturnType<E>;\nexport function tapResource<E extends ResourceElement<any, any>>(\n element: E,\n propsDeps: readonly unknown[],\n): ExtractResourceReturnType<E>;\nexport function tapResource<E extends ResourceElement<any, any>>(\n element: E,\n propsDeps?: readonly unknown[],\n): ExtractResourceReturnType<E> {\n const parentFiber = getCurrentResourceFiber();\n const versionRef = tapRef(0);\n const fiber = tapMemo(() => {\n void element.key;\n return createResourceFiber(element.type, parentFiber.root, () => {\n versionRef.current++;\n parentFiber.markDirty?.();\n });\n }, [element.type, element.key, parentFiber]);\n\n const result = propsDeps\n ?
|
|
1
|
+
{"version":3,"file":"tap-resource.js","names":[],"sources":["../../src/hooks/tap-resource.ts"],"sourcesContent":["import type { ExtractResourceReturnType, ResourceElement } from \"../core/types\";\nimport { tapEffect } from \"./tap-effect\";\nimport {\n createResourceFiber,\n unmountResourceFiber,\n renderResourceFiber,\n commitResourceFiber,\n} from \"../core/ResourceFiber\";\nimport { tapMemo } from \"./tap-memo\";\nimport { tapRef } from \"./tap-ref\";\nimport { getCurrentResourceFiber } from \"../core/helpers/execution-context\";\n\nexport function tapResource<E extends ResourceElement<any, any>>(\n element: E,\n): ExtractResourceReturnType<E>;\nexport function tapResource<E extends ResourceElement<any, any>>(\n element: E,\n propsDeps: readonly unknown[],\n): ExtractResourceReturnType<E>;\nexport function tapResource<E extends ResourceElement<any, any>>(\n element: E,\n propsDeps?: readonly unknown[],\n): ExtractResourceReturnType<E> {\n const parentFiber = getCurrentResourceFiber();\n const versionRef = tapRef(0);\n const fiber = tapMemo(() => {\n void element.key;\n return createResourceFiber(element.type, parentFiber.root, () => {\n versionRef.current++;\n parentFiber.markDirty?.();\n });\n }, [element.type, element.key, parentFiber]);\n\n const result = propsDeps\n ? tapMemo(\n () => renderResourceFiber(fiber, element.props),\n // oxlint-disable-next-line tap-hooks/exhaustive-deps -- props identity replaced by user-provided deps\n [fiber, ...propsDeps, versionRef.current],\n )\n : renderResourceFiber(fiber, element.props);\n\n tapEffect(() => () => unmountResourceFiber(fiber), [fiber]);\n tapEffect(() => {\n commitResourceFiber(fiber, result);\n }, [fiber, result]);\n\n return result.output;\n}\n"],"mappings":";;;;;;AAmBA,SAAgB,YACd,SACA,WAC8B;CAC9B,MAAM,cAAc,wBAAwB;CAC5C,MAAM,aAAa,OAAO,CAAC;CAC3B,MAAM,QAAQ,cAAc;EAC1B,QAAa;EACb,OAAO,oBAAoB,QAAQ,MAAM,YAAY,YAAY;GAC/D,WAAW;GACX,YAAY,YAAY;EAC1B,CAAC;CACH,GAAG;EAAC,QAAQ;EAAM,QAAQ;EAAK;CAAW,CAAC;CAE3C,MAAM,SAAS,YACX,cACQ,oBAAoB,OAAO,QAAQ,KAAK,GAE9C;EAAC;EAAO,GAAG;EAAW,WAAW;CAAO,CAC1C,IACA,oBAAoB,OAAO,QAAQ,KAAK;CAE5C,sBAAsB,qBAAqB,KAAK,GAAG,CAAC,KAAK,CAAC;CAC1D,gBAAgB;EACd,oBAAoB,OAAO,MAAM;CACnC,GAAG,CAAC,OAAO,MAAM,CAAC;CAElB,OAAO,OAAO;AAChB"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"tap-resources.js","names":[],"sources":["../../src/hooks/tap-resources.ts"],"sourcesContent":["import type {\n ExtractResourceReturnType,\n RenderResult,\n ResourceElement,\n ResourceFiber,\n} from \"../core/types\";\nimport { tapEffect } from \"./tap-effect\";\nimport { tapMemo } from \"./tap-memo\";\nimport { tapCallback } from \"./tap-callback\";\nimport {\n createResourceFiber,\n unmountResourceFiber,\n renderResourceFiber,\n commitResourceFiber,\n} from \"../core/ResourceFiber\";\nimport { tapConst } from \"./tap-const\";\nimport { tapRef } from \"./tap-ref\";\nimport { getCurrentResourceFiber } from \"../core/helpers/execution-context\";\n\ntype FiberState = {\n fiber: ResourceFiber<unknown, unknown>;\n next:\n | RenderResult\n | [ResourceFiber<unknown, unknown>, RenderResult]\n | \"delete\";\n};\n\nexport function tapResources<E extends ResourceElement<any, any>>(\n getElements: () => readonly E[],\n getElementsDeps?: readonly unknown[],\n): ExtractResourceReturnType<E>[] {\n const versionRef = tapRef(0);\n const version = versionRef.current;\n\n const parentFiber = tapConst(getCurrentResourceFiber, []);\n const markDirty = tapConst(\n () => () => {\n versionRef.current++;\n parentFiber.markDirty?.();\n },\n [],\n );\n const fibers = tapConst(() => new Map<string | number, FiberState>(), []);\n\n const getElementsMemo = getElementsDeps\n ? //
|
|
1
|
+
{"version":3,"file":"tap-resources.js","names":[],"sources":["../../src/hooks/tap-resources.ts"],"sourcesContent":["import type {\n ExtractResourceReturnType,\n RenderResult,\n ResourceElement,\n ResourceFiber,\n} from \"../core/types\";\nimport { tapEffect } from \"./tap-effect\";\nimport { tapMemo } from \"./tap-memo\";\nimport { tapCallback } from \"./tap-callback\";\nimport {\n createResourceFiber,\n unmountResourceFiber,\n renderResourceFiber,\n commitResourceFiber,\n} from \"../core/ResourceFiber\";\nimport { tapConst } from \"./tap-const\";\nimport { tapRef } from \"./tap-ref\";\nimport { getCurrentResourceFiber } from \"../core/helpers/execution-context\";\n\ntype FiberState = {\n fiber: ResourceFiber<unknown, unknown>;\n next:\n | RenderResult\n | [ResourceFiber<unknown, unknown>, RenderResult]\n | \"delete\";\n};\n\nexport function tapResources<E extends ResourceElement<any, any>>(\n getElements: () => readonly E[],\n getElementsDeps?: readonly unknown[],\n): ExtractResourceReturnType<E>[] {\n const versionRef = tapRef(0);\n const version = versionRef.current;\n\n const parentFiber = tapConst(getCurrentResourceFiber, []);\n const markDirty = tapConst(\n () => () => {\n versionRef.current++;\n parentFiber.markDirty?.();\n },\n [],\n );\n const fibers = tapConst(() => new Map<string | number, FiberState>(), []);\n\n const getElementsMemo = getElementsDeps\n ? // oxlint-disable-next-line tap-hooks/exhaustive-deps -- deps forwarded by caller\n tapCallback(getElements, getElementsDeps)\n : getElements;\n\n // Process each element\n\n const res = tapMemo(() => {\n void version;\n\n const elementsArray = getElementsMemo();\n const seenKeys = new Set<string | number>();\n const results: any[] = [];\n let newCount = 0;\n\n // Create/update fibers and render\n for (let i = 0; i < elementsArray.length; i++) {\n const element = elementsArray[i]!;\n\n const elementKey = element.key;\n if (elementKey === undefined) {\n throw new Error(\n `tapResources did not provide a key for array at index ${i}`,\n );\n }\n\n if (seenKeys.has(elementKey))\n throw new Error(`Duplicate key ${elementKey} in tapResources`);\n seenKeys.add(elementKey);\n\n let state = fibers.get(elementKey);\n if (!state) {\n const fiber = createResourceFiber(\n element.type,\n parentFiber.root,\n markDirty,\n );\n const result = renderResourceFiber(fiber, element.props);\n state = {\n fiber,\n next: result,\n };\n newCount++;\n fibers.set(elementKey, state);\n results.push(result.output);\n } else if (state.fiber.type !== element.type) {\n const fiber = createResourceFiber(\n element.type,\n parentFiber.root,\n markDirty,\n );\n const result = renderResourceFiber(fiber, element.props);\n state.next = [fiber, result];\n results.push(result.output);\n } else {\n state.next = renderResourceFiber(state.fiber, element.props);\n results.push(state.next.output);\n }\n }\n\n // Clean up removed fibers (only if there might be stale ones)\n if (fibers.size > results.length - newCount) {\n for (const key of fibers.keys()) {\n if (!seenKeys.has(key)) {\n fibers.get(key)!.next = \"delete\";\n }\n }\n }\n\n return results;\n }, [getElementsMemo, version]);\n\n // Cleanup on unmount\n tapEffect(() => {\n return () => {\n for (const key of fibers.keys()) {\n const fiber = fibers.get(key)!.fiber;\n unmountResourceFiber(fiber);\n }\n };\n }, []);\n\n tapEffect(() => {\n res; // as a performance optimization, we only run if the results have changed\n\n for (const [key, state] of fibers.entries()) {\n if (state.next === \"delete\") {\n if (state.fiber.isMounted) {\n unmountResourceFiber(state.fiber);\n }\n\n fibers.delete(key);\n } else if (Array.isArray(state.next)) {\n unmountResourceFiber(state.fiber);\n state.fiber = state.next[0];\n commitResourceFiber(state.fiber, state.next[1]);\n } else {\n commitResourceFiber(state.fiber, state.next);\n }\n }\n }, [res]);\n\n return res;\n}\n"],"mappings":";;;;;;;;AA2BA,SAAgB,aACd,aACA,iBACgC;CAChC,MAAM,aAAa,OAAO,CAAC;CAC3B,MAAM,UAAU,WAAW;CAE3B,MAAM,cAAc,SAAS,yBAAyB,CAAC,CAAC;CACxD,MAAM,YAAY,qBACJ;EACV,WAAW;EACX,YAAY,YAAY;CAC1B,GACA,CAAC,CACH;CACA,MAAM,SAAS,+BAAe,IAAI,IAAiC,GAAG,CAAC,CAAC;CAExE,MAAM,kBAAkB,kBAEpB,YAAY,aAAa,eAAe,IACxC;CAIJ,MAAM,MAAM,cAAc;EAGxB,MAAM,gBAAgB,gBAAgB;EACtC,MAAM,2BAAW,IAAI,IAAqB;EAC1C,MAAM,UAAiB,CAAC;EACxB,IAAI,WAAW;EAGf,KAAK,IAAI,IAAI,GAAG,IAAI,cAAc,QAAQ,KAAK;GAC7C,MAAM,UAAU,cAAc;GAE9B,MAAM,aAAa,QAAQ;GAC3B,IAAI,eAAe,KAAA,GACjB,MAAM,IAAI,MACR,yDAAyD,GAC3D;GAGF,IAAI,SAAS,IAAI,UAAU,GACzB,MAAM,IAAI,MAAM,iBAAiB,WAAW,iBAAiB;GAC/D,SAAS,IAAI,UAAU;GAEvB,IAAI,QAAQ,OAAO,IAAI,UAAU;GACjC,IAAI,CAAC,OAAO;IACV,MAAM,QAAQ,oBACZ,QAAQ,MACR,YAAY,MACZ,SACF;IACA,MAAM,SAAS,oBAAoB,OAAO,QAAQ,KAAK;IACvD,QAAQ;KACN;KACA,MAAM;IACR;IACA;IACA,OAAO,IAAI,YAAY,KAAK;IAC5B,QAAQ,KAAK,OAAO,MAAM;GAC5B,OAAO,IAAI,MAAM,MAAM,SAAS,QAAQ,MAAM;IAC5C,MAAM,QAAQ,oBACZ,QAAQ,MACR,YAAY,MACZ,SACF;IACA,MAAM,SAAS,oBAAoB,OAAO,QAAQ,KAAK;IACvD,MAAM,OAAO,CAAC,OAAO,MAAM;IAC3B,QAAQ,KAAK,OAAO,MAAM;GAC5B,OAAO;IACL,MAAM,OAAO,oBAAoB,MAAM,OAAO,QAAQ,KAAK;IAC3D,QAAQ,KAAK,MAAM,KAAK,MAAM;GAChC;EACF;EAGA,IAAI,OAAO,OAAO,QAAQ,SAAS;QAC5B,MAAM,OAAO,OAAO,KAAK,GAC5B,IAAI,CAAC,SAAS,IAAI,GAAG,GACnB,OAAO,IAAI,GAAG,EAAG,OAAO;EAAA;EAK9B,OAAO;CACT,GAAG,CAAC,iBAAiB,OAAO,CAAC;CAG7B,gBAAgB;EACd,aAAa;GACX,KAAK,MAAM,OAAO,OAAO,KAAK,GAAG;IAC/B,MAAM,QAAQ,OAAO,IAAI,GAAG,EAAG;IAC/B,qBAAqB,KAAK;GAC5B;EACF;CACF,GAAG,CAAC,CAAC;CAEL,gBAAgB;EAGd,KAAK,MAAM,CAAC,KAAK,UAAU,OAAO,QAAQ,GACxC,IAAI,MAAM,SAAS,UAAU;GAC3B,IAAI,MAAM,MAAM,WACd,qBAAqB,MAAM,KAAK;GAGlC,OAAO,OAAO,GAAG;EACnB,OAAO,IAAI,MAAM,QAAQ,MAAM,IAAI,GAAG;GACpC,qBAAqB,MAAM,KAAK;GAChC,MAAM,QAAQ,MAAM,KAAK;GACzB,oBAAoB,MAAM,OAAO,MAAM,KAAK,EAAE;EAChD,OACE,oBAAoB,MAAM,OAAO,MAAM,IAAI;CAGjD,GAAG,CAAC,GAAG,CAAC;CAER,OAAO;AACT"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"use-resource.js","names":[],"sources":["../../src/react/use-resource.ts"],"sourcesContent":["import { useLayoutEffect, useMemo, useReducer, useRef, useState } from \"react\";\nimport type {\n ResourceFiberRoot,\n ExtractResourceReturnType,\n ResourceElement,\n} from \"../core/types\";\nimport {\n createResourceFiber,\n unmountResourceFiber,\n renderResourceFiber,\n commitResourceFiber,\n} from \"../core/ResourceFiber\";\nimport { isDevelopment } from \"../core/helpers/env\";\nimport {\n commitRoot,\n createResourceFiberRoot,\n setRootVersion,\n} from \"../core/helpers/root\";\n\nconst useDevStrictMode = () => {\n if (!isDevelopment) return null;\n\n //
|
|
1
|
+
{"version":3,"file":"use-resource.js","names":[],"sources":["../../src/react/use-resource.ts"],"sourcesContent":["import { useLayoutEffect, useMemo, useReducer, useRef, useState } from \"react\";\nimport type {\n ResourceFiberRoot,\n ExtractResourceReturnType,\n ResourceElement,\n} from \"../core/types\";\nimport {\n createResourceFiber,\n unmountResourceFiber,\n renderResourceFiber,\n commitResourceFiber,\n} from \"../core/ResourceFiber\";\nimport { isDevelopment } from \"../core/helpers/env\";\nimport {\n commitRoot,\n createResourceFiberRoot,\n setRootVersion,\n} from \"../core/helpers/root\";\n\nconst useDevStrictMode = () => {\n if (!isDevelopment) return null;\n\n // oxlint-disable-next-line react-hooks/rules-of-hooks -- isDevelopment is a build-time constant, so this branch is stable per build\n const count = useRef(0);\n const isFirstRender = count.current === 0;\n // oxlint-disable-next-line react-hooks/rules-of-hooks -- isDevelopment is a build-time constant, so this branch is stable per build\n useState(() => count.current++);\n if (count.current !== 2) return null;\n return isFirstRender ? (\"child\" as const) : (\"root\" as const);\n};\n\nexport function useResource<E extends ResourceElement<any, any>>(\n element: E,\n): ExtractResourceReturnType<E> {\n const root = useMemo<ResourceFiberRoot>(() => {\n return createResourceFiberRoot((cb) => dispatch(cb));\n }, []);\n\n const [version, dispatch] = useReducer((v: number, cb: () => boolean) => {\n setRootVersion(root, v);\n return v + (cb() ? 1 : 0);\n }, 0);\n setRootVersion(root, version);\n\n const devStrictMode = useDevStrictMode();\n const fiber = useMemo(() => {\n void element.key;\n return createResourceFiber(element.type, root, undefined, devStrictMode);\n }, [element.type, element.key, root, devStrictMode]);\n\n const result = renderResourceFiber(fiber, element.props);\n useLayoutEffect(() => {\n return () => unmountResourceFiber(fiber);\n }, [fiber]);\n useLayoutEffect(() => {\n commitRoot(root);\n commitResourceFiber(fiber, result);\n });\n\n return result.output;\n}\n"],"mappings":";;;;;AAmBA,MAAM,yBAAyB;CAC7B,IAAI,CAAC,eAAe,OAAO;CAG3B,MAAM,QAAQ,OAAO,CAAC;CACtB,MAAM,gBAAgB,MAAM,YAAY;CAExC,eAAe,MAAM,SAAS;CAC9B,IAAI,MAAM,YAAY,GAAG,OAAO;CAChC,OAAO,gBAAiB,UAAqB;AAC/C;AAEA,SAAgB,YACd,SAC8B;CAC9B,MAAM,OAAO,cAAiC;EAC5C,OAAO,yBAAyB,OAAO,SAAS,EAAE,CAAC;CACrD,GAAG,CAAC,CAAC;CAEL,MAAM,CAAC,SAAS,YAAY,YAAY,GAAW,OAAsB;EACvE,eAAe,MAAM,CAAC;EACtB,OAAO,KAAK,GAAG,IAAI,IAAI;CACzB,GAAG,CAAC;CACJ,eAAe,MAAM,OAAO;CAE5B,MAAM,gBAAgB,iBAAiB;CACvC,MAAM,QAAQ,cAAc;EAC1B,QAAa;EACb,OAAO,oBAAoB,QAAQ,MAAM,MAAM,KAAA,GAAW,aAAa;CACzE,GAAG;EAAC,QAAQ;EAAM,QAAQ;EAAK;EAAM;CAAa,CAAC;CAEnD,MAAM,SAAS,oBAAoB,OAAO,QAAQ,KAAK;CACvD,sBAAsB;EACpB,aAAa,qBAAqB,KAAK;CACzC,GAAG,CAAC,KAAK,CAAC;CACV,sBAAsB;EACpB,WAAW,IAAI;EACf,oBAAoB,OAAO,MAAM;CACnC,CAAC;CAED,OAAO,OAAO;AAChB"}
|
package/package.json
CHANGED
|
@@ -91,15 +91,18 @@ describe("tapEffect - Basic Functionality", () => {
|
|
|
91
91
|
describe("Multiple Effects", () => {
|
|
92
92
|
it("should execute multiple effects in registration order", () => {
|
|
93
93
|
const executionOrder: string[] = [];
|
|
94
|
-
const effects = [
|
|
94
|
+
const effects: tapEffect.EffectCallback[] = [
|
|
95
95
|
() => {
|
|
96
96
|
executionOrder.push("effect1");
|
|
97
|
+
return undefined;
|
|
97
98
|
},
|
|
98
99
|
() => {
|
|
99
100
|
executionOrder.push("effect2");
|
|
101
|
+
return undefined;
|
|
100
102
|
},
|
|
101
103
|
() => {
|
|
102
104
|
executionOrder.push("effect3");
|
|
105
|
+
return undefined;
|
|
103
106
|
},
|
|
104
107
|
];
|
|
105
108
|
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
|
|
1
|
+
/* oxlint-disable tap-hooks/exhaustive-deps -- tests deliberately exercise invalid dep arrays */
|
|
2
2
|
import { describe, it, expect, vi } from "vitest";
|
|
3
3
|
import { tapEffect } from "../../hooks/tap-effect";
|
|
4
4
|
import { tapState } from "../../hooks/tap-state";
|
|
@@ -83,9 +83,8 @@ describe("Errors - Effect Errors", () => {
|
|
|
83
83
|
});
|
|
84
84
|
|
|
85
85
|
// Should throw aggregate error
|
|
86
|
-
expect(() =>
|
|
87
|
-
|
|
88
|
-
).toThrowErrorMatchingInlineSnapshot(`
|
|
86
|
+
expect(() => renderTest(resource, undefined))
|
|
87
|
+
.toThrowErrorMatchingInlineSnapshot(`
|
|
89
88
|
[AggregateError: Errors during commit]
|
|
90
89
|
`);
|
|
91
90
|
expect(goodEffect).toHaveBeenCalledTimes(1);
|
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
|
|
1
|
+
/* oxlint-disable tap-hooks/exhaustive-deps -- tests deliberately exercise invalid dep arrays */
|
|
2
2
|
import { describe, it, expect, vi } from "vitest";
|
|
3
3
|
import { tapEffect } from "../../hooks/tap-effect";
|
|
4
4
|
import { tapState } from "../../hooks/tap-state";
|
|
@@ -2,6 +2,7 @@
|
|
|
2
2
|
* Tests to verify React's strict mode behavior
|
|
3
3
|
* These tests verify React's own behavior, not tap's implementation
|
|
4
4
|
*/
|
|
5
|
+
/* oxlint-disable tap-hooks/exhaustive-deps -- intentional missing-dep patterns for strict-mode tests */
|
|
5
6
|
|
|
6
7
|
import { describe, it, expect } from "vitest";
|
|
7
8
|
import { render } from "@testing-library/react";
|
|
@@ -3,9 +3,9 @@
|
|
|
3
3
|
* for different sources of setState calls
|
|
4
4
|
*/
|
|
5
5
|
|
|
6
|
-
import { describe, it, expect } from "vitest";
|
|
6
|
+
import { describe, it, expect, vi, afterEach } from "vitest";
|
|
7
7
|
import { render, fireEvent, waitFor } from "@testing-library/react";
|
|
8
|
-
import { StrictMode, useState, useEffect } from "react";
|
|
8
|
+
import { StrictMode, useState, useEffect, useLayoutEffect } from "react";
|
|
9
9
|
|
|
10
10
|
describe("React Strict Mode - Rerender Sources", () => {
|
|
11
11
|
describe("Source 1: Initial render", () => {
|
|
@@ -190,7 +190,17 @@ describe("React Strict Mode - Rerender Sources", () => {
|
|
|
190
190
|
});
|
|
191
191
|
|
|
192
192
|
describe("Source 5: setState in setTimeout", () => {
|
|
193
|
+
afterEach(() => {
|
|
194
|
+
vi.useRealTimers();
|
|
195
|
+
});
|
|
196
|
+
|
|
193
197
|
it("should double-render AND double-call setTimeout callback (React 19)", async () => {
|
|
198
|
+
// Use fake timers so both strict-mode setTimeout callbacks fire
|
|
199
|
+
// synchronously before React gets a chance to flush a re-render
|
|
200
|
+
// between them. Without this, slow CI can process the first
|
|
201
|
+
// setTimeout, run its renders, and only then fire the second.
|
|
202
|
+
vi.useFakeTimers();
|
|
203
|
+
|
|
194
204
|
const events: string[] = [];
|
|
195
205
|
|
|
196
206
|
function TestComponent() {
|
|
@@ -215,9 +225,12 @@ describe("React Strict Mode - Rerender Sources", () => {
|
|
|
215
225
|
</StrictMode>,
|
|
216
226
|
);
|
|
217
227
|
|
|
218
|
-
//
|
|
228
|
+
// Fire both setTimeout callbacks synchronously via fake timers
|
|
229
|
+
vi.advanceTimersByTime(10);
|
|
230
|
+
// Restore real timers and wait for React's scheduler (MessageChannel) to flush
|
|
231
|
+
vi.useRealTimers();
|
|
219
232
|
await waitFor(() => {
|
|
220
|
-
expect(events).
|
|
233
|
+
expect(events).toHaveLength(6);
|
|
221
234
|
});
|
|
222
235
|
|
|
223
236
|
// ACTUAL: setTimeout callback runs TWICE and renders are DOUBLED
|
|
@@ -353,7 +366,6 @@ describe("React Strict Mode - Rerender Sources", () => {
|
|
|
353
366
|
describe("Source 8: setState in useLayoutEffect", () => {
|
|
354
367
|
it("should double-render after setState in useLayoutEffect", () => {
|
|
355
368
|
const events: string[] = [];
|
|
356
|
-
const { useLayoutEffect } = require("react");
|
|
357
369
|
|
|
358
370
|
function TestComponent() {
|
|
359
371
|
const [count, setCount] = useState(0);
|
|
@@ -2,6 +2,7 @@
|
|
|
2
2
|
* Tests to verify when tap strict mode causes double-rendering
|
|
3
3
|
* These tests should mirror the React strict mode behavior
|
|
4
4
|
*/
|
|
5
|
+
/* oxlint-disable tap-hooks/exhaustive-deps -- empty dep arrays are part of the test scenarios */
|
|
5
6
|
|
|
6
7
|
import { afterEach, describe, it, expect, vi } from "vitest";
|
|
7
8
|
import { resource } from "../../core/resource";
|
|
@@ -4,6 +4,6 @@ export const tapCallback = <T extends (...args: any[]) => any>(
|
|
|
4
4
|
fn: T,
|
|
5
5
|
deps: readonly unknown[],
|
|
6
6
|
): T => {
|
|
7
|
-
//
|
|
7
|
+
// oxlint-disable-next-line tap-hooks/exhaustive-deps -- user-provided dep array forwarded verbatim
|
|
8
8
|
return tapMemo(() => fn, deps);
|
|
9
9
|
};
|
|
@@ -32,9 +32,9 @@ export function tapResource<E extends ResourceElement<any, any>>(
|
|
|
32
32
|
}, [element.type, element.key, parentFiber]);
|
|
33
33
|
|
|
34
34
|
const result = propsDeps
|
|
35
|
-
?
|
|
36
|
-
tapMemo(
|
|
35
|
+
? tapMemo(
|
|
37
36
|
() => renderResourceFiber(fiber, element.props),
|
|
37
|
+
// oxlint-disable-next-line tap-hooks/exhaustive-deps -- props identity replaced by user-provided deps
|
|
38
38
|
[fiber, ...propsDeps, versionRef.current],
|
|
39
39
|
)
|
|
40
40
|
: renderResourceFiber(fiber, element.props);
|
|
@@ -43,7 +43,7 @@ export function tapResources<E extends ResourceElement<any, any>>(
|
|
|
43
43
|
const fibers = tapConst(() => new Map<string | number, FiberState>(), []);
|
|
44
44
|
|
|
45
45
|
const getElementsMemo = getElementsDeps
|
|
46
|
-
? //
|
|
46
|
+
? // oxlint-disable-next-line tap-hooks/exhaustive-deps -- deps forwarded by caller
|
|
47
47
|
tapCallback(getElements, getElementsDeps)
|
|
48
48
|
: getElements;
|
|
49
49
|
|
|
@@ -20,10 +20,10 @@ import {
|
|
|
20
20
|
const useDevStrictMode = () => {
|
|
21
21
|
if (!isDevelopment) return null;
|
|
22
22
|
|
|
23
|
-
//
|
|
23
|
+
// oxlint-disable-next-line react-hooks/rules-of-hooks -- isDevelopment is a build-time constant, so this branch is stable per build
|
|
24
24
|
const count = useRef(0);
|
|
25
25
|
const isFirstRender = count.current === 0;
|
|
26
|
-
//
|
|
26
|
+
// oxlint-disable-next-line react-hooks/rules-of-hooks -- isDevelopment is a build-time constant, so this branch is stable per build
|
|
27
27
|
useState(() => count.current++);
|
|
28
28
|
if (count.current !== 2) return null;
|
|
29
29
|
return isFirstRender ? ("child" as const) : ("root" as const);
|