@assistant-ui/react 0.12.26 → 0.12.27

package/dist/primitives/message/MessageIf.js

@@ -28,7 +28,7 @@ const useMessageIf = (props) => {
             return false;
         if (props.hasAttachments === false &&
             role === "user" &&
-            !!attachments?.length)
+            attachments?.length)
             return false;
         if (props.hasContent === true && parts.length === 0)
             return false;

package/dist/primitives/message/MessageIf.js.map

@@ -1 +1 @@
-{"version":3,"file":"MessageIf.js","sourceRoot":"","sources":["../../../src/primitives/message/MessageIf.ts"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAGb,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAkBlD,MAAM,YAAY,GAAG,CAAC,KAAwB,EAAE,EAAE;IAChD,OAAO,WAAW,CAAC,CAAC,CAAC,EAAE,EAAE;QACvB,MAAM,EACJ,IAAI,EACJ,WAAW,EACX,KAAK,EACL,WAAW,EACX,MAAM,EACN,MAAM,EACN,QAAQ,EACR,UAAU,GACX,GAAG,CAAC,CAAC,OAAO,CAAC;QAEd,IAAI,KAAK,CAAC,WAAW,KAAK,IAAI,IAAI,WAAW,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAEhE,IAAI,KAAK,CAAC,IAAI,IAAI,IAAI,KAAK,MAAM;YAAE,OAAO,KAAK,CAAC;QAChD,IAAI,KAAK,CAAC,SAAS,IAAI,IAAI,KAAK,WAAW;YAAE,OAAO,KAAK,CAAC;QAC1D,IAAI,KAAK,CAAC,MAAM,IAAI,IAAI,KAAK,QAAQ;YAAE,OAAO,KAAK,CAAC;QAEpD,IAAI,KAAK,CAAC,WAAW,KAAK,IAAI,IAAI,CAAC,UAAU,IAAI,CAAC,MAAM;YAAE,OAAO,KAAK,CAAC;QACvE,IAAI,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,KAAK,CAAC,IAAI,KAAK,MAAM;YAAE,OAAO,KAAK,CAAC;QAEpE,IAAI,KAAK,CAAC,MAAM,KAAK,IAAI,IAAI,CAAC,QAAQ;YAAE,OAAO,KAAK,CAAC;QACrD,IAAI,KAAK,CAAC,MAAM,KAAK,KAAK,IAAI,QAAQ;YAAE,OAAO,KAAK,CAAC;QAErD,IAAI,KAAK,CAAC,QAAQ,KAAK,IAAI,IAAI,MAAM,IAAI,IAAI;YAAE,OAAO,KAAK,CAAC;QAC5D,IAAI,KAAK,CAAC,QAAQ,KAAK,KAAK,IAAI,MAAM,IAAI,IAAI;YAAE,OAAO,KAAK,CAAC;QAE7D,IACE,KAAK,CAAC,cAAc,KAAK,IAAI;YAC7B,CAAC,IAAI,KAAK,MAAM,IAAI,CAAC,WAAW,EAAE,MAAM,CAAC;YAEzC,OAAO,KAAK,CAAC;QACf,IACE,KAAK,CAAC,cAAc,KAAK,KAAK;YAC9B,IAAI,KAAK,MAAM;YACf,CAAC,CAAC,WAAW,EAAE,MAAM;YAErB,OAAO,KAAK,CAAC;QAEf,IAAI,KAAK,CAAC,UAAU,KAAK,IAAI,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,KAAK,CAAC;QAClE,IAAI,KAAK,CAAC,UAAU,KAAK,KAAK,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAEjE,IACE,KAAK,CAAC,iBAAiB,KAAK,SAAS;YACrC,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,iBAAiB,EAAE,IAAI,IAAI,IAAI,CAAC;gBAClD,KAAK,CAAC,iBAAiB;YAEzB,OAAO,KAAK,CAAC;QAEf,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;AACL,CAAC,CAAC;AAMF;;GAEG;AACH,MAAM,CAAC,MAAM,kBAAkB,GAAiC,CAAC,EAC/D,QAAQ,EACR,GAAG,KAAK,EACT,EAAE,EAAE;IACH,MAAM,MAAM,GAAG,YAAY,CAAC,KAAK,CAAC,CAAC;IACnC,OAAO,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC;AAClC,CAAC,CAAC;AAEF,kBAAkB,CAAC,WAAW,GAAG,qBAAqB,CAAC"}
+{"version":3,"file":"MessageIf.js","sourceRoot":"","sources":["../../../src/primitives/message/MessageIf.ts"],"names":[],"mappings":"AAAA,YAAY,CAAC;AAGb,OAAO,EAAE,WAAW,EAAE,MAAM,qBAAqB,CAAC;AAkBlD,MAAM,YAAY,GAAG,CAAC,KAAwB,EAAE,EAAE;IAChD,OAAO,WAAW,CAAC,CAAC,CAAC,EAAE,EAAE;QACvB,MAAM,EACJ,IAAI,EACJ,WAAW,EACX,KAAK,EACL,WAAW,EACX,MAAM,EACN,MAAM,EACN,QAAQ,EACR,UAAU,GACX,GAAG,CAAC,CAAC,OAAO,CAAC;QAEd,IAAI,KAAK,CAAC,WAAW,KAAK,IAAI,IAAI,WAAW,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAEhE,IAAI,KAAK,CAAC,IAAI,IAAI,IAAI,KAAK,MAAM;YAAE,OAAO,KAAK,CAAC;QAChD,IAAI,KAAK,CAAC,SAAS,IAAI,IAAI,KAAK,WAAW;YAAE,OAAO,KAAK,CAAC;QAC1D,IAAI,KAAK,CAAC,MAAM,IAAI,IAAI,KAAK,QAAQ;YAAE,OAAO,KAAK,CAAC;QAEpD,IAAI,KAAK,CAAC,WAAW,KAAK,IAAI,IAAI,CAAC,UAAU,IAAI,CAAC,MAAM;YAAE,OAAO,KAAK,CAAC;QACvE,IAAI,KAAK,CAAC,IAAI,KAAK,SAAS,IAAI,KAAK,CAAC,IAAI,KAAK,MAAM;YAAE,OAAO,KAAK,CAAC;QAEpE,IAAI,KAAK,CAAC,MAAM,KAAK,IAAI,IAAI,CAAC,QAAQ;YAAE,OAAO,KAAK,CAAC;QACrD,IAAI,KAAK,CAAC,MAAM,KAAK,KAAK,IAAI,QAAQ;YAAE,OAAO,KAAK,CAAC;QAErD,IAAI,KAAK,CAAC,QAAQ,KAAK,IAAI,IAAI,MAAM,IAAI,IAAI;YAAE,OAAO,KAAK,CAAC;QAC5D,IAAI,KAAK,CAAC,QAAQ,KAAK,KAAK,IAAI,MAAM,IAAI,IAAI;YAAE,OAAO,KAAK,CAAC;QAE7D,IACE,KAAK,CAAC,cAAc,KAAK,IAAI;YAC7B,CAAC,IAAI,KAAK,MAAM,IAAI,CAAC,WAAW,EAAE,MAAM,CAAC;YAEzC,OAAO,KAAK,CAAC;QACf,IACE,KAAK,CAAC,cAAc,KAAK,KAAK;YAC9B,IAAI,KAAK,MAAM;YACf,WAAW,EAAE,MAAM;YAEnB,OAAO,KAAK,CAAC;QAEf,IAAI,KAAK,CAAC,UAAU,KAAK,IAAI,IAAI,KAAK,CAAC,MAAM,KAAK,CAAC;YAAE,OAAO,KAAK,CAAC;QAClE,IAAI,KAAK,CAAC,UAAU,KAAK,KAAK,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;YAAE,OAAO,KAAK,CAAC;QAEjE,IACE,KAAK,CAAC,iBAAiB,KAAK,SAAS;YACrC,CAAC,CAAC,CAAC,OAAO,CAAC,QAAQ,CAAC,iBAAiB,EAAE,IAAI,IAAI,IAAI,CAAC;gBAClD,KAAK,CAAC,iBAAiB;YAEzB,OAAO,KAAK,CAAC;QAEf,OAAO,IAAI,CAAC;IACd,CAAC,CAAC,CAAC;AACL,CAAC,CAAC;AAMF;;GAEG;AACH,MAAM,CAAC,MAAM,kBAAkB,GAAiC,CAAC,EAC/D,QAAQ,EACR,GAAG,KAAK,EACT,EAAE,EAAE;IACH,MAAM,MAAM,GAAG,YAAY,CAAC,KAAK,CAAC,CAAC;IACnC,OAAO,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC;AAClC,CAAC,CAAC;AAEF,kBAAkB,CAAC,WAAW,GAAG,qBAAqB,CAAC"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@assistant-ui/react",
-  "version": "0.12.26",
+  "version": "0.12.27",
   "description": "TypeScript/React library for AI Chat",
   "keywords": [
     "radix-ui",
@@ -48,9 +48,9 @@
   ],
   "sideEffects": false,
   "dependencies": {
-    "@assistant-ui/core": "^0.1.15",
-    "@assistant-ui/store": "^0.2.8",
-    "@assistant-ui/tap": "^0.5.9",
+    "@assistant-ui/core": "^0.1.16",
+    "@assistant-ui/store": "^0.2.9",
+    "@assistant-ui/tap": "^0.5.10",
     "@radix-ui/primitive": "^1.1.3",
     "@radix-ui/react-compose-refs": "^1.1.2",
     "@radix-ui/react-context": "^1.1.3",
@@ -85,7 +85,7 @@
     "@types/node": "^25.6.0",
     "@types/react": "^19.2.14",
     "@types/react-dom": "^19.2.3",
-    "jsdom": "^29.0.2",
+    "jsdom": "^29.1.0",
     "react": "^19.2.5",
     "react-dom": "^19.2.5",
     "vitest": "^4.1.5",

package/src/primitives/message/MessageIf.ts

@@ -55,7 +55,7 @@ const useMessageIf = (props: UseMessageIfProps) => {
     if (
       props.hasAttachments === false &&
       role === "user" &&
-      !!attachments?.length
+      attachments?.length
     )
       return false;
 

package/src/tests/BaseComposerRuntimeCore.test.ts

@@ -426,6 +426,149 @@ describe("BaseComposerRuntimeCore", () => {
       // Pending was sent through adapter
       expect(adapter.send).toHaveBeenCalledTimes(1);
     });
+
+    describe("adapter.accept enforcement", () => {
+      const makeImageAdapter = (): AttachmentAdapter => ({
+        accept: "image/*",
+        add: vi.fn(),
+        remove: vi.fn(),
+        send: vi.fn(),
+      });
+
+      it("rejects external attachment with contentType not matching adapter.accept", async () => {
+        composer.setAttachmentAdapter(makeImageAdapter());
+        const onError = vi.fn();
+        const onAdd = vi.fn();
+        composer.unstable_on("attachmentAddError", onError);
+        composer.unstable_on("attachmentAdd", onAdd);
+
+        await expect(
+          composer.addAttachment(
+            makeCreateAttachment({
+              name: "doc.pdf",
+              contentType: "application/pdf",
+            }),
+          ),
+        ).rejects.toThrow(/File type application\/pdf is not accepted/);
+
+        expect(composer.attachments).toHaveLength(0);
+        expect(onError).toHaveBeenCalledTimes(1);
+        expect(onAdd).not.toHaveBeenCalled();
+      });
+
+      it("accepts external attachment with contentType matching adapter.accept", async () => {
+        composer.setAttachmentAdapter(makeImageAdapter());
+        const onError = vi.fn();
+
+        composer.unstable_on("attachmentAddError", onError);
+        await composer.addAttachment(
+          makeCreateAttachment({
+            name: "photo.png",
+            contentType: "image/png",
+          }),
+        );
+
+        expect(composer.attachments).toHaveLength(1);
+        expect(onError).not.toHaveBeenCalled();
+      });
+
+      it("accepts external attachment when only filename extension matches adapter.accept", async () => {
+        composer.setAttachmentAdapter({
+          accept: ".pdf",
+          add: vi.fn(),
+          remove: vi.fn(),
+          send: vi.fn(),
+        });
+
+        await composer.addAttachment(
+          makeCreateAttachment({ name: "report.pdf" }),
+        );
+
+        expect(composer.attachments).toHaveLength(1);
+      });
+
+      it("rejects external attachment when contentType missing and extension does not match", async () => {
+        composer.setAttachmentAdapter(makeImageAdapter());
+        const onError = vi.fn();
+        composer.unstable_on("attachmentAddError", onError);
+
+        await expect(
+          composer.addAttachment(makeCreateAttachment({ name: "notes.txt" })),
+        ).rejects.toThrow(/is not accepted/);
+
+        expect(onError).toHaveBeenCalledTimes(1);
+      });
+
+      it("adds external attachment without check when no adapter is configured", async () => {
+        // No adapter — preserves the original "no adapter required" guarantee
+        await composer.addAttachment(
+          makeCreateAttachment({
+            name: "anything.xyz",
+            contentType: "application/x-anything",
+          }),
+        );
+
+        expect(composer.attachments).toHaveLength(1);
+      });
+
+      it("does not let subscriber errors mask the original throw", async () => {
+        composer.setAttachmentAdapter(makeImageAdapter());
+        composer.unstable_on("attachmentAddError", () => {
+          throw new Error("subscriber boom");
+        });
+
+        await expect(
+          composer.addAttachment(
+            makeCreateAttachment({
+              name: "doc.pdf",
+              contentType: "application/pdf",
+            }),
+          ),
+        ).rejects.toThrow(/is not accepted/);
+      });
+
+      it("does not fire attachmentAddError when an attachmentAdd subscriber throws", async () => {
+        composer.setAttachmentAdapter(makeImageAdapter());
+        const onError = vi.fn();
+        composer.unstable_on("attachmentAdd", () => {
+          throw new Error("add subscriber boom");
+        });
+        composer.unstable_on("attachmentAddError", onError);
+
+        await expect(
+          composer.addAttachment(
+            makeCreateAttachment({
+              name: "photo.png",
+              contentType: "image/png",
+            }),
+          ),
+        ).rejects.toThrow("add subscriber boom");
+
+        expect(composer.attachments).toHaveLength(1);
+        expect(onError).not.toHaveBeenCalled();
+      });
+
+      it("does not fire attachmentAddError when a state subscriber throws on add", async () => {
+        composer.setAttachmentAdapter(makeImageAdapter());
+        const onError = vi.fn();
+        composer.subscribe(() => {
+          throw new Error("state subscriber boom");
+        });
+        composer.unstable_on("attachmentAddError", onError);
+
+        await expect(
+          composer.addAttachment(
+            makeCreateAttachment({
+              name: "photo.png",
+              contentType: "image/png",
+            }),
+          ),
+        ).rejects.toThrow("state subscriber boom");
+
+        expect(composer.attachments).toHaveLength(1);
+        expect(onError).not.toHaveBeenCalled();
+      });
+    });
   });
 
   describe("send options", () => {

package/src/tests/MessageParts.loading.test.tsx

@@ -0,0 +1,104 @@
+// @vitest-environment jsdom
+
+import { render, screen, waitFor } from "@testing-library/react";
+import type { FC, PropsWithChildren } from "react";
+import { describe, expect, it } from "vitest";
+import { AssistantRuntimeProvider } from "../context";
+import * as MessagePartPrimitive from "../primitives/messagePart";
+import * as MessagePrimitive from "../primitives/message";
+import * as ThreadPrimitive from "../primitives/thread";
+import { useLocalRuntime } from "../legacy-runtime/runtime-cores/local/useLocalRuntime";
+import type { ChatModelAdapter, ThreadMessageLike } from "../index";
+
+const noOpAdapter: ChatModelAdapter = {
+  async *run() {},
+};
+
+const initialMessages: ThreadMessageLike[] = [
+  {
+    role: "assistant",
+    content: [],
+    status: { type: "running" },
+  },
+];
+
+const completeInitialMessages: ThreadMessageLike[] = [
+  {
+    role: "assistant",
+    content: [],
+    status: { type: "complete", reason: "stop" },
+  },
+];
+
+const RunningText: FC = () => {
+  return (
+    <p>
+      <MessagePartPrimitive.Text />
+      <MessagePartPrimitive.InProgress>
+        <span data-testid="loading-dot">dot</span>
+      </MessagePartPrimitive.InProgress>
+    </p>
+  );
+};
+
+const ComponentsMessage: FC = () => {
+  return <MessagePrimitive.Parts components={{ Text: RunningText }} />;
+};
+
+const ChildrenMessage: FC = () => {
+  return (
+    <MessagePrimitive.Parts>
+      {({ part }) => {
+        if (part.type === "text") return <RunningText />;
+        return null;
+      }}
+    </MessagePrimitive.Parts>
+  );
+};
+
+const RuntimeProvider: FC<
+  PropsWithChildren<{ messages?: ThreadMessageLike[] }>
+> = ({ children, messages = initialMessages }) => {
+  const runtime = useLocalRuntime(noOpAdapter, {
+    initialMessages: messages,
+  });
+  return (
+    <AssistantRuntimeProvider runtime={runtime}>
+      {children}
+    </AssistantRuntimeProvider>
+  );
+};
+
+const renderThread = (MessageComponent: FC, messages?: ThreadMessageLike[]) => {
+  render(
+    <RuntimeProvider messages={messages}>
+      <ThreadPrimitive.Messages components={{ Message: MessageComponent }} />
+    </RuntimeProvider>,
+  );
+};
+
+describe("MessagePrimitive.Parts loading state", () => {
+  it("renders the loading indicator for the components API when assistant parts are empty", async () => {
+    renderThread(ComponentsMessage);
+
+    await waitFor(() => {
+      expect(screen.getByTestId("loading-dot")).toBeTruthy();
+    });
+  });
+
+  it("renders the loading indicator for the children API when assistant parts are empty", async () => {
+    renderThread(ChildrenMessage);
+
+    await waitFor(() => {
+      expect(screen.getByTestId("loading-dot")).toBeTruthy();
+    });
+  });
+
+  it("does not render the loading indicator when assistant parts are empty but the message is complete", async () => {
+    renderThread(ChildrenMessage, completeInitialMessages);
+
+    await waitFor(() => {
+      expect(screen.queryByTestId("loading-dot")).toBeNull();
+    });
+  });
+});

package/src/tests/RemoteThreadListRuntime.deferredProvider.test.tsx

@@ -0,0 +1,79 @@
+// @vitest-environment jsdom
+
+import { render } from "@testing-library/react";
+import { type FC, type PropsWithChildren, useState } from "react";
+import { describe, expect, it } from "vitest";
+import { useRemoteThreadListRuntime } from "@assistant-ui/core/react";
+import { makeAdapter } from "@assistant-ui/core/tests/remote-thread-list-test-helpers";
+import type { AssistantRuntime } from "@assistant-ui/core";
+import { AssistantRuntimeProvider } from "../context";
+import { useLocalRuntime } from "../legacy-runtime/runtime-cores/local/useLocalRuntime";
+import { useAssistantRuntime } from "../legacy-runtime/hooks/AssistantContext";
+import type { ChatModelAdapter, RemoteThreadListAdapter } from "../index";
+
+const noOpAdapter: ChatModelAdapter = {
+  async *run() {},
+};
+
+const useTestRuntimeHook = () => useLocalRuntime(noOpAdapter);
+
+const RuntimeProvider: FC<
+  PropsWithChildren<{ adapter: RemoteThreadListAdapter }>
+> = ({ children, adapter }) => {
+  const runtime = useRemoteThreadListRuntime({
+    runtimeHook: useTestRuntimeHook,
+    adapter,
+  });
+  return (
+    <AssistantRuntimeProvider runtime={runtime}>
+      {children}
+    </AssistantRuntimeProvider>
+  );
+};
+
+const RuntimeCapture: FC<{
+  runtimeRef: { current: AssistantRuntime | null };
+}> = ({ runtimeRef }) => {
+  const runtime = useAssistantRuntime();
+  runtimeRef.current = runtime;
+  return null;
+};
+
+// regression for #3678: deferred unstable_Provider must not strand the runtime binder.
+describe("useRemoteThreadListRuntime with a deferred unstable_Provider", () => {
+  it("composer.setText does not throw EMPTY_THREAD_ERROR when unstable_Provider defers children", () => {
+    const Provider: FC<PropsWithChildren> = ({ children }) => {
+      const [ready] = useState(false);
+      if (!ready) return null;
+      return <>{children}</>;
+    };
+    const adapter = makeAdapter({ unstable_Provider: Provider });
+
+    const runtimeRef: { current: AssistantRuntime | null } = { current: null };
+    render(
+      <RuntimeProvider adapter={adapter}>
+        <RuntimeCapture runtimeRef={runtimeRef} />
+      </RuntimeProvider>,
+    );
+
+    const runtime = runtimeRef.current;
+    expect(runtime).toBeTruthy();
+    expect(() => runtime!.thread.composer.setText("hello")).not.toThrow();
+  });
+
+  it("composer.setText still works when unstable_Provider renders children unconditionally", () => {
+    const Provider: FC<PropsWithChildren> = ({ children }) => <>{children}</>;
+    const adapter = makeAdapter({ unstable_Provider: Provider });
+
+    const runtimeRef: { current: AssistantRuntime | null } = { current: null };
+    render(
+      <RuntimeProvider adapter={adapter}>
+        <RuntimeCapture runtimeRef={runtimeRef} />
+      </RuntimeProvider>,
+    );
+
+    const runtime = runtimeRef.current;
+    expect(runtime).toBeTruthy();
+    expect(() => runtime!.thread.composer.setText("hello")).not.toThrow();
+  });
+});