@assistant-ui/core 0.3.15 → 0.3.17

package/src/tests/RemoteThreadListThreadListRuntimeCore-load-race.test.ts

@@ -0,0 +1,305 @@
+import { describe, it, expect, vi } from "vitest";
+import {
+  createCore,
+  makeAdapter,
+  deferred,
+} from "./remote-thread-list-test-helpers";
+import {
+  preserveMidLoadTransitions,
+  createThreadMappingId,
+  type RemoteThreadState,
+} from "../runtimes/remote-thread-list/remote-thread-state";
+
+type ListResult = Awaited<ReturnType<ReturnType<typeof makeAdapter>["list"]>>;
+
+describe("RemoteThreadListThreadListRuntimeCore load race", () => {
+  it("keeps a thread initialized during the list() flight at the top", async () => {
+    const listDeferred = deferred<ListResult>();
+    const adapter = makeAdapter({ list: vi.fn(() => listDeferred.promise) });
+    const core = createCore(adapter);
+
+    const loadPromise = core.getLoadThreadsPromise();
+
+    await core.switchToNewThread();
+    const newId = core.newThreadId!;
+    await core.initialize(newId);
+    expect(core.threadIds).toContain(newId);
+
+    listDeferred.resolve({
+      threads: [
+        { status: "regular", remoteId: "t1", externalId: "t1", title: "One" },
+      ],
+    });
+    await loadPromise;
+
+    expect(core.getItemById(newId)?.status).toBe("regular");
+    expect(core.threadIds[0]).toBe(newId);
+    expect(core.threadIds).toContain("t1");
+  });
+
+  it("keeps one slot when the list reports the thread just initialized", async () => {
+    const listDeferred = deferred<ListResult>();
+    const adapter = makeAdapter({
+      list: vi.fn(() => listDeferred.promise),
+      initialize: vi.fn(async () => ({
+        remoteId: "remote-1",
+        externalId: "remote-1",
+      })),
+    });
+    const core = createCore(adapter);
+
+    const loadPromise = core.getLoadThreadsPromise();
+    await core.switchToNewThread();
+    const localId = core.newThreadId!;
+    await core.initialize(localId);
+
+    listDeferred.resolve({
+      threads: [
+        { status: "regular", remoteId: "remote-1", externalId: "remote-1" },
+      ],
+    });
+    await loadPromise;
+
+    expect(Object.keys(core.threadItems)).toEqual([localId]);
+    expect(core.threadIds).toEqual([localId]);
+    expect(core.getItemById("remote-1")?.id).toBe(localId);
+    expect(core.mainThreadId).toBe(localId);
+
+    await core.delete("remote-1");
+
+    expect(core.getItemById(localId)).toBeUndefined();
+    expect(core.getItemById("remote-1")).toBeUndefined();
+    expect(core.threadIds).toEqual([]);
+  });
+
+  it("collapses a slot the list minted while initialize was in flight", async () => {
+    const listDeferred = deferred<ListResult>();
+    const initializeDeferred = deferred<{
+      remoteId: string;
+      externalId: string;
+    }>();
+    const adapter = makeAdapter({
+      list: vi.fn(() => listDeferred.promise),
+      initialize: vi.fn(() => initializeDeferred.promise),
+    });
+    const core = createCore(adapter);
+
+    const loadPromise = core.getLoadThreadsPromise();
+    await core.switchToNewThread();
+    const localId = core.newThreadId!;
+    const initializePromise = core.initialize(localId);
+
+    listDeferred.resolve({
+      threads: [
+        { status: "regular", remoteId: "remote-1", externalId: "remote-1" },
+      ],
+    });
+    await loadPromise;
+
+    initializeDeferred.resolve({
+      remoteId: "remote-1",
+      externalId: "remote-1",
+    });
+    await initializePromise;
+
+    expect(Object.keys(core.threadItems)).toEqual([localId]);
+    expect(core.threadIds).toEqual([localId]);
+    expect(core.getItemById("remote-1")?.id).toBe(localId);
+
+    await core.delete("remote-1");
+
+    expect(core.getItemById(localId)).toBeUndefined();
+    expect(core.getItemById("remote-1")).toBeUndefined();
+    expect(core.threadIds).toEqual([]);
+  });
+
+  it("does not leave the collapsed slot in both lists when the race reported it archived", async () => {
+    const listDeferred = deferred<ListResult>();
+    const initializeDeferred = deferred<{
+      remoteId: string;
+      externalId: string;
+    }>();
+    const adapter = makeAdapter({
+      list: vi.fn(() => listDeferred.promise),
+      initialize: vi.fn(() => initializeDeferred.promise),
+    });
+    const core = createCore(adapter);
+
+    const loadPromise = core.getLoadThreadsPromise();
+    await core.switchToNewThread();
+    const localId = core.newThreadId!;
+    const initializePromise = core.initialize(localId);
+
+    listDeferred.resolve({
+      threads: [
+        { status: "archived", remoteId: "remote-1", externalId: "remote-1" },
+      ],
+    });
+    await loadPromise;
+
+    initializeDeferred.resolve({
+      remoteId: "remote-1",
+      externalId: "remote-1",
+    });
+    await initializePromise;
+
+    expect(Object.keys(core.threadItems)).toEqual([localId]);
+    expect(core.threadIds).toEqual([localId]);
+    expect(core.archivedThreadIds).toEqual([]);
+  });
+});
+
+describe("preserveMidLoadTransitions", () => {
+  const stateWith = (
+    data: {
+      id: string;
+      remoteId?: string;
+      status: "new" | "regular" | "archived";
+      localOrigin?: true;
+    }[],
+    lists: { threadIds?: string[]; archivedThreadIds?: string[] } = {},
+  ): RemoteThreadState => ({
+    isLoading: false,
+    isLoadingMore: false,
+    cursor: undefined,
+    newThreadId: undefined,
+    threadIds: lists.threadIds ?? [],
+    archivedThreadIds: lists.archivedThreadIds ?? [],
+    threadIdMap: Object.fromEntries(
+      data.map((d) => [d.id, createThreadMappingId(d.id)]),
+    ),
+    threadData: Object.fromEntries(
+      data.map((d) => [
+        createThreadMappingId(d.id),
+        {
+          id: d.id,
+          remoteId: d.remoteId,
+          externalId: undefined,
+          status: d.status,
+          ...(d.localOrigin ? { localOrigin: true as const } : {}),
+          initializeTask: Promise.resolve({
+            remoteId: d.remoteId ?? d.id,
+            externalId: undefined,
+          }),
+        },
+      ]),
+    ) as RemoteThreadState["threadData"],
+  });
+
+  it("does not resurrect a thread the server already knew and omitted", () => {
+    const state = stateWith([{ id: "t1", remoteId: "t1", status: "regular" }]);
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["t1"], archivedThreadIds: [] },
+      new Map([["t1", "regular"]]),
+    );
+    expect(result.threadIds).toEqual([]);
+  });
+
+  it("does not duplicate a thread the response contains by remoteId", () => {
+    const state = stateWith(
+      [
+        {
+          id: "__LOCALID_1",
+          remoteId: "remote-1",
+          status: "regular",
+          localOrigin: true,
+        },
+      ],
+      { threadIds: ["remote-1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["__LOCALID_1"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["remote-1"]);
+  });
+
+  it("prepends a mid-flight transition ahead of listed threads", () => {
+    const state = stateWith(
+      [
+        { id: "local-1", remoteId: "remote-1", status: "regular" },
+        { id: "t1", remoteId: "t1", status: "regular" },
+      ],
+      { threadIds: ["t1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["local-1", "t1"], archivedThreadIds: [] },
+      new Map([
+        ["local-1", "new"],
+        ["t1", "regular"],
+      ]),
+    );
+    expect(result.threadIds).toEqual(["local-1", "t1"]);
+  });
+
+  it("orders multiple rescued threads by their live pre-response order", () => {
+    const state = stateWith(
+      [
+        {
+          id: "__LOCALID_1",
+          remoteId: "remote-1",
+          status: "regular",
+          localOrigin: true,
+        },
+        {
+          id: "__LOCALID_2",
+          remoteId: "remote-2",
+          status: "regular",
+          localOrigin: true,
+        },
+      ],
+      { threadIds: ["t1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["__LOCALID_2", "__LOCALID_1"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["__LOCALID_2", "__LOCALID_1", "t1"]);
+  });
+
+  it("leaves a fetched non-local thread governed by the response", () => {
+    const state = stateWith([{ id: "t9", remoteId: "t9", status: "regular" }], {
+      threadIds: ["t1"],
+    });
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["t1", "t9"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["t1"]);
+  });
+
+  it("does not trust a remote id that mimics the local prefix", () => {
+    const state = stateWith(
+      [{ id: "__LOCALID_evil", remoteId: "__LOCALID_evil", status: "regular" }],
+      { threadIds: ["t1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["t1", "__LOCALID_evil"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["t1"]);
+  });
+
+  it("re-inserts an archived mid-flight transition", () => {
+    const state = stateWith([
+      {
+        id: "__LOCALID_1",
+        remoteId: "remote-1",
+        status: "archived",
+        localOrigin: true,
+      },
+    ]);
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: [], archivedThreadIds: ["__LOCALID_1"] },
+      new Map([["__LOCALID_1", "new"]]),
+    );
+    expect(result.archivedThreadIds).toEqual(["__LOCALID_1"]);
+  });
+});

package/src/tests/RemoteThreadListThreadListRuntimeCore-loadMore.test.ts

@@ -195,6 +195,30 @@ describe("RemoteThreadListThreadListRuntimeCore.loadMore", () => {
     expect(core.hasMore).toBe(false);
   });
 
+  it("clears loadingMore when the superseded request never settles", async () => {
+    const listFn = vi
+      .fn<ListFn>()
+      .mockResolvedValueOnce({
+        threads: [{ status: "regular", remoteId: "a", externalId: "a" }],
+        nextCursor: "c1",
+      })
+      .mockReturnValueOnce(new Promise<never>(() => {}))
+      .mockResolvedValueOnce({
+        threads: [
+          { status: "regular", remoteId: "fresh", externalId: "fresh" },
+        ],
+      });
+    const adapter = makeAdapter({ list: listFn });
+    const core = createCore(adapter);
+
+    await core.getLoadThreadsPromise();
+    void core.loadMore();
+    await core.reload();
+
+    expect(core.threadIds).toEqual(["fresh"]);
+    expect(core.isLoadingMore).toBe(false);
+  });
+
   it("releases the dedup handle after a rejection so retries can proceed", async () => {
     vi.spyOn(console, "error").mockImplementation(() => {});
     const listFn = vi
@@ -241,6 +265,60 @@ describe("RemoteThreadListThreadListRuntimeCore.loadMore", () => {
     expect(core.threadIds).toEqual(["a", "b"]);
   });
 
+  it("refreshes a thread repeated on a later page instead of dropping it", async () => {
+    const listFn = vi
+      .fn<ListFn>()
+      .mockResolvedValueOnce({
+        threads: [
+          { status: "regular", remoteId: "a", externalId: "a", title: "old" },
+        ],
+        nextCursor: "c1",
+      })
+      .mockResolvedValueOnce({
+        threads: [
+          {
+            status: "regular",
+            remoteId: "a",
+            externalId: "a",
+            title: "updated",
+          },
+          { status: "regular", remoteId: "b", externalId: "b", title: "New" },
+        ],
+      });
+    const core = createCore(makeAdapter({ list: listFn }));
+
+    await core.getLoadThreadsPromise();
+    await core.loadMore();
+
+    expect(core.threadIds).toEqual(["a", "b"]);
+    expect(core.getItemById("a")?.title).toBe("updated");
+  });
+
+  it("moves a thread whose status flips between pages", async () => {
+    const listFn = vi
+      .fn<ListFn>()
+      .mockResolvedValueOnce({
+        threads: [
+          { status: "regular", remoteId: "a", externalId: "a", title: "A" },
+          { status: "regular", remoteId: "b", externalId: "b", title: "B" },
+        ],
+        nextCursor: "c1",
+      })
+      .mockResolvedValueOnce({
+        threads: [
+          { status: "archived", remoteId: "a", externalId: "a", title: "A" },
+        ],
+      });
+    const core = createCore(makeAdapter({ list: listFn }));
+
+    await core.getLoadThreadsPromise();
+    await core.loadMore();
+
+    expect(core.threadIds).toEqual(["b"]);
+    expect(core.archivedThreadIds).toEqual(["a"]);
+    expect(core.getItemById("a")?.status).toBe("archived");
+  });
+
   it("__internal_setOptions clears cursor and dedup handles on adapter swap, then refetches via the new adapter", async () => {
     const firstAdapter = makeAdapter({
       list: vi.fn<ListFn>(async () => ({

package/src/tests/RemoteThreadListThreadListRuntimeCore-reload.test.ts

@@ -95,6 +95,58 @@ describe("RemoteThreadListThreadListRuntimeCore.reload", () => {
     expect(core.threadIds).not.toContain("stale");
   });
 
+  it("clears loading when the superseded request never settles", async () => {
+    const listFn = vi
+      .fn<() => Promise<RemoteThreadListResponse>>()
+      .mockReturnValueOnce(new Promise<never>(() => {}))
+      .mockResolvedValueOnce({
+        threads: [
+          {
+            status: "regular",
+            remoteId: "fresh",
+            externalId: "fresh",
+            title: "Fresh",
+          },
+        ],
+      });
+    const adapter = makeAdapter({ list: listFn });
+    const core = createCore(adapter);
+
+    void core.getLoadThreadsPromise();
+    await core.reload();
+
+    expect(core.threadIds).toEqual(["fresh"]);
+    expect(core.isLoading).toBe(false);
+  });
+
+  it("clears loading once the fresh list arrives, before the superseded request settles", async () => {
+    const first = deferred<RemoteThreadListResponse>();
+    const listFn = vi
+      .fn<() => Promise<RemoteThreadListResponse>>()
+      .mockReturnValueOnce(first.promise)
+      .mockResolvedValueOnce({
+        threads: [
+          {
+            status: "regular",
+            remoteId: "fresh",
+            externalId: "fresh",
+            title: "Fresh",
+          },
+        ],
+      });
+    const core = createCore(makeAdapter({ list: listFn }));
+
+    void core.getLoadThreadsPromise();
+    await core.reload();
+
+    expect(core.threadIds).toEqual(["fresh"]);
+    expect(core.isLoading).toBe(false);
+
+    first.resolve({ threads: [] });
+    await Promise.resolve();
+    expect(core.isLoading).toBe(false);
+  });
+
   it("recovers after a failed initial load", async () => {
     vi.spyOn(console, "error").mockImplementation(() => {});
     const listFn = vi

package/src/tests/RemoteThreadListThreadListRuntimeCore-title-race.test.ts

@@ -0,0 +1,158 @@
+import { describe, expect, it, vi } from "vitest";
+import {
+  createCore,
+  deferred,
+  makeAdapter,
+} from "./remote-thread-list-test-helpers";
+
+describe("RemoteThreadListThreadListRuntimeCore title generation", () => {
+  it("keeps a generated title when an earlier rename completes during another update", async () => {
+    const reloadRequest = deferred<{
+      threads: {
+        status: "regular";
+        remoteId: string;
+        externalId: string;
+        title: string;
+      }[];
+    }>();
+    const adapter = makeAdapter({
+      list: vi
+        .fn()
+        .mockResolvedValueOnce({
+          threads: [
+            {
+              status: "regular" as const,
+              remoteId: "thread-1",
+              externalId: "thread-1",
+              title: "New chat",
+            },
+          ],
+        })
+        .mockImplementationOnce(() => reloadRequest.promise),
+      generateTitle: vi.fn(
+        async () =>
+          new ReadableStream({
+            start(controller) {
+              controller.enqueue({
+                type: "part-start",
+                path: [0],
+                part: { type: "text" },
+              });
+              controller.enqueue({
+                type: "text-delta",
+                path: [0],
+                textDelta: "Generated Title",
+              });
+              controller.enqueue({ type: "part-finish", path: [0] });
+              controller.close();
+            },
+          }) as never,
+      ),
+    });
+    const core = createCore(adapter);
+    await core.getLoadThreadsPromise();
+
+    const internals = core as unknown as {
+      _hookManager: { getThreadRuntimeCore: () => { messages: never[] } };
+    };
+    internals._hookManager.getThreadRuntimeCore = () => ({ messages: [] });
+
+    const overlappingUpdate = core.reload();
+
+    await core.rename("thread-1", "Instant name");
+    await core.generateTitle("thread-1");
+
+    expect(core.getItemById("thread-1")?.title).toBe("Generated Title");
+
+    reloadRequest.resolve({
+      threads: [
+        {
+          status: "regular",
+          remoteId: "thread-1",
+          externalId: "thread-1",
+          title: "New chat",
+        },
+      ],
+    });
+    await overlappingUpdate;
+
+    expect(core.getItemById("thread-1")?.title).toBe("Generated Title");
+  });
+
+  it("does not apply a generated title after the adapter changes", async () => {
+    const adapterA = makeAdapter({
+      list: vi.fn(async () => ({
+        threads: [
+          {
+            status: "regular" as const,
+            remoteId: "thread-1",
+            externalId: "thread-1",
+            title: "Adapter A title",
+          },
+        ],
+      })),
+      generateTitle: vi.fn(
+        async () =>
+          new ReadableStream({
+            start(controller) {
+              controller.enqueue({
+                type: "part-start",
+                path: [0],
+                part: { type: "text" },
+              });
+              controller.enqueue({
+                type: "text-delta",
+                path: [0],
+                textDelta: "Generated by adapter A",
+              });
+              controller.enqueue({ type: "part-finish", path: [0] });
+              controller.close();
+            },
+          }) as never,
+      ),
+    });
+    const adapterB = makeAdapter({
+      list: vi.fn(async () => ({
+        threads: [
+          {
+            status: "regular" as const,
+            remoteId: "thread-1",
+            externalId: "thread-1",
+            title: "Adapter B title",
+          },
+        ],
+      })),
+    });
+    const core = createCore(adapterA);
+    await core.getLoadThreadsPromise();
+
+    const internals = core as unknown as {
+      _hookManager: { getThreadRuntimeCore: () => { messages: never[] } };
+    };
+    internals._hookManager.getThreadRuntimeCore = () => ({ messages: [] });
+
+    let replacementLoad: Promise<void> | undefined;
+    let adapterChanged = false;
+    const unsubscribe = core.subscribe(() => {
+      if (
+        adapterChanged ||
+        core.getItemById("thread-1")?.title !== "Generated by adapter A"
+      ) {
+        return;
+      }
+      adapterChanged = true;
+      core.__internal_setOptions({
+        adapter: adapterB,
+        runtimeHook: () => ({}) as never,
+      });
+      replacementLoad = core.getLoadThreadsPromise();
+    });
+
+    await core.generateTitle("thread-1");
+    unsubscribe();
+    expect(adapterChanged).toBe(true);
+    await replacementLoad;
+
+    expect(core.getItemById("thread-1")?.title).toBe("Adapter B title");
+  });
+});

package/src/tests/external-store-optimistic-id.test.ts

@@ -0,0 +1,79 @@
+import { describe, it, expect, vi } from "vitest";
+import { ExternalStoreThreadRuntimeCore } from "../runtimes/external-store/external-store-thread-runtime-core";
+import type { ExternalStoreAdapter } from "../runtimes/external-store/external-store-adapter";
+import type { ModelContextProvider } from "../model-context/types";
+import type { ThreadMessage } from "../types/message";
+
+const createContextProvider = (): ModelContextProvider => ({
+  getModelContext: () => ({}),
+});
+
+const createUserMessage = (id: string, text = "Hello"): ThreadMessage =>
+  ({
+    id,
+    role: "user" as const,
+    createdAt: new Date(),
+    content: [{ type: "text" as const, text }],
+    attachments: [],
+    metadata: {
+      custom: {},
+    },
+  }) as ThreadMessage;
+
+const createAssistantMessage = (id: string, text = "Hi there"): ThreadMessage =>
+  ({
+    id,
+    role: "assistant" as const,
+    createdAt: new Date(),
+    content: [{ type: "text" as const, text }],
+    status: { type: "complete" as const, reason: "stop" as const },
+    metadata: {
+      unstable_state: null,
+      unstable_annotations: [],
+      unstable_data: [],
+      steps: [],
+      custom: {},
+    },
+  }) as ThreadMessage;
+
+const createAdapter = (
+  messages: readonly ThreadMessage[],
+  isRunning: boolean,
+): ExternalStoreAdapter<ThreadMessage> => ({
+  messages,
+  isRunning,
+  onNew: vi.fn(async () => {}),
+});
+
+describe("ExternalStoreThreadRuntimeCore optimistic placeholder id", () => {
+  it("keeps one placeholder id per pending response and issues a fresh one per episode", () => {
+    const u1 = createUserMessage("u1");
+    const core = new ExternalStoreThreadRuntimeCore(
+      createContextProvider(),
+      createAdapter([u1], true),
+    );
+    const first = core.messages.at(-1)!;
+    expect(first.role).toBe("assistant");
+    expect(first.content).toHaveLength(0);
+
+    core.__internal_setAdapter(createAdapter([u1], true));
+    core.__internal_setAdapter(createAdapter([u1], true));
+    expect(core.messages.at(-1)!.id).toBe(first.id);
+
+    const u2 = createUserMessage("u2", "follow-up");
+    core.__internal_setAdapter(createAdapter([u1, u2], true));
+    const second = core.messages.at(-1)!;
+    expect(second.role).toBe("assistant");
+    expect(second.id).not.toBe(first.id);
+
+    const a1 = createAssistantMessage("a1");
+    core.__internal_setAdapter(createAdapter([u1, u2, a1], false));
+    expect(core.messages.at(-1)!.id).toBe("a1");
+
+    const u3 = createUserMessage("u3", "again");
+    core.__internal_setAdapter(createAdapter([u1, u2, a1, u3], true));
+    const third = core.messages.at(-1)!;
+    expect(third.role).toBe("assistant");
+    expect(third.id).not.toBe(second.id);
+  });
+});