@assistant-ui/core 0.3.15 → 0.3.16

package/src/tests/MessageRepository.test.ts

@@ -576,6 +576,83 @@ describe("MessageRepository", () => {
     });
   });
 
+  describe("ExportedMessageRepository auto status", () => {
+    const pendingToolCall: ThreadMessageLike = {
+      id: "a1",
+      role: "assistant",
+      content: [
+        {
+          type: "tool-call",
+          toolCallId: "t1",
+          toolName: "search",
+          args: {},
+          argsText: "{}",
+          approval: { id: "a1" },
+        },
+      ],
+    };
+
+    it("fromArray reports requires-action for an unresolved approval", () => {
+      const result = ExportedMessageRepository.fromArray([pendingToolCall]);
+      expect(result.messages[0]!.message.status).toMatchObject({
+        type: "requires-action",
+        reason: "interrupt",
+      });
+    });
+
+    it("fromBranchableArray reports requires-action for an unresolved approval", () => {
+      const result = ExportedMessageRepository.fromBranchableArray([
+        { message: pendingToolCall, parentId: null },
+      ]);
+      expect(result.messages[0]!.message.status).toMatchObject({
+        type: "requires-action",
+        reason: "interrupt",
+      });
+    });
+
+    it("fromArray reports requires-action with reason tool-calls for a resultless tool call", () => {
+      const result = ExportedMessageRepository.fromArray([
+        {
+          ...pendingToolCall,
+          content: [
+            {
+              type: "tool-call",
+              toolCallId: "t1",
+              toolName: "search",
+              args: {},
+              argsText: "{}",
+            },
+          ],
+        },
+      ]);
+      expect(result.messages[0]!.message.status).toMatchObject({
+        type: "requires-action",
+        reason: "tool-calls",
+      });
+    });
+
+    it("keeps complete for a resolved tool call", () => {
+      const result = ExportedMessageRepository.fromArray([
+        {
+          ...pendingToolCall,
+          content: [
+            {
+              type: "tool-call",
+              toolCallId: "t1",
+              toolName: "search",
+              args: {},
+              argsText: "{}",
+              result: "ok",
+            },
+          ],
+        },
+      ]);
+      expect(result.messages[0]!.message.status).toMatchObject({
+        type: "complete",
+      });
+    });
+  });
+
   describe("ExportedMessageRepository.fromBranchableArray", () => {
     it("should create a branching tree structure", () => {
       const items = [

package/src/tests/RemoteThreadListThreadListRuntimeCore-load-race.test.ts

@@ -0,0 +1,194 @@
+import { describe, it, expect, vi } from "vitest";
+import {
+  createCore,
+  makeAdapter,
+  deferred,
+} from "./remote-thread-list-test-helpers";
+import {
+  preserveMidLoadTransitions,
+  createThreadMappingId,
+  type RemoteThreadState,
+} from "../runtimes/remote-thread-list/remote-thread-state";
+
+type ListResult = Awaited<ReturnType<ReturnType<typeof makeAdapter>["list"]>>;
+
+describe("RemoteThreadListThreadListRuntimeCore load race", () => {
+  it("keeps a thread initialized during the list() flight at the top", async () => {
+    const listDeferred = deferred<ListResult>();
+    const adapter = makeAdapter({ list: vi.fn(() => listDeferred.promise) });
+    const core = createCore(adapter);
+
+    const loadPromise = core.getLoadThreadsPromise();
+
+    await core.switchToNewThread();
+    const newId = core.newThreadId!;
+    await core.initialize(newId);
+    expect(core.threadIds).toContain(newId);
+
+    listDeferred.resolve({
+      threads: [
+        { status: "regular", remoteId: "t1", externalId: "t1", title: "One" },
+      ],
+    });
+    await loadPromise;
+
+    expect(core.getItemById(newId)?.status).toBe("regular");
+    expect(core.threadIds[0]).toBe(newId);
+    expect(core.threadIds).toContain("t1");
+  });
+});
+
+describe("preserveMidLoadTransitions", () => {
+  const stateWith = (
+    data: {
+      id: string;
+      remoteId?: string;
+      status: "new" | "regular" | "archived";
+      localOrigin?: true;
+    }[],
+    lists: { threadIds?: string[]; archivedThreadIds?: string[] } = {},
+  ): RemoteThreadState => ({
+    isLoading: false,
+    isLoadingMore: false,
+    cursor: undefined,
+    newThreadId: undefined,
+    threadIds: lists.threadIds ?? [],
+    archivedThreadIds: lists.archivedThreadIds ?? [],
+    threadIdMap: Object.fromEntries(
+      data.map((d) => [d.id, createThreadMappingId(d.id)]),
+    ),
+    threadData: Object.fromEntries(
+      data.map((d) => [
+        createThreadMappingId(d.id),
+        {
+          id: d.id,
+          remoteId: d.remoteId,
+          externalId: undefined,
+          status: d.status,
+          ...(d.localOrigin ? { localOrigin: true as const } : {}),
+          initializeTask: Promise.resolve({
+            remoteId: d.remoteId ?? d.id,
+            externalId: undefined,
+          }),
+        },
+      ]),
+    ) as RemoteThreadState["threadData"],
+  });
+
+  it("does not resurrect a thread the server already knew and omitted", () => {
+    const state = stateWith([{ id: "t1", remoteId: "t1", status: "regular" }]);
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["t1"], archivedThreadIds: [] },
+      new Map([["t1", "regular"]]),
+    );
+    expect(result.threadIds).toEqual([]);
+  });
+
+  it("does not duplicate a thread the response contains by remoteId", () => {
+    const state = stateWith(
+      [
+        {
+          id: "__LOCALID_1",
+          remoteId: "remote-1",
+          status: "regular",
+          localOrigin: true,
+        },
+      ],
+      { threadIds: ["remote-1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["__LOCALID_1"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["remote-1"]);
+  });
+
+  it("prepends a mid-flight transition ahead of listed threads", () => {
+    const state = stateWith(
+      [
+        { id: "local-1", remoteId: "remote-1", status: "regular" },
+        { id: "t1", remoteId: "t1", status: "regular" },
+      ],
+      { threadIds: ["t1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["local-1", "t1"], archivedThreadIds: [] },
+      new Map([
+        ["local-1", "new"],
+        ["t1", "regular"],
+      ]),
+    );
+    expect(result.threadIds).toEqual(["local-1", "t1"]);
+  });
+
+  it("orders multiple rescued threads by their live pre-response order", () => {
+    const state = stateWith(
+      [
+        {
+          id: "__LOCALID_1",
+          remoteId: "remote-1",
+          status: "regular",
+          localOrigin: true,
+        },
+        {
+          id: "__LOCALID_2",
+          remoteId: "remote-2",
+          status: "regular",
+          localOrigin: true,
+        },
+      ],
+      { threadIds: ["t1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["__LOCALID_2", "__LOCALID_1"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["__LOCALID_2", "__LOCALID_1", "t1"]);
+  });
+
+  it("leaves a fetched non-local thread governed by the response", () => {
+    const state = stateWith([{ id: "t9", remoteId: "t9", status: "regular" }], {
+      threadIds: ["t1"],
+    });
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["t1", "t9"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["t1"]);
+  });
+
+  it("does not trust a remote id that mimics the local prefix", () => {
+    const state = stateWith(
+      [{ id: "__LOCALID_evil", remoteId: "__LOCALID_evil", status: "regular" }],
+      { threadIds: ["t1"] },
+    );
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: ["t1", "__LOCALID_evil"], archivedThreadIds: [] },
+      new Map(),
+    );
+    expect(result.threadIds).toEqual(["t1"]);
+  });
+
+  it("re-inserts an archived mid-flight transition", () => {
+    const state = stateWith([
+      {
+        id: "__LOCALID_1",
+        remoteId: "remote-1",
+        status: "archived",
+        localOrigin: true,
+      },
+    ]);
+    const result = preserveMidLoadTransitions(
+      state,
+      { threadIds: [], archivedThreadIds: ["__LOCALID_1"] },
+      new Map([["__LOCALID_1", "new"]]),
+    );
+    expect(result.archivedThreadIds).toEqual(["__LOCALID_1"]);
+  });
+});

package/src/tests/RemoteThreadListThreadListRuntimeCore-title-race.test.ts

@@ -0,0 +1,158 @@
+import { describe, expect, it, vi } from "vitest";
+import {
+  createCore,
+  deferred,
+  makeAdapter,
+} from "./remote-thread-list-test-helpers";
+
+describe("RemoteThreadListThreadListRuntimeCore title generation", () => {
+  it("keeps a generated title when an earlier rename completes during another update", async () => {
+    const reloadRequest = deferred<{
+      threads: {
+        status: "regular";
+        remoteId: string;
+        externalId: string;
+        title: string;
+      }[];
+    }>();
+    const adapter = makeAdapter({
+      list: vi
+        .fn()
+        .mockResolvedValueOnce({
+          threads: [
+            {
+              status: "regular" as const,
+              remoteId: "thread-1",
+              externalId: "thread-1",
+              title: "New chat",
+            },
+          ],
+        })
+        .mockImplementationOnce(() => reloadRequest.promise),
+      generateTitle: vi.fn(
+        async () =>
+          new ReadableStream({
+            start(controller) {
+              controller.enqueue({
+                type: "part-start",
+                path: [0],
+                part: { type: "text" },
+              });
+              controller.enqueue({
+                type: "text-delta",
+                path: [0],
+                textDelta: "Generated Title",
+              });
+              controller.enqueue({ type: "part-finish", path: [0] });
+              controller.close();
+            },
+          }) as never,
+      ),
+    });
+    const core = createCore(adapter);
+    await core.getLoadThreadsPromise();
+
+    const internals = core as unknown as {
+      _hookManager: { getThreadRuntimeCore: () => { messages: never[] } };
+    };
+    internals._hookManager.getThreadRuntimeCore = () => ({ messages: [] });
+
+    const overlappingUpdate = core.reload();
+
+    await core.rename("thread-1", "Instant name");
+    await core.generateTitle("thread-1");
+
+    expect(core.getItemById("thread-1")?.title).toBe("Generated Title");
+
+    reloadRequest.resolve({
+      threads: [
+        {
+          status: "regular",
+          remoteId: "thread-1",
+          externalId: "thread-1",
+          title: "New chat",
+        },
+      ],
+    });
+    await overlappingUpdate;
+
+    expect(core.getItemById("thread-1")?.title).toBe("Generated Title");
+  });
+
+  it("does not apply a generated title after the adapter changes", async () => {
+    const adapterA = makeAdapter({
+      list: vi.fn(async () => ({
+        threads: [
+          {
+            status: "regular" as const,
+            remoteId: "thread-1",
+            externalId: "thread-1",
+            title: "Adapter A title",
+          },
+        ],
+      })),
+      generateTitle: vi.fn(
+        async () =>
+          new ReadableStream({
+            start(controller) {
+              controller.enqueue({
+                type: "part-start",
+                path: [0],
+                part: { type: "text" },
+              });
+              controller.enqueue({
+                type: "text-delta",
+                path: [0],
+                textDelta: "Generated by adapter A",
+              });
+              controller.enqueue({ type: "part-finish", path: [0] });
+              controller.close();
+            },
+          }) as never,
+      ),
+    });
+    const adapterB = makeAdapter({
+      list: vi.fn(async () => ({
+        threads: [
+          {
+            status: "regular" as const,
+            remoteId: "thread-1",
+            externalId: "thread-1",
+            title: "Adapter B title",
+          },
+        ],
+      })),
+    });
+    const core = createCore(adapterA);
+    await core.getLoadThreadsPromise();
+
+    const internals = core as unknown as {
+      _hookManager: { getThreadRuntimeCore: () => { messages: never[] } };
+    };
+    internals._hookManager.getThreadRuntimeCore = () => ({ messages: [] });
+
+    let replacementLoad: Promise<void> | undefined;
+    let adapterChanged = false;
+    const unsubscribe = core.subscribe(() => {
+      if (
+        adapterChanged ||
+        core.getItemById("thread-1")?.title !== "Generated by adapter A"
+      ) {
+        return;
+      }
+      adapterChanged = true;
+      core.__internal_setOptions({
+        adapter: adapterB,
+        runtimeHook: () => ({}) as never,
+      });
+      replacementLoad = core.getLoadThreadsPromise();
+    });
+
+    await core.generateTitle("thread-1");
+    unsubscribe();
+    expect(adapterChanged).toBe(true);
+    await replacementLoad;
+
+    expect(core.getItemById("thread-1")?.title).toBe("Adapter B title");
+  });
+});

package/src/tests/external-store-thread-runtime-core-adapter.test.ts

@@ -802,6 +802,170 @@ describe("ExternalStoreThreadRuntimeCore adapter contract", () => {
   });
 
   describe("tool callbacks", () => {
+    it("keeps the runtime running until an executing client tool settles", async () => {
+      let resolveTool!: (value: { forecast: string }) => void;
+      const execute = vi.fn(
+        () =>
+          new Promise<{ forecast: string }>((resolve) => {
+            resolveTool = resolve;
+          }),
+      );
+      const core = new ExternalStoreThreadRuntimeCore(
+        {
+          getModelContext: () => ({
+            tools: {
+              weatherSearch: {
+                parameters: { type: "object", properties: {} },
+                execute,
+              },
+            },
+          }),
+        },
+        createBaseAdapter({
+          unstable_enableToolInvocations: true,
+          isRunning: false,
+        }),
+      );
+      const onRunEnd = vi.fn();
+      const onUpdate = vi.fn();
+      core.unstable_on("runEnd", onRunEnd);
+      core.subscribe(onUpdate);
+
+      core.__internal_setAdapter(
+        createBaseAdapter({
+          unstable_enableToolInvocations: true,
+          isRunning: false,
+          messages: [
+            {
+              ...createAssistantMessage("a1"),
+              status: { type: "requires-action", reason: "tool-calls" },
+              content: [
+                {
+                  type: "tool-call",
+                  toolCallId: "tc1",
+                  toolName: "weatherSearch",
+                  args: { city: "London" },
+                  argsText: '{"city":"London"}',
+                },
+              ],
+            },
+          ],
+        }),
+      );
+
+      await vi.waitFor(() => expect(core.isRunning).toBe(true));
+      expect(onRunEnd).not.toHaveBeenCalled();
+
+      onUpdate.mockClear();
+      resolveTool({ forecast: "sunny" });
+
+      await vi.waitFor(() => expect(core.isRunning).toBe(false));
+      expect(onRunEnd).toHaveBeenCalledOnce();
+      expect(onUpdate).toHaveBeenCalled();
+    });
+
+    it("mirrors the adapter running value when tool invocations are disabled", () => {
+      const core = new ExternalStoreThreadRuntimeCore(
+        contextProvider,
+        createBaseAdapter(),
+      );
+
+      expect(core.isRunning).toBeUndefined();
+
+      core.__internal_setAdapter(createBaseAdapter({ isRunning: false }));
+      expect(core.isRunning).toBe(false);
+
+      core.__internal_setAdapter(createBaseAdapter({ isRunning: true }));
+      expect(core.isRunning).toBe(true);
+    });
+
+    it("passes an undefined adapter running value through when no tool is executing", () => {
+      const core = new ExternalStoreThreadRuntimeCore(
+        contextProvider,
+        createBaseAdapter({ unstable_enableToolInvocations: true }),
+      );
+
+      expect(core.isRunning).toBeUndefined();
+    });
+
+    it("stops running when the session resets during a tool execution", async () => {
+      const execute = vi.fn(() => new Promise<never>(() => {}));
+      const core = new ExternalStoreThreadRuntimeCore(
+        {
+          getModelContext: () => ({
+            tools: {
+              weatherSearch: {
+                parameters: { type: "object", properties: {} },
+                execute,
+              },
+            },
+          }),
+        },
+        createBaseAdapter({
+          unstable_enableToolInvocations: true,
+          isRunning: false,
+        }),
+      );
+      const onRunEnd = vi.fn();
+      core.unstable_on("runEnd", onRunEnd);
+
+      core.__internal_setAdapter(
+        createBaseAdapter({
+          unstable_enableToolInvocations: true,
+          isRunning: false,
+          messages: [
+            {
+              ...createAssistantMessage("a1"),
+              status: { type: "requires-action", reason: "tool-calls" },
+              content: [
+                {
+                  type: "tool-call",
+                  toolCallId: "tc1",
+                  toolName: "weatherSearch",
+                  args: { city: "London" },
+                  argsText: '{"city":"London"}',
+                },
+              ],
+            },
+          ],
+        }),
+      );
+
+      await vi.waitFor(() => expect(core.isRunning).toBe(true));
+
+      core.unstable_notifySessionReset();
+
+      expect(core.isRunning).toBe(false);
+      expect(onRunEnd).toHaveBeenCalledOnce();
+
+      execute.mockClear();
+      core.__internal_setAdapter(
+        createBaseAdapter({
+          unstable_enableToolInvocations: true,
+          isRunning: false,
+          messages: [
+            {
+              ...createAssistantMessage("a2"),
+              status: { type: "requires-action", reason: "tool-calls" },
+              content: [
+                {
+                  type: "tool-call",
+                  toolCallId: "tc2",
+                  toolName: "weatherSearch",
+                  args: { city: "Paris" },
+                  argsText: '{"city":"Paris"}',
+                },
+              ],
+            },
+          ],
+        }),
+      );
+
+      await new Promise((resolve) => setTimeout(resolve, 10));
+      expect(execute).not.toHaveBeenCalled();
+      expect(core.isRunning).toBe(false);
+    });
+
     it("handles rejected automatic tool result callbacks", async () => {
       const error = new Error("tool result failed");
       const consoleError = vi