@assembly-js/app-foundation 0.0.38 → 0.0.39

package/bin/check-crons.mjs

@@ -13,7 +13,9 @@
 // cronWiringChangedThisTurn). Everything else — a template clone, a Vercel
 // build, an update turn that never touched the cron — gets the same findings
 // as warnings: those paths have no agent who can act on a failure, so failing
-// them would only strand an app that already worked.
+// them would only strand an app that already worked. A below-floor schedule
+// the app shipped before the turn stays a warning even then (see
+// baselineCronSchedules).
 import { readFileSync, readdirSync, existsSync } from 'node:fs';
 import { spawnSync } from 'node:child_process';
 import { join, relative, sep } from 'node:path';
@@ -65,6 +67,30 @@ function isCronWiringPath(file) {
   return CRON_WIRING_PATHS.some((p) => (p.endsWith('/') ? file.startsWith(p) : file === p));
 }
 
+// The cron entries vercel.json carried at the turn baseline, keyed by path and
+// schedule. A schedule the app already shipped is product behavior the turn has
+// no mandate to change, so its interval finding stays a warning even when the
+// turn rewired the route behind it. An unreadable baseline yields an empty set,
+// which keeps every interval finding fatal.
+function baselineCronSchedules() {
+  const baseline = (process.env[TURN_BASELINE_ENV] ?? '').trim();
+  const schedules = new Set();
+  if (!baseline) return schedules;
+  const result = spawnSync('git', ['show', `${baseline}:vercel.json`], { cwd: ROOT, encoding: 'utf8' });
+  if (result.status !== 0) return schedules;
+  try {
+    const crons = JSON.parse(result.stdout).crons;
+    if (Array.isArray(crons)) for (const c of crons) schedules.add(cronKey(c));
+  } catch {
+    // An unparseable baseline file shipped no schedule this turn could preserve.
+  }
+  return schedules;
+}
+
+function cronKey(entry) {
+  return `${entry?.path}\n${typeof entry?.schedule === 'string' ? entry.schedule.trim() : ''}`;
+}
+
 // Whether this turn changed vercel.json or a cron route: commits since the
 // baseline plus whatever is still uncommitted. No baseline means no turn (a
 // Vercel build, a clone bootstrap), so nothing is the agent's to fix. A git
@@ -226,6 +252,8 @@ if (crons !== undefined && !Array.isArray(crons)) {
 }
 const entries = Array.isArray(crons) ? crons : [];
 const coveredRoutes = new Set();
+const shippedSchedules = baselineCronSchedules();
+const preexistingIntervals = [];
 
 entries.forEach((entry, i) => {
   const label = `vercel.json crons[${i}]`;
@@ -251,10 +279,12 @@ entries.forEach((entry, i) => {
   if (interval === null) {
     problems.push(`${label} (${entry.path}): "${entry.schedule}" is not a valid 5-field cron expression.`);
   } else if (interval < MIN_INTERVAL_MINUTES) {
-    problems.push(
-      `${label} (${entry.path}): "${entry.schedule}" fires every ${interval} minutes; the floor is every ` +
-        `${MIN_INTERVAL_MINUTES}. Use "*/30 * * * *" and keep per-action cadences in the app's schedule table.`,
-    );
+    const finding = `${label} (${entry.path}): "${entry.schedule}" fires every ${interval} minutes; the floor is every ${MIN_INTERVAL_MINUTES}.`;
+    if (shippedSchedules.has(cronKey(entry))) {
+      preexistingIntervals.push(`${finding} The app already shipped this schedule, so leave it unchanged.`);
+    } else {
+      problems.push(`${finding} Use "*/30 * * * *" and keep per-action cadences in the app's schedule table.`);
+    }
   }
 });
 
@@ -281,4 +311,5 @@ if (entries.length > 0) {
   }
 }
 
+if (preexistingIntervals.length > 0) report(preexistingIntervals, { fatal: false });
 if (problems.length > 0) report(problems, { fatal: cronWiringChangedThisTurn() });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@assembly-js/app-foundation",
-  "version": "0.0.38",
+  "version": "0.0.39",
   "description": "Versioned foundation helpers and build context for Assembly generated apps",
   "type": "module",
   "files": [