@ask-llm/plugin 0.18.0 → 0.19.0

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "ask-llm",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "AI-to-AI collaboration — review code and debate plans across Codex, Grok, Antigravity, Ollama, and Gemini",
   "author": {
     "name": "Anton Lykhoyda",

package/.cursor-plugin/plugin.json

@@ -1,7 +1,7 @@
 {
   "name": "ask-llm",
   "displayName": "Ask LLM",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "Portable AI-to-AI review and pairing workflows for Cursor Agent with explicit provider transports.",
   "author": {
     "name": "Anton Lykhoyda"

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # @ask-llm/plugin
 
+## 0.19.0
+
+### Minor Changes
+
+- [#340](https://github.com/Lykhoyda/ask-llm/pull/340) [`d9c4ff8`](https://github.com/Lykhoyda/ask-llm/commit/d9c4ff804fe3349dffa16be451b58ac39bd6d5da) Thanks [@Lykhoyda](https://github.com/Lykhoyda)! - Keep the codex-pair broker opt-in with project and environment controls, stale-broker cleanup, and direct-review fallback on broker protocol failures.
+
+- [#340](https://github.com/Lykhoyda/ask-llm/pull/340) [`d9c4ff8`](https://github.com/Lykhoyda/ask-llm/commit/d9c4ff804fe3349dffa16be451b58ac39bd6d5da) Thanks [@Lykhoyda](https://github.com/Lykhoyda)! - Author the codex-pair hooks and broker in TypeScript, ship them as generated JavaScript, and require Node 24 or newer.
+
+### Patch Changes
+
+- [#340](https://github.com/Lykhoyda/ask-llm/pull/340) [`d9c4ff8`](https://github.com/Lykhoyda/ask-llm/commit/d9c4ff804fe3349dffa16be451b58ac39bd6d5da) Thanks [@Lykhoyda](https://github.com/Lykhoyda)! - Make the opt-in codex-pair broker safe to tear down and recover, keep its socket usable on deep project paths, and give broker reviews the same quota fallback and transient retry as direct reviews.
+
+- [#341](https://github.com/Lykhoyda/ask-llm/pull/341) [`97030be`](https://github.com/Lykhoyda/ask-llm/commit/97030bec4dd923ed64b8f5bf3378493da3e2c316) Thanks [@Lykhoyda](https://github.com/Lykhoyda)! - Keep a codex-pair broker running and tracked when `ps` cannot verify it, and give a stalled broker review half the review timeout so its direct fallback still finishes within one timeout.
+
+- [#338](https://github.com/Lykhoyda/ask-llm/pull/338) [`52f5230`](https://github.com/Lykhoyda/ask-llm/commit/52f5230a1e67ea499d18a3250801780ac39bdd4e) Thanks [@Lykhoyda](https://github.com/Lykhoyda)! - Insert codex-pair file and context text literally to prevent phantom injected-prompt findings.
+
 ## 0.18.0
 
 ### Minor Changes

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ask-llm/plugin",
-  "version": "0.18.0",
+  "version": "0.19.0",
   "description": "Ask LLM review, comparison, brainstorming, image, verification, and pairing workflows for Claude Code, Cursor Agent, and Pi",
   "type": "module",
   "main": "dist/index.js",
@@ -14,8 +14,9 @@
   },
   "scripts": {
     "build": "tsc",
+    "build:hooks": "tsc -p scripts/tsconfig.json && chmod 755 scripts/codex-pair-debounce-worker.mjs scripts/codex-pair-prompt-drain.mjs scripts/codex-pair-session.mjs scripts/codex-pair-stop-gate.mjs scripts/codex-pair-watch.mjs",
     "test": "vitest run",
-    "lint": "biome check src/ pi/ && biome lint scripts/ && tsc --noEmit && tsc --noEmit -p pi/tsconfig.json"
+    "lint": "biome check src/ pi/ && biome lint scripts/ && tsc --noEmit && tsc --noEmit -p pi/tsconfig.json && tsc -p scripts/tsconfig.json --noEmit"
   },
   "keywords": [
     "pi-package",
@@ -56,7 +57,7 @@
     "prompts/",
     "README.md",
     "scripts/*.mjs",
-    "scripts/lib/",
+    "scripts/lib/*.mjs",
     "skills/"
   ],
   "pi": {
@@ -96,7 +97,7 @@
     "typebox": "*"
   },
   "engines": {
-    "node": ">=20.0.0"
+    "node": ">=24.0.0"
   },
   "devDependencies": {
     "@biomejs/biome": "^2.5.10",

package/scripts/codex-pair-debounce-worker.mjs

@@ -1,103 +1,75 @@
 #!/usr/bin/env node
-// Detached edit-debounce worker (design 2026-06-03, closes #96 Bug 2 / Idea 1).
-//
-// Spawned by codex-pair-watch.mjs on each edit when debounceMs > 0. Sleeps the
-// settle window, then — only if no newer edit superseded it (trailing-edge) or
-// the burst exceeded the max cap — re-invokes the hook in FORCED-SYNC mode to
-// run the real review. The forced-sync hook acquires the existing per-file
-// inflight lock itself, so concurrent workers race there and exactly one
-// reviews (the inflight lock IS the claim — the worker holds no lock, which
-// would otherwise deadlock against the hook).
-//
-// The worker has no stdout channel to Claude, so it captures the hook's emitted
-// systemMessage and queues it in the per-file pending store; the next edit hook
-// (or the UserPromptSubmit drain) surfaces it. MUST exit 0 on every path (ADR-077).
-
+// Source of truth: codex-pair-debounce-worker.mts. The sibling .mjs is generated by `yarn workspace @ask-llm/plugin build:hooks`; never edit it.
+// Workers defer edits to the forced-sync hook, which owns the per-file lock; pending verdicts surface on a later hook.
 import { spawnSync } from "node:child_process";
 import { dirname, join } from "node:path";
 import { fileURLToPath } from "node:url";
-import {
-  clearReviewing,
-  decideReview,
-  markReviewed,
-  markReviewing,
-  readEditRecord,
-  writePending,
-} from "./lib/debounce-state.mjs";
-
+import { clearReviewing, decideReview, markReviewed, markReviewing, readEditRecord, writePending, } from "./lib/debounce-state.mjs";
 const SCRIPT_DIR = dirname(fileURLToPath(import.meta.url));
 const HOOK_PATH = join(SCRIPT_DIR, "codex-pair-watch.mjs");
-
 function sleep(ms) {
-  return new Promise((r) => setTimeout(r, ms));
+    return new Promise((r) => setTimeout(r, ms));
 }
-
-// The forced-sync hook writes one `{ "continue": true, "systemMessage": "..." }`
-// JSON line to stdout. Pull systemMessage from the last parseable line.
+// Read the last parseable hook output line; earlier stdout may not be JSON.
 function extractSystemMessage(stdout) {
-  if (!stdout) return null;
-  const lines = stdout.split("\n").filter((l) => l.trim().length > 0);
-  for (let i = lines.length - 1; i >= 0; i--) {
-    try {
-      const obj = JSON.parse(lines[i]);
-      if (typeof obj.systemMessage === "string") return obj.systemMessage;
-    } catch {
-      // not JSON — skip
+    if (!stdout)
+        return null;
+    const lines = stdout.split("\n").filter((l) => l.trim().length > 0);
+    for (let i = lines.length - 1; i >= 0; i--) {
+        try {
+            const obj = JSON.parse(lines[i]);
+            if (typeof obj.systemMessage === "string")
+                return obj.systemMessage;
+        }
+        catch {
+            // not JSON — skip
+        }
     }
-  }
-  return null;
+    return null;
 }
-
 async function main() {
-  const markerDir = process.env.CP_MARKER_DIR;
-  const file = process.env.CP_FILE;
-  const tool = process.env.CP_TOOL || "Edit";
-  const myGeneration = Number(process.env.CP_GENERATION);
-  const settleMs = Number(process.env.CP_SETTLE_MS);
-  const rawMaxMs = Number(process.env.CP_MAX_MS);
-  // Guard maxMs like settleMs: a missing/NaN CP_MAX_MS must not silently
-  // disable the anti-starvation cap (every `>= NaN` comparison is false).
-  const maxMs = Number.isFinite(rawMaxMs) && rawMaxMs > 0 ? rawMaxMs : 60_000;
-  if (!markerDir || !file || !Number.isFinite(myGeneration)) process.exit(0);
-
-  await sleep(Number.isFinite(settleMs) ? settleMs : 15_000);
-
-  const record = readEditRecord(markerDir, file);
-  const decision = decideReview({ record, myGeneration, now: Date.now(), maxMs });
-  if (!decision.review) process.exit(0);
-
-  // Hold a `reviewing` marker across the whole handoff: markReviewed consumes
-  // the debounce record BEFORE the forced-sync hook acquires the inflight
-  // lock, and the Stop-gate's in-flight check would otherwise see neither
-  // signal in that gap (dogfood review finding, 2026-07-02). Marker first,
-  // then record advance — no instant where both are absent.
-  markReviewing(markerDir, file);
-  // Advance the burst marker so the next edit starts a fresh burst. The actual
-  // concurrency claim is the inflight lock acquired by the forced-sync hook.
-  markReviewed(markerDir, file, myGeneration);
-
-  const payload = JSON.stringify({
-    hook_event_name: "PostToolUse",
-    tool_name: tool,
-    tool_input: { file_path: file },
-    session_id: process.env.CP_SESSION_ID || "",
-  });
-  const codexTimeout = Number(process.env.ASK_CODEX_TIMEOUT_MS ?? 800_000);
-  let res;
-  try {
-    res = spawnSync(process.execPath, [HOOK_PATH], {
-      input: payload,
-      cwd: markerDir,
-      encoding: "utf-8",
-      env: { ...process.env, CODEX_PAIR_FORCE_SYNC: "1" },
-      timeout: codexTimeout + 60_000,
+    const markerDir = process.env.CP_MARKER_DIR;
+    const file = process.env.CP_FILE;
+    const tool = process.env.CP_TOOL || "Edit";
+    const myGeneration = Number(process.env.CP_GENERATION);
+    const settleMs = Number(process.env.CP_SETTLE_MS);
+    const rawMaxMs = Number(process.env.CP_MAX_MS);
+    // NaN would disable the anti-starvation cap because comparisons always fail.
+    const maxMs = Number.isFinite(rawMaxMs) && rawMaxMs > 0 ? rawMaxMs : 60_000;
+    if (!markerDir || !file || !Number.isFinite(myGeneration))
+        process.exit(0);
+    await sleep(Number.isFinite(settleMs) ? settleMs : 15_000);
+    const record = readEditRecord(markerDir, file);
+    const decision = decideReview({ record, myGeneration, now: Date.now(), maxMs });
+    if (!decision.review)
+        process.exit(0);
+    // Mark reviewing before consuming the debounce record so the Stop-gate always sees in-flight work.
+    markReviewing(markerDir, file);
+    // The forced-sync hook owns the concurrency lock, not this worker.
+    markReviewed(markerDir, file, myGeneration);
+    const payload = JSON.stringify({
+        hook_event_name: "PostToolUse",
+        tool_name: tool,
+        tool_input: { file_path: file },
+        session_id: process.env.CP_SESSION_ID || "",
     });
-  } finally {
-    clearReviewing(markerDir, file);
-  }
-  const message = extractSystemMessage(res.stdout);
-  if (message) writePending(markerDir, file, message);
-  process.exit(0);
+    const codexTimeout = Number(process.env.ASK_CODEX_TIMEOUT_MS ?? 800_000);
+    let res;
+    try {
+        res = spawnSync(process.execPath, [HOOK_PATH], {
+            input: payload,
+            cwd: markerDir,
+            encoding: "utf-8",
+            env: { ...process.env, CODEX_PAIR_FORCE_SYNC: "1" },
+            timeout: codexTimeout + 60_000,
+        });
+    }
+    finally {
+        clearReviewing(markerDir, file);
+    }
+    const message = extractSystemMessage(res?.stdout);
+    if (message)
+        writePending(markerDir, file, message);
+    process.exit(0);
 }
-
 main().catch(() => process.exit(0));

package/scripts/codex-pair-prompt-drain.mjs

@@ -1,81 +1,67 @@
 #!/usr/bin/env node
-// UserPromptSubmit drain hook (design 2026-06-03 + plan red-team 2026-06-04).
-//
-// Surfaces any verdict a debounce worker queued, at the START of the next user
-// turn — closing the gap where a single edit (with no following edit) leaves
-// its review in the log but never in Claude's context. Cheap no-op when nothing
-// is pending. MUST exit 0 on every path (ADR-077).
-//
-// findMarkerUp is duplicated from codex-pair-watch/session.mjs by design:
-// zero-workspace-imports (marketplace git-subdir install has no node_modules)
-// and the helper is too small to extract (15 LOC).
-
+// Source of truth: codex-pair-prompt-drain.mts. The sibling .mjs is generated by `yarn workspace @ask-llm/plugin build:hooks`; never edit it.
+// Drain queued worker verdicts at the next user turn; failures must not block submission.
 import { access } from "node:fs/promises";
 import { homedir } from "node:os";
 import { dirname, join, resolve } from "node:path";
 import { drainPending, joinPendingForSurface } from "./lib/debounce-state.mjs";
 import { collectSessionMarkers } from "./lib/session-registry.mjs";
 import { CONTEXT_FILENAME, PAIR_ROOT_DIR } from "./lib/state.mjs";
-
 const MARKER_FILE = join(PAIR_ROOT_DIR, CONTEXT_FILENAME);
-
 async function findMarkerUp(startDir) {
-  const home = homedir();
-  let current = resolve(startDir);
-  for (let depth = 0; depth < 20; depth++) {
-    try {
-      await access(join(current, MARKER_FILE));
-      return current;
-    } catch {
-      // not here
+    const home = homedir();
+    let current = resolve(startDir);
+    for (let depth = 0; depth < 20; depth++) {
+        try {
+            await access(join(current, MARKER_FILE));
+            return current;
+        }
+        catch {
+            // not here
+        }
+        const parent = dirname(current);
+        if (parent === current || current === home)
+            return null;
+        current = parent;
     }
-    const parent = dirname(current);
-    if (parent === current || current === home) return null;
-    current = parent;
-  }
-  return null;
+    return null;
 }
-
 async function readStdin() {
-  return new Promise((r) => {
-    let data = "";
-    process.stdin.on("data", (c) => {
-      data += c.toString();
+    return new Promise((r) => {
+        let data = "";
+        process.stdin.on("data", (c) => {
+            data += c.toString();
+        });
+        process.stdin.on("end", () => r(data));
+        process.stdin.on("error", () => r(""));
     });
-    process.stdin.on("end", () => r(data));
-    process.stdin.on("error", () => r(""));
-  });
 }
-
 async function main() {
-  const raw = await readStdin();
-  let payload;
-  try {
-    payload = JSON.parse(raw);
-  } catch {
-    process.exit(0);
-  }
-  if (payload?.hook_event_name !== "UserPromptSubmit") process.exit(0);
-
-  // ADR-131 (#209): drain EVERY repo active this session, not just cwd's. The
-  // watch hook registers each edited repo under session_id; union it with the
-  // cwd marker so single-repo behavior is unchanged when no session_id is present.
-  const cwdMarker = await findMarkerUp(process.cwd());
-  const markers = collectSessionMarkers(cwdMarker, payload?.session_id);
-  if (markers.length === 0) process.exit(0);
-
-  const messages = markers.flatMap((m) => drainPending(m));
-  if (messages.length === 0) process.exit(0);
-
-  // UserPromptSubmit context-injection contract: additionalContext is added to
-  // the model's context for the upcoming turn.
-  const out = JSON.stringify({
-    hookSpecificOutput: {
-      hookEventName: "UserPromptSubmit",
-      additionalContext: joinPendingForSurface(messages),
-    },
-  });
-  process.stdout.write(`${out}\n`, () => process.exit(0));
+    const raw = await readStdin();
+    let payload;
+    try {
+        payload = JSON.parse(raw);
+    }
+    catch {
+        process.exit(0);
+    }
+    if (payload?.hook_event_name !== "UserPromptSubmit")
+        process.exit(0);
+    // Include registered sibling repositories, not only cwd.
+    const cwdMarker = await findMarkerUp(process.cwd());
+    const markers = collectSessionMarkers(cwdMarker, payload?.session_id);
+    if (markers.length === 0)
+        process.exit(0);
+    const messages = markers.flatMap((m) => drainPending(m));
+    if (messages.length === 0)
+        process.exit(0);
+    // additionalContext reaches the model on the next user turn.
+    const out = JSON.stringify({
+        hookSpecificOutput: {
+            hookEventName: "UserPromptSubmit",
+            additionalContext: joinPendingForSurface(messages),
+        },
+    });
+    process.stdout.write(`${out}\n`, () => process.exit(0));
 }
-
 main().catch(() => process.exit(0));