@ashx-j/lunr 0.2.21 → 0.2.23

package/dist/core/agent-session.js

@@ -34,8 +34,10 @@ import { expandPromptTemplate } from "./prompt-templates.js";
 import { rollbackSnapshotBeforeWrite } from "./rollback.js";
 import { CURRENT_SESSION_VERSION, getLatestCompactionEntry } from "./session-manager.js";
 import { createSyntheticSourceInfo } from "./source-info.js";
+import { registerSubagentWaitInterruptionOwner, } from "./subagent-wait-interruption.js";
 import { buildSystemPrompt } from "./system-prompt.js";
 import { measureStartup } from "./timings.js";
+import { TODO_TOOL_NAMES } from "./todo-settings.js";
 import { createLocalBashOperations } from "./tools/bash.js";
 import { createAllToolDefinitions } from "./tools/index.js";
 import { createToolDefinitionFromAgentTool } from "./tools/tool-definition-wrapper.js";
@@ -89,6 +91,11 @@ export class AgentSession {
     _isAgentRunActive = false;
     _idleWaitPromise;
     _resolveIdleWait;
+    _activePromptRun;
+    _waitPromptHandoff;
+    _waitPromptAcceptance = Promise.resolve();
+    _waitPromptGeneration = 0;
+    _unregisterSubagentWaitInterruptionOwners = [];
     /** Tracks pending steering messages for UI display. Removed when delivered. */
     _steeringMessages = [];
     /** Tracks pending follow-up messages for UI display. Removed when delivered. */
@@ -160,6 +167,10 @@ export class AgentSession {
         this._excludedToolNames = config.excludedToolNames ? new Set(config.excludedToolNames) : undefined;
         this._baseToolsOverride = config.baseToolsOverride;
         this._sessionStartEvent = config.sessionStartEvent ?? { type: "session_start", reason: "startup" };
+        const waitInterruptionOwner = { register: () => this._registerSubagentWaitInterruption() };
+        for (const identity of new Set([this.sessionId, this.sessionFile].filter((value) => !!value))) {
+            this._unregisterSubagentWaitInterruptionOwners.push(registerSubagentWaitInterruptionOwner(identity, waitInterruptionOwner));
+        }
         // Always subscribe to agent events for internal handling
         // (session persistence, extensions, auto-compaction, retry logic)
         this._unsubscribeAgent = this.agent.subscribe(this._handleAgentEvent);
@@ -640,7 +651,21 @@ export class AgentSession {
      * Remove all listeners and disconnect from agent.
      * Call this when completely done with the session.
      */
+    transferring = false;
+    setTransferring(value) {
+        this.transferring = value;
+        if (value)
+            this._invalidateWaitPromptHandoffs("Session transfer interrupted the pending prompt.");
+    }
+    assertCanStartWork() {
+        this.sessionManager.assertWritable();
+        if (this.transferring)
+            throw new Error("Session transfer is in progress. Wait or reclaim the session.");
+    }
     dispose() {
+        this._invalidateWaitPromptHandoffs("Session closed before the pending prompt could run.");
+        for (const unregister of this._unregisterSubagentWaitInterruptionOwners.splice(0))
+            unregister();
         try {
             this.abortRetry();
             this.abortCompaction();
@@ -655,6 +680,7 @@ export class AgentSession {
         this._disconnectFromAgent();
         this._eventListeners = [];
         cleanupSessionResources(this.sessionId);
+        this.sessionManager.dispose();
     }
     // =========================================================================
     // Read-only State Access
@@ -679,6 +705,10 @@ export class AgentSession {
     get isIdle() {
         return !this._isAgentRunActive;
     }
+    /** Whether normal Enter is still being reserved for an interrupted wait handoff. */
+    get isWaitPromptHandoffActive() {
+        return this._waitPromptHandoff?.accepting === true;
+    }
     /** Current effective system prompt (includes any per-turn extension modifications) */
     get systemPrompt() {
         return this.agent.state.systemPrompt;
@@ -874,24 +904,67 @@ export class AgentSession {
     // =========================================================================
     // Prompting
     // =========================================================================
+    _registerSubagentWaitInterruption() {
+        const run = this._activePromptRun;
+        const ownerSignal = this.agent.signal;
+        const wait = run && ownerSignal ? { controller: new AbortController(), interrupted: false, ownerSignal } : undefined;
+        if (run && wait) {
+            run.waits.add(wait);
+            if (run.gracefulStopRequested) {
+                wait.interrupted = true;
+                wait.controller.abort();
+            }
+        }
+        const signal = wait?.controller.signal ?? new AbortController().signal;
+        return {
+            signal,
+            wasInterrupted: () => wait?.interrupted === true,
+            unregister: () => {
+                if (wait)
+                    run?.waits.delete(wait);
+            },
+        };
+    }
+    _interruptSubagentWaits(run, ownerSignal) {
+        for (const wait of run.waits) {
+            if (wait.ownerSignal !== ownerSignal)
+                continue;
+            wait.interrupted = true;
+            wait.controller.abort();
+        }
+    }
+    _invalidateWaitPromptHandoffs(message) {
+        this._waitPromptGeneration++;
+        const handoff = this._waitPromptHandoff;
+        this._waitPromptHandoff = undefined;
+        if (!handoff)
+            return;
+        const error = new Error(message);
+        for (const reservation of handoff.reservations.splice(0))
+            reservation.reject(error);
+    }
     async _runAgentPrompt(messages) {
+        const run = { waits: new Set(), gracefulStopRequested: false };
+        this._activePromptRun = run;
         this._isAgentRunActive = true;
         try {
             await this.agent.prompt(messages);
-            while (await this._handlePostAgentRun()) {
+            while (await this._handlePostAgentRun(run)) {
                 await this.agent.continue();
             }
         }
         finally {
+            if (this._activePromptRun === run)
+                this._activePromptRun = undefined;
             this._systemPromptOverride = undefined;
             this._flushPendingBashMessages();
             await this._emitAgentSettled();
         }
     }
-    async _handlePostAgentRun() {
+    async _handlePostAgentRun(run) {
         const msg = this._lastAssistantMessage;
         this._lastAssistantMessage = undefined;
-        if (!msg) {
+        if (!msg || run.gracefulStopRequested) {
             return false;
         }
         // lunr: quota-dead or auth-invalid keys rotate immediately — same-key backoff
@@ -932,130 +1005,194 @@ export class AgentSession {
      * @throws Error if no model selected or no API key available (when not streaming)
      */
     async prompt(text, options) {
-        const expandPromptTemplates = options?.expandPromptTemplates ?? true;
+        this.assertCanStartWork();
         const preflightResult = options?.preflightResult;
+        let prepared;
         let messages;
         try {
-            // Handle extension commands first (execute immediately, even during streaming)
-            // Extension commands manage their own LLM interaction via pi.sendMessage()
-            if (expandPromptTemplates && text.startsWith("/")) {
-                const handled = await this._tryExecuteExtensionCommand(text);
-                if (handled) {
-                    // Extension command executed, no prompt to send
-                    preflightResult?.(true);
-                    return;
-                }
-            }
-            // Emit input event for extension interception (before skill/template expansion)
-            let currentText = text;
-            let currentImages = options?.images;
-            if (this._extensionRunner.hasHandlers("input")) {
-                const inputResult = await this._extensionRunner.emitInput(currentText, currentImages, options?.source ?? "interactive", this.isStreaming ? options?.streamingBehavior : undefined);
-                if (inputResult.action === "handled") {
-                    preflightResult?.(true);
-                    return;
-                }
-                if (inputResult.action === "transform") {
-                    currentText = inputResult.text;
-                    currentImages = inputResult.images ?? currentImages;
-                }
-            }
-            // Expand skill commands (/skill:name args) and prompt templates (/template args)
-            let expandedText = currentText;
-            if (expandPromptTemplates) {
-                expandedText = this._expandSkillCommand(expandedText);
-                expandedText = expandPromptTemplate(expandedText, [...this.promptTemplates]);
+            prepared = await this._preparePromptInput(text, options, this.isStreaming ? options?.streamingBehavior : undefined);
+            if (!prepared) {
+                preflightResult?.(true);
+                return;
             }
-            // If streaming, queue via steer() or followUp() based on option
             if (this.isStreaming) {
                 if (!options?.streamingBehavior) {
                     throw new Error("Agent is already processing. Specify streamingBehavior ('steer' or 'followUp') to queue the message.");
                 }
                 if (options.streamingBehavior === "followUp") {
-                    await this._queueFollowUp(expandedText, currentImages);
+                    await this._queueFollowUp(prepared.text, prepared.images);
                 }
                 else {
-                    await this._queueSteer(expandedText, currentImages);
+                    await this._queueSteer(prepared.text, prepared.images);
                 }
                 preflightResult?.(true);
                 return;
             }
-            // Flush any pending bash messages before the new prompt
-            this._flushPendingBashMessages();
-            // Validate model
-            if (!this.model) {
-                throw new Error(formatNoModelSelectedMessage());
-            }
-            const hasConfiguredAuth = this._modelRuntime.hasConfiguredAuth(this.model.provider) ||
-                (await this._modelRuntime.checkAuth(this.model.provider)) !== undefined;
-            if (!hasConfiguredAuth) {
-                const isOAuth = this._modelRuntime.isUsingOAuth(this.model.provider);
-                if (isOAuth) {
-                    throw new Error(`Authentication failed for "${this.model.provider}". ` +
-                        `Credentials may have expired or network is unavailable. ` +
-                        `Run '/login ${this.model.provider}' to re-authenticate.`);
-                }
-                throw new Error(formatNoApiKeyFoundMessage(this.model.provider));
-            }
-            // Check if we need to compact before sending (catches aborted responses).
-            // The user's new prompt is sent below, so do not call agent.continue() here.
-            const lastAssistant = this._findLastAssistantMessage();
-            if (lastAssistant) {
-                await this._checkCompaction(lastAssistant, false);
-            }
-            // Build messages array (custom message if any, then user message)
-            messages = [];
-            // Add user message
-            const userContent = [{ type: "text", text: expandedText }];
-            if (currentImages) {
-                userContent.push(...currentImages);
-            }
-            messages.push({
+            messages = await this._createPromptMessages(prepared);
+        }
+        catch (error) {
+            preflightResult?.(false);
+            throw error;
+        }
+        preflightResult?.(true);
+        await this._runAgentPrompt(messages);
+    }
+    async _preparePromptInput(text, options, streamingBehavior) {
+        const expandPromptTemplates = options?.expandPromptTemplates ?? true;
+        if (expandPromptTemplates && text.startsWith("/") && (await this._tryExecuteExtensionCommand(text))) {
+            return undefined;
+        }
+        let currentText = text;
+        let currentImages = options?.images;
+        if (this._extensionRunner.hasHandlers("input")) {
+            const inputResult = await this._extensionRunner.emitInput(currentText, currentImages, options?.source ?? "interactive", streamingBehavior);
+            if (inputResult.action === "handled")
+                return undefined;
+            if (inputResult.action === "transform") {
+                currentText = inputResult.text;
+                currentImages = inputResult.images ?? currentImages;
+            }
+        }
+        if (expandPromptTemplates) {
+            currentText = this._expandSkillCommand(currentText);
+            currentText = expandPromptTemplate(currentText, [...this.promptTemplates]);
+        }
+        return { text: currentText, images: currentImages };
+    }
+    async _createPromptMessages(input) {
+        this._flushPendingBashMessages();
+        if (!this.model)
+            throw new Error(formatNoModelSelectedMessage());
+        const hasConfiguredAuth = this._modelRuntime.hasConfiguredAuth(this.model.provider) ||
+            (await this._modelRuntime.checkAuth(this.model.provider)) !== undefined;
+        if (!hasConfiguredAuth) {
+            if (this._modelRuntime.isUsingOAuth(this.model.provider)) {
+                throw new Error(`Authentication failed for "${this.model.provider}". ` +
+                    `Credentials may have expired or network is unavailable. ` +
+                    `Run '/login ${this.model.provider}' to re-authenticate.`);
+            }
+            throw new Error(formatNoApiKeyFoundMessage(this.model.provider));
+        }
+        const lastAssistant = this._findLastAssistantMessage();
+        if (lastAssistant)
+            await this._checkCompaction(lastAssistant, false);
+        const userContent = [{ type: "text", text: input.text }];
+        if (input.images)
+            userContent.push(...input.images);
+        const messages = [
+            {
                 role: "user",
                 content: userContent,
                 timestamp: Date.now(),
-            });
-            // Inject any pending "nextTurn" messages as context alongside the user message
-            for (const msg of this._pendingNextTurnMessages) {
-                messages.push(msg);
-            }
-            this._pendingNextTurnMessages = [];
-            // Emit before_agent_start extension event
-            const result = await this._extensionRunner.emitBeforeAgentStart(expandedText, currentImages, this._baseSystemPrompt, this._baseSystemPromptOptions);
-            // Add all custom messages from extensions
-            if (result?.messages) {
-                for (const msg of result.messages) {
-                    messages.push({
-                        role: "custom",
-                        customType: msg.customType,
-                        // Untyped extensions can pass null/missing content; normalize at ingestion.
-                        content: msg.content ?? [],
-                        display: msg.display,
-                        details: msg.details,
-                        timestamp: Date.now(),
-                    });
-                }
-            }
-            // Apply extension-modified system prompt, or reset to base
-            if (result?.systemPrompt !== undefined) {
-                this._systemPromptOverride = result.systemPrompt;
-                this.agent.state.systemPrompt = this._withSystemPromptAppend(result.systemPrompt);
-            }
-            else {
-                // Ensure we're using the base prompt (in case previous turn had modifications)
-                this._systemPromptOverride = undefined;
-                this.agent.state.systemPrompt = this._withSystemPromptAppend(this._baseSystemPrompt);
+            },
+            ...this._pendingNextTurnMessages,
+        ];
+        this._pendingNextTurnMessages = [];
+        const result = await this._extensionRunner.emitBeforeAgentStart(input.text, input.images, this._baseSystemPrompt, this._baseSystemPromptOptions);
+        if (result?.messages) {
+            for (const msg of result.messages) {
+                messages.push({
+                    role: "custom",
+                    customType: msg.customType,
+                    content: msg.content ?? [],
+                    display: msg.display,
+                    details: msg.details,
+                    timestamp: Date.now(),
+                });
             }
         }
+        if (result?.systemPrompt !== undefined) {
+            this._systemPromptOverride = result.systemPrompt;
+            this.agent.state.systemPrompt = this._withSystemPromptAppend(result.systemPrompt);
+        }
+        else {
+            this._systemPromptOverride = undefined;
+            this.agent.state.systemPrompt = this._withSystemPromptAppend(this._baseSystemPrompt);
+        }
+        return messages;
+    }
+    async interruptSubagentWaitWithPrompt(text, options) {
+        const acceptance = this._waitPromptAcceptance.then(() => this._reserveWaitPrompt(text, options));
+        this._waitPromptAcceptance = acceptance.then(() => { }, () => { });
+        return acceptance;
+    }
+    async _reserveWaitPrompt(text, options) {
+        this.assertCanStartWork();
+        const activeRun = this._activePromptRun;
+        const existing = this._waitPromptHandoff;
+        const activeWait = activeRun?.waits.values().next().value;
+        const run = existing?.accepting ? existing.run : activeWait ? activeRun : undefined;
+        const ownerSignal = existing?.accepting ? existing.ownerSignal : activeWait?.ownerSignal;
+        if (!run || !ownerSignal)
+            return undefined;
+        const handoff = existing?.run === run && existing.accepting
+            ? existing
+            : {
+                run,
+                ownerSignal,
+                generation: this._waitPromptGeneration,
+                reservations: [],
+                draining: false,
+                accepting: true,
+            };
+        this._waitPromptHandoff = handoff;
+        let prepared;
+        try {
+            prepared = await this._preparePromptInput(text, options, undefined);
+        }
         catch (error) {
-            preflightResult?.(false);
+            if (handoff.reservations.length === 0 && this._waitPromptHandoff === handoff) {
+                this._waitPromptHandoff = undefined;
+            }
             throw error;
         }
-        if (!messages) {
-            return;
+        if (!prepared) {
+            if (handoff.reservations.length === 0 && this._waitPromptHandoff === handoff) {
+                this._waitPromptHandoff = undefined;
+            }
+            return { completion: Promise.resolve() };
         }
-        preflightResult?.(true);
-        await this._runAgentPrompt(messages);
+        let resolveCompletion = () => { };
+        let rejectCompletion = (_error) => { };
+        const completion = new Promise((resolve, reject) => {
+            resolveCompletion = resolve;
+            rejectCompletion = reject;
+        });
+        handoff.reservations.push({ input: prepared, resolve: resolveCompletion, reject: rejectCompletion });
+        if (!run.gracefulStopRequested && this.agent.requestGracefulStop(handoff.ownerSignal)) {
+            run.gracefulStopRequested = true;
+        }
+        this._interruptSubagentWaits(run, handoff.ownerSignal);
+        if (!handoff.draining) {
+            handoff.draining = true;
+            void this._drainWaitPromptHandoff(handoff);
+        }
+        return { completion };
+    }
+    async _drainWaitPromptHandoff(handoff) {
+        await this.waitForIdle();
+        while (this._waitPromptHandoff === handoff &&
+            handoff.generation === this._waitPromptGeneration &&
+            handoff.reservations.length > 0) {
+            const reservation = handoff.reservations[0];
+            try {
+                this.assertCanStartWork();
+                const messages = await this._createPromptMessages(reservation.input);
+                handoff.accepting = false;
+                await this._runAgentPrompt(messages);
+                reservation.resolve();
+            }
+            catch (error) {
+                reservation.reject(error);
+            }
+            finally {
+                if (handoff.reservations[0] === reservation)
+                    handoff.reservations.shift();
+            }
+        }
+        handoff.accepting = false;
+        if (this._waitPromptHandoff === handoff)
+            this._waitPromptHandoff = undefined;
     }
     /**
      * Try to execute an extension command. Returns true if command was found and executed.
@@ -1123,6 +1260,7 @@ export class AgentSession {
      * @throws Error if text is an extension command
      */
     async steer(text, images) {
+        this.assertCanStartWork();
         // Check for extension commands (cannot be queued)
         if (text.startsWith("/")) {
             this._throwIfExtensionCommand(text);
@@ -1140,6 +1278,7 @@ export class AgentSession {
      * @throws Error if text is an extension command
      */
     async followUp(text, images) {
+        this.assertCanStartWork();
         // Check for extension commands (cannot be queued)
         if (text.startsWith("/")) {
             this._throwIfExtensionCommand(text);
@@ -1205,6 +1344,7 @@ export class AgentSession {
      * @param options.deliverAs Delivery mode: "steer", "followUp", or "nextTurn"
      */
     async sendCustomMessage(message, options) {
+        this.assertCanStartWork();
         const appMessage = {
             role: "custom",
             customType: message.customType,
@@ -1305,6 +1445,7 @@ export class AgentSession {
      * Abort current operation and wait for agent to become idle.
      */
     async abort() {
+        this._invalidateWaitPromptHandoffs("The active run was aborted before the pending prompt could run.");
         this.abortRetry();
         this.agent.abort();
         await this.waitForIdle();
@@ -2177,7 +2318,7 @@ export class AgentSession {
                 }
                 void this.abort();
             },
-            hasPendingMessages: () => this.pendingMessageCount > 0,
+            hasPendingMessages: () => this.pendingMessageCount > 0 || this.agent.hasQueuedMessages(),
             shutdown: () => {
                 this._extensionShutdownHandler?.();
             },
@@ -2214,7 +2355,9 @@ export class AgentSession {
         const excludedToolNames = this._excludedToolNames;
         const isAllowedTool = (name) => (!allowedToolNames || allowedToolNames.has(name)) &&
             !excludedToolNames?.has(name) &&
-            (this.settingsManager.getMemoryEnabled() || !MEMORY_TOOL_NAMES.has(name));
+            (this.settingsManager.getMemoryEnabled() || !MEMORY_TOOL_NAMES.has(name)) &&
+            (this.settingsManager.getTodosEnabled() || !TODO_TOOL_NAMES.has(name)) &&
+            (name !== "browser" || this.settingsManager.getBrowserEnabled());
         const registeredTools = this._extensionRunner.getAllRegisteredTools();
         const allCustomTools = [
             ...registeredTools,
@@ -2322,6 +2465,7 @@ export class AgentSession {
         });
     }
     async reload(options) {
+        this._invalidateWaitPromptHandoffs("Extensions reloaded before the pending prompt could run.");
         const previousFlagValues = this._extensionRunner.getFlagValues();
         await emitSessionShutdownEvent(this._extensionRunner, { type: "session_shutdown", reason: "reload" });
         await this.settingsManager.reload();
@@ -2484,6 +2628,7 @@ export class AgentSession {
      * @param options.operations Custom BashOperations for remote execution
      */
     async executeBash(command, onChunk, options) {
+        this.assertCanStartWork();
         this._bashAbortController = new AbortController();
         // Apply command prefix if configured (e.g., "shopt -s expand_aliases" for alias support)
         const prefix = this.settingsManager.getShellCommandPrefix();