@ashray.mehta/statement-converter 1.7.0 → 1.7.1

package/adapters/ICICICreditCardAdapter.d.ts

@@ -3,7 +3,8 @@ import { Transaction } from '../models/Transaction';
 import { TransactionAdapter } from './TransactionAdapter';
 export declare class ICICICreditCardAdapter extends TransactionAdapter {
     convert(xlsxData: ArrayBuffer): Promise<Transaction[]>;
-    private findStartingRow;
+    private findFirstRow;
+    private findLastRow;
     private determineDebitOrCredit;
     supports(bank: Bank): boolean;
 }

package/adapters/ICICICreditCardAdapter.js

@@ -65,20 +65,14 @@ class ICICICreditCardAdapter extends TransactionAdapter_1.TransactionAdapter {
             const addressForCreditOrDebit = XLSXUtil_1.XLSXUtil.findTextIgnoringWhitespace(sheet, "BillingAmountSign");
             const range = XLSX.utils.decode_range(sheet['!ref']);
             const rangeEnd = range.e;
-            const lastRow = rangeEnd.r;
-            const startingRow = this.findStartingRow(sheet, range, addressForTransactionDate);
+            const lastRow = this.findLastRow(sheet, range, addressForTransactionDate);
+            const startingRow = this.findFirstRow(sheet, range, addressForTransactionDate);
             const rows = [...Array(1 + lastRow - startingRow).keys()].map(v => startingRow + v);
             return rows
                 .filter(row => {
                 // ICICI sometimes has account numbers in the Date field which serve as a separator between inflows and outflows.
                 // This filters those rows out.
-                const dateText = XLSXUtil_1.XLSXUtil.getCellValue(sheet, row, addressForTransactionDate.c);
-                if ((0, lodash_es_1.size)(dateText) === 16) {
-                    return false;
-                }
-                else {
-                    return true;
-                }
+                return (0, moment_1.default)(XLSXUtil_1.XLSXUtil.getCellValue(sheet, row, addressForTransactionDate.c), 'DD/MM/YYYY').isValid();
             })
                 .map(row => {
                 let isOutflow, amount;
@@ -105,7 +99,7 @@ class ICICICreditCardAdapter extends TransactionAdapter_1.TransactionAdapter {
             });
         });
     }
-    findStartingRow(sheet, range, addressForTransactionDate) {
+    findFirstRow(sheet, range, addressForTransactionDate) {
         var current = addressForTransactionDate.r; // Right after this is where the data should start, but sometimes there are blank rows after the header.
         for (var current = addressForTransactionDate.r + 1; current <= range.e.r; current++) {
             if (!(0, lodash_es_1.isEmpty)(XLSXUtil_1.XLSXUtil.getCellValue(sheet, current, addressForTransactionDate.c))) {
@@ -114,6 +108,15 @@ class ICICICreditCardAdapter extends TransactionAdapter_1.TransactionAdapter {
         }
         return addressForTransactionDate.r;
     }
+    findLastRow(sheet, range, addressForTransactionDate) {
+        for (var current = 0; current <= range.e.r; current++) {
+            const cellValue = XLSXUtil_1.XLSXUtil.getCellValue(sheet, current, addressForTransactionDate.c);
+            if (!!cellValue && cellValue.toString().includes("MESSAGE Details")) {
+                return current - 1;
+            }
+        }
+        return range.e.r;
+    }
     determineDebitOrCredit(sheet, row, column) {
         const cellValue = XLSXUtil_1.XLSXUtil.getCellValue(sheet, row, column);
         // TODO - Replace parsing with Globalize

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ashray.mehta/statement-converter",
-  "version": "1.7.0",
+  "version": "1.7.1",
   "description": "Library to convert statements from frequently used banks to QIF.",
   "main": "index.js",
   "types": "index.d.ts",
@@ -34,12 +34,12 @@
     "@types/lodash-es": "4.17.12",
     "@types/mocha": "10.0.10",
     "@types/moment": "2.13.0",
-    "@types/node": "25.5.2",
+    "@types/node": "25.6.0",
     "@types/yargs": "17.0.35",
     "chai": "6.2.2",
     "mocha": "11.7.5",
     "ts-node": "10.9.2",
     "tsx": "4.21.0",
-    "typescript": "6.0.2"
+    "typescript": "6.0.3"
   }
 }