@ashley-shrok/viewmodel-shell 0.4.3 → 0.4.4

package/README.md

@@ -56,7 +56,13 @@ const shell = new ViewModelShell({
 shell.load();
 ```
 
-The TUI is built on [Ink](https://github.com/vadimdemedes/ink), declared as an **optional** dependency: CLI/`npx` use installs it automatically, while web and server consumers are unaffected — it is never imported by the browser, server, or core entrypoints. See [AGENTS.md](https://github.com/ashley-shrok/ViewModelShell/blob/main/AGENTS.md) for what the terminal renders.
+The TUI is built on [Ink](https://github.com/vadimdemedes/ink) and friends, declared as **optional** dependencies (`ink`, `react`, `ink-text-input`, `ink-select-input`) so web and server consumers are unaffected — they are never imported by the browser, server, or core entrypoints. `npx vms-tui` installs them automatically. **Project consumers using `TuiAdapter` programmatically must add all four explicitly** — optional dependencies are *not* pulled transitively when another project depends on this package (notably with `bun install`):
+
+```bash
+npm i @ashley-shrok/viewmodel-shell ink react ink-text-input ink-select-input
+```
+
+See [AGENTS.md](https://github.com/ashley-shrok/ViewModelShell/blob/main/AGENTS.md) for what the terminal renders.
 
 ## Themes
 

package/dist/tui-cli.js

@@ -40,8 +40,9 @@ async function main() {
         ({ TuiAdapter, openExternal, classify } = await import("./tui.js"));
     }
     catch (err) {
-        process.stderr.write("vms-tui requires the optional 'ink' and 'react' packages.\n" +
-            "Install them:  npm i ink react\n" +
+        process.stderr.write("vms-tui requires its optional peer packages: 'ink', 'react', " +
+            "'ink-text-input', 'ink-select-input'.\n" +
+            "Install them:  npm i ink react ink-text-input ink-select-input\n" +
             `(load error: ${err.message})\n`);
         process.exitCode = 1;
         return;
@@ -119,6 +120,14 @@ async function main() {
     // onRedirect, so redirects chain.
     let redirectFailed = false;
     let currentShell;
+    // Non-interactive iff EITHER stream is not a TTY. Checking stdin too (not
+    // just stdout) is load-bearing: with the tui.tsx isActive fix the App's
+    // useInput is correctly inert on non-TTY stdin, so nothing holds the event
+    // loop — if stdout were a TTY but stdin a pipe (`vms-tui url </dev/null`
+    // from an interactive shell), a stdout-only guard would fall through to the
+    // keep-alive + waitUntilExit() and HANG forever (no input can ever arrive).
+    // One static frame + exit is the only correct behavior when stdin is dead.
+    const nonInteractive = !process.stdout.isTTY || !process.stdin.isTTY;
     const handleRedirect = (url, fromEndpoint) => {
         const c = classify(url, fromEndpoint);
         if (c.kind === "same-origin") {
@@ -127,9 +136,9 @@ async function main() {
             void currentShell.load(); // failures flow through the shared onError
             return;
         }
-        if (!process.stdout.isTTY) {
-            // Non-TTY: never spawn a browser; loud stderr + nonzero exit via the
-            // SINGLE shutdown funnel (redirectFailed is read at the exit site).
+        if (nonInteractive) {
+            // Non-interactive: never spawn a browser; loud stderr + nonzero exit via
+            // the SINGLE shutdown funnel (redirectFailed is read at the exit site).
             process.stderr.write(`vms-tui: cannot follow redirect (${c.kind}): ${url}\n`);
             redirectFailed = true;
             return;
@@ -167,9 +176,9 @@ async function main() {
         loadFailed = true;
         process.stderr.write(`vms-tui: ${err.message}\n`);
     }
-    if (!process.stdout.isTTY) {
-        // Non-TTY (piped / CI): nothing to interact with — emit one static frame
-        // and exit instead of hanging on a Ctrl-C that can never come. The delay
+    if (nonInteractive) {
+        // Non-interactive (piped / CI / dead stdin): nothing to interact with —
+        // emit one static frame and exit instead of hanging forever. The delay
         // lets Ink flush its throttled render. (Redirects can't fire here: load()
         // ignores response.redirect and non-TTY performs no dispatch — so
         // redirectFailed stays false unless a future code path dispatches.)

package/dist/tui.js

@@ -616,7 +616,16 @@ function App(props) {
     const { vm, renderWith } = props;
     const { isRawModeSupported } = useStdin();
     const { write } = useStdout();
-    const interactive = isRawModeSupported;
+    // `=== true` is LOAD-BEARING, not defensive. Ink's App.isRawModeSupported()
+    // returns `this.props.stdin.isTTY`, which is `true` on a TTY but `undefined`
+    // (never `false`) on a non-TTY stdin (pipe / </dev/null / agent / CI). Ink's
+    // useInput skips raw mode ONLY when `options.isActive === false` (strict).
+    // So passing the raw `undefined` as isActive does NOT skip → Ink calls
+    // setRawMode → throws "Raw mode is not supported" and dumps a react error
+    // frame on the non-TTY path. Coercing to a real boolean makes the gate
+    // `{ isActive: false }`, which Ink honors → clean static render. (A TTY
+    // gives `true`; ink-testing-library gives `true` → tests unchanged.)
+    const interactive = isRawModeSupported === true;
     const [focusedKey, setFocusedKey] = useState(null);
     const [copiedKey, setCopiedKey] = useState(null);
     // User-typed field drafts, keyed by focus key. Mirrors BrowserAdapter's

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ashley-shrok/viewmodel-shell",
-  "version": "0.4.3",
+  "version": "0.4.4",
   "description": "A server-driven UI framework where the wire format is structured enough that agents can build full-stack apps without ever opening a browser and all UI tests are pure unit tests with no browser runtime. Server returns a JSON tree of typed nodes; a thin TypeScript adapter renders it to DOM. Backend-agnostic — a .NET reference backend ships with the repo, but any language can produce the JSON contract.",
   "type": "module",
   "license": "MIT",