@aryacode/dsh-engineering 0.9.1 → 0.9.2

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [0.9.2] - 2026-10-27
+
+### Fixed
+
+- **The `engineering-standards` skill was missing from the catalog.** 0.9.1 mounted it by calling the skills
+  service from inside the resources row's `apply()`, which only works if that service already exists at that
+  row's turn — it mounts before the Optix row, so the skill was silently skipped (the tools still loaded).
+  The skill is now its own plugin with `inject: ['skills']`, the same pattern the product skills use, so the
+  host activates it when the service is up regardless of row order. A test asserts the injection list and
+  registration.
 ## [0.9.1] - 2026-10-27
 
 ### Fixed

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aryacode/dsh-engineering",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "description": "AryaCode engineering bundle: one install surface for the Studio 5000 L5X, FactoryTalk View ME, MotionWorks IEC and FactoryTalk Optix surfaces, one row per product, with the ladder and display previews.",
   "keywords": [
     "dsh",

package/vendor/resources/lib/index.d.ts

@@ -5,24 +5,18 @@
  *
  * The corpus is generated data (`index.json`, `SOURCE.json`) over authored
  * Markdown; the profile is produced by whichever product package has a project
- * open. This entry only wires them to the tool registry and, when the host offers
- * it, to the skills service.
+ * open. This entry wires them to the tool registry and mounts the skill as a
+ * sub-plugin that waits for the skills service, so row order cannot drop it.
  *
  * @module dsh-engineering-resources
  */
 import type { StyleProfile } from './profile.ts';
 /** Plugin name in a composition. */
 export declare const name = "engineering-resources";
-/** The tools need the registry; the skill is registered when the host offers it. */
+/** The tools need the registry; the skill is a sub-plugin with its own injection. */
 export declare const inject: string[];
 /** The service name a generation tool can inject to read a profile by handle. */
 export declare const PROFILES_SERVICE = "engineeringProfiles";
-/** The skill metadata, kept here so a test can assert it without the file. */
-export declare const SKILL: {
-    name: string;
-    description: string;
-    whenToUse: string;
-};
 /** Configuration for the row. */
 export interface Config {
     /** Whether the reference and profile tools are registered. Defaults to true. */
@@ -33,23 +27,27 @@ export interface ProfilesService {
     /** The profile for one handle, when it is still in memory. */
     get(id: string): StyleProfile | undefined;
 }
-/**
- * Register the resource tools and the standards skill.
- *
- * @param ctx - Plugin context with the tool registry and optional services.
- * @param config - Row configuration.
- */
-export declare function apply(ctx: {
+/** The plugin context shape this row needs. */
+interface RowContext {
     tools: {
         register(definition: unknown): void;
     };
     get?: (name: string) => unknown;
     provide?: (name: string, value: unknown) => void;
+    plugin?: (plugin: unknown) => void;
     logger?: {
         warn?(message: string): void;
     };
-}, config?: Config): void;
+}
+/**
+ * Register the resource tools and mount the standards skill.
+ *
+ * @param ctx - Plugin context with the tool registry and optional services.
+ * @param config - Row configuration.
+ */
+export declare function apply(ctx: RowContext, config?: Config): void;
 export { getProfile } from './store.ts';
 export { validateProfile, profileId } from './profile.ts';
 export type { StyleProfile } from './profile.ts';
 export { resourceTools, referenceTool, profileTool } from './tools.ts';
+export { SKILL } from './skill.ts';

package/vendor/resources/lib/index.js

@@ -5,39 +5,22 @@
  *
  * The corpus is generated data (`index.json`, `SOURCE.json`) over authored
  * Markdown; the profile is produced by whichever product package has a project
- * open. This entry only wires them to the tool registry and, when the host offers
- * it, to the skills service.
+ * open. This entry wires them to the tool registry and mounts the skill as a
+ * sub-plugin that waits for the skills service, so row order cannot drop it.
  *
  * @module dsh-engineering-resources
  */
-import { existsSync, readFileSync } from 'node:fs';
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
 import { resourceTools } from "./tools.js";
 import { getProfile } from "./store.js";
+import * as skill from "./skill.js";
 /** Plugin name in a composition. */
 export const name = 'engineering-resources';
-/** The tools need the registry; the skill is registered when the host offers it. */
+/** The tools need the registry; the skill is a sub-plugin with its own injection. */
 export const inject = ['tools'];
 /** The service name a generation tool can inject to read a profile by handle. */
 export const PROFILES_SERVICE = 'engineeringProfiles';
-/** The skill metadata, kept here so a test can assert it without the file. */
-export const SKILL = {
-    name: 'engineering-standards',
-    description: 'Engineering standards and house style for control code and HMI: read the local corpus for IEC 61131-3, Rockwell, Yaskawa, FactoryTalk and craft rules, profile the open project to follow its own conventions, and cite rule IDs in findings.',
-    whenToUse: 'Before writing or reviewing PLC code, ladder, Structured Text, FactoryTalk View or Optix screens — especially when matching an existing project’s style, or when starting new work that should meet a professional standard.',
-};
-const HERE = dirname(fileURLToPath(import.meta.url));
-/** The skill file, in the built package or the source tree. */
-function skillPath() {
-    for (const candidate of [join(HERE, '..', 'SKILL.md'), join(HERE, '..', '..', 'SKILL.md')]) {
-        if (existsSync(candidate))
-            return candidate;
-    }
-    return undefined;
-}
 /**
- * Register the resource tools and the standards skill.
+ * Register the resource tools and mount the standards skill.
  *
  * @param ctx - Plugin context with the tool registry and optional services.
  * @param config - Row configuration.
@@ -53,26 +36,16 @@ export function apply(ctx, config = {}) {
                 ctx.tools.register(definition);
         }
         ctx.provide?.(PROFILES_SERVICE, { get: getProfile });
-        const path = skillPath();
-        const skills = getService('skills');
-        if (path === undefined || skills?.register === undefined) {
-            try {
-                ctx.logger?.warn?.('engineering-resources: the engineering-standards skill was not registered; the tools are available.');
-            }
-            catch {
-                // A logger that refuses must not turn a missing skill into a crash.
-            }
-            return;
+        // Mount the skill as its own plugin: it declares `inject: ['skills']`, so the
+        // host activates it when that service exists rather than at this row's turn.
+        if (typeof ctx.plugin === 'function') {
+            ctx.plugin(skill);
+        }
+        else {
+            const skills = getService('skills');
+            if (skills !== undefined)
+                skill.registerSkill(skills);
         }
-        const content = readFileSync(path, 'utf8').replace(/^---\r?\n[\s\S]*?\r?\n---\r?\n/u, '');
-        skills.register({
-            ...SKILL,
-            content,
-            path,
-            source: 'custom',
-            provider: '@aryacode/dsh-engineering',
-            invocation: { modelInvocable: true, userInvocable: true },
-        });
     }
     catch (error) {
         try {
@@ -86,3 +59,4 @@ export function apply(ctx, config = {}) {
 export { getProfile } from "./store.js";
 export { validateProfile, profileId } from "./profile.js";
 export { resourceTools, referenceTool, profileTool } from "./tools.js";
+export { SKILL } from "./skill.js";

package/vendor/resources/lib/skill.d.ts

@@ -0,0 +1,46 @@
+/**
+ * The engineering-standards skill, mounted as its own plugin.
+ *
+ * The first version registered the skill inside the resources row's `apply`,
+ * which meant it ran only if the skills service already existed at that moment.
+ * The resources row mounts before the Optix row, and the skill silently
+ * disappeared from the catalog when the service was not up yet. Declaring
+ * `inject: ['skills']` lets the host activate this plugin when the service
+ * exists, exactly like the product skill plugins.
+ *
+ * @module dsh-engineering-resources/skill
+ */
+/** Plugin name in a composition. */
+export declare const name = "engineering-resources-skill";
+/** The host must offer the skills service before this plugin activates. */
+export declare const inject: string[];
+/** The skill metadata. */
+export declare const SKILL: {
+    name: string;
+    description: string;
+    whenToUse: string;
+};
+/** The skill file, in the built package or the source tree. */
+export declare function skillPath(): string | undefined;
+/** The skill body, with any front matter removed. */
+export declare function skillContent(path: string): string;
+/**
+ * Register the skill in one skills service.
+ *
+ * @param service - The host's skills service.
+ * @returns True when it was registered; false when the file is missing.
+ */
+export declare function registerSkill(service: {
+    register?(definition: unknown): void;
+}): boolean;
+/**
+ * Activate the skill plugin.
+ *
+ * @param ctx - Plugin context, with the skills service present by injection.
+ */
+export declare function apply(ctx: {
+    get?: (name: string) => unknown;
+    logger?: {
+        warn?(message: string): void;
+    };
+}): void;

package/vendor/resources/lib/skill.js

@@ -0,0 +1,74 @@
+/**
+ * The engineering-standards skill, mounted as its own plugin.
+ *
+ * The first version registered the skill inside the resources row's `apply`,
+ * which meant it ran only if the skills service already existed at that moment.
+ * The resources row mounts before the Optix row, and the skill silently
+ * disappeared from the catalog when the service was not up yet. Declaring
+ * `inject: ['skills']` lets the host activate this plugin when the service
+ * exists, exactly like the product skill plugins.
+ *
+ * @module dsh-engineering-resources/skill
+ */
+import { existsSync, readFileSync } from 'node:fs';
+import { dirname, join } from 'node:path';
+import { fileURLToPath } from 'node:url';
+/** Plugin name in a composition. */
+export const name = 'engineering-resources-skill';
+/** The host must offer the skills service before this plugin activates. */
+export const inject = ['skills'];
+/** The skill metadata. */
+export const SKILL = {
+    name: 'engineering-standards',
+    description: 'Engineering standards and house style for control code and HMI: read the local corpus for IEC 61131-3, Rockwell, Yaskawa, FactoryTalk and craft rules, profile the open project to follow its own conventions, and cite rule IDs in findings.',
+    whenToUse: 'Before writing or reviewing PLC code, ladder, Structured Text, FactoryTalk View or Optix screens — especially when matching an existing project’s style, or when starting new work that should meet a professional standard.',
+};
+const HERE = dirname(fileURLToPath(import.meta.url));
+/** The skill file, in the built package or the source tree. */
+export function skillPath() {
+    for (const candidate of [join(HERE, '..', 'SKILL.md'), join(HERE, '..', '..', 'SKILL.md')]) {
+        if (existsSync(candidate))
+            return candidate;
+    }
+    return undefined;
+}
+/** The skill body, with any front matter removed. */
+export function skillContent(path) {
+    return readFileSync(path, 'utf8').replace(/^---\r?\n[\s\S]*?\r?\n---\r?\n/u, '');
+}
+/**
+ * Register the skill in one skills service.
+ *
+ * @param service - The host's skills service.
+ * @returns True when it was registered; false when the file is missing.
+ */
+export function registerSkill(service) {
+    const path = skillPath();
+    if (path === undefined || service.register === undefined)
+        return false;
+    service.register({
+        ...SKILL,
+        content: skillContent(path),
+        path,
+        source: 'custom',
+        provider: '@aryacode/dsh-engineering',
+        invocation: { modelInvocable: true, userInvocable: true },
+    });
+    return true;
+}
+/**
+ * Activate the skill plugin.
+ *
+ * @param ctx - Plugin context, with the skills service present by injection.
+ */
+export function apply(ctx) {
+    const skills = typeof ctx.get === 'function' ? ctx.get('skills') : undefined;
+    if (skills === undefined || !registerSkill(skills)) {
+        try {
+            ctx.logger?.warn?.('engineering-resources: the engineering-standards skill could not be registered; the tools are available.');
+        }
+        catch {
+            // Nothing left to report to.
+        }
+    }
+}