@aryacode/dsh-engineering 0.4.4 → 0.4.6

package/vendor/l5x/lib/engine/cip-transaction.d.ts

@@ -0,0 +1,115 @@
+/**
+ * One-shot EtherNet/IP transactions: batch reads, identity/clock, writes and
+ * discovery, each in its own worker so a hung socket cannot hold the host.
+ *
+ * Reads are the normal case. Writes are only ever reached through a tool that
+ * has already asked a human for this exact operation, and every write result is
+ * the readback the controller returned, never an assumption that it worked.
+ *
+ * @module dsh-engineering-l5x/engine/cip-transaction
+ */
+/** One observed value from a batch read. */
+export interface CipValue {
+    tag: string;
+    data_type: string;
+    actual_data_type?: string;
+    value: boolean | number | null;
+    quality: 'good' | 'bad';
+    observed_at: string;
+    error?: string;
+}
+/** Controller identity as CIP reports it. */
+export interface CipIdentity {
+    product_name: string;
+    serial_number: number;
+    revision: string;
+    status: number;
+}
+/** Result of the batch read. */
+export interface CipReadResult {
+    controller: CipIdentity;
+    request_count: number;
+    observed_at: string;
+    values: CipValue[];
+}
+/** Result of the clock read. */
+export interface CipClockResult {
+    controller: CipIdentity;
+    supported: boolean;
+    controller_time?: string;
+    host_time: string;
+    reason?: string;
+}
+/** Result of one tag write. */
+export interface CipWriteResult {
+    tag: string;
+    declared_data_type: string;
+    actual_data_type?: string;
+    previous_value: boolean | number | null;
+    requested_value: boolean | number;
+    readback: boolean | number | null;
+    verified: boolean;
+    written_at: string;
+}
+/** Result of a wall-clock write. */
+export interface CipWriteClockResult {
+    requested_time: string;
+    readback: string;
+    verified: boolean;
+}
+/** One discovered device. */
+export interface CipDevice {
+    ip_address: string;
+    product_name: string;
+    revision: string;
+    serial_number: string;
+    vendor_id: number;
+    device_type: number;
+    status: number;
+}
+/** Result of discovery. */
+export interface CipDiscoverResult {
+    seconds: number;
+    devices: CipDevice[];
+}
+/** Validate a batch-read result. */
+export declare function decodeReadResult(value: unknown): CipReadResult;
+/** Validate a clock result. */
+export declare function decodeClockResult(value: unknown): CipClockResult;
+/** Validate a write result. */
+export declare function decodeWriteResult(value: unknown): CipWriteResult;
+/** Validate a wall-clock write result. */
+export declare function decodeWriteClockResult(value: unknown): CipWriteClockResult;
+/** Validate a discovery result. */
+export declare function decodeDiscoverResult(value: unknown): CipDiscoverResult;
+/** Bounds shared with the polling engine. */
+export interface TransactionLimits {
+    /** Per-request driver timeout, in milliseconds. */
+    timeout: number;
+    /** Most simultaneous transactions. */
+    maxConcurrent: number;
+}
+/**
+ * Run one worker transaction and enforce its deadline.
+ *
+ * The worker emits exactly one message: `{ ok: true, value }` or
+ * `{ ok: false, message }`. Anything else, or a worker that outlives the
+ * deadline, fails the call rather than returning a partial answer.
+ */
+export declare class CipTransactions {
+    private readonly workerPath;
+    private readonly limits;
+    private active;
+    private disposed;
+    constructor(workerPath: string, limits: TransactionLimits);
+    /**
+     * Run one operation.
+     * @param spec - Worker request, already validated by the caller.
+     * @param signal - Optional lifetime, aborted by the calling turn.
+     * @param extraMs - Deadline beyond the driver timeout (discovery needs its window).
+     * @returns The raw `value` of the worker's reply.
+     */
+    run(spec: Readonly<Record<string, unknown>>, signal?: AbortSignal, extraMs?: number): Promise<unknown>;
+    /** Refuse new work and let running transactions finish. */
+    dispose(): Promise<void>;
+}

package/vendor/l5x/lib/engine/cip-transaction.js

@@ -0,0 +1,185 @@
+/**
+ * One-shot EtherNet/IP transactions: batch reads, identity/clock, writes and
+ * discovery, each in its own worker so a hung socket cannot hold the host.
+ *
+ * Reads are the normal case. Writes are only ever reached through a tool that
+ * has already asked a human for this exact operation, and every write result is
+ * the readback the controller returned, never an assumption that it worked.
+ *
+ * @module dsh-engineering-l5x/engine/cip-transaction
+ */
+import { Worker } from 'node:worker_threads';
+import { EngineeringError } from "../session.js";
+const isRecord = (value) => typeof value === 'object' && value !== null && !Array.isArray(value);
+const isText = (value) => typeof value === 'string';
+const isInteger = (value) => typeof value === 'number' && Number.isInteger(value);
+const isFiniteNumber = (value) => typeof value === 'number' && Number.isFinite(value);
+const isScalar = (value) => typeof value === 'boolean' || isFiniteNumber(value);
+/** Narrow one identity record. */
+function identityOf(value) {
+    if (!isRecord(value) || !isText(value.product_name) || !isInteger(value.serial_number)
+        || !isText(value.revision) || !isFiniteNumber(value.status))
+        throw new Error('Invalid controller identity in CIP result');
+    return { product_name: value.product_name, serial_number: value.serial_number, revision: value.revision, status: value.status };
+}
+/** Narrow one observed value. */
+function valueOf(value) {
+    if (!isRecord(value) || !isText(value.tag) || !isText(value.data_type) || !isText(value.observed_at)
+        || !(value.value === null || isScalar(value.value)) || (value.quality !== 'good' && value.quality !== 'bad'))
+        throw new Error('Invalid CIP read value');
+    return {
+        tag: value.tag,
+        data_type: value.data_type,
+        ...(isText(value.actual_data_type) ? { actual_data_type: value.actual_data_type } : {}),
+        value: value.value,
+        quality: value.quality,
+        observed_at: value.observed_at,
+        ...(isText(value.error) ? { error: value.error.slice(0, 1000) } : {}),
+    };
+}
+/** Validate a batch-read result. */
+export function decodeReadResult(value) {
+    if (!isRecord(value) || !isInteger(value.request_count) || !isText(value.observed_at)
+        || !Array.isArray(value.values) || value.values.length > 256)
+        throw new Error('Invalid CIP read result');
+    return {
+        controller: identityOf(value.controller),
+        request_count: value.request_count,
+        observed_at: value.observed_at,
+        values: value.values.map(valueOf),
+    };
+}
+/** Validate a clock result. */
+export function decodeClockResult(value) {
+    if (!isRecord(value) || typeof value.supported !== 'boolean' || !isText(value.host_time))
+        throw new Error('Invalid CIP clock result');
+    return {
+        controller: identityOf(value.controller),
+        supported: value.supported,
+        host_time: value.host_time,
+        ...(isText(value.controller_time) ? { controller_time: value.controller_time } : {}),
+        ...(isText(value.reason) ? { reason: value.reason.slice(0, 500) } : {}),
+    };
+}
+/** Validate a write result. */
+export function decodeWriteResult(value) {
+    if (!isRecord(value) || !isText(value.tag) || !isText(value.declared_data_type) || !isText(value.written_at)
+        || !(value.previous_value === null || isScalar(value.previous_value))
+        || !isScalar(value.requested_value) || !(value.readback === null || isScalar(value.readback))
+        || typeof value.verified !== 'boolean')
+        throw new Error('Invalid CIP write result');
+    return {
+        tag: value.tag,
+        declared_data_type: value.declared_data_type,
+        ...(isText(value.actual_data_type) ? { actual_data_type: value.actual_data_type } : {}),
+        previous_value: value.previous_value,
+        requested_value: value.requested_value,
+        readback: value.readback,
+        verified: value.verified,
+        written_at: value.written_at,
+    };
+}
+/** Validate a wall-clock write result. */
+export function decodeWriteClockResult(value) {
+    if (!isRecord(value) || !isText(value.requested_time) || !isText(value.readback) || typeof value.verified !== 'boolean')
+        throw new Error('Invalid CIP clock write result');
+    return { requested_time: value.requested_time, readback: value.readback, verified: value.verified };
+}
+/** Validate a discovery result. */
+export function decodeDiscoverResult(value) {
+    if (!isRecord(value) || !isFiniteNumber(value.seconds) || !Array.isArray(value.devices) || value.devices.length > 512)
+        throw new Error('Invalid CIP discovery result');
+    return {
+        seconds: value.seconds,
+        devices: value.devices.map((device) => {
+            if (!isRecord(device) || !isText(device.ip_address) || !isText(device.product_name) || !isText(device.revision)
+                || !isText(device.serial_number) || !isFiniteNumber(device.vendor_id) || !isFiniteNumber(device.device_type)
+                || !isFiniteNumber(device.status))
+                throw new Error('Invalid discovered device');
+            return {
+                ip_address: device.ip_address,
+                product_name: device.product_name,
+                revision: device.revision,
+                serial_number: device.serial_number,
+                vendor_id: device.vendor_id,
+                device_type: device.device_type,
+                status: device.status,
+            };
+        }),
+    };
+}
+/**
+ * Run one worker transaction and enforce its deadline.
+ *
+ * The worker emits exactly one message: `{ ok: true, value }` or
+ * `{ ok: false, message }`. Anything else, or a worker that outlives the
+ * deadline, fails the call rather than returning a partial answer.
+ */
+export class CipTransactions {
+    workerPath;
+    limits;
+    active = 0;
+    disposed = false;
+    constructor(workerPath, limits) {
+        this.workerPath = workerPath;
+        this.limits = limits;
+    }
+    /**
+     * Run one operation.
+     * @param spec - Worker request, already validated by the caller.
+     * @param signal - Optional lifetime, aborted by the calling turn.
+     * @param extraMs - Deadline beyond the driver timeout (discovery needs its window).
+     * @returns The raw `value` of the worker's reply.
+     */
+    async run(spec, signal, extraMs = 0) {
+        if (this.disposed)
+            throw new EngineeringError('CONTROLLER_BUSY', 'The controller bridge is shutting down');
+        if (this.active >= this.limits.maxConcurrent)
+            throw new EngineeringError('CONTROLLER_BUSY', 'Controller transaction capacity is occupied');
+        signal?.throwIfAborted();
+        this.active += 1;
+        const worker = new Worker(this.workerPath, { workerData: spec, env: {}, stdout: true, stderr: true });
+        worker.stdout.resume();
+        worker.stderr.resume();
+        const deadline = this.limits.timeout + extraMs;
+        const timer = setTimeout(() => { void worker.terminate(); }, deadline);
+        const onAbort = () => { void worker.terminate(); };
+        signal?.addEventListener('abort', onAbort, { once: true });
+        try {
+            return await new Promise((resolve, reject) => {
+                let settled = false;
+                const settle = (fn) => { if (!settled) {
+                    settled = true;
+                    fn();
+                } };
+                worker.on('message', (message) => {
+                    if (!isRecord(message))
+                        return settle(() => reject(new Error('Malformed controller reply')));
+                    if (message.ok === true)
+                        return settle(() => resolve(message.value));
+                    settle(() => reject(new Error(isText(message.message) ? message.message : 'Controller transaction failed')));
+                });
+                worker.once('error', error => settle(() => reject(error)));
+                worker.once('exit', code => {
+                    settle(() => reject(new Error(`Controller transaction ended without a reply (exit ${String(code)})`)));
+                });
+            });
+        }
+        catch (error) {
+            if (signal?.aborted)
+                throw new EngineeringError('CONTROLLER_CANCELLED', 'The controller transaction was cancelled');
+            throw error instanceof EngineeringError ? error : new EngineeringError('CONTROLLER_UNREACHABLE', error instanceof Error ? error.message : 'Controller transaction failed', 'Check the controller address and slot, that the port is reachable, and retry.');
+        }
+        finally {
+            clearTimeout(timer);
+            signal?.removeEventListener('abort', onAbort);
+            this.active -= 1;
+            void worker.terminate();
+        }
+    }
+    /** Refuse new work and let running transactions finish. */
+    async dispose() {
+        this.disposed = true;
+        this.active = 0;
+    }
+}

package/vendor/l5x/lib/live.d.ts

@@ -32,6 +32,10 @@ export interface Config {
     maxConcurrent?: number;
     /** Optional IPv4 allowlist; empty permits any explicit address. */
     allowedAddresses?: string[];
+    /** Permit one-shot writes (tag and wall clock). Each write still needs human approval. Defaults to false. */
+    allowWrites?: boolean;
+    /** Largest accepted batch read. Defaults to 64. */
+    maxBatchTags?: number;
     /** Chart redraw interval, independent of reads. Defaults to 250 ms. */
     displayRefreshMs?: number;
     /** Most points retained per chart. Defaults to 1200. */
@@ -45,4 +49,5 @@ export interface Config {
  */
 export declare function apply(ctx: PluginContext, config?: Config): void;
 export { DirectPolling } from './engine/direct-polling.ts';
+export { CipTransactions } from './engine/cip-transaction.ts';
 export { liveTools } from './tools/live.ts';

package/vendor/l5x/lib/live.js

@@ -9,6 +9,7 @@
  */
 import { fileURLToPath } from 'node:url';
 import { DirectPolling } from "./engine/direct-polling.js";
+import { CipTransactions } from "./engine/cip-transaction.js";
 import { liveTools } from "./tools/live.js";
 import { PROJECTS_SERVICE } from "./index.js";
 /** Plugin name in a composition. */
@@ -39,10 +40,20 @@ export function apply(ctx, config = {}) {
         displayRefreshMs: config.displayRefreshMs ?? 250,
         displayMaxSamples: config.displayMaxSamples ?? 1200,
     });
+    const transactions = new CipTransactions(fileURLToPath(new URL('../cip-worker.mjs', import.meta.url)), {
+        timeout: config.requestTimeoutMs ?? 3000,
+        maxConcurrent: config.maxConcurrent ?? 2,
+    });
     const effect = ctx.effect;
-    effect?.(() => () => { void polling.dispose(); });
-    for (const definition of liveTools(session, polling, ctx))
+    effect?.(() => () => { void polling.dispose(); void transactions.dispose(); });
+    const extensions = {
+        transactions,
+        allowWrites: config.allowWrites === true,
+        maxBatchTags: config.maxBatchTags ?? 64,
+    };
+    for (const definition of liveTools(session, polling, ctx, extensions))
         ctx.tools.register(definition);
 }
 export { DirectPolling } from "./engine/direct-polling.js";
+export { CipTransactions } from "./engine/cip-transaction.js";
 export { liveTools } from "./tools/live.js";

package/vendor/l5x/lib/tools/live.d.ts

@@ -1,21 +1,32 @@
 /**
- * SDK-free live reads over EtherNet/IP.
+ * SDK-free EtherNet/IP surface: reads, identity, discovery and the two
+ * approval-gated writes.
  *
- * Two tools: a bounded foreground poll, and a session-owned trend job the chart
- * can follow without a model call per sample. Both read declared scalar tags,
- * never write, and state that live logic is not the exported logic.
+ * Reads never change the controller and need no approval. Writes do: a write is
+ * refused unless the row's config allows writes AND a human approves that exact
+ * operation, and its result is the value read back over CIP, not an assumption.
  *
  * @module dsh-engineering-l5x/tools/live
  */
 import type { PluginContext, ToolDefinition } from '../core/tool.ts';
 import type { ProjectSession } from '../session.ts';
 import { type DirectPolling } from '../engine/direct-polling.ts';
+import { type CipTransactions } from '../engine/cip-transaction.ts';
+/** Extra capabilities the live entry mounts beside polling. */
+export interface LiveExtensions {
+    readonly transactions: CipTransactions;
+    /** Writes are refused unless the row config enables them. */
+    readonly allowWrites: boolean;
+    /** Largest accepted batch read. */
+    readonly maxBatchTags: number;
+}
 /**
  * The live tools.
  *
  * @param session - Project handles for the calling chat.
  * @param polling - The polling engine and its configuration.
- * @param ctx - Plugin context that may provide the job service.
+ * @param ctx - Plugin context that may provide the job and approval services.
+ * @param extensions - One-shot transactions and the write switch.
  * @returns Tool definitions in registration order.
  */
-export declare function liveTools(session: ProjectSession, polling: DirectPolling, ctx: PluginContext): readonly ToolDefinition[];
+export declare function liveTools(session: ProjectSession, polling: DirectPolling, ctx: PluginContext, extensions: LiveExtensions): readonly ToolDefinition[];

package/vendor/l5x/lib/tools/live.js

@@ -1,16 +1,20 @@
 /**
- * SDK-free live reads over EtherNet/IP.
+ * SDK-free EtherNet/IP surface: reads, identity, discovery and the two
+ * approval-gated writes.
  *
- * Two tools: a bounded foreground poll, and a session-owned trend job the chart
- * can follow without a model call per sample. Both read declared scalar tags,
- * never write, and state that live logic is not the exported logic.
+ * Reads never change the controller and need no approval. Writes do: a write is
+ * refused unless the row's config allows writes AND a human approves that exact
+ * operation, and its result is the value read back over CIP, not an assumption.
  *
  * @module dsh-engineering-l5x/tools/live
  */
 import { success } from "../core/result.js";
-import { integer, list, object, objectItem, string } from "../core/params.js";
+import { integer, list, object, objectItem, scalar, string } from "../core/params.js";
 import { pollingRequest } from "../engine/direct-polling.js";
+import { batchReadRequest, controllerTarget, discoverRequest, writableTagRequest } from "../engine/cip-request.js";
+import { decodeClockResult, decodeDiscoverResult, decodeReadResult, decodeWriteClockResult, decodeWriteResult, } from "../engine/cip-transaction.js";
 import { L5xError } from "../core/errors.js";
+import { requireHumanApproval } from "../approvals.js";
 import { PROJECT_ID, optionalInteger, optionalString, requiredString, tool } from "./common.js";
 /** A direct read is not a guarantee about the scan. */
 const LIVE_COVERAGE = {
@@ -21,6 +25,15 @@ const LIVE_COVERAGE = {
         'transitions between sweeps',
     ],
 };
+/** A verified write is a fact about the tag, not about the machine. */
+const WRITE_COVERAGE = {
+    complete: false,
+    unverified: [
+        'that the written value is the intended process change',
+        'that the logic reacts as expected on the next scan',
+        'that the value is still in place after the next scan',
+    ],
+};
 /** The tags argument, as flat objects rather than a JSON string. */
 function tagsOf(args) {
     const raw = args.tags;
@@ -41,28 +54,34 @@ function tagsOf(args) {
     });
     return JSON.stringify(tags);
 }
-/** The same tag parameter for both tools. */
+/** The same tag parameter for the polling tools. */
 const TAGS_PARAM = list('Controller-scoped scalar tags to read, 1 to 16. Each entry names the tag and optionally its program.', objectItem('One declared scalar tag.', {
     name: string('Tag name. Example: "LineSpeed".'),
     program: string('Program scope for a program-scoped tag. Omit for a controller tag.'),
 }, ['name']), { minItems: 1, maxItems: 16 });
+/** The controller address shared by every non-discovery call. */
+const target = {
+    ip_address: string('Controller IPv4 address the human named. Example: "192.168.1.10".'),
+    slot: integer('CPU slot, 0 to 31. Default 0.', { minimum: 0, maximum: 31, default: 0 }),
+};
 /**
  * The live tools.
  *
  * @param session - Project handles for the calling chat.
  * @param polling - The polling engine and its configuration.
- * @param ctx - Plugin context that may provide the job service.
+ * @param ctx - Plugin context that may provide the job and approval services.
+ * @param extensions - One-shot transactions and the write switch.
  * @returns Tool definitions in registration order.
  */
-export function liveTools(session, polling, ctx) {
+export function liveTools(session, polling, ctx, extensions) {
+    const { transactions } = extensions;
     return [
         tool({
             name: 'poll_live_tags',
             description: 'Read declared scalar PLC tags directly over EtherNet/IP without Studio, FactoryTalk Linx, an ACD upload or the SDK. Explicit controller IPv4 and slot required. Returns timestamped sweeps, quality and controller identity; no writes.',
             parameters: object({
                 project_id: PROJECT_ID,
-                ip_address: string('Controller IPv4 address the human named. Example: "192.168.1.10".'),
-                slot: integer('CPU slot, 0 to 31. Default 0.', { minimum: 0, maximum: 31, default: 0 }),
+                ...target,
                 tags: TAGS_PARAM,
                 sample_count: integer('Number of sweeps to read. Default 1.', { minimum: 1, maximum: 1200, default: 1 }),
                 interval_ms: integer('Requested interval between sweeps. Default 200.', { minimum: 50, maximum: 600000, default: 200 }),
@@ -78,7 +97,7 @@ export function liveTools(session, polling, ctx) {
                 }, polling.config);
                 const frames = await polling.start(request, () => { }, exec.signal).done;
                 await session.require(project.id, exec);
-                return success(`Read ${request.samples} sweep(s) from ${request.ip}.`, {
+                return success(`Read ${String(request.samples)} sweep(s) from ${request.ip}.`, {
                     project_id: project.id,
                     source_sha256: project.sha256,
                     ip_address: request.ip,
@@ -95,13 +114,156 @@ export function liveTools(session, polling, ctx) {
                 }, [], LIVE_COVERAGE);
             },
         }),
+        tool({
+            name: 'read_live_tags',
+            description: 'Read up to 64 declared scalar tags in ONE EtherNet/IP request (CIP tag group). Faster than polling for a one-shot snapshot; no writes, no Studio, no Linx, no SDK.',
+            parameters: object({
+                project_id: PROJECT_ID,
+                ...target,
+                tags: list('Declared scalar tags to read together, 1 to 64. Each entry names the tag and optionally its program.', objectItem('One declared scalar tag.', {
+                    name: string('Tag name. Example: "LineSpeed".'),
+                    program: string('Program scope for a program-scoped tag. Omit for a controller tag.'),
+                }, ['name']), { minItems: 1, maxItems: 64 }),
+            }, ['ip_address', 'tags']),
+            async run(args, exec) {
+                const project = await session.require(optionalString(args, 'project_id'), exec);
+                const { request, evidence } = batchReadRequest(project, {
+                    ip_address: requiredString(args, 'ip_address'),
+                    slot: optionalInteger(args, 'slot') ?? 0,
+                    tags_json: tagsOf(args),
+                }, polling.config, extensions.maxBatchTags);
+                const result = decodeReadResult(await transactions.run(request, exec.signal));
+                await session.require(project.id, exec);
+                return success(`Read ${String(result.values.length)} tag(s) from ${request.ip} in one request.`, {
+                    project_id: project.id,
+                    source_sha256: project.sha256,
+                    ip_address: request.ip,
+                    slot: request.slot,
+                    provider: 'ethernet-ip',
+                    request_count: result.request_count,
+                    controller: result.controller,
+                    values: result.values,
+                    evidence,
+                    live_logic_matches_export: 'unverified',
+                }, [], LIVE_COVERAGE);
+            },
+        }),
+        tool({
+            name: 'read_controller_clock',
+            description: 'Read controller identity and, on L8x controllers, the wall clock beside the workstation clock. Reports unsupported instead of guessing on other models. No writes.',
+            parameters: object({ ...target }, ['ip_address']),
+            async run(args, exec) {
+                const request = { op: 'clock', ...controllerTarget(args, polling.config) };
+                const result = decodeClockResult(await transactions.run(request, exec.signal));
+                const drift = result.supported && result.controller_time !== undefined
+                    ? Date.parse(result.host_time) - Date.parse(result.controller_time)
+                    : undefined;
+                return success(result.supported
+                    ? `Controller clock ${String(result.controller_time)}; workstation ${result.host_time}.`
+                    : `Controller identity read; wall clock is unavailable on ${result.controller.product_name}.`, {
+                    ip_address: request.ip,
+                    slot: request.slot,
+                    provider: 'ethernet-ip',
+                    controller: result.controller,
+                    clock_supported: result.supported,
+                    ...(result.controller_time === undefined ? {} : { controller_time: result.controller_time }),
+                    host_time: result.host_time,
+                    ...(drift === undefined ? {} : { clock_offset_ms: drift }),
+                    ...(result.reason === undefined ? {} : { reason: result.reason }),
+                }, [], LIVE_COVERAGE);
+            },
+        }),
+        tool({
+            name: 'discover_controllers',
+            description: 'Discover EtherNet/IP controllers on this LAN by UDP broadcast for a bounded window: address, product, revision, serial, status. No address needed, no writes, no Studio or Linx.',
+            parameters: object({
+                duration_seconds: integer('How long to listen for replies, 1 to 15. Default 3.', { minimum: 1, maximum: 15, default: 3 }),
+            }),
+            async run(args, exec) {
+                const { request } = discoverRequest({ duration_seconds: optionalInteger(args, 'duration_seconds') ?? 3 }, polling.config);
+                const result = decodeDiscoverResult(await transactions.run(request, exec.signal, request.duration + 2000));
+                return success(`Found ${String(result.devices.length)} controller(s) in ${String(result.seconds)} s.`, {
+                    provider: 'ethernet-ip',
+                    broadcast_seconds: result.seconds,
+                    devices: result.devices,
+                    limitation: 'Broadcast discovery only reaches devices that answer on this subnet; a routed or filtered network returns nothing.',
+                }, [], { complete: false, unverified: ['that a silent device is absent', 'that a listed device is reachable for tag reads'] });
+            },
+        }),
+        tool({
+            name: 'write_live_tag',
+            description: 'Write ONE declared scalar PLC tag over EtherNet/IP, then read it back and report the controller\'s own value. Requires the row\'s writes switch AND human approval for this exact write. Destructive: it changes a running machine.',
+            parameters: object({
+                project_id: PROJECT_ID,
+                ...target,
+                name: string('Declared scalar tag name. Example: "LineSpeed".'),
+                program: string('Program scope for a program-scoped tag. Omit for a controller tag.'),
+                value: scalar('Value to write: true or false for BOOL, a number for INT, DINT or REAL.'),
+            }, ['ip_address', 'name', 'value']),
+            async run(args, exec) {
+                if (!extensions.allowWrites) {
+                    throw new L5xError('WRITES_DISABLED', 'Live writes are switched off for this bundle row.', 'Turn on "allowWrites" in the L5X row configuration on the Plugins page, then request the write again.');
+                }
+                const project = await session.require(optionalString(args, 'project_id'), exec);
+                const { request } = writableTagRequest(project, {
+                    ip_address: requiredString(args, 'ip_address'),
+                    slot: optionalInteger(args, 'slot') ?? 0,
+                    name: requiredString(args, 'name'),
+                    ...(optionalString(args, 'program') === undefined ? {} : { program: optionalString(args, 'program') }),
+                    value: args.value,
+                }, polling.config);
+                const address = request.tag.program === undefined
+                    ? request.tag.name
+                    : `Program:${String(request.tag.program)}.${String(request.tag.name)}`;
+                await requireHumanApproval(ctx, exec, 'write_live_tag', `Write ${JSON.stringify(args.value)} to ${address} on controller ${request.ip} slot ${String(request.slot)}. This changes a running machine.`);
+                const result = decodeWriteResult(await transactions.run(request, exec.signal));
+                await session.require(project.id, exec);
+                if (!result.verified) {
+                    throw new L5xError('WRITE_NOT_VERIFIED', `${result.tag} was written but the readback is ${JSON.stringify(result.readback)}, not ${JSON.stringify(result.requested_value)}.`, 'Inspect the tag in the controller before retrying; a type or scaling mismatch can reject the value.');
+                }
+                return success(`Wrote ${JSON.stringify(result.requested_value)} to ${result.tag}; the controller reads back ${JSON.stringify(result.readback)}.`, {
+                    project_id: project.id,
+                    source_sha256: project.sha256,
+                    ip_address: request.ip,
+                    slot: request.slot,
+                    provider: 'ethernet-ip',
+                    approved: 'allowed-once',
+                    ...result,
+                    live_logic_matches_export: 'unverified',
+                }, [], WRITE_COVERAGE);
+            },
+        }),
+        tool({
+            name: 'write_controller_clock',
+            description: 'Set the controller wall clock (L8x only), then read it back. Requires the row\'s writes switch AND human approval for this exact change.',
+            parameters: object({
+                ...target,
+                time: string('ISO 8601 timestamp to set. Omit to use the workstation clock now. Example: "2026-10-25T09:30:00Z".'),
+            }, ['ip_address']),
+            async run(args, exec) {
+                if (!extensions.allowWrites) {
+                    throw new L5xError('WRITES_DISABLED', 'Live writes are switched off for this bundle row.', 'Turn on "allowWrites" in the L5X row configuration on the Plugins page, then request the change again.');
+                }
+                const request = { op: 'write-clock', ...controllerTarget(args, polling.config), iso: optionalString(args, 'time') ?? new Date().toISOString() };
+                await requireHumanApproval(ctx, exec, 'write_controller_clock', `Set the wall clock of controller ${request.ip} slot ${String(request.slot)} to ${String(request.iso)}.`);
+                const result = decodeWriteClockResult(await transactions.run(request, exec.signal));
+                if (!result.verified) {
+                    throw new L5xError('WRITE_NOT_VERIFIED', `The clock readback ${result.readback} does not match ${result.requested_time}.`, 'Retry once; if it still differs, the controller rejects clock changes (unsupported model or protected).');
+                }
+                return success(`Controller clock set to ${result.readback}.`, {
+                    ip_address: request.ip,
+                    slot: request.slot,
+                    approved: 'allowed-once',
+                    ...result,
+                }, [], WRITE_COVERAGE);
+            },
+        }),
         tool({
             name: 'start_plc_trend',
             description: 'Start a bounded, read-only PLC trend as a session-owned background job. Explicit IPv4, slot and declared scalar tags required. SDK-independent EtherNet/IP; the chart follows the job without a model call per sample.',
             parameters: object({
                 project_id: PROJECT_ID,
-                ip_address: string('Controller IPv4 address the human named. Example: "192.168.1.10".'),
-                slot: integer('CPU slot, 0 to 31. Default 0.', { minimum: 0, maximum: 31, default: 0 }),
+                ...target,
                 tags: TAGS_PARAM,
                 sample_count: integer('Number of sweeps in the trend. Default 300.', { minimum: 1, maximum: 1200, default: 300 }),
                 interval_ms: integer('Requested interval between sweeps. Default 200.', { minimum: 50, maximum: 600000, default: 200 }),
@@ -123,7 +285,7 @@ export function liveTools(session, polling, ctx) {
                 const jobId = jobs.start({
                     kind: 'plc-trend',
                     owner,
-                    label: `PLC trend ${request.ip} slot ${request.slot}`,
+                    label: `PLC trend ${request.ip} slot ${String(request.slot)}`,
                     run(job) {
                         job.append(JSON.stringify({
                             type: 'source',
@@ -157,7 +319,7 @@ export function liveTools(session, polling, ctx) {
                         return { cancel: handle.cancel, done };
                     },
                 });
-                return success(`Trend ${jobId} started for ${request.samples} sweep(s) from ${request.ip}.`, {
+                return success(`Trend ${jobId} started for ${String(request.samples)} sweep(s) from ${request.ip}.`, {
                     job_id: jobId,
                     owner_session_id: owner,
                     project_id: project.id,