@aryacode/dsh-engineering 0.4.1 → 0.4.2

package/CHANGELOG.md

@@ -1,5 +1,26 @@
 # Changelog
 
+## [0.4.2] - 2026-10-25
+
+### Fixed
+
+- **The bundle now installs and mounts in AryaCode.** 0.4.1 fixed the pnpm error, but the install still
+  failed one step later, when the profile tried to apply the bundle: the patch's first entry targeted
+  the `tool-capability-policy` row, and no such row exists in an AryaCode profile, so composition threw
+  `dsh: [@aryacode/dsh-engineering] patch: entry "tool-capability-policy" not found` and the plugin
+  manager rolled the install back — which is what the market card reported as *Cannot install*.
+
+### Removed
+
+- **The per-skill tool filter.** `policyOnly` / `toolPolicy` / `capabilities` are an AryaAI harness
+  feature: AryaAI's fork of `@deepseek-ai/dsh-tool-skill` implements them, and the AryaCode line's copy
+  of the same package does not. In this product the layer never filtered anything — an older harness
+  skipped the missing row with a warning, the current one treats it as fatal. Rows are the switch:
+  disabling `l5x-editing`, `l5x-studio`, `l5x-live` or `mwi-edit` unmounts that plugin and removes its
+  tool schemas from the request, which is the same context saving by a mechanism this harness has.
+- The patch is now **inserts only**, and `test/patch.spec.mjs` fails if any entry targets a row another
+  bundle owns. `test/docs.spec.mjs` fails if the README still promises a capability policy.
+
 ## [0.4.1] - 2026-10-25
 
 ### Fixed

package/README.md

@@ -1,9 +1,8 @@
 # AryaCode Engineering
 
 **One bundle for automation-engineering work in AryaCode.** Studio 5000 L5X, FactoryTalk View ME,
-MotionWorks IEC and FactoryTalk Optix sit behind a single install, one row per capability, and one
-switch per product — so the switch removes tool schemas from the request instead of leaving them
-visible after the guidance is off.
+MotionWorks IEC and FactoryTalk Optix sit behind a single install, one row per surface. A row is the
+switch: disable it and that plugin unloads, so its tool schemas leave the request.
 
 `@aryacode/dsh-engineering` · 79 tools · 16 rows · 4 products · MIT
 
@@ -15,18 +14,19 @@ A general assistant pays for every tool schema on every request. An automation e
 surfaces — reading a 3 MB L5X, comparing two projects, staging ladder edits, talking to a controller —
 but only one or two of them at a time.
 
-This bundle splits those surfaces into independently switchable rows and links each product's tools to
-the skill that governs it. Turning a product off removes **both** its guidance and its schemas:
+This bundle splits those surfaces into independently switchable rows. The expensive ones are off by
+default, so a read-only profile pays for the read tools and nothing else:
 
-| State | What the model receives |
-|---|---|
-| `rockwell-l5x` skill **on** | L5X guidance + 35 tool schemas |
-| `rockwell-l5x` skill **off** | neither |
+| Row | Default | What a disabled row removes |
+|---|---|---|
+| `l5x-editing` | off | the nine `draft_*` schemas |
+| `l5x-studio` | off | the Logix Designer SDK and supervised controller schemas |
+| `l5x-live` | off | the EtherNet/IP polling and trend schemas |
+| `mwi-edit` | off | the seven MotionWorks edit schemas |
 
-The heavy surfaces are separate rows on purpose. A read-only profile pays for the read tools and
-nothing else, and the previews are independent of the tools — switching L5X tools off does not remove
-the ladder viewer. Both previews mount from **one** row (`viewers`), because a package registers
-exactly one browser bundle.
+The previews are independent of the tools — switching L5X tools off does not remove the ladder viewer.
+Both previews mount from **one** row (`viewers`), because a package registers exactly one browser
+bundle.
 
 ## What it supports
 
@@ -45,25 +45,32 @@ Tool groups, by product:
 - **MotionWorks IEC** — 7 session, 7 saved-project reads, 3 verify, 7 staged edits
 - **Optix** — 6 tools, unlinked to a skill until one exists
 
-## What the policy changes
+## Switches
 
-Each skill governs a product's tools. The capability policy is per-tool, not per-prefix, because the
-rebuilt tools use descriptive names.
+A row is a plugin. Disabling it in the profile (or on the Plugins page) unmounts that plugin and its
+tool schemas stop being sent; the guidance skill keeps its own row so reading guidance and reading
+tools switch separately.
 
-| Skill | Governs | Tools |
-|---|---|---|
-| `rockwell-l5x` | `l5x_*` **and** the 35 L5X tools by exact name | 35 |
-| `factorytalk-view` | `ftview_*` | 14 |
-| `motionworks-iec` | `mw_*` | 24 |
-| — | `optix_*` | 6 (always visible: no skill yet) |
-
-`onDemand` stays `false`. Bounded on-demand discovery was measured against eager exposure and kept
-eager, because discovery cost more turns than the schema characters it saved. The context win comes
-from the per-product switches and from splitting the surfaces into rows.
+| Row | Surface | Default | Why the default |
+|---|---|---|---|
+| `l5x-read`, `l5x-read-skill` | offline reads, checks, comparison + guidance | on | cheap and safe |
+| `l5x-editing` | nine staged `draft_*` tools | **off** | a read-only profile should not pay for them |
+| `l5x-studio` | Logix Designer SDK and supervised controller | **off** | needs Studio 5000 installed |
+| `l5x-live` | EtherNet/IP polling and trends | **off** | needs a controller address |
+| `viewers` | ladder + ME display previews | on | adds no model context |
+| `ftview-read`, `ftview-read-skill`, `ftview-edit`, `ftview-studio` | FactoryTalk View ME read, edits, Studio handoff | on | small enough to default on |
+| `mwi-session`, `mwi-read`, `mwi-read-skill`, `mwi-verify` | MotionWorks IEC session, reads, verify + guidance | on | — |
+| `mwi-edit` | seven staged MotionWorks edits | **off** | the largest schemas in the bundle |
+| `optix` | FactoryTalk Optix Studio authoring | on | separate component package |
+
+**No capability policy.** Earlier releases also carried a per-skill tool filter (`policyOnly` /
+`toolPolicy`) that gated tools by skill state. That filter is an AryaAI harness feature and is **not
+part of this product line** — `@deepseek-ai/dsh-tool-skill` here has no such config. Rows are the
+switch. Do not re-add a patch entry that targets another bundle's row: composition fails when the row
+is absent, and that is what made 0.4.0 and 0.4.1 uninstallable.
 
 The reference in [docs/reference/tools.md](docs/reference/tools.md) is generated from the registered
-definitions, and `pnpm test` fails when a registered tool is not governed or the committed reference
-drifts.
+definitions, and `pnpm test` fails when the committed reference drifts.
 
 ## Status
 
@@ -108,8 +115,8 @@ Where each surface actually stands, based on what has been exercised.
 
 ## Install
 
-The bundle carries its components (`vendor/`), its own browser face (both previews) and the
-tool-exposure policy. Installing a component on its own gives you tools **without** the policy.
+The bundle carries its components (`vendor/`), its own browser face (both previews) and the rows.
+Installing a component on its own gives you tools **without** the rows that switch them.
 
 ```sh
 # in the AryaCode profile
@@ -129,13 +136,12 @@ development home mounts the same rows.
 
 ## How it composes
 
-The bundle adds one loader layer after the Web app. It patches the existing `tool-capability-policy`
-row and inserts its own rows; it never replaces a product plugin id.
+The bundle adds one loader layer after the Web app: it **inserts** its own rows and never touches a row
+another bundle owns.
 
 ```mermaid
 flowchart TB
   Profile["Profile bundle list"] --> Bundle["@aryacode/dsh-engineering"]
-  Bundle -->|"id-targeted config override"| Policy["tool-capability-policy"]
   Bundle -->|insert| L5XRead["l5x-read (on)"]
   L5XRead --> L5XSkill["l5x-read-skill (on)"]
   Bundle -->|insert| L5XEdit["l5x-editing (off)"]
@@ -145,9 +151,6 @@ flowchart TB
   Bundle -->|insert| FTV["ftview-read / edit / studio (on)"]
   Bundle -->|insert| MWI["mwi-session / read / verify (on), edit (off)"]
   Bundle -->|insert| Optix["optix (on)"]
-  Policy -->|"rockwell-l5x governs 35 tools"| L5XRead
-  Policy -->|"factorytalk-view governs ftview_*"| FTV
-  Policy -->|"motionworks-iec governs mw_*"| MWI
 ```
 
 Row ids are stable. Profiles and patches address these ids, so per-row enable state survives upgrades

package/cordis.patch.yml

@@ -1,77 +1,21 @@
 # AryaCode engineering bundle.
 #
-# Two layers live here.
+# One layer lives here: the product rows. Each row mounts one surface of the
+# bundle, and the row is the switch — disabling `l5x-editing`, `l5x-studio`,
+# `l5x-live` or `mwi-edit` unloads that plugin, so its tool schemas never reach
+# the request. Row ids are stable, so per-entry enable state survives upgrades
+# even as the package behind a row is rebuilt.
 #
-# 1. Tool exposure. Targets the existing `tool-capability-policy` row and links
-#    each engineering product's tool namespace to the skill that governs it, so
-#    the Skills page switch controls the guidance and the tools together instead
-#    of leaving the tool schemas exposed after the skill is off.
+# The patch only ever inserts. It must never target a row another bundle owns:
+# a profile without that row makes composition fail ("patch: entry ... not
+# found"), and in 0.4.0/0.4.1 that is exactly why the bundle could not be
+# installed.
 #
-#    `onDemand` stays false. Arya measured bounded on-demand discovery against
-#    eager exposure and kept eager exposure because discovery cost more turns
-#    than the schema characters it saved. The context gain comes from per-product
-#    switches and from trimming the product schemas.
-#
-#    Optix has no skill yet, so `optix_*` stays unlinked and always visible. Link
-#    it here once a FactoryTalk Optix skill registers one.
-#
-# 2. The product rows. Mounts the rebuilt L5X and FactoryTalk View surfaces and
-#    their guidance as components of this bundle. The row ids are stable, so per-entry enable
-#    state survives upgrades even as the package behind them is rebuilt.
-- id: tool-capability-policy
-  config:
-    policyOnly: true
-    toolPolicy:
-      onDemand: false
-      capabilities:
-        - skill: rockwell-l5x
-          # The rebuilt L5X tools keep descriptive names (open_project,
-          # draft_apply, ...). This exact list is what the skill switch
-          # governs; `l5x_` stays linked for any prefixed tool added later.
-          tools:
-            - open_project
-            - project_overview
-            - list_components
-            - get_component
-            - search_logic
-            - find_references
-            - trace_dependencies
-            - resolve_tag
-            - usage_map
-            - run_checks
-            - compare_projects
-            - draft_rung
-            - draft_st
-            - draft_routine
-            - draft_tag
-            - draft_tag_description
-            - draft_udt_member
-            - draft_udt_description
-            - draft_validate
-            - draft_apply
-            - studio_sdk_status
-            - studio_capabilities
-            - export_acd_to_l5x
-            - verify_offline_l5x
-            - build_acd_from_draft
-            - studio_review_evidence
-            - controller_approval_status
-            - capture_controller_snapshot
-            - go_online
-            - read_controller_mode
-            - read_live_tag
-            - change_controller_mode
-            - download_project
-            - poll_live_tags
-            - start_plc_trend
-          prefixes:
-            - l5x_
-        - skill: factorytalk-view
-          prefixes:
-            - ftview_
-        - skill: motionworks-iec
-          prefixes:
-            - mw_
+# The per-skill tool filter (`policyOnly` / `toolPolicy` / `capabilities`) is an
+# AryaAI harness feature. The AryaCode line's `@deepseek-ai/dsh-tool-skill` has
+# no such config, so a capability layer here would either fail composition or be
+# rejected by the plugin's schema. Rows are the switch in this product; when
+# that filter ships here, it belongs in a bundle mount of its own.
 - insert:
     - id: l5x-read
       name: '@aryacode/dsh-engineering/l5x'

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aryacode/dsh-engineering",
-  "version": "0.4.1",
+  "version": "0.4.2",
   "description": "AryaCode engineering bundle: one install surface and one tool-exposure policy for the Studio 5000 L5X, FactoryTalk View and MotionWorks IEC plugins, with skill links for Optix and CAD.",
   "keywords": [
     "dsh",