@aryacode/dsh-aryacode-polish 0.3.9 → 0.4.4

package/CHANGELOG.md

@@ -1,5 +1,60 @@
 # Changelog
 
+## [0.4.4] - 2026-10-27
+
+### Fixed
+
+- **The row reported "this Host cannot open a folder" on a Host that can.** A Remote
+  method answers an envelope — `{ ok, value }` — not the bare return value, so
+  `canOpenWorkspacePath()` never looked like `true`. The row now reads
+  `ok === true && value === true`, tolerates a plain boolean, and checks the
+  `ok` flag of the open call itself instead of trusting that no throw means opened.
+
+## [0.4.3] - 2026-10-27
+
+### Fixed
+
+- **The row still could not open anything.** 0.4.2 declared `remote.session` but the
+  guard checks each namespace on its own: reading `ctx.remote.session` needs both
+  `remote` and `remote.session` on the inject list, so the call failed one level
+  earlier. The registration now declares `['workspaces', 'remote', 'remote.session']`.
+
+## [0.4.2] - 2026-10-27
+
+### Fixed
+
+- **The row did nothing when clicked.** The Shell refuses `ctx.get('remote.session')`
+  — a Remote namespace may only be read through a declared injection — so the open
+  call failed before it reached the Host. The registration now declares
+  `ctx.inject(['workspaces', 'remote.session'], …)` and calls the namespace the
+  injected context hands it. Found by the row reporting its own failure (0.4.1).
+
+## [0.4.1] - 2026-10-27
+
+### Changed
+
+- The **Open workspace folder** row reports a failed open instead of doing nothing.
+  A menu row that silently ignores the click is impossible to diagnose in the
+  field; the bundle now writes one console.warn naming the failing step (no
+  Session Remote, a Host that cannot open a path, or the Remote error itself).
+
+## [0.4.0] - 2026-10-27
+
+### Added
+
+- **Open workspace folder.** A Session's "…" menu gains an **Open workspace folder**
+  row that opens the Session's workspace directory in Explorer/Finder through the
+  Session Remote (`openWorkspacePath`), gated by `canOpenWorkspacePath` and resolved
+  from the Workspace snapshot. New switch `openWorkspaceFolder`, on by default, and
+  the row hides itself when the Session has no workspace or the Host cannot open a
+  path.
+- `docs/workspace-folder.md` records why the requested surface — right-clicking the
+  workspace row itself — is not reachable from a plugin: that row has no context
+  menu, the workspace-scoped menu list slot does not exist, and native menus and
+  desktop IPC are closed to plugins. The bundle ships on the documented Session-row
+  slot rather than hijacking private markup, and the note says where the feature
+  should move if a workspace-scoped slot ever lands.
+
 ## [0.3.9] - 2026-10-27
 
 ### Changed

package/README.md

@@ -7,7 +7,7 @@ installed into and patches nothing. It is one package, one Plugins row, and one
 switch per feature, so a refinement that turns out to be wrong for a machine can
 be turned off without uninstalling anything.
 
-Status: **two features shipped.** The version is the package's, and the card
+Status: **three features shipped.** The version is the package's, and the card
 header already shows it.
 
 ## What it is
@@ -32,6 +32,7 @@ Configure page automatically.
 | --- | --- | --- |
 | **Estimated session cost** (`sessionCost`) | On | A `≈$0.39` pill in the composer dock that opens a breakdown card — cache hit, uncached input, cached input, output, requests, and the estimate — priced from the session's recorded usage at the published DeepSeek rates. |
 | **Account balance** (`accountBalance`) | On | The account's remaining wallet (`$17.33`) in the sidebar foot, above the account row. Renders nothing when the Host exposes no wallet, so it never shows a number nobody gave it. |
+| **Open workspace folder** (`openWorkspaceFolder`) | On | An **Open workspace folder** row in a Session's "…" menu that opens the Session's workspace in Explorer/Finder. Renders nothing when the Session has no workspace or the Host cannot open a path. See [Open a workspace folder](docs/workspace-folder.md) for why the request had to land here instead of on the workspace row itself. |
 
 ### How the cost is computed
 
@@ -130,7 +131,7 @@ client/switches.json the browser half of the seam — one entry per switch
 scripts/build-client.mjs  wraps client/face.js into lib/client.js
 lib/client.js        generated: the bundle the Shell loads
 locale/              card title and description (en, zh)
-docs/                parked investigations
+docs/                feature notes and parked investigations
 test/                node --test specs
 ```
 

package/client/face.js

@@ -17,6 +17,19 @@
 const React = require('react')
 const ReactDOM = require('react-dom')
 
+/**
+ * The Shell's own UI primitives. Guarded because the menu row degrades to a plain
+ * button when a Shell answers no primitives, and a bundle that throws on load
+ * would take every other surface down with it.
+ */
+const primitives = (() => {
+  try {
+    return require('@deepseek-ai/dsh-client-ui-primitives')
+  } catch {
+    return undefined
+  }
+})()
+
 /** Shared spacing for the page's prose. */
 const SPACING = { margin: '0 0 10px', opacity: 0.85, lineHeight: '1.5' }
 
@@ -535,6 +548,74 @@ function BalanceLine(props) {
   }, props.wide === false ? money : 'Balance ' + money)
 }
 
+/**
+ * The workspace a Session belongs to.
+ *
+ * Occupants of `sidebar.workspaces.session.menu.item` address their data by
+ * Session id and must not bind or retain the Session, so the workspace is read
+ * from the Workspace snapshot at render time and never memoized.
+ *
+ * @param workspaces - the Shell's Workspace service, when it is loaded.
+ * @param sessionId - the row's Session.
+ * @returns the owning workspace, or undefined when it cannot be resolved.
+ */
+function workspaceOf(workspaces, sessionId) {
+  if (workspaces === undefined || workspaces === null || sessionId === undefined) return undefined
+  let items
+  try {
+    items = workspaces.list.getSnapshot().items
+  } catch {
+    return undefined
+  }
+  if (!Array.isArray(items)) return undefined
+  return items.find(item => Array.isArray(item.sessionIds)
+    && item.sessionIds.indexOf(sessionId) !== -1
+    && typeof item.path === 'string'
+    && item.path !== '')
+}
+
+/**
+ * "Open workspace folder": one row in a Session's "…" menu.
+ *
+ * It renders nothing when the switch is off or the Session has no workspace the
+ * Host could open, because a menu row that cannot act is worse than no row.
+ *
+ * @param props - the row's Session id, our lazy `configForms`/`workspaces`, the
+ *   opener, and the slot's injected `useMenuOpenState` hook.
+ * @returns the menu row, or null.
+ */
+function OpenFolderMenuItem(props) {
+  const enabled = useSwitch(props.configForms, 'openWorkspaceFolder', true)
+  // Hooks run unconditionally; the row simply renders nothing when it cannot act.
+  const menu = typeof props.useMenuOpenState === 'function' ? props.useMenuOpenState() : undefined
+  const closeMenu = Array.isArray(menu) && typeof menu[1] === 'function' ? menu[1] : undefined
+  const workspace = enabled ? workspaceOf(props.workspaces, props.sessionId) : undefined
+  if (!enabled || workspace === undefined) return null
+  const label = 'Open workspace folder'
+  const onSelect = () => {
+    if (closeMenu !== undefined) closeMenu(false)
+    const open = props.openFolder
+    if (typeof open !== 'function') return
+    void Promise.resolve()
+      .then(() => open(workspace))
+      .catch(error => {
+        // A menu row that silently does nothing is unfixable in the field, so the
+        // failure is reported instead of dropped. This is the only diagnostic the
+        // bundle writes.
+        if (typeof console !== 'undefined' && typeof console.warn === 'function') {
+          console.warn('[aryacode-polish] open workspace folder failed:', error && error.message ? error.message : error)
+        }
+      })
+  }
+  if (primitives !== undefined && typeof primitives.MenuItemButton === 'function') {
+    const icon = typeof primitives.IconFolderOpenRegular === 'function'
+      ? React.createElement(primitives.IconFolderOpenRegular)
+      : undefined
+    return React.createElement(primitives.MenuItemButton, { icon, onSelect }, label)
+  }
+  return React.createElement('button', { type: 'button', role: 'menuitem', onClick: onSelect }, label)
+}
+
 return {
   inject: ['slots'],
   /**
@@ -571,5 +652,31 @@ return {
         inject: () => ({ configForms, loadBalance }),
       }, BalanceLine))
     })
+    // The Workspace service and the Session Remote are both required for the menu
+    // row: it reads the folder from the first and opens it through the second.
+    // They are declared on the inject list because a Remote namespace may not be
+    // read through `ctx.get` — the Shell's guard refuses it.
+    ctx.inject(['workspaces', 'remote', 'remote.session'], (workspaceCtx) => {
+      const openFolder = async (workspace) => {
+        const remote = workspaceCtx.remote.session
+        // A Remote method answers an envelope (`{ ok, value }`), not the bare
+        // return value; a Shell that answered a plain boolean is tolerated too.
+        const answer = await remote.canOpenWorkspacePath()
+        const available = answer !== null && typeof answer === 'object'
+          ? answer.ok === true && answer.value === true
+          : answer === true
+        if (!available) throw new Error('this Host cannot open a folder')
+        const result = await remote.openWorkspacePath({ path: workspace.path })
+        if (result !== null && typeof result === 'object' && 'ok' in result && result.ok !== true) {
+          throw new Error('the Host refused to open the folder')
+        }
+      }
+      workspaceCtx.slots.inject('sidebar.workspaces.session.menu.item', () => workspaceCtx.slots.register({
+        name: 'sidebar.workspaces.session.menu.item',
+        id: 'polish-open-folder',
+        order: 460,
+        inject: () => ({ configForms, openFolder, workspaces: workspaceCtx.get('workspaces') }),
+      }, OpenFolderMenuItem))
+    })
   },
 }

package/client/switches.json

@@ -12,6 +12,12 @@
       "label": "Account balance",
       "description": "Show the remaining account balance in the sidebar foot, above the account row.",
       "defaultOn": true
+    },
+    {
+      "key": "openWorkspaceFolder",
+      "label": "Open workspace folder",
+      "description": "Add an \u201cOpen workspace folder\u201d row to a Session\u2019s menu that opens its workspace in the file browser.",
+      "defaultOn": true
     }
   ]
 }

package/docs/workspace-folder.md

@@ -0,0 +1,67 @@
+# Open a workspace folder in the file browser
+
+## What ships
+
+A row in a Session's "…" menu: **Open workspace folder**. It resolves the workspace
+that owns the Session and asks the Host to open that directory in the platform file
+manager (Explorer on Windows, Finder on macOS, the desktop's file manager elsewhere).
+
+- Switch: `openWorkspaceFolder` (on by default).
+- Seat: `sidebar.workspaces.session.menu.item`, registered as `polish-open-folder`
+  at `order: 460`, after the shipped `session-id` row at `450`.
+- Host call: `ctx.remote.session.openWorkspacePath({ path })`, gated by
+  `ctx.remote.session.canOpenWorkspacePath()`.
+- Path source: the Workspace snapshot (`ctx.workspaces.list`), matched through
+  `WorkspaceView.sessionIds`.
+
+The row renders nothing when the switch is off, when the Session belongs to no
+workspace, or when the Host reports it cannot open a path. A menu row that cannot
+act is worse than no row.
+
+## What cannot ship, and why
+
+The requested surface was **right-click on the workspace row itself**, with a menu
+like the one AryaAI has (`Open in Explorer`, `Rename`, `Manage folders`, `Delete
+workspace`). That is not reachable from a plugin, for three independent reasons:
+
+1. The workspace row is drawn by `packages/client/ui-workspace/src/client/rows/Rows.tsx`.
+   The row element carries `data-row-key`, `role="treeitem"` and `onClick`, and has
+   no `onContextMenu`. Its "…" button opens a menu whose entries are hardcoded
+   (`rename`, `delete.workspace`).
+2. No slot exists for per-workspace menu entries. The only workspace-related list
+   slots are `sidebar.workspaces.session.menu.item` and
+   `sidebar.workspaces.session.row.action`, both scoped to a **Session** row. The
+   single `sidebar.workspaces` slot replaces the whole browser
+   (`replaceRisk: 'shadows-shipped-ui'`), which would mean rebuilding the shipped
+   sidebar.
+3. Native menus are closed to plugins: `apps/desktop/src/main.ts` allows only the
+   `application` and `edit` roles from the main window's main frame, and the
+   desktop IPC surface (`apps/desktop/src/ipc.ts`, `DshDesktopProductApi`) exposes
+   no open/reveal call.
+
+Attaching an `onContextMenu` to the row's DOM by selector would be a hack against
+private markup — the thing this bundle's ground rules forbid, and the first thing
+to break when the sidebar changes. The honest options were:
+
+- **Ship on the Session row menu** (chosen): documented slot, supported API,
+  survives harness updates.
+- Change the shell to declare `sidebar.workspaces.menu.item` and render it from the
+  workspace row, then release a harness patch. Declined: the owner wants to keep
+  taking harness updates from public releases.
+- Park the feature. Declined: the underlying capability (open a workspace folder)
+  is worth shipping now.
+
+If the harness ever declares a workspace-scoped menu slot, this feature should move
+there: the Host call and the path resolution stay exactly as they are, and only the
+registration line changes.
+
+## Evidence for the next reader
+
+- Slot contract: `packages/client/ui-workspace/src/client/contract/slots.ts:152-205`.
+- Shipped row to copy: `packages/client/ui-workspace/src/client/session-actions/SessionId.tsx`.
+- Remote methods: `packages/api/session-controller/src/index.ts:336-339`
+  (`canOpenWorkspacePath`) and `:357-367` (`openWorkspacePath`).
+- Windows reveal path: `packages/util/native-command/src/path-opener.ts:307`
+  (`runExplorer(['/select,', …])`); `open-in-app` is mounted in the web bundle at
+  `packages/bundle/web-app/cordis.patch.yml:73-81`, so this works under `start:web`.
+- Workspace view: `packages/api/workspace-controller/src/types.ts:18-30`.

package/entries/registry.js

@@ -46,6 +46,12 @@ export const features = [
     description: 'Show the remaining account balance in the sidebar foot, above the account row.',
     defaultOn: true,
   },
+  {
+    id: 'openWorkspaceFolder',
+    label: 'Open workspace folder',
+    description: 'Add an "Open workspace folder" row to a Session\u2019s menu that opens its workspace in the file browser.',
+    defaultOn: true,
+  },
 ]
 
 /**

package/lib/client.js

@@ -19,11 +19,17 @@ window.__ModuleLoader__.load({
         "label": "Account balance",
         "description": "Show the remaining account balance in the sidebar foot, above the account row.",
         "defaultOn": true
+      },
+      {
+        "key": "openWorkspaceFolder",
+        "label": "Open workspace folder",
+        "description": "Add an “Open workspace folder” row to a Session’s menu that opens its workspace in the file browser.",
+        "defaultOn": true
       }
     ]
     const ROW_ID = "polish"
     const ROW_KEY = "@aryacode/dsh-aryacode-polish" + '#' + ROW_ID
-    const CLIENT_VERSION = "0.3.9"
+    const CLIENT_VERSION = "0.4.4"
 
     /**
      * The two pure decisions behind the balance line: which wallet to show, and how
@@ -166,6 +172,19 @@ window.__ModuleLoader__.load({
     const React = require('react')
     const ReactDOM = require('react-dom')
 
+    /**
+     * The Shell's own UI primitives. Guarded because the menu row degrades to a plain
+     * button when a Shell answers no primitives, and a bundle that throws on load
+     * would take every other surface down with it.
+     */
+    const primitives = (() => {
+      try {
+        return require('@deepseek-ai/dsh-client-ui-primitives')
+      } catch {
+        return undefined
+      }
+    })()
+
     /** Shared spacing for the page's prose. */
     const SPACING = { margin: '0 0 10px', opacity: 0.85, lineHeight: '1.5' }
 
@@ -684,6 +703,74 @@ window.__ModuleLoader__.load({
       }, props.wide === false ? money : 'Balance ' + money)
     }
 
+    /**
+     * The workspace a Session belongs to.
+     *
+     * Occupants of `sidebar.workspaces.session.menu.item` address their data by
+     * Session id and must not bind or retain the Session, so the workspace is read
+     * from the Workspace snapshot at render time and never memoized.
+     *
+     * @param workspaces - the Shell's Workspace service, when it is loaded.
+     * @param sessionId - the row's Session.
+     * @returns the owning workspace, or undefined when it cannot be resolved.
+     */
+    function workspaceOf(workspaces, sessionId) {
+      if (workspaces === undefined || workspaces === null || sessionId === undefined) return undefined
+      let items
+      try {
+        items = workspaces.list.getSnapshot().items
+      } catch {
+        return undefined
+      }
+      if (!Array.isArray(items)) return undefined
+      return items.find(item => Array.isArray(item.sessionIds)
+        && item.sessionIds.indexOf(sessionId) !== -1
+        && typeof item.path === 'string'
+        && item.path !== '')
+    }
+
+    /**
+     * "Open workspace folder": one row in a Session's "…" menu.
+     *
+     * It renders nothing when the switch is off or the Session has no workspace the
+     * Host could open, because a menu row that cannot act is worse than no row.
+     *
+     * @param props - the row's Session id, our lazy `configForms`/`workspaces`, the
+     *   opener, and the slot's injected `useMenuOpenState` hook.
+     * @returns the menu row, or null.
+     */
+    function OpenFolderMenuItem(props) {
+      const enabled = useSwitch(props.configForms, 'openWorkspaceFolder', true)
+      // Hooks run unconditionally; the row simply renders nothing when it cannot act.
+      const menu = typeof props.useMenuOpenState === 'function' ? props.useMenuOpenState() : undefined
+      const closeMenu = Array.isArray(menu) && typeof menu[1] === 'function' ? menu[1] : undefined
+      const workspace = enabled ? workspaceOf(props.workspaces, props.sessionId) : undefined
+      if (!enabled || workspace === undefined) return null
+      const label = 'Open workspace folder'
+      const onSelect = () => {
+        if (closeMenu !== undefined) closeMenu(false)
+        const open = props.openFolder
+        if (typeof open !== 'function') return
+        void Promise.resolve()
+          .then(() => open(workspace))
+          .catch(error => {
+            // A menu row that silently does nothing is unfixable in the field, so the
+            // failure is reported instead of dropped. This is the only diagnostic the
+            // bundle writes.
+            if (typeof console !== 'undefined' && typeof console.warn === 'function') {
+              console.warn('[aryacode-polish] open workspace folder failed:', error && error.message ? error.message : error)
+            }
+          })
+      }
+      if (primitives !== undefined && typeof primitives.MenuItemButton === 'function') {
+        const icon = typeof primitives.IconFolderOpenRegular === 'function'
+          ? React.createElement(primitives.IconFolderOpenRegular)
+          : undefined
+        return React.createElement(primitives.MenuItemButton, { icon, onSelect }, label)
+      }
+      return React.createElement('button', { type: 'button', role: 'menuitem', onClick: onSelect }, label)
+    }
+
     return {
       inject: ['slots'],
       /**
@@ -720,6 +807,32 @@ window.__ModuleLoader__.load({
             inject: () => ({ configForms, loadBalance }),
           }, BalanceLine))
         })
+        // The Workspace service and the Session Remote are both required for the menu
+        // row: it reads the folder from the first and opens it through the second.
+        // They are declared on the inject list because a Remote namespace may not be
+        // read through `ctx.get` — the Shell's guard refuses it.
+        ctx.inject(['workspaces', 'remote', 'remote.session'], (workspaceCtx) => {
+          const openFolder = async (workspace) => {
+            const remote = workspaceCtx.remote.session
+            // A Remote method answers an envelope (`{ ok, value }`), not the bare
+            // return value; a Shell that answered a plain boolean is tolerated too.
+            const answer = await remote.canOpenWorkspacePath()
+            const available = answer !== null && typeof answer === 'object'
+              ? answer.ok === true && answer.value === true
+              : answer === true
+            if (!available) throw new Error('this Host cannot open a folder')
+            const result = await remote.openWorkspacePath({ path: workspace.path })
+            if (result !== null && typeof result === 'object' && 'ok' in result && result.ok !== true) {
+              throw new Error('the Host refused to open the folder')
+            }
+          }
+          workspaceCtx.slots.inject('sidebar.workspaces.session.menu.item', () => workspaceCtx.slots.register({
+            name: 'sidebar.workspaces.session.menu.item',
+            id: 'polish-open-folder',
+            order: 460,
+            inject: () => ({ configForms, openFolder, workspaces: workspaceCtx.get('workspaces') }),
+          }, OpenFolderMenuItem))
+        })
       },
     }
   },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aryacode/dsh-aryacode-polish",
-  "version": "0.3.9",
+  "version": "0.4.4",
   "description": "AryaCode Polish: one install for the small things that make AryaCode feel finished. One Plugins row, one switch per quality-of-life feature.",
   "keywords": [
     "dsh",