@aryacode/dsh-aryacode-polish 0.3.7 → 0.4.4

package/CHANGELOG.md

@@ -1,5 +1,94 @@
 # Changelog
 
+## [0.4.4] - 2026-10-27
+
+### Fixed
+
+- **The row reported "this Host cannot open a folder" on a Host that can.** A Remote
+  method answers an envelope — `{ ok, value }` — not the bare return value, so
+  `canOpenWorkspacePath()` never looked like `true`. The row now reads
+  `ok === true && value === true`, tolerates a plain boolean, and checks the
+  `ok` flag of the open call itself instead of trusting that no throw means opened.
+
+## [0.4.3] - 2026-10-27
+
+### Fixed
+
+- **The row still could not open anything.** 0.4.2 declared `remote.session` but the
+  guard checks each namespace on its own: reading `ctx.remote.session` needs both
+  `remote` and `remote.session` on the inject list, so the call failed one level
+  earlier. The registration now declares `['workspaces', 'remote', 'remote.session']`.
+
+## [0.4.2] - 2026-10-27
+
+### Fixed
+
+- **The row did nothing when clicked.** The Shell refuses `ctx.get('remote.session')`
+  — a Remote namespace may only be read through a declared injection — so the open
+  call failed before it reached the Host. The registration now declares
+  `ctx.inject(['workspaces', 'remote.session'], …)` and calls the namespace the
+  injected context hands it. Found by the row reporting its own failure (0.4.1).
+
+## [0.4.1] - 2026-10-27
+
+### Changed
+
+- The **Open workspace folder** row reports a failed open instead of doing nothing.
+  A menu row that silently ignores the click is impossible to diagnose in the
+  field; the bundle now writes one console.warn naming the failing step (no
+  Session Remote, a Host that cannot open a path, or the Remote error itself).
+
+## [0.4.0] - 2026-10-27
+
+### Added
+
+- **Open workspace folder.** A Session's "…" menu gains an **Open workspace folder**
+  row that opens the Session's workspace directory in Explorer/Finder through the
+  Session Remote (`openWorkspacePath`), gated by `canOpenWorkspacePath` and resolved
+  from the Workspace snapshot. New switch `openWorkspaceFolder`, on by default, and
+  the row hides itself when the Session has no workspace or the Host cannot open a
+  path.
+- `docs/workspace-folder.md` records why the requested surface — right-clicking the
+  workspace row itself — is not reachable from a plugin: that row has no context
+  menu, the workspace-scoped menu list slot does not exist, and native menus and
+  desktop IPC are closed to plugins. The bundle ships on the documented Session-row
+  slot rather than hijacking private markup, and the note says where the feature
+  should move if a workspace-scoped slot ever lands.
+
+## [0.3.9] - 2026-10-27
+
+### Changed
+
+- **The cost pill now looks like it belongs in the composer.** It was a foreign
+  widget next to the harness pills: two lines of text ("≈$0.538 partially
+  priced") in the row's flow. It now wears the same skin as the statistics pills
+  — the same 13 px-minus-one scale, 20 px line height, `1px 8px` padding, tertiary
+  label colour, tabular digits, a 14 px glyph, and `white-space: nowrap`, so it
+  reads as one line at the same size as its neighbours.
+- The "partially priced" caveat moved out of the pill and into the card, where it
+  can be read. The pill keeps a single `*` marker for the same fact.
+- The breakdown card is now the harness's own stat-dialog: same panel width
+  clamp, 16 px padding, `--dsw-radius-lg` corners, menu backdrop, prominent
+  elevation, 12/18 type, a two-column definition list with tabular figures, and
+  a portaled `position: fixed` panel measured from the pill so it cannot be
+  clipped by the composer scroller. It closes on outside click and on Escape.
+
+## [0.3.8] - 2026-10-27
+
+### Fixed
+
+- **The balance line never showed a number.** It waited for the host account
+  bundle's own access grant before reading, on the theory that the grant proves
+  the call is allowed. That grant belongs to the bundle that owns the account
+  stream, so for a plugin it can simply never arrive — the read hit its timeout,
+  resolved to nothing, and the sidebar looked empty with no error anywhere. The
+  line now reads the account Remote directly inside
+  `ctx.inject(['remote', 'remote.account'], …)`, and the Host still decides: an
+  unauthorised call comes back refused and the line stays hidden.
+- The read retries on its own (1.5 s, 5 s, 15 s, 30 s, and again whenever the
+  window regains focus), so a Shell that is still signing in at first paint no
+  longer leaves a permanently blank line.
+
 ## [0.3.7] - 2026-10-27
 
 ### Fixed

package/README.md

@@ -7,7 +7,7 @@ installed into and patches nothing. It is one package, one Plugins row, and one
 switch per feature, so a refinement that turns out to be wrong for a machine can
 be turned off without uninstalling anything.
 
-Status: **two features shipped.** The version is the package's, and the card
+Status: **three features shipped.** The version is the package's, and the card
 header already shows it.
 
 ## What it is
@@ -32,6 +32,7 @@ Configure page automatically.
 | --- | --- | --- |
 | **Estimated session cost** (`sessionCost`) | On | A `≈$0.39` pill in the composer dock that opens a breakdown card — cache hit, uncached input, cached input, output, requests, and the estimate — priced from the session's recorded usage at the published DeepSeek rates. |
 | **Account balance** (`accountBalance`) | On | The account's remaining wallet (`$17.33`) in the sidebar foot, above the account row. Renders nothing when the Host exposes no wallet, so it never shows a number nobody gave it. |
+| **Open workspace folder** (`openWorkspaceFolder`) | On | An **Open workspace folder** row in a Session's "…" menu that opens the Session's workspace in Explorer/Finder. Renders nothing when the Session has no workspace or the Host cannot open a path. See [Open a workspace folder](docs/workspace-folder.md) for why the request had to land here instead of on the workspace row itself. |
 
 ### How the cost is computed
 
@@ -130,7 +131,7 @@ client/switches.json the browser half of the seam — one entry per switch
 scripts/build-client.mjs  wraps client/face.js into lib/client.js
 lib/client.js        generated: the bundle the Shell loads
 locale/              card title and description (en, zh)
-docs/                parked investigations
+docs/                feature notes and parked investigations
 test/                node --test specs
 ```
 

package/client/account.js

@@ -1,12 +1,19 @@
 /**
  * Reading the account balance from a plugin face.
  *
- * The account Remote methods are gated, so the read runs inside a
- * `remoteAccess.whenAccess('account/watch', …)` grant and the grant is released
- * as soon as the read settles. Every failure — no service in this Shell, a
- * refused grant, a failed call — resolves to `undefined` instead of throwing: a
- * sidebar line is never worth breaking the shell over, and a line that stays
- * empty is honest about a number it never received.
+ * The account Remote methods are the same ones the shipped account row uses. An
+ * earlier version waited for the host account bundle's own access grant before
+ * reading, on the theory that the grant proves the call is allowed. It does not:
+ * that grant belongs to the bundle that owns the account stream, and a plugin
+ * that waits for it can wait forever — the sidebar line then stays empty with no
+ * error anywhere, which is exactly what a user reports as "I don't see the
+ * balance".
+ *
+ * So this reads directly. The Host still decides: an unauthorised call comes back
+ * `{ ok: false }` (or throws) and this resolves to `undefined`. Every failure — no
+ * account namespace in this Shell, a refused call, a failed call — resolves to
+ * `undefined` instead of throwing, because a sidebar line is never worth breaking
+ * the shell over.
  *
  * This module is inlined into `lib/client.js` by `scripts/build-client.mjs` and
  * imported directly by `test/account.spec.mjs`, so the tested source is the one
@@ -35,62 +42,48 @@ export function clientMetadata(version) {
 }
 
 /**
- * Build the one-shot balance reader.
+ * The account Remote namespace, or undefined when this Shell has none.
  *
- * @param ctx - the browser plugin context; `ctx.get` resolves an optional service.
- * @param version - the version this build stamps into the account metadata.
- * @returns a reader that resolves to the balance view, or undefined when unavailable.
+ * @param ctx - the browser plugin context; the balance surface is registered
+ *   inside `ctx.inject(['remote', 'remote.account'], …)` so this normally resolves.
+ * @returns the namespace, or undefined.
  */
-export function makeBalanceReader(ctx, version, { timeoutMs = 10000 } = {}) {
-  const service = name => {
-    try {
-      return ctx.get(name)
-    } catch {
-      return undefined
-    }
+export function accountService(ctx) {
+  try {
+    const remote = ctx.remote !== undefined ? ctx.remote : ctx.get('remote')
+    const account = remote !== undefined && remote !== null ? remote.account : undefined
+    return account !== undefined && account !== null && typeof account.getBalance === 'function' ? account : undefined
+  } catch {
+    return undefined
   }
-  return async () => {
-    const access = service('remoteAccess')
-    const remote = service('remote')
-    if (access === undefined || remote === undefined) return undefined
-    const metadata = clientMetadata(version)
-    return await new Promise(resolve => {
-      let settled = false
-      let stop
-      const timer = setTimeout(() => finish(undefined), timeoutMs)
-      const finish = value => {
-        if (settled) return
-        settled = true
-        clearTimeout(timer)
-        resolve(value)
-        if (typeof stop === 'function') {
-          try {
-            stop()
-          } catch {
-            /* the grant may already have been released */
-          }
-        }
-      }
-      // The read starts before the yield so an effect runner that stops at the
-      // first yielded disposer still performs the call.
-      stop = access.whenAccess('account/watch', function* () {
-        void (async () => {
-          try {
-            const result = await remote.account.getBalance(metadata)
-            const value = result !== undefined && result.ok === true ? result.value : undefined
-            finish(value !== undefined && value.status === 'ready' ? value : undefined)
-          } catch {
-            finish(undefined)
-          }
-        })()
-        yield () => {
-          if (!settled) {
-            settled = true
-            clearTimeout(timer)
-            resolve(undefined)
-          }
-        }
-      })
-    })
+}
+
+/**
+ * Read the balance once.
+ *
+ * @param ctx - the browser plugin context.
+ * @param version - the version this build stamps into the account metadata.
+ * @param options - `timeoutMs` bounds a call that never settles.
+ * @returns the ready balance view, or undefined when there is no number to show.
+ */
+export async function readBalance(ctx, version, { timeoutMs = 15000 } = {}) {
+  const account = accountService(ctx)
+  if (account === undefined) return undefined
+  const call = (async () => {
+    const result = await account.getBalance(clientMetadata(version))
+    if (result === undefined || result === null || result.ok !== true) return undefined
+    const value = result.value
+    return value !== undefined && value !== null && value.status === 'ready' ? value : undefined
+  })().catch(() => undefined)
+  let timer
+  const timeout = new Promise(resolve => {
+    timer = setTimeout(() => resolve(undefined), timeoutMs)
+    // A pending balance read must not keep a Node process alive during tests.
+    if (typeof timer === 'object' && timer !== null && typeof timer.unref === 'function') timer.unref()
+  })
+  try {
+    return await Promise.race([call, timeout])
+  } finally {
+    clearTimeout(timer)
   }
 }