@artymclabin/qa-review 0.3.11 → 0.3.12

package/dist/client/fingerprint.d.ts

@@ -5,9 +5,24 @@ export declare function normalizeText(text: string): string;
 export declare function fingerprintText(text: string): string;
 /**
  * Fingerprint the CURRENT content of an item: anchored items hash the
- * element's rendered innerText; off-DOM task items hash their question text
- * (sub, falling back to title). Returns null when the anchor is not present
- * (e.g. other-viewport element) - no judgement is made then.
+ * element's textContent; off-DOM task items hash their question text (sub,
+ * falling back to title). Returns null when the anchor is not present (e.g.
+ * other-viewport element) - no judgement is made then.
+ *
+ * 🚨 textContent, NEVER innerText (Arty 2026-09-24, GameReady fundraise FAQ).
+ * innerText is spec'd to approximate what a user currently SEES, so it
+ * excludes anything not laid out - which includes the body of a closed
+ * native `<details>`. Every accordion-style FAQ defaults to collapsed, so an
+ * anchor on the answer paragraph inside it fingerprinted ONLY the always-
+ * visible summary/question text forever, regardless of how the answer was
+ * edited. "NOT ALTERED since your rejection" then showed on an item that
+ * had, in fact, been fixed the same day it was rejected - the exact
+ * regression this poka-yoke exists to prevent, silently defeated by the one
+ * DOM shape (collapsed accordion) FAQ content overwhelmingly uses. textContent
+ * does not care about layout/visibility, which is what "did the words
+ * change" actually needs - this was invisible in tests because jsdom does
+ * not implement `<details>` collapse or innerText's visibility semantics at
+ * all, so the bug could only ever surface against a real rendered page.
  */
 export declare function itemFingerprint(item: QAReviewItem, doc: Document): string | null;
 export type FingerprintStatus = "unchanged" | "changed";

package/dist/client/fingerprint.js

@@ -16,9 +16,24 @@ export function fingerprintText(text) {
 }
 /**
  * Fingerprint the CURRENT content of an item: anchored items hash the
- * element's rendered innerText; off-DOM task items hash their question text
- * (sub, falling back to title). Returns null when the anchor is not present
- * (e.g. other-viewport element) - no judgement is made then.
+ * element's textContent; off-DOM task items hash their question text (sub,
+ * falling back to title). Returns null when the anchor is not present (e.g.
+ * other-viewport element) - no judgement is made then.
+ *
+ * 🚨 textContent, NEVER innerText (Arty 2026-09-24, GameReady fundraise FAQ).
+ * innerText is spec'd to approximate what a user currently SEES, so it
+ * excludes anything not laid out - which includes the body of a closed
+ * native `<details>`. Every accordion-style FAQ defaults to collapsed, so an
+ * anchor on the answer paragraph inside it fingerprinted ONLY the always-
+ * visible summary/question text forever, regardless of how the answer was
+ * edited. "NOT ALTERED since your rejection" then showed on an item that
+ * had, in fact, been fixed the same day it was rejected - the exact
+ * regression this poka-yoke exists to prevent, silently defeated by the one
+ * DOM shape (collapsed accordion) FAQ content overwhelmingly uses. textContent
+ * does not care about layout/visibility, which is what "did the words
+ * change" actually needs - this was invisible in tests because jsdom does
+ * not implement `<details>` collapse or innerText's visibility semantics at
+ * all, so the bug could only ever surface against a real rendered page.
  */
 export function itemFingerprint(item, doc) {
     if (!item.selector)
@@ -26,7 +41,7 @@ export function itemFingerprint(item, doc) {
     const el = doc.querySelector(item.selector);
     if (!el)
         return null;
-    return fingerprintText(el.innerText ?? el.textContent ?? "");
+    return fingerprintText(el.textContent ?? "");
 }
 /**
  * Compare the fingerprint STORED with the last verdict against the current

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@artymclabin/qa-review",
-  "version": "0.3.11",
+  "version": "0.3.12",
   "description": "Interactive on-page QA review overlay (spotlight walkthrough, approve/reject verdict ledger) with a framework-agnostic server handler factory and a self-provisioning Postgres store.",
   "license": "MIT",
   "repository": {