@artifactly/mcp 0.1.6 → 0.1.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@artifactly/mcp",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "private": false,
   "files": [
     "bin",

package/src/mcp/artifactly-mcp.test.ts

@@ -48,6 +48,48 @@ describe("Artifactly MCP tools", () => {
     rmSync(dir, { recursive: true, force: true });
   });
 
+  it("can validate auth status against the Artifactly API", async () => {
+    const dir = mkdtempSync(join(tmpdir(), "artifactly-mcp-"));
+    const credentialPath = join(dir, "credentials.json");
+    const requests: Array<{ method: string; path: string; apiKey?: string }> = [];
+    writeCredentials(
+      {
+        apiBaseUrl: "https://artifactly.example",
+        apiKey: "art_test_secret",
+        email: "agent@example.com",
+        workspace: "agent",
+      },
+      credentialPath,
+    );
+
+    await expect(
+      callArtifactlyMcpTool({
+        name: "artifactly_auth_status",
+        credentialPath,
+        arguments: { validate: true },
+        requestJson: async (method, path, _body, options) => {
+          requests.push({ method, path, apiKey: options?.apiKey });
+          return { artifacts: [] };
+        },
+      }),
+    ).resolves.toMatchObject({
+      authenticated: true,
+      serverAuthenticated: true,
+      validationError: null,
+    });
+    expect(requests).toEqual([
+      { method: "GET", path: "/api/artifacts", apiKey: "art_test_secret" },
+    ]);
+
+    rmSync(dir, { recursive: true, force: true });
+  });
+
+  it("gives complete login guidance when protected tools lack credentials", async () => {
+    await expect(
+      callArtifactlyMcpTool({ name: "artifactly_list_artifacts", credentialPath: "/tmp/nope.json" }),
+    ).rejects.toThrow(/artifactly_request_login_code[\s\S]*artifactly_verify_login_code/);
+  });
+
   it("logs out by clearing the shared credential store", async () => {
     const dir = mkdtempSync(join(tmpdir(), "artifactly-mcp-"));
     const credentialPath = join(dir, "credentials.json");
@@ -252,4 +294,28 @@ describe("Artifactly MCP tools", () => {
     ]);
     rmSync(dir, { recursive: true, force: true });
   });
+
+  it("returns a friendly error when publishing a missing file", async () => {
+    const dir = mkdtempSync(join(tmpdir(), "artifactly-mcp-"));
+    const credentialPath = join(dir, "credentials.json");
+    writeCredentials(
+      {
+        apiBaseUrl: "https://artifactly.example",
+        apiKey: "art_test_secret",
+        email: "agent@example.com",
+        workspace: "agent",
+      },
+      credentialPath,
+    );
+
+    await expect(
+      callArtifactlyMcpTool({
+        name: "artifactly_publish_file",
+        credentialPath,
+        arguments: { path: join(dir, "missing.pdf") },
+      }),
+    ).rejects.toThrow(/File not found.*missing\.pdf/);
+
+    rmSync(dir, { recursive: true, force: true });
+  });
 });

package/src/mcp/artifactly-mcp.ts

@@ -65,6 +65,14 @@ function stringArg(
   return typeof value === "string" && value.trim() ? value.trim() : undefined;
 }
 
+function optionalStringArg(
+  args: Record<string, unknown> | undefined,
+  key: string,
+): string | undefined {
+  const value = args?.[key];
+  return typeof value === "string" ? value.trim() : undefined;
+}
+
 function requireStringArg(
   args: Record<string, unknown> | undefined,
   key: string,
@@ -94,6 +102,28 @@ function objectResult(value: unknown): Record<string, unknown> {
   return value as Record<string, unknown>;
 }
 
+const LOGIN_GUIDANCE =
+  "Artifactly credentials are not configured. Run artifactly_request_login_code first, then run artifactly_verify_login_code with the emailed code.";
+
+function booleanArg(args: Record<string, unknown> | undefined, key: string): boolean {
+  return args?.[key] === true;
+}
+
+function readFileForPublish(path: string): Buffer {
+  try {
+    return readFileSync(path);
+  } catch (error) {
+    const code = typeof error === "object" && error && "code" in error ? String(error.code) : "";
+    if (code === "ENOENT") {
+      throw new Error(`File not found: ${path}`);
+    }
+    if (code === "EACCES" || code === "EPERM") {
+      throw new Error(`File is not readable: ${path}`);
+    }
+    throw error;
+  }
+}
+
 function titleFromPath(path: string): string {
   const name = basename(path, extname(path));
   return name || "artifact";
@@ -123,7 +153,7 @@ export function listArtifactlyMcpTools(): ArtifactlyMcpTool[] {
     {
       name: "artifactly_auth_status",
       description: "Check whether local Artifactly credentials are configured.",
-      inputSchema: { type: "object", properties: {} },
+      inputSchema: { type: "object", properties: { validate: { type: "boolean" } } },
     },
     {
       name: "artifactly_request_login_code",
@@ -227,14 +257,29 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
   const requestJson = input.requestJson ?? createDefaultRequestJson(apiBaseUrl);
 
   if (input.name === "artifactly_auth_status") {
-    return credentials
-      ? {
-          authenticated: true,
-          apiBaseUrl: credentials.apiBaseUrl,
-          email: credentials.email,
-          workspace: credentials.workspace,
-        }
-      : { authenticated: false, apiBaseUrl };
+    if (!credentials) {
+      return { authenticated: false, apiBaseUrl };
+    }
+
+    const result: Record<string, unknown> = {
+      authenticated: true,
+      apiBaseUrl: credentials.apiBaseUrl,
+      email: credentials.email,
+      workspace: credentials.workspace,
+    };
+
+    if (booleanArg(input.arguments, "validate")) {
+      try {
+        await requestJson("GET", "/api/artifacts", undefined, { apiKey: credentials.apiKey });
+        result.serverAuthenticated = true;
+        result.validationError = null;
+      } catch (error) {
+        result.serverAuthenticated = false;
+        result.validationError = error instanceof Error ? error.message : "Validation failed";
+      }
+    }
+
+    return result;
   }
 
   if (input.name === "artifactly_request_login_code") {
@@ -280,7 +325,7 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
 
   if (input.name === "artifactly_publish_markdown") {
     if (!credentials) {
-      throw new Error("Artifactly credentials are not configured. Run artifactly_request_login_code first.");
+      throw new Error(LOGIN_GUIDANCE);
     }
     const title = requireStringArg(input.arguments, "title");
     const content = requireStringArg(input.arguments, "markdown");
@@ -296,14 +341,14 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
 
   if (input.name === "artifactly_list_artifacts") {
     if (!credentials) {
-      throw new Error("Artifactly credentials are not configured. Run artifactly_request_login_code first.");
+      throw new Error(LOGIN_GUIDANCE);
     }
     return objectResult(await requestJson("GET", "/api/artifacts", undefined, { apiKey: credentials.apiKey }));
   }
 
   if (input.name === "artifactly_get_artifact") {
     if (!credentials) {
-      throw new Error("Artifactly credentials are not configured. Run artifactly_request_login_code first.");
+      throw new Error(LOGIN_GUIDANCE);
     }
     const artifactId = requireStringArg(input.arguments, "artifactId");
     return objectResult(await requestJson("GET", `/api/artifacts/${artifactId}`, undefined, { apiKey: credentials.apiKey }));
@@ -311,13 +356,13 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
 
   if (input.name === "artifactly_update_artifact") {
     if (!credentials) {
-      throw new Error("Artifactly credentials are not configured. Run artifactly_request_login_code first.");
+      throw new Error(LOGIN_GUIDANCE);
     }
     const artifactId = requireStringArg(input.arguments, "artifactId");
     const title = stringArg(input.arguments, "title");
     const markdown = stringArg(input.arguments, "markdown");
     const content = stringArg(input.arguments, "content");
-    const description = stringArg(input.arguments, "description");
+    const description = optionalStringArg(input.arguments, "description");
     const visibility = stringArg(input.arguments, "visibility");
     const accessList = stringArrayArg(input.arguments, "accessList");
     return objectResult(
@@ -328,7 +373,7 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
           ...(title ? { title } : {}),
           ...(markdown ? { markdown } : {}),
           ...(content ? { content } : {}),
-          ...(description ? { description } : {}),
+          ...(description !== undefined ? { description } : {}),
           ...(visibility ? { visibility } : {}),
           ...(accessList ? { accessList } : {}),
         },
@@ -339,7 +384,7 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
 
   if (input.name === "artifactly_delete_artifact") {
     if (!credentials) {
-      throw new Error("Artifactly credentials are not configured. Run artifactly_request_login_code first.");
+      throw new Error(LOGIN_GUIDANCE);
     }
     const artifactId = requireStringArg(input.arguments, "artifactId");
     return objectResult(await requestJson("DELETE", `/api/artifacts/${artifactId}`, undefined, { apiKey: credentials.apiKey }));
@@ -347,14 +392,14 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
 
   if (input.name === "artifactly_publish_file") {
     if (!credentials) {
-      throw new Error("Artifactly credentials are not configured. Run artifactly_request_login_code first.");
+      throw new Error(LOGIN_GUIDANCE);
     }
     const path = requireStringArg(input.arguments, "path");
     const title = stringArg(input.arguments, "title") ?? titleFromPath(path);
     const mimeType = stringArg(input.arguments, "mimeType") ?? inferMimeType(path);
     const visibility = stringArg(input.arguments, "visibility") ?? "unlisted";
     const kind = kindForMime(path, mimeType);
-    const file = readFileSync(path);
+    const file = readFileForPublish(path);
     const payload =
       kind === "file"
         ? {