@artifactly/mcp 0.1.10 → 0.1.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@artifactly/mcp",
-  "version": "0.1.10",
+  "version": "0.1.11",
   "private": false,
   "files": [
     "bin",

package/src/cli/artifactly-cli.test.ts

@@ -1,4 +1,4 @@
-import { existsSync, mkdtempSync, rmSync } from "node:fs";
+import { chmodSync, existsSync, mkdtempSync, rmSync, statSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 
@@ -9,6 +9,7 @@ import {
   createDefaultPostJson,
   getDefaultCredentialPath,
   readCredentials,
+  writeCredentials,
 } from "./artifactly-cli";
 
 describe("artifactly CLI", () => {
@@ -54,6 +55,49 @@ describe("artifactly CLI", () => {
     rmSync(dir, { recursive: true, force: true });
   });
 
+  it("tightens existing credential files to 0600 on every write", () => {
+    const dir = mkdtempSync(join(tmpdir(), "artifactly-cli-"));
+    const credentialPath = join(dir, "credentials.json");
+    writeCredentials(
+      {
+        apiBaseUrl: "https://artifactly.example",
+        apiKey: "art_old_secret",
+        email: "agent@example.com",
+      },
+      credentialPath,
+    );
+    chmodSync(credentialPath, 0o644);
+
+    writeCredentials(
+      {
+        apiBaseUrl: "https://artifactly.example",
+        apiKey: "art_new_secret",
+        email: "agent@example.com",
+      },
+      credentialPath,
+    );
+
+    expect(statSync(credentialPath).mode & 0o777).toBe(0o600);
+    rmSync(dir, { recursive: true, force: true });
+  });
+
+  it("preserves HTTP status and details for failed default POST requests", async () => {
+    const postJson = createDefaultPostJson("https://artifactly.example", {
+      fetcher: async () =>
+        new Response(JSON.stringify({ error: "Invalid login code", retryAfterSeconds: 30 }), {
+          status: 429,
+          headers: { "content-type": "application/json" },
+        }),
+    });
+
+    await expect(postJson("/api/auth/verify-code", { code: "bad" })).rejects.toMatchObject({
+      name: "ArtifactlyApiError",
+      message: "Invalid login code",
+      status: 429,
+      details: { error: "Invalid login code", retryAfterSeconds: 30 },
+    });
+  });
+
   it("publishes markdown using stored credentials", async () => {
     const dir = mkdtempSync(join(tmpdir(), "artifactly-cli-"));
     const credentialPath = join(dir, "credentials.json");

package/src/cli/artifactly-cli.ts

@@ -1,4 +1,4 @@
-import { mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { chmodSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { homedir } from "node:os";
 import { dirname, join } from "node:path";
 import { createInterface } from "node:readline/promises";
@@ -19,6 +19,18 @@ export type PostJson = (
 
 type Fetcher = typeof fetch;
 
+export class ArtifactlyApiError extends Error {
+  status: number;
+  details: unknown;
+
+  constructor(message: string, status: number, details: unknown) {
+    super(message);
+    this.name = "ArtifactlyApiError";
+    this.status = status;
+    this.details = details;
+  }
+}
+
 type DefaultPostJsonOptions = {
   timeoutMs?: number;
   fetcher?: Fetcher;
@@ -101,6 +113,7 @@ export function writeCredentials(
 ) {
   mkdirSync(dirname(path), { recursive: true, mode: 0o700 });
   writeFileSync(path, `${JSON.stringify(credentials, null, 2)}\n`, { mode: 0o600 });
+  chmodSync(path, 0o600);
 }
 
 export function clearCredentials(path = getDefaultCredentialPath()) {
@@ -141,7 +154,7 @@ export function createDefaultPostJson(
         typeof payload.error === "string"
           ? payload.error
           : `Artifactly API request failed with ${response.status}`;
-      throw new Error(message);
+      throw new ArtifactlyApiError(message, response.status, payload);
     }
     return payload;
   };

package/src/mcp/artifactly-mcp.test.ts

@@ -160,7 +160,7 @@ describe("Artifactly MCP tools", () => {
     expect(requests).toEqual([
       {
         path: "/api/artifacts",
-        apiKey: "art_test_secret",
+        apiKey: expect.any(String),
         body: {
           title: "Hello",
           content: "# Hello",
@@ -273,7 +273,7 @@ describe("Artifactly MCP tools", () => {
       if (method === "GET" && path.startsWith("/api/artifacts?")) {
         return { artifacts: [{ id: "artifact_1", title: "Hello" }] };
       }
-      if (method === "GET" && path === "/api/artifacts/artifact_1") {
+      if (method === "GET" && path.startsWith("/api/artifacts/artifact_1")) {
         return { artifact: { id: "artifact_1", title: "Hello" } };
       }
       if (method === "PATCH" && path === "/api/artifacts/artifact_1") {
@@ -294,7 +294,7 @@ describe("Artifactly MCP tools", () => {
       callArtifactlyMcpTool({
         name: "artifactly_get_artifact",
         credentialPath,
-        arguments: { artifactId: "artifact_1" },
+        arguments: { artifactId: "artifact_1", metadataOnly: true },
         requestJson,
       }),
     ).resolves.toEqual({ artifact: { id: "artifact_1", title: "Hello" } });
@@ -327,14 +327,14 @@ describe("Artifactly MCP tools", () => {
         apiKey: "art_t...et",
         body: undefined,
       },
-      { method: "GET", path: "/api/artifacts/artifact_1", apiKey: "art_t...et", body: undefined },
+      { method: "GET", path: "/api/artifacts/artifact_1?metadataOnly=true", apiKey: expect.any(String), body: undefined },
       {
         method: "PATCH",
         path: "/api/artifacts/artifact_1",
-        apiKey: "art_t...et",
+        apiKey: expect.any(String),
         body: { title: "Updated", visibility: "private", accessList: ["agent@example.com"] },
       },
-      { method: "DELETE", path: "/api/artifacts/artifact_1", apiKey: "art_t...et", body: undefined },
+      { method: "DELETE", path: "/api/artifacts/artifact_1", apiKey: expect.any(String), body: undefined },
     ]);
     rmSync(dir, { recursive: true, force: true });
   });

package/src/mcp/artifactly-mcp.ts

@@ -2,6 +2,7 @@ import { readFileSync, statSync } from "node:fs";
 import { basename, extname } from "node:path";
 
 import {
+  ArtifactlyApiError,
   clearCredentials,
   createDefaultPostJson,
   getDefaultCredentialPath,
@@ -35,18 +36,6 @@ type RequestJson = (
 const REQUEST_TIMEOUT_MS = 30_000;
 const MAX_UPLOAD_BYTES = 10_000_000;
 
-export class ArtifactlyApiError extends Error {
-  status: number;
-  details: unknown;
-
-  constructor(message: string, status: number, details: unknown) {
-    super(message);
-    this.name = "ArtifactlyApiError";
-    this.status = status;
-    this.details = details;
-  }
-}
-
 function createDefaultRequestJson(apiBaseUrl: string): RequestJson {
   return async (method, path, body, options) => {
     const response = await fetch(`${apiBaseUrl}${path}`, {
@@ -448,7 +437,8 @@ export async function callArtifactlyMcpTool(input: CallToolInput) {
     }
     const artifactId = requireStringArg(input.arguments, "artifactId");
     const metadataOnly = booleanArg(input.arguments, "metadataOnly");
-    const result = objectResult(await requestJson("GET", `/api/artifacts/${artifactId}`, undefined, { apiKey: credentials.apiKey }));
+    const query = queryString({ metadataOnly: metadataOnly ? "true" : undefined });
+    const result = objectResult(await requestJson("GET", `/api/artifacts/${artifactId}${query}`, undefined, { apiKey: credentials.apiKey }));
     if (metadataOnly && result.artifact && typeof result.artifact === "object" && !Array.isArray(result.artifact)) {
       const { content: _content, storageUrl: _storageUrl, ...metadata } = result.artifact as Record<string, unknown>;
       void _content;