@artblocks/abx-cli 0.1.0-alpha.2 → 0.1.0-alpha.3

package/dist/main.js

@@ -134,7 +134,7 @@ async function maybeNotifyUpdate(flags) {
         const latest = await checkForCliUpdate(current);
         if (latest) {
             console.error(`\n    ${c.orange}⚠${c.reset}  update available: ${bold('abx')} ${dim(current)} → ${g(latest)}\n` +
-                `       upgrade: ${g('npm i -g @artblocks/abx-cli@latest')} ${dim('· or invoke:')} ${g('npx abx@latest <command>')}\n` +
+                `       upgrade: ${g('npm i -g @artblocks/abx-cli@latest')} ${dim('· or invoke:')} ${g('npx @artblocks/abx-cli@latest <command>')}\n` +
                 `       release notes: https://github.com/ArtBlocks/abx/releases ${dim('· silence: ABX_NO_UPDATE_CHECK=1')}\n`);
         }
     }
@@ -4167,114 +4167,109 @@ async function cmdMigrate(address, flags) {
 }
 // ── doctor ────────────────────────────────────────────────────────────────--
 async function cmdDoctor(flags) {
-    console.log(bold('\n  abx doctor\n'));
-    const check = (label, pass, detail = '') => console.log(`  ${pass ? g('✓') : `${c.red}✗${c.reset}`} ${label}${detail ? dim('  ' + detail) : ''}`);
+    console.log(bold('\n  abx doctor') + dim(`  ·  ${CHAIN}`) + '\n');
+    // Two visual tiers: PASS/FAIL checks (✓/✗) for things that are either working or broken, and an
+    // "Optional" block (·) for path-dependent setup that is fine to be unset. We deliberately do NOT
+    // use ⚠ for "unset but often fine" — that read as noise; ⚠ is reserved for a real gotcha (a
+    // range-capped RPC). Labels are padded so both tiers align.
+    const CONT = ' '.repeat(17); // continuation indent: aligns under a check/opt detail column
+    const check = (label, pass, detail = '') => console.log(`  ${pass ? g('✓') : `${c.red}✗${c.reset}`} ${label.padEnd(13)}${detail ? dim(detail) : ''}`);
+    const opt = (label, detail) => console.log(`  ${dim('·')} ${label.padEnd(13)}${dim(detail)}`);
     const hasKey = !!(process.env.ABX_DEPLOYER_PK ?? process.env.SEPOLIA_FUNDED_PK ?? process.env.SEPOLIA_WALLET_PK);
-    // Not having an env key is NOT fatal: the wallet lane (`--sign`) signs in the user's own wallet,
-    // key-free. Only flag it as a soft note + point at the lanes — never imply "paste a private key."
-    if (hasKey)
-        check('signing key in env', true, 'hot lane ready (env key signs unattended)');
-    else
-        console.log(`  ${c.orange}⚠${c.reset} signing key in env${dim('  none — fine if you sign in your own wallet (`--sign`; the key never touches the CLI). Only set ABX_DEPLOYER_PK / SEPOLIA_FUNDED_PK / SEPOLIA_WALLET_PK for hot/unattended signing.')}`);
+    // 1. Agent skill — FIRST and prominent. The primary way to use abx is to let a coding agent drive
+    //    it, so a missing/stale skill is a ✗: not broken infra, but the main UX isn't set up. Its
+    //    version lives in SKILL.md frontmatter (version-locked to this CLI). Notify-only — no exit code.
+    const cliVersion = readCliVersion();
+    const skillVersions = installedSkillVersions();
+    const staleSkills = skillVersions.filter((v) => compareVersions(cliVersion, v) > 0);
+    if (skillVersions.length === 0) {
+        check('agent skill', false, `not installed — run ${g('abx skill install')}`);
+        console.log(`${CONT}${dim('(recommended: let a coding agent drive abx)')}`);
+    }
+    else if (staleSkills.length > 0) {
+        check('agent skill', false, `v${staleSkills.join(', v')} behind CLI v${cliVersion} — run ${g('abx skill install')}`);
+    }
+    else {
+        check('agent skill', true, `in sync (v${cliVersion})`);
+    }
+    console.log('');
+    // 2. Core environment (✓/✗). Signing-wallet balances are computed here (they need the RPC) but
+    //    printed in the Optional block below, so buffer them.
+    let signingOpt = null;
+    let forOpt = null;
     try {
         const publicClient = makePublicClient({ chainKey: CHAIN });
         const bn = await publicClient.getBlockNumber();
-        check(`RPC reachable (${CHAIN})`, true, `head block ${bn}`);
-        // RPC endpoints — probe each for reachability, getLogs range, and archive depth,
-        // so the toolkit uses (and recommends) the one fit for the job — and says so if none are.
+        // Collapse the RPC report to one line (best endpoint + head), and only add a ⚠ when there is a
+        // genuine problem — a range-capped-only set that will grind a resolver under load.
         const probes = await probeRpcEndpoints({ chainKey: CHAIN });
         const usable = probes.filter((pr) => pr.verdict !== 'unusable');
         const best = probes.find((pr) => pr.verdict === 'best') ?? usable[0];
-        check(`RPC endpoints for ${CHAIN} (${probes.length})`, usable.length > 0, usable.length > 0
-            ? `best for reconstruction: ${best.label} (${best.verdict === 'best' ? 'wide range + archive' : 'usable, range-capped'})`
-            : 'none usable for reconstruction');
-        for (const pr of probes) {
-            const glyph = pr.verdict === 'best' ? g('✓') : pr.verdict === 'capped' ? `${c.orange}⚠${c.reset}` : `${c.red}✗${c.reset}`;
-            console.log(`      ${glyph} ${pr.label} ${dim('— ' + (pr.verdict === 'best' ? 'wide getLogs range + archive' : pr.reason ?? pr.verdict))}`);
-        }
-        if (usable.length === 0) {
-            console.log(`  ${c.orange}↳${c.reset} ${dim('research a current free archive RPC with a wide getLogs range and add it to ABX_RPC_URLS — see the skill’s “Choosing an RPC”')}`);
-        }
-        else if (!probes.some((pr) => pr.verdict === 'best')) {
-            // Every usable endpoint is range-capped. Indexing still works (chunking), but a first
-            // reconstruction — and a resolver under marketplace load — is slow + rate-limit-prone. That's
-            // a serious infra signal, NOT "a paid plan is required": flag it. A normal deploy→index only
-            // scans from the deploy block, so this bites first reconstructions and busy resolvers most.
-            console.log(`  ${c.orange}⚠ every usable RPC is getLogs-range-capped${c.reset} ${dim('— add a wide-range archive endpoint to ABX_RPC_URLS before running a resolver under load; capped ones grind on wide scans (skill → “Choosing an RPC”).')}`);
-        }
-        if (hasKey) {
-            const { account } = makeWalletClient({ chainKey: CHAIN });
-            const bal = await publicClient.getBalance({ address: account.address });
-            check('deployer funded', bal > 0n, `${account.address} · ${formatEther(bal)} ETH`);
-        }
-        // Wallet lane has no env key — let a creator preflight THEIR OWN signing wallet's balance,
-        // the one gap where an unfunded wallet otherwise only surfaces at the signing step.
-        if (flags.for) {
-            const bal = await publicClient.getBalance({ address: flags.for });
-            check('wallet funded (--for)', bal > 0n, `${flags.for} · ${formatEther(bal)} ETH${bal > 0n ? '' : ` — ${faucetHint(CHAIN)}`}`);
+        if (usable.length > 0) {
+            check('RPC', true, `${best.label} · head ${bn} · ${best.verdict === 'best' ? 'wide range + archive' : 'range-capped'}`);
+            if (!probes.some((pr) => pr.verdict === 'best')) {
+                console.log(`${CONT}${c.orange}⚠${c.reset}${dim(' every endpoint is getLogs-range-capped — add a wide-range archive RPC to ABX_RPC_URLS before running a resolver under load')}`);
+            }
         }
-        else if (!hasKey) {
-            console.log(`  ${dim('↳ wallet lane: run `abx doctor --for 0x<your wallet>` to check your signing wallet is funded')}`);
+        else {
+            check('RPC', false, `${CHAIN} — no endpoint usable for reconstruction; add a wide-range archive RPC to ABX_RPC_URLS`);
         }
         const factory = factoryAddress();
         if (factory) {
             const code = await publicClient.getCode({ address: factory });
-            if (!code || code === '0x') {
-                check('canonical factory deployed', false, `${factory} — no code on ${CHAIN}; \`abx deploy\` redeploys`);
-            }
-            else if (await isCurrentFactory(publicClient, factory)) {
-                check('canonical factory deployed', true, factory);
-            }
-            else {
-                check('canonical factory deployed', false, `${factory} — older/incompatible version; \`abx deploy\` redeploys`);
-            }
+            if (!code || code === '0x')
+                check('factory', false, `${factory} — no code on ${CHAIN}; \`abx deploy\` redeploys`);
+            else if (await isCurrentFactory(publicClient, factory))
+                check('factory', true, factory);
+            else
+                check('factory', false, `${factory} — older/incompatible; \`abx deploy\` redeploys`);
         }
         else {
-            check('canonical factory deployed', false, 'none yet — `abx demo` deploys one');
+            check('factory', false, 'none yet — `abx demo` deploys one');
+        }
+        if (hasKey) {
+            const { account } = makeWalletClient({ chainKey: CHAIN });
+            const bal = await publicClient.getBalance({ address: account.address });
+            signingOpt = `env key ${account.address} · ${bal > 0n ? `funded ${formatEther(bal)} ETH` : `empty — fund it (${faucetHint(CHAIN)})`}`;
+        }
+        if (flags.for) {
+            const bal = await publicClient.getBalance({ address: flags.for });
+            forOpt = `${flags.for} · ${bal > 0n ? `funded ${formatEther(bal)} ETH` : `empty — ${faucetHint(CHAIN)}`}`;
         }
     }
     catch (err) {
-        check('RPC reachable', false, err.message);
+        check('RPC', false, err.message);
     }
-    // public base URL — baked into on-chain URIs at deploy; unset is fine for a demo
-    // but a silent footgun for a real launch, so surface it explicitly.
-    const baseUrl = process.env.ABX_PUBLIC_BASE_URL;
-    if (baseUrl)
-        check('public base URL set (baked into on-chain URIs)', true, baseUrl);
-    else
-        console.log(`  ${c.orange}⚠${c.reset} public base URL${dim('  ABX_PUBLIC_BASE_URL unset → resolver-served deploys REFUSE (localhost on-chain resolves for no one). Set it (or --public-base-url) for a hosted resolver. IRRELEVANT if you go fully on-chain: --onchain-image (1/1) or --onchain-uri (code project) bake no resolver base.')}`);
     // storage backend — resolve it (catches missing config), then probe liveness/creds
     const backendId = activeBackendId();
     try {
         const backend = resolveBackend(storageOptions());
         const h = await backend.health?.();
         if (h)
-            check(`storage backend '${backend.id}' reachable`, h.ok, h.detail ?? '');
+            check('storage', h.ok, `${backend.id} · ${h.detail ?? ''}`);
         else
-            check(`storage backend '${backend.id}' configured`, true);
+            check('storage', true, `${backend.id} · configured`);
     }
     catch (err) {
-        check(`storage backend '${backendId}' configured`, false, err.message);
+        check('storage', false, `${backendId} · ${err.message}`);
     }
-    // Managed Turbo/Arweave key — if it exists, it holds prepaid credits, so remind them to back it up.
+    // 3. Optional — path-dependent setup. Unset is fine; these say WHEN you'll need each, so an unset
+    //    value never reads as a warning.
+    console.log(`\n  ${dim('Optional — depends how you deploy:')}`);
+    if (signingOpt)
+        opt('signing', signingOpt);
+    else
+        opt('signing', 'no env key → sign in your browser wallet (--sign). Preflight yours: `abx doctor --for 0x<addr>`. Set ABX_DEPLOYER_PK for the unattended hot lane.');
+    if (forOpt)
+        opt('wallet --for', forOpt);
+    const baseUrl = process.env.ABX_PUBLIC_BASE_URL;
+    if (baseUrl)
+        opt('resolver URL', baseUrl);
+    else
+        opt('resolver URL', 'ABX_PUBLIC_BASE_URL unset → needed for off-chain/resolver-served deploys; skip if fully on-chain (--onchain-image / --onchain-uri).');
     if (!process.env.ARWEAVE_JWK && existsSync(arweaveKeyFilePath())) {
         const jwk = loadArweaveJwk();
-        console.log(`  ${dim('↳ Turbo/Arweave key ' + (jwk ? arweaveAddress(jwk) + ' ' : '') + 'holds your upload credits — back it up: `abx storage backup-key --out <path>`')}`);
-    }
-    // Agent skill co-versioning — the skill drives this CLI and is version-locked to it (its version
-    // lives in SKILL.md frontmatter). Report any installed copy and flag drift; notify-only, so a
-    // stale/absent skill never fails doctor (`abx skill install` resyncs).
-    const cliVersion = readCliVersion();
-    const skillVersions = installedSkillVersions();
-    const staleSkills = skillVersions.filter((v) => compareVersions(cliVersion, v) > 0);
-    if (skillVersions.length === 0) {
-        console.log(`  ${dim('↳ agent skill: not installed here — `abx skill install` so a coding agent can drive abx')}`);
-    }
-    else if (staleSkills.length > 0) {
-        console.log(`  ${c.orange}⚠${c.reset} agent skill behind CLI${dim(`  installed v${staleSkills.join(', v')} · CLI v${cliVersion} — refresh: `)}${g('abx skill install')}`);
-    }
-    else {
-        check(`agent skill in sync (v${cliVersion})`, true);
+        opt('arweave key', `${jwk ? arweaveAddress(jwk) + ' ' : ''}holds upload credits — back it up: \`abx storage backup-key --out <path>\``);
     }
     console.log('');
 }