@arsedizioni/ars-utils 22.0.46 → 22.0.47

package/fesm2022/arsedizioni-ars-utils-core.mjs

@@ -2168,6 +2168,11 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "22.0.1", ngImpor
  * The host control is re-validated whenever the OTHER control's value changes:
  * without this, typing a new password AFTER the confirmation field was filled
  * left the form incorrectly valid (the classic password/confirm bug).
+ *
+ * IMPORTANT (reciprocal-binding safety): the re-validation triggered from the
+ * other control's `valueChanges` runs with `{ emitEvent: false }`. Calling
+ * Angular's `onValidatorChange` instead would re-emit valueChanges, so a
+ * reciprocal setup (A [equals]=B and B [equals]=A) would overflow the stack.
  */
 class EqualsValidatorDirective {
     constructor() {
@@ -2175,21 +2180,18 @@ class EqualsValidatorDirective {
         this.equals = input(undefined, /* @ts-ignore */
         ...(ngDevMode ? [{ debugName: "equals" }] : /* istanbul ignore next */ []));
         // Re-subscribe whenever the [equals] binding points to a different control,
-        // and trigger host re-validation on every change of the other control.
+        // and re-validate the host on every change of the other control.
         effect(() => {
             const other = this.equals();
             this.subscription?.unsubscribe();
-            this.subscription = other?.valueChanges.subscribe(() => this.onValidatorChange?.());
+            this.subscription = other?.valueChanges.subscribe(() => 
+            // emitEvent:false breaks the reciprocal valueChanges loop (see class doc).
+            this.hostControl?.updateValueAndValidity({ emitEvent: false }));
+            // Re-validate the host when the bound control itself is swapped.
+            this.hostControl?.updateValueAndValidity({ emitEvent: false });
         });
         inject(DestroyRef).onDestroy(() => this.subscription?.unsubscribe());
     }
-    /**
-     * Registers the callback Angular invokes to re-run this validator.
-     * @param fn - The revalidation callback provided by the forms API.
-     */
-    registerOnValidatorChange(fn) {
-        this.onValidatorChange = fn;
-    }
     /**
      * Validates that the host control value equals the bound control's value.
      * Returns `null` (valid) when no control is bound.
@@ -2197,6 +2199,7 @@ class EqualsValidatorDirective {
      * @returns `null` when valid, `{ equals: ... }` otherwise.
      */
     validate(control) {
+        this.hostControl = control;
         const eq = this.equals();
         if (!eq)
             return null;
@@ -2411,6 +2414,12 @@ i0.ɵɵngDeclareClassMetadata({ minVersion: "12.0.0", version: "22.0.1", ngImpor
  *
  * The host control is re-validated whenever the OTHER control's value changes,
  * so editing either field keeps both error states consistent.
+ *
+ * IMPORTANT (reciprocal-binding safety): the re-validation triggered from the
+ * other control's `valueChanges` is run with `{ emitEvent: false }`. Using
+ * Angular's `onValidatorChange` here instead would call `host.updateValueAndValidity()`
+ * WITH events, so a reciprocal setup (A [notEqual]=B and B [notEqual]=A) would
+ * ping-pong valueChanges between the two controls and overflow the stack.
  */
 class NotEqualValidatorDirective {
     constructor() {
@@ -2420,17 +2429,15 @@ class NotEqualValidatorDirective {
         effect(() => {
             const other = this.notEqual();
             this.subscription?.unsubscribe();
-            this.subscription = other?.valueChanges.subscribe(() => this.onValidatorChange?.());
+            this.subscription = other?.valueChanges.subscribe(() => 
+            // Re-validate the host WITHOUT emitting valueChanges, otherwise a
+            // reciprocal binding would loop forever (see class doc).
+            this.hostControl?.updateValueAndValidity({ emitEvent: false }));
+            // Re-validate the host when the bound control itself is swapped.
+            this.hostControl?.updateValueAndValidity({ emitEvent: false });
         });
         inject(DestroyRef).onDestroy(() => this.subscription?.unsubscribe());
     }
-    /**
-     * Registers the callback Angular invokes to re-run this validator.
-     * @param fn - The revalidation callback provided by the forms API.
-     */
-    registerOnValidatorChange(fn) {
-        this.onValidatorChange = fn;
-    }
     /**
      * Validates that the host control value is not equal to the bound control's value.
      * Also clears the `notequal` error on the other control when the host becomes valid.
@@ -2439,6 +2446,7 @@ class NotEqualValidatorDirective {
      * @returns `null` when valid, `{ notequal: true }` otherwise.
      */
     validate(control) {
+        this.hostControl = control;
         const notEqual = this.notEqual();
         if (!notEqual)
             return null;
@@ -2449,7 +2457,9 @@ class NotEqualValidatorDirective {
         }
         else if (notEqual.hasError('notequal')) {
             const { notequal: _removed, ...rest } = notEqual.errors ?? {};
-            notEqual.setErrors(Object.keys(rest).length > 0 ? rest : null);
+            // emitEvent:false on both: clearing the partner's error must not feed
+            // back through valueChanges/statusChanges into this validator.
+            notEqual.setErrors(Object.keys(rest).length > 0 ? rest : null, { emitEvent: false });
             notEqual.updateValueAndValidity({ onlySelf: true, emitEvent: false });
             notEqual.markAsTouched();
             notEqual.markAsDirty();