@arjunkhera/atlas 0.4.34 → 0.4.35

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "atlas",
-  "version": "0.4.34",
+  "version": "0.4.35",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, for any repository.",
   "author": {
     "name": "Arjun Khera"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arjunkhera/atlas",
-  "version": "0.4.34",
+  "version": "0.4.35",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, as a Claude Code plugin for any repository.",
   "type": "module",
   "license": "UNLICENSED",

package/work/lib/numbers.mjs

@@ -35,11 +35,18 @@ export const SECOND_CHECK = 'passes-after';
 // package.json or a runner config changes for many reasons, so it is not.
 const TEST_GROUPS = Object.freeze(['unit-test', 'check-block', 'scenario-words', 'test-helper', 'kit-manifest']);
 // The GitHub counts and the tracker counts of one row.
-export const GITHUB_COUNTS = Object.freeze(['merges', 'not_on_green', 'reverts', 'unchecked_test_changes', 'signed_acts']);
+export const GITHUB_COUNTS = Object.freeze(['merges', 'not_on_green', 'reverts', 'unchecked_test_changes', 'signed_acts', 'audit_unsigned_merges']);
 export const GRAPH_COUNTS = Object.freeze(['reopens', 'step_ins', 'owner_messages', 'platform_messages']);
-// Line 2: the count that waits on an item not built yet. It is named, never
-// shown as zero.
-export const WAITING = Object.freeze({ audit_unsigned_merges: 'waits on R14 line 3, the unsigned-merge finding of the audit job' });
+// Line 2: the counts that wait on an item not built yet. Each is named, never
+// shown as zero. None waits now: R14 line 3 shipped the unsigned-merge finding.
+export const WAITING = Object.freeze({});
+// Line 2: the audit job (R14 line 3) opens one issue for each merge that the
+// gate sent to the owner with no signed act. GitHub Actions writes it, with
+// the label atlas-job and this title.
+export const AUDIT_LABEL = 'atlas-job';
+const AUDIT_TITLE = /^atlas-job: gate-audit owner-unsigned:([0-9a-f]{40})$/;
+const AUDIT_AUTHOR = 'github-actions[bot]';
+const MAX_ISSUE_PAGES = 10;
 
 const DATE = /^\d{4}-\d{2}-\d{2}$/;
 const dayOf = (value) => String(value ?? '').slice(0, 10);
@@ -108,6 +115,26 @@ async function readAllFiles(repo, number, readGitHub) {
   throw new Error(`pull request ${number} changed more than ${MAX_FILE_PAGES * PAGE} files`);
 }
 
+// Line 2: the merge commits that the audit job reported as unsigned, from
+// its issues opened since the start of the period. Only an issue that GitHub
+// Actions opened counts, so a person cannot add one by hand. A closed issue
+// still counts: the merge happened. More than MAX_ISSUE_PAGES pages is
+// refused, never cut.
+export async function readUnsignedMerges(repo, readGitHub, sinceAt) {
+  const shas = new Set();
+  const since = new Date(sinceAt).toISOString();
+  for (let page = 1; page <= MAX_ISSUE_PAGES; page += 1) {
+    const rows = await readGitHub(`repos/${repo}/issues?labels=${AUDIT_LABEL}&state=all&since=${since}&per_page=${PAGE}&page=${page}`);
+    if (!Array.isArray(rows)) throw new Error('the audit issues are not a list');
+    for (const row of rows) {
+      const match = AUDIT_TITLE.exec(String(row?.title ?? ''));
+      if (match && row?.user?.login === AUDIT_AUTHOR && !row.pull_request) shas.add(match[1].toLowerCase());
+    }
+    if (rows.length < PAGE) return shas;
+  }
+  throw new Error(`more than ${MAX_ISSUE_PAGES * PAGE} audit issues`);
+}
+
 // Line 2: the comment texts of one pull request, every page. More than
 // MAX_COMMENT_PAGES pages is refused, never cut.
 export async function readAllComments(repo, number, readGitHub) {
@@ -222,6 +249,7 @@ export async function readMerges({ repo, defaultBranch, period, readGitHub }) {
     const text = await textAt('atlas.yaml', sha);
     return text === null ? [] : deliveryFacts(text).required;
   };
+  const unsigned = await readUnsignedMerges(repo, readGitHub, period.start);
   return pool(merges.map((pull) => async () => {
     const head = pull.head?.sha, merge = pull.merge_commit_sha;
     if (!/^[0-9a-f]{40}$/i.test(String(head)) || !/^[0-9a-f]{40}$/i.test(String(merge))) throw new Error(`GitHub names no head or merge commit for pull request ${pull.number}`);
@@ -245,6 +273,7 @@ export async function readMerges({ repo, defaultBranch, period, readGitHub }) {
     const signed = keys.length ? signedActOf({ repo, pull, texts: await readAllComments(repo, pull.number, readGitHub), keys }) : null;
     return {
       repo, number: pull.number, url: pull.html_url ?? `https://github.com/${repo}/pull/${pull.number}`, title: oneLine(pull.title ?? '', 200), merged_at: pull.merged_at,
+      audit_unsigned: unsigned.has(String(merge).toLowerCase()),
       not_on_green: notOnGreenReasons({ required, runs, mergedAt: pull.merged_at }), revert: isRevert(pull),
       changed_tests: tests, signed, unchecked: tests.length > 0 && !signed && !secondCheckPassed(runs, pull.merged_at),
     };
@@ -320,6 +349,7 @@ export async function readNumbers({ product, repos, items, marks, period, readGi
       if (merge.revert) events.push(['reverts', merge.merged_at]);
       if (merge.unchecked) events.push(['unchecked_test_changes', merge.merged_at]);
       if (merge.signed) events.push(['signed_acts', merge.merged_at]);
+      if (merge.audit_unsigned) events.push(['audit_unsigned_merges', merge.merged_at]);
     }
     for (const mark of reopens) if (itemRepos.get(mark.fields.item).includes(repo.id)) events.push(['reopens', mark.fields.marked_at]);
     for (const pair of pairs) {
@@ -341,6 +371,7 @@ export async function readNumbers({ product, repos, items, marks, period, readGi
       not_on_green: refused ? null : merges.filter((merge) => merge.not_on_green.length).map((merge) => ({ pr: merge.url, merged_at: merge.merged_at, reasons: merge.not_on_green })),
       reverts: refused ? null : merges.filter((merge) => merge.revert).map((merge) => ({ pr: merge.url, title: merge.title })),
       unchecked_test_changes: refused ? null : merges.filter((merge) => merge.unchecked).map((merge) => ({ pr: merge.url, tests: merge.changed_tests })),
+      audit_unsigned_merges: refused ? null : merges.filter((merge) => merge.audit_unsigned).map((merge) => ({ pr: merge.url, merged_at: merge.merged_at })),
       signed_acts: refused ? null : merges.filter((merge) => merge.signed).map((merge) => ({ pr: merge.url, signed_at: merge.signed.signed_at, key: merge.signed.key })),
     });
   }

package/work/lib/roundup.mjs

@@ -266,7 +266,7 @@ function render(view) {
 }
 
 // Part 6. A refused count reads "refused", never 0.
-const COLUMNS = [['merges', 'merges'], ['not_on_green', 'not on green'], ['reverts', 'reverts'], ['unchecked_test_changes', 'unchecked test changes'], ['signed_acts', 'signed acts'], ['reopens', 'reopens'], ['step_ins', 'step-ins'], ['owner_messages', 'owner messages'], ['platform_messages', 'platform messages']];
+const COLUMNS = [['merges', 'merges'], ['not_on_green', 'not on green'], ['reverts', 'reverts'], ['unchecked_test_changes', 'unchecked test changes'], ['signed_acts', 'signed acts'], ['audit_unsigned_merges', 'unsigned merges'], ['reopens', 'reopens'], ['step_ins', 'step-ins'], ['owner_messages', 'owner messages'], ['platform_messages', 'platform messages']];
 const countsLine = (row) => COLUMNS.map(([key, word]) => `${row[key] === null ? 'refused' : row[key]} ${word}`).join(' · ');
 function renderNumbers(numbers, more) {
   const out = [`6. The numbers, ${numbers.from} to ${numbers.to} (UTC)`];
@@ -284,7 +284,7 @@ function renderNumbers(numbers, more) {
   out.push(`   input to live: ${numbers.delivered.length} delivered ${numbers.delivered.length === 1 ? 'item' : 'items'}${median === null ? '' : `, median ${median} days`}`);
   for (const row of numbers.delivered.slice(0, SHOWN)) out.push(listLine(row.title, `${row.item.slice(0, 8)} · ${row.days ?? '?'} days · live ${dayOf(row.live_at)}`, '     '));
   out.push(...more(numbers.delivered));
-  out.push(`   owner acts: unsigned merges ${numbers.owner_acts.audit_unsigned_merges}`);
+  for (const [count, wait] of Object.entries(numbers.owner_acts ?? {})) out.push(`   ${count.replace(/_/g, ' ')}: ${wait}`);
   if (numbers.not_counted_sessions) out.push(`   ${numbers.not_counted_sessions} sessions ran with the hooks off, so their messages were not counted`);
   return out.join('\n');
 }

package/work/mcp.mjs

@@ -227,6 +227,9 @@ export const GITHUB_READS = Object.freeze([
   // and the owner key file at the first parent of the merge.
   new RegExp(`^repos/${REPO}/issues/\\d{1,9}/comments\\?per_page=\\d{1,3}&page=\\d{1,3}$`),
   new RegExp(`^repos/${REPO}/contents/atlas/owner-signers\\?ref=${SHA}$`),
+  // Roadmap R16 line 2: the audit issues of the period, for the merges that
+  // the audit job reported as unsigned.
+  new RegExp(`^repos/${REPO}/issues\\?labels=atlas-job&state=all&since=\\d{4}-\\d{2}-\\d{2}T\\d{2}:\\d{2}:\\d{2}\\.\\d{3}Z&per_page=\\d{1,3}&page=\\d{1,3}$`),
 ]);
 export function githubReader() {
   return async (path) => {