@arjunkhera/atlas 0.4.31 → 0.4.32

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "atlas",
-  "version": "0.4.31",
+  "version": "0.4.32",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, for any repository.",
   "author": {
     "name": "Arjun Khera"

package/door/lib/fails-before.mjs

@@ -186,17 +186,26 @@ function caseTexts(xml) {
 
 // The results of one report: Map of case name to pass, assertion, error or skipped.
 // For pytest, a name with parameters ("test_x[1]") counts under its function name.
-export function readReport(xml) {
+// `known` holds the case names that the case reader found in the file. node --test writes a test
+// whose body holds subtests as a <testsuite> with the subtests as its cases, and no case of its own
+// name. So a subtest counts under the outermost suite around it whose name is known (item
+// 30badd46). A suite of describe() has no known name, so its cases count under their own names.
+// Limit: node writes no failure for a parent test that fails outside its subtests, so that failure
+// does not show here.
+export function readReport(xml, known = []) {
   const cases = readJunit(xml);
   const texts = caseTexts(xml);
   const rank = { pass: 0, skipped: 1, error: 2, assertion: 3 };
+  const named = new Set(known);
+  // The junit reporter of node writes a double quote as "&amp;quot;", so one
+  // unescape leaves "&quot;" (f2d07e35). Undo the second escape here.
+  const unquote = (text) => text.replaceAll('&quot;', '"');
   const out = new Map();
   cases.forEach((c, i) => {
     let result = c.result;
     if (result === 'fail') result = /AssertionError|ERR_ASSERTION/.test(`${c.message ?? ''}\n${texts[i] ?? ''}`) ? 'assertion' : 'error';
-    // The junit reporter of node writes a double quote as "&amp;quot;", so one
-    // unescape leaves "&quot;" (f2d07e35). Undo the second escape here.
-    const name = c.name.replaceAll('&quot;', '"').replace(/\[.*\]$/, '');
+    const parent = (c.suites ?? []).map(unquote).find((s) => named.has(s));
+    const name = parent ?? unquote(c.name).replace(/\[.*\]$/, '');
     // When one name holds several results, the worst one counts: a fail beats a pass.
     if (!out.has(name) || rank[result] > rank[out.get(name)]) out.set(name, result);
   });
@@ -336,7 +345,7 @@ export function runSide({ top, changed, plans, side, work = join(tmpdir(), 'atla
       if (r.error) why = `the runner did not finish: ${r.error.message}`;
       else if (!existsSync(report)) why = `the runner wrote no report (exit ${r.status})`;
       else {
-        try { cases = Object.fromEntries(readReport(readFileSync(report, 'utf8'))); } catch (error) { why = `the report does not read: ${error.message}`; }
+        try { cases = Object.fromEntries(readReport(readFileSync(report, 'utf8'), p.known)); } catch (error) { why = `the report does not read: ${error.message}`; }
       }
       out.files[p.path] = { command, cases, why };
     }

package/door/lib/passes-after.mjs

@@ -84,7 +84,7 @@ export function plan({ root, base, head = 'HEAD', list = null }) {
     if (!picked.length && !all) continue;
     if (!runner) { files.push({ path, runner: null, result: 'not run', why: 'no runner for this file yet' }); plans.push({ path, runner: null, picked, all }); continue; }
     files.push({ path, runner, result: 'ran', why: null });
-    plans.push({ path, runner, picked, all, head: r.status === 'removed' ? null : r.path });
+    plans.push({ path, runner, picked, all, head: r.status === 'removed' ? null : r.path, known: before ? [...before.cases.keys()] : [] });
   }
   files.sort((x, y) => (x.path < y.path ? -1 : 1));
   return {
@@ -131,7 +131,7 @@ export function runOld({ top, changed, plans, work = join(tmpdir(), 'atlas-after
       if (r.error) why = `the runner did not finish: ${r.error.message}`;
       else if (!existsSync(report)) why = `the runner wrote no report (exit ${r.status})`;
       else {
-        try { cases = Object.fromEntries(readReport(readFileSync(report, 'utf8'))); } catch (error) { why = `the report does not read: ${error.message}`; }
+        try { cases = Object.fromEntries(readReport(readFileSync(report, 'utf8'), p.known)); } catch (error) { why = `the report does not read: ${error.message}`; }
       }
       out.files[p.path] = { command, cases, why };
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arjunkhera/atlas",
-  "version": "0.4.31",
+  "version": "0.4.32",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, as a Claude Code plugin for any repository.",
   "type": "module",
   "license": "UNLICENSED",

package/tests/junit.mjs

@@ -3,8 +3,10 @@
 // write this report: node --test (--test-reporter=junit), pytest
 // (--junitxml), TestNG, JUnit, Vitest and Jest.
 //
-//   readJunit(xml) -> [{ name, classname, file, suite, result, message }]
+//   readJunit(xml) -> [{ name, classname, file, suite, suites, result, message }]
 //   result: "pass", "fail" or "skipped". An <error> is a fail too.
+//   suites: the names of the <testsuite> elements around the case, outermost
+//   first. node --test writes a test with subtests as a <testsuite>.
 //
 // The reader has no dependency. It reads only the parts it needs: the
 // <testsuite> nesting, each <testcase> and its <failure>, <error> and
@@ -44,9 +46,10 @@ export function readJunit(xml) {
     if (tag === 'testcase') {
       if (closing) { current = null; continue; }
       const a = attributes(attrs);
-      const suite = suites.map((s) => s.name).filter(Boolean).join(' > ');
+      const names = suites.map((s) => s.name).filter(Boolean);
+      const suite = names.join(' > ');
       const file = a.file ?? suites.map((s) => s.file).filter(Boolean).at(-1) ?? null;
-      const one = { name: a.name ?? '', classname: a.classname ?? null, file, suite: suite || null, result: 'pass', message: null };
+      const one = { name: a.name ?? '', classname: a.classname ?? null, file, suite: suite || null, suites: names, result: 'pass', message: null };
       cases.push(one);
       current = selfClosing ? null : one;
       continue;