@arjunkhera/atlas 0.4.28 → 0.4.29

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "atlas",
-  "version": "0.4.28",
+  "version": "0.4.29",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, for any repository.",
   "author": {
     "name": "Arjun Khera"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arjunkhera/atlas",
-  "version": "0.4.28",
+  "version": "0.4.29",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, as a Claude Code plugin for any repository.",
   "type": "module",
   "license": "UNLICENSED",

package/work/lib/numbers.mjs

@@ -16,6 +16,7 @@ import { deliveryFacts, FATAL_CONCLUSIONS } from './delivery.mjs';
 import { standingOf, isOwnerMessage, isStepIn, senderOfMark } from './step-ins.mjs';
 import { ACTIONS_APP_ID } from '../../door/lib/gate.mjs';
 import { groupOf } from '../../door/lib/changed-tests.mjs';
+import { SIGNERS_FILE, parseSigners, verifyTexts, findAct } from '../../door/lib/signed-act.mjs';
 
 export const NUMBERS_MAX_DAYS = 92;
 export const NUMBERS_DEFAULT_DAYS = 28;
@@ -24,20 +25,21 @@ export const PAGE = 100;
 // never cut.
 export const MAX_PULL_PAGES = 10;
 const MAX_FILE_PAGES = 30;
+const MAX_COMMENT_PAGES = 10;
 const CONCURRENCY = 8;
 const DAY = 86_400_000;
 // The second check of a changed test (roadmap R73). A signed act (R72) is
-// the other one; it is not built yet.
+// the other one.
 export const SECOND_CHECK = 'passes-after';
 // A changed or removed file of these groups is an old test that changed. A
 // package.json or a runner config changes for many reasons, so it is not.
 const TEST_GROUPS = Object.freeze(['unit-test', 'check-block', 'scenario-words', 'test-helper', 'kit-manifest']);
 // The GitHub counts and the tracker counts of one row.
-export const GITHUB_COUNTS = Object.freeze(['merges', 'not_on_green', 'reverts', 'unchecked_test_changes']);
+export const GITHUB_COUNTS = Object.freeze(['merges', 'not_on_green', 'reverts', 'unchecked_test_changes', 'signed_acts']);
 export const GRAPH_COUNTS = Object.freeze(['reopens', 'step_ins', 'owner_messages', 'platform_messages']);
-// Line 2: the counts that wait on items not built yet. They are named, never
+// Line 2: the count that waits on an item not built yet. It is named, never
 // shown as zero.
-export const WAITING = Object.freeze({ signed_acts: 'waits on R72, the signed act', audit_unsigned_merges: 'waits on R14, the audit job' });
+export const WAITING = Object.freeze({ audit_unsigned_merges: 'waits on R14 line 3, the unsigned-merge finding of the audit job' });
 
 const DATE = /^\d{4}-\d{2}-\d{2}$/;
 const dayOf = (value) => String(value ?? '').slice(0, 10);
@@ -106,6 +108,29 @@ async function readAllFiles(repo, number, readGitHub) {
   throw new Error(`pull request ${number} changed more than ${MAX_FILE_PAGES * PAGE} files`);
 }
 
+// Line 2: the comment texts of one pull request, every page. More than
+// MAX_COMMENT_PAGES pages is refused, never cut.
+export async function readAllComments(repo, number, readGitHub) {
+  const texts = [];
+  for (let page = 1; page <= MAX_COMMENT_PAGES; page += 1) {
+    const rows = await readGitHub(`repos/${repo}/issues/${number}/comments?per_page=${PAGE}&page=${page}`);
+    if (!Array.isArray(rows)) throw new Error(`the comments of pull request ${number} are not a list`);
+    texts.push(...rows.map((row) => String(row?.body ?? '')));
+    if (rows.length < PAGE) return texts;
+  }
+  throw new Error(`pull request ${number} has more than ${MAX_COMMENT_PAGES * PAGE} comments`);
+}
+
+// Line 2: the owner's signed act for the merged head of one pull request, or
+// null. The key comes from atlas/owner-signers at the first parent of the
+// merge, as the gate reads it from the base. The act must name this repo,
+// this pull request, its base branch and its last head. The gate checked the
+// merge base when it let the head pass; this count does not read it again.
+export function signedActOf({ repo, pull, texts, keys }) {
+  const found = findAct(verifyTexts(texts, keys), { kind: 'merge', repo, pr: Number(pull.number), base: pull.base?.ref, head: pull.head?.sha });
+  return found ? { signed_at: found.signed_at, key: found.key } : null;
+}
+
 // Run each job, at most `limit` at a time. The first failure stops the rest
 // and is thrown, so a count is whole or refused.
 async function pool(jobs, limit = CONCURRENCY) {
@@ -179,38 +204,48 @@ export function secondCheckPassed(runs = [], mergedAt) {
 export async function readMerges({ repo, defaultBranch, period, readGitHub }) {
   const pulls = await readAllPulls(repo, readGitHub, period.start);
   const merges = pulls.filter((pull) => pull.merged_at && time(pull.merged_at) >= period.start && time(pull.merged_at) < period.end && (!defaultBranch || pull.base?.ref === defaultBranch));
-  const facts = new Map();
-  const requiredAt = (sha) => {
-    if (!facts.has(sha)) facts.set(sha, (async () => {
+  const cache = new Map();
+  // One file at one commit, read once. A file that is not there is null.
+  const textAt = (path, sha) => {
+    const key = `${path}@${sha}`;
+    if (!cache.has(key)) cache.set(key, (async () => {
       let file;
-      try { file = await readGitHub(`repos/${repo}/contents/atlas.yaml?ref=${sha}`); }
-      catch (error) { if (error?.status === 404 || /HTTP 404|Not Found/i.test(String(error?.message ?? ''))) return []; throw error; }
-      if (!file || typeof file.content !== 'string') return [];
-      return deliveryFacts(Buffer.from(file.content, 'base64').toString('utf8')).required;
+      try { file = await readGitHub(`repos/${repo}/contents/${path}?ref=${sha}`); }
+      catch (error) { if (error?.status === 404 || /HTTP 404|Not Found/i.test(String(error?.message ?? ''))) return null; throw error; }
+      if (!file || typeof file.content !== 'string') return null;
+      return Buffer.from(file.content, 'base64').toString('utf8');
     })());
-    return facts.get(sha);
+    return cache.get(key);
+  };
+  const requiredAt = async (sha) => {
+    const text = await textAt('atlas.yaml', sha);
+    return text === null ? [] : deliveryFacts(text).required;
   };
   return pool(merges.map((pull) => async () => {
     const head = pull.head?.sha, merge = pull.merge_commit_sha;
     if (!/^[0-9a-f]{40}$/i.test(String(head)) || !/^[0-9a-f]{40}$/i.test(String(merge))) throw new Error(`GitHub names no head or merge commit for pull request ${pull.number}`);
-    const requiredBefore = async () => {
+    const before = async () => {
       const parent = (await readGitHub(`repos/${repo}/commits/${merge}`))?.parents?.[0]?.sha;
       if (!/^[0-9a-f]{40}$/i.test(String(parent))) throw new Error(`GitHub names no parent of the merge commit of pull request ${pull.number}`);
-      return requiredAt(parent);
+      const [required, signers] = await Promise.all([requiredAt(parent), textAt(SIGNERS_FILE, parent)]);
+      return { required, signers };
     };
-    const [checks, files, required] = await Promise.all([
+    const [checks, files, { required, signers }] = await Promise.all([
       readGitHub(`repos/${repo}/commits/${head}/check-runs?per_page=${PAGE}`),
       readAllFiles(repo, pull.number, readGitHub),
-      requiredBefore(),
+      before(),
     ]);
     if (!Array.isArray(checks?.check_runs)) throw new Error(`the check runs of pull request ${pull.number} are not a list`);
     const runs = checks.check_runs;
     if (Number(checks?.total_count ?? runs.length) > runs.length) throw new Error(`the head of pull request ${pull.number} has more than ${PAGE} check runs`);
     const tests = changedOldTests(files);
+    // With no owner key at the merge, no act can count: the comments are not read.
+    const keys = parseSigners(signers ?? '').keys;
+    const signed = keys.length ? signedActOf({ repo, pull, texts: await readAllComments(repo, pull.number, readGitHub), keys }) : null;
     return {
       repo, number: pull.number, url: pull.html_url ?? `https://github.com/${repo}/pull/${pull.number}`, title: oneLine(pull.title ?? '', 200), merged_at: pull.merged_at,
       not_on_green: notOnGreenReasons({ required, runs, mergedAt: pull.merged_at }), revert: isRevert(pull),
-      changed_tests: tests, unchecked: tests.length > 0 && !secondCheckPassed(runs, pull.merged_at),
+      changed_tests: tests, signed, unchecked: tests.length > 0 && !signed && !secondCheckPassed(runs, pull.merged_at),
     };
   }));
 }
@@ -283,6 +318,7 @@ export async function readNumbers({ product, repos, items, marks, period, readGi
       if (merge.not_on_green.length) events.push(['not_on_green', merge.merged_at]);
       if (merge.revert) events.push(['reverts', merge.merged_at]);
       if (merge.unchecked) events.push(['unchecked_test_changes', merge.merged_at]);
+      if (merge.signed) events.push(['signed_acts', merge.merged_at]);
     }
     for (const mark of reopens) if (itemRepos.get(mark.fields.item).includes(repo.id)) events.push(['reopens', mark.fields.marked_at]);
     for (const pair of pairs) {
@@ -304,6 +340,7 @@ export async function readNumbers({ product, repos, items, marks, period, readGi
       not_on_green: refused ? null : merges.filter((merge) => merge.not_on_green.length).map((merge) => ({ pr: merge.url, merged_at: merge.merged_at, reasons: merge.not_on_green })),
       reverts: refused ? null : merges.filter((merge) => merge.revert).map((merge) => ({ pr: merge.url, title: merge.title })),
       unchecked_test_changes: refused ? null : merges.filter((merge) => merge.unchecked).map((merge) => ({ pr: merge.url, tests: merge.changed_tests })),
+      signed_acts: refused ? null : merges.filter((merge) => merge.signed).map((merge) => ({ pr: merge.url, signed_at: merge.signed.signed_at, key: merge.signed.key })),
     });
   }
   const delivered = deliveredRows({ marks: marks.filter((mark) => mark.fields?.product === product), items, period });

package/work/lib/roundup.mjs

@@ -251,7 +251,7 @@ function render(view) {
 }
 
 // Part 6. A refused count reads "refused", never 0.
-const COLUMNS = [['merges', 'merges'], ['not_on_green', 'not on green'], ['reverts', 'reverts'], ['unchecked_test_changes', 'unchecked test changes'], ['reopens', 'reopens'], ['step_ins', 'step-ins'], ['owner_messages', 'owner messages'], ['platform_messages', 'platform messages']];
+const COLUMNS = [['merges', 'merges'], ['not_on_green', 'not on green'], ['reverts', 'reverts'], ['unchecked_test_changes', 'unchecked test changes'], ['signed_acts', 'signed acts'], ['reopens', 'reopens'], ['step_ins', 'step-ins'], ['owner_messages', 'owner messages'], ['platform_messages', 'platform messages']];
 const countsLine = (row) => COLUMNS.map(([key, word]) => `${row[key] === null ? 'refused' : row[key]} ${word}`).join(' · ');
 function renderNumbers(numbers, more) {
   const out = [`6. The numbers, ${numbers.from} to ${numbers.to} (UTC)`];
@@ -269,7 +269,7 @@ function renderNumbers(numbers, more) {
   out.push(`   input to live: ${numbers.delivered.length} delivered ${numbers.delivered.length === 1 ? 'item' : 'items'}${median === null ? '' : `, median ${median} days`}`);
   for (const row of numbers.delivered.slice(0, SHOWN)) out.push(listLine(row.title, `${row.item.slice(0, 8)} · ${row.days ?? '?'} days · live ${dayOf(row.live_at)}`, '     '));
   out.push(...more(numbers.delivered));
-  out.push(`   owner acts: signed acts ${numbers.owner_acts.signed_acts}; unsigned merges ${numbers.owner_acts.audit_unsigned_merges}`);
+  out.push(`   owner acts: unsigned merges ${numbers.owner_acts.audit_unsigned_merges}`);
   if (numbers.not_counted_sessions) out.push(`   ${numbers.not_counted_sessions} sessions ran with the hooks off, so their messages were not counted`);
   return out.join('\n');
 }

package/work/mcp.mjs

@@ -216,6 +216,10 @@ export const GITHUB_READS = Object.freeze([
   new RegExp(`^repos/${REPO}/pulls/\\d{1,9}/files\\?per_page=\\d{1,3}&page=\\d{1,3}$`),
   // Roadmap R14 line 6: the newest run of the daily audit, for the roundup.
   new RegExp(`^repos/${REPO}/actions/workflows/atlas-jobs\\.yml/runs\\?per_page=\\d{1,3}$`),
+  // Roadmap R16 line 2: the comments of a merge, for the owner's signed act,
+  // and the owner key file at the first parent of the merge.
+  new RegExp(`^repos/${REPO}/issues/\\d{1,9}/comments\\?per_page=\\d{1,3}&page=\\d{1,3}$`),
+  new RegExp(`^repos/${REPO}/contents/atlas/owner-signers\\?ref=${SHA}$`),
 ]);
 export function githubReader() {
   return async (path) => {