@arjunkhera/atlas 0.4.18 → 0.4.19

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "atlas",
-  "version": "0.4.18",
+  "version": "0.4.19",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, for any repository.",
   "author": {
     "name": "Arjun Khera"

package/door/cli.mjs

@@ -38,7 +38,7 @@ import { changedCommand as testsChanged } from './lib/changed-tests.mjs';
 import { beforeCommand as testsBefore } from './lib/fails-before.mjs';
 import { afterCommand as testsAfter } from './lib/passes-after.mjs';
 import { upkeepCommand } from './lib/upkeep.mjs';
-import { gateCommand } from './lib/gate.mjs';
+import { gateCommand, mergeList } from './lib/gate.mjs';
 import { judgeCommand } from './lib/judge.mjs';
 
 export const PACKAGE_ROOT = resolve(dirname(fileURLToPath(import.meta.url)), '..');
@@ -290,6 +290,8 @@ function statusCommand(chosen) {
     line(`         ${row.why}`);
     if (row.copy) line(`         copy    sha256 ${row.copy.sha256.slice(0, 12)}…  check version ${row.copy.check_version ?? '?'}`);
     if (row.packaged) line(`         package sha256 ${row.packaged.sha256.slice(0, 12)}…  check version ${row.packaged.check_version}${row.packaged.released ? '' : '  (not released)'}`);
+    const list = mergeList(row.root);
+    if (list) line(`         ${list.line}`);
     line('');
   }
   line(`Decided by the release list in Atlas ${ATLAS_VERSION}, never by git history.`);
@@ -461,6 +463,9 @@ function checkCommand(chosen) {
   const report = scan({ root, repoId: chosen.repo ?? null });
   const decision = verdict(report, chosen['fail-on'] ?? 'error');
   process.stdout.write(toText(report));
+  // A report, never a reason for red: the list is an owner-only key.
+  const list = mergeList(root);
+  if (list && list.state !== 'listed') line(list.line);
   line(`${decision.green ? 'GREEN' : 'RED'}: ${decision.why}`);
   return decision.green ? 0 : 1;
 }

package/door/lib/gate.mjs

@@ -15,7 +15,7 @@
 // The plan is built by pure functions, so a test reads it without GitHub. The
 // gh calls sit in one place, behind `gh`, which a test replaces.
 import { execFileSync } from 'node:child_process';
-import { readFileSync, existsSync, mkdirSync, writeFileSync, rmSync, renameSync } from 'node:fs';
+import { readFileSync, existsSync, mkdirSync, writeFileSync, rmSync, renameSync, readdirSync } from 'node:fs';
 import { homedir } from 'node:os';
 import { dirname, join } from 'node:path';
 import { childEnvironment } from '../../work/lib/child-env.mjs';
@@ -38,16 +38,40 @@ export function gateFacts(root) {
   return factsOf(readFileSync(path, 'utf8'));
 }
 
+// A repo with no list cannot merge through the door: ready reads the list,
+// and the door never makes one up (item 3d675dc7).
+export const NO_LIST = 'atlas.yaml lists no required_checks.';
+export const LIST_FIX = 'Fix: add required_checks to atlas.yaml, with the names of the CI jobs that run on every pull request. The key is owner-only, so the owner merges that pull request by hand.';
+
 function factsOf(text) {
   const facts = parseYaml(text) ?? {};
   const checks = facts.required_checks;
   if (!Array.isArray(checks) || checks.length === 0 || checks.some((name) => typeof name !== 'string' || !name.trim())) {
-    throw new GateError('atlas.yaml lists no required_checks. Nothing was changed.');
+    throw Object.assign(new GateError(`${NO_LIST} Nothing was changed.`), { noList: true });
   }
   if (facts.up_to_date !== undefined && typeof facts.up_to_date !== 'boolean') throw new GateError('atlas.yaml up_to_date must be true or false. Nothing was changed.');
   return { checks: [...checks], upToDate: facts.up_to_date === true };
 }
 
+// Can this repo merge through the door? The answer does not read the repo
+// kind: each kind merges on the same list. `atlas status` and `atlas check`
+// print it.
+//   listed   atlas.yaml names the checks
+//   missing  CI runs, but atlas.yaml names no checks
+//   no-ci    no workflow runs, so no list can exist yet
+export function mergeList(root) {
+  const path = join(root, 'atlas.yaml');
+  if (!existsSync(path)) return null;
+  let checks = null;
+  try { checks = factsOf(readFileSync(path, 'utf8')).checks; } catch (error) { if (!error.noList) return { state: 'missing', checks: [], line: `merge door: atlas.yaml cannot be read (${error.message}). ${LIST_FIX}` }; }
+  if (checks) return { state: 'listed', checks, line: `merge door: ${checks.length} required check(s) in atlas.yaml.` };
+  const flows = join(root, '.github', 'workflows');
+  const ci = existsSync(flows) && readdirSync(flows).some((name) => /\.ya?ml$/.test(name));
+  return ci
+    ? { state: 'missing', checks: [], line: `merge door: ${NO_LIST} ${LIST_FIX}` }
+    : { state: 'no-ci', checks: [], line: 'merge door: no list, because no CI workflow runs here. Merges stay with the owner.' };
+}
+
 // The two ruleset bodies, as the GitHub rulesets API takes them.
 export function rulesets({ checks, upToDate }, enforcement = 'active') {
   return [
@@ -317,7 +341,14 @@ export function readyCommand({ repo, pr, answer }, line, gh = ghApi) {
   if (answer && typeof pull?.head?.sha === 'string') answer.sha = pull.head.sha;
   if (pull?.state !== 'open') { line(`atlas gate ready: pull request #${pr} is ${pull?.merged ? 'merged' : pull?.state ?? 'not found'}. NOT READY.`); return 1; }
   const sha = pull.head.sha;
-  const checks = checksAt(gh, repo, pull.base.ref);
+  let checks;
+  try { checks = checksAt(gh, repo, pull.base.ref); } catch (error) {
+    if (!error.noList) throw error;
+    line(`atlas gate ready: #${pr} at ${sha.slice(0, 7)}: atlas.yaml lists no required_checks on ${pull.base.ref}.`);
+    line(`  ${LIST_FIX}`);
+    line('NOT READY: do not merge. Until the list exists, merges in this repo stay with the owner.');
+    return 1;
+  }
   const { kept, refused } = pinnedRuns(gh, repo, { pr, sha, baseRef: pull.base.ref, head: pull.head, checks });
   const rows = checkStates(checks, kept);
   line(`atlas gate ready: #${pr} at ${sha.slice(0, 7)}, ${checks.length} required check(s) from atlas.yaml on ${pull.base.ref}.`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arjunkhera/atlas",
-  "version": "0.4.18",
+  "version": "0.4.19",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, as a Claude Code plugin for any repository.",
   "type": "module",
   "license": "UNLICENSED",

package/skills/lead/SKILL.md

@@ -117,6 +117,11 @@ set. A test keeps the two lists equal.
 A person merges every file that `atlas tooling` writes.
 A person merges every file that `atlas tests write` writes.
 
+When a repo joins Atlas, its first pull request lists `required_checks` in
+`atlas.yaml`: the CI jobs that run on every pull request. The owner merges
+that pull request by hand. With no list, the merge check says NOT READY,
+and merges stay with the owner.
+
 ## 7. The first reply of a cloud session
 
 A cloud session can start from an old setup and run an old Atlas. So in a