@arjunkhera/atlas 0.4.11 → 0.4.12

package/.claude-plugin/plugin.json

@@ -1,6 +1,6 @@
 {
   "name": "atlas",
-  "version": "0.4.11",
+  "version": "0.4.12",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, for any repository.",
   "author": {
     "name": "Arjun Khera"

package/door/lib/gate.mjs

@@ -218,36 +218,48 @@ export const gateRunTitle = (pr, sha) => `gate #${pr} at ${sha}`;
 // Why one workflow run cannot carry a required check of this pull request,
 // or null when it can. The run must come from a base file that defines the
 // check, from a pull request event, on this head, for this pull request into
-// its base branch.
-export function refusal(run, { name, pr, sha, baseRef, homes }) {
+// its base branch. The gate runs on pull_request_target, and its title must
+// name this pull request and this head. The probe of 26 October (done line
+// 15, atlas#211) showed that its run and its check run sit on the head commit,
+// like the others.
+export function refusal(run, { name, pr, sha, baseRef, homes, sides = () => [] }) {
   if (!run) return 'no workflow run';
   if (!homes.get(name)?.has(run.path)) return `from ${run.path ?? 'no file'}, not a base file that defines the check`;
-  if (run.event !== 'pull_request') return `from the event ${run.event}`;
+  const event = name === GATE_CHECK ? 'pull_request_target' : 'pull_request';
+  if (run.event !== event) return `from the event ${run.event}`;
   if (run.head_sha !== sha) return 'of another head commit';
+  if (name === GATE_CHECK && run.display_title !== gateRunTitle(pr, sha)) return 'of another pull request or head';
   const pulls = run.pull_requests ?? [];
   if (!pulls.some((each) => Number(each.number) === Number(pr) && each.base?.ref === baseRef)) return `not of #${pr} into ${baseRef}`;
   // GitHub lists every open pull request with this head, so a run made for a
   // pull request into a side branch can also name this one. Such a run used
   // the side branch's file, so it does not count.
   if (pulls.some((each) => each.base?.ref !== baseRef)) return `also of a pull request into ${pulls.find((each) => each.base?.ref !== baseRef).base?.ref ?? 'another branch'}`;
-  return null;
-}
-
-// The same for a run of the gate. It runs on pull_request_target, so it sits
-// on a commit of the base branch, not on the head. Its title names the pull
-// request and the head; the run must come from the base branch and its file.
-export function gateRefusal(run, { pr, sha, baseRef, onBase }) {
-  if (run.path !== GATE_WORKFLOW) return `from ${run.path ?? 'no file'}, not ${GATE_WORKFLOW}`;
-  if (run.event !== 'pull_request_target') return `from the event ${run.event}`;
-  if (run.display_title !== gateRunTitle(pr, sha)) return 'of another pull request or head';
-  if (run.head_branch !== baseRef) return `from the branch ${run.head_branch}, not ${baseRef}`;
-  if (!onBase(run.head_sha)) return `from a commit that is not on ${baseRef}`;
+  // GitHub builds that list when it is read, from the open pull requests of
+  // the head branch. Once a side pull request closes, its gate run names only
+  // this one, and its title can be set to match. So the gate also refuses a
+  // head branch that ever had a pull request into another branch.
+  if (name === GATE_CHECK) {
+    const side = sides();
+    if (side === null) return 'no head branch to check for side pull requests';
+    if (side.length) return `the head branch also had #${side[0].number} into ${side[0].base?.ref ?? 'another branch'}`;
+  }
   return null;
 }
 
 // The check runs that may count for this pull request, and the ones refused.
-function pinnedRuns(gh, repo, { pr, sha, baseRef, checks }) {
+function pinnedRuns(gh, repo, { pr, sha, baseRef, head, checks }) {
   const homes = homesAt(gh, repo, baseRef, checks);
+  // Every pull request, open or closed, from the head branch into another
+  // branch. Read once, and only when a gate run needs it.
+  let sideList;
+  const sides = () => {
+    if (sideList !== undefined) return sideList;
+    const owner = head?.repo?.owner?.login ?? head?.user?.login;
+    if (!head?.ref || !owner) return (sideList = null);
+    const all = gh('GET', `repos/${repo}/pulls?head=${encodeURIComponent(`${owner}:${head.ref}`)}&state=all&per_page=100`) ?? [];
+    return (sideList = all.filter((each) => each.base?.ref !== baseRef));
+  };
   const suites = new Map();
   const runOf = (id) => {
     if (!suites.has(id)) suites.set(id, id ? (gh('GET', `repos/${repo}/actions/runs?check_suite_id=${id}`)?.workflow_runs ?? [])[0] ?? null : null);
@@ -256,21 +268,10 @@ function pinnedRuns(gh, repo, { pr, sha, baseRef, checks }) {
   const kept = [];
   const refused = [];
   for (const check of checkRuns(gh, repo, sha)) {
-    if (!checks.includes(check.name) || check.name === GATE_CHECK || check.app?.id !== ACTIONS_APP_ID) continue;
-    const why = refusal(runOf(check.check_suite?.id), { name: check.name, pr, sha, baseRef, homes });
+    if (!checks.includes(check.name) || check.app?.id !== ACTIONS_APP_ID) continue;
+    const why = refusal(runOf(check.check_suite?.id), { name: check.name, pr, sha, baseRef, homes, sides });
     if (why) refused.push({ name: check.name, why }); else kept.push(check);
   }
-  if (checks.includes(GATE_CHECK)) {
-    const onBase = (commit) => ['ahead', 'identical'].includes(gh('GET', `repos/${repo}/compare/${commit}...${encodeURIComponent(baseRef)}`)?.status);
-    const runs = gh('GET', `repos/${repo}/actions/workflows/${GATE_WORKFLOW.split('/').pop()}/runs?event=pull_request_target&per_page=100`)?.workflow_runs ?? [];
-    for (const run of runs.filter((each) => each.display_title === gateRunTitle(pr, sha))) {
-      const why = gateRefusal(run, { pr, sha, baseRef, onBase });
-      if (why) { refused.push({ name: GATE_CHECK, why }); continue; }
-      for (const job of gh('GET', `repos/${repo}/actions/runs/${run.id}/jobs`)?.jobs ?? []) {
-        if (job.name === GATE_CHECK) kept.push({ ...job, app: { id: ACTIONS_APP_ID } });
-      }
-    }
-  }
   return { kept, refused };
 }
 
@@ -283,7 +284,7 @@ export function readyCommand({ repo, pr, answer }, line, gh = ghApi) {
   if (pull?.state !== 'open') { line(`atlas gate ready: pull request #${pr} is ${pull?.merged ? 'merged' : pull?.state ?? 'not found'}. NOT READY.`); return 1; }
   const sha = pull.head.sha;
   const checks = checksAt(gh, repo, pull.base.ref);
-  const { kept, refused } = pinnedRuns(gh, repo, { pr, sha, baseRef: pull.base.ref, checks });
+  const { kept, refused } = pinnedRuns(gh, repo, { pr, sha, baseRef: pull.base.ref, head: pull.head, checks });
   const rows = checkStates(checks, kept);
   line(`atlas gate ready: #${pr} at ${sha.slice(0, 7)}, ${checks.length} required check(s) from atlas.yaml on ${pull.base.ref}.`);
   for (const row of rows) line(checkLine(row));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arjunkhera/atlas",
-  "version": "0.4.11",
+  "version": "0.4.12",
   "description": "Atlas: the delivery lifecycle, its crews and the Atlas tools, as a Claude Code plugin for any repository.",
   "type": "module",
   "license": "UNLICENSED",