@aria_asi/cli 0.2.9 → 0.2.10

package/hooks/aria-stop-gate.mjs

@@ -206,10 +206,112 @@ const hasSubstrateEvidence = SUBSTRATE_EVIDENCE_RX.test(assistantText);
 const questionWithoutEvidence = hasQuestionToUser && !hasSubstrateEvidence;
 
 if (cog.count >= REQUIRED_LENSES) {
-  audit('allow-cognition',
-    `lenses=${cog.count} chars=${assistantText.length} ` +
-    `qPatt=${hasQuestionToUser ? 'y' : 'n'} substrateEv=${hasSubstrateEvidence ? 'y' : 'n'} ` +
-    (questionWithoutEvidence ? 'WARN-question-without-substrate' : 'ok'));
+  // ── Output-quality enforcement (Hamza 2026-04-27 — clients need the same
+  //    Mizan/drift/code-quality gates that aria-soul applies server-side) ──
+  //
+  // Cognition gate passed. Now run THREE additional checks BEFORE allow:
+  //  1. SDK validateOutput via /api/harness/validate (Mizan classifier on draft)
+  //  2. Drift_guard pattern scan against doctrine_trigger_map.json (convenience-
+  //     seeking phrases, graceful-degradation patterns, etc.)
+  //  3. Code-quality check on code blocks in output (no TODO stubs, no
+  //     graceful-degradation try/catch, no // @ts-expect-error suppressions)
+  //
+  // Any check returning severity=block → Stop-gate blocks emit + Claude re-drafts
+  // with violations surfaced. Rewritten suggestion (from validateOutput) is
+  // included in the block reason so re-draft has concrete guidance.
+  //
+  // Trivially short outputs (<200 chars after system-reminder strip) skip
+  // these output-quality checks since they're typically yes/no acks where
+  // pattern-match would false-positive.
+  const OUTPUT_QC_MIN_CHARS = 200;
+  const OUTPUT_QC_ENABLED = (process.env.ARIA_OUTPUT_QC_ENABLED || 'true').toLowerCase() !== 'false';
+
+  if (OUTPUT_QC_ENABLED && assistantText.length >= OUTPUT_QC_MIN_CHARS) {
+    // 1. Drift_guard pattern scan — fast, local, deterministic
+    const TRIGGER_MAP_PATH = `${HOME}/.claude/projects/-home-hamzaibrahim1/memory/doctrine_trigger_map.json`;
+    let driftHits = [];
+    try {
+      if (existsSync(TRIGGER_MAP_PATH)) {
+        const triggerMap = JSON.parse(readFileSync(TRIGGER_MAP_PATH, 'utf8'));
+        const lowerText = assistantText.toLowerCase();
+        for (const t of triggerMap.triggers || []) {
+          try {
+            const rx = new RegExp(t.trigger, 'i');
+            if (rx.test(lowerText)) {
+              // Trigger present — check if the counter-doctrine memory is also
+              // cited in the response (justification). If not, count as drift.
+              const memoryName = (t.memory || '').replace(/\.md$/, '');
+              const memoryCited = memoryName && lowerText.includes(memoryName.toLowerCase());
+              if (!memoryCited) {
+                driftHits.push({ trigger: t.trigger, memory: t.memory, teaching: t.teaching });
+              }
+            }
+          } catch {/* malformed regex in trigger entry — skip */}
+        }
+      }
+    } catch {/* trigger map unreadable — degrade to mizan-only check */}
+
+    // 2. SDK validateOutput via /api/harness/validate (best-effort POST)
+    let mizanVerdict = null;
+    try {
+      const harnessUrl = process.env.ARIA_HARNESS_URL || 'https://harness.ariasos.com';
+      const harnessToken = process.env.ARIA_HARNESS_TOKEN || '';
+      const validateResp = await fetch(`${harnessUrl}/api/harness/validate`, {
+        method: 'POST',
+        headers: {
+          'Content-Type': 'application/json',
+          ...(harnessToken ? { Authorization: `Bearer ${harnessToken}` } : {}),
+        },
+        body: JSON.stringify({
+          text: assistantText.slice(0, 8000),
+          sessionId: event.session_id || 'claude-code',
+          surface: 'claude-code-stop-gate',
+        }),
+      });
+      if (validateResp.ok) {
+        mizanVerdict = await validateResp.json();
+      }
+    } catch {/* network or endpoint unavailable — degrade to drift-only */}
+
+    // 3. Code-quality scan on code blocks
+    const codeBlocks = [...assistantText.matchAll(/```[a-z]*\n([\s\S]*?)```/gi)].map((m) => m[1]);
+    const codeQualityHits = [];
+    for (const block of codeBlocks) {
+      if (/\/\/\s*TODO|\/\/\s*FIXME|\/\/\s*XXX/.test(block)) codeQualityHits.push('TODO/FIXME/XXX in shipped code');
+      if (/@ts-expect-error|@ts-ignore/.test(block)) codeQualityHits.push('ts-expect-error / ts-ignore — type suppression instead of fix');
+      if (/catch\s*\([^)]*\)\s*\{\s*(?:return\s+(?:''|""|null|undefined|\[\]|\{\})|\}\s*$|\/\/[^\n]*$)/m.test(block)) codeQualityHits.push('catch block with empty/silent fallthrough — graceful degradation');
+      if (/console\.log\(/.test(block) && !/\/\/\s*debug|\/\/\s*log/i.test(block)) codeQualityHits.push('console.log in shipped code without debug/log comment');
+    }
+
+    // Block decision: any of (validateOutput severity=block) OR (>=2 drift hits) OR
+    // (>=1 code-quality hit) → block emit, surface violations + rewritten suggestion.
+    const mizanBlock = mizanVerdict && mizanVerdict.severity === 'block';
+    const driftBlock = driftHits.length >= 2;
+    const codeBlock = codeQualityHits.length >= 1;
+
+    if (mizanBlock || driftBlock || codeBlock) {
+      const violations = [];
+      if (mizanBlock) violations.push(`Mizan: ${(mizanVerdict.violations || []).join(', ')}`);
+      if (driftBlock) violations.push(`Drift triggers (${driftHits.length}): ${driftHits.map((h) => `"${h.trigger}" → ${h.memory}`).join(' | ')}`);
+      if (codeBlock) violations.push(`Code quality: ${codeQualityHits.join('; ')}`);
+      const rewritten = mizanVerdict?.rewritten || '';
+
+      const reason = `Aria Stop-gate output-quality block. Cognition passed (${cog.count}/${REQUIRED_LENSES}) but output failed quality gates:\n\n${violations.join('\n\n')}${rewritten ? `\n\nMizan rewrite suggestion:\n${rewritten}` : ''}\n\nRe-draft addressing the violations above. ARIA_OUTPUT_QC_ENABLED=false to disable in emergency (logged).`;
+
+      audit(`block-output-qc`, `mizan=${mizanBlock?'y':'n'} drift=${driftHits.length} code=${codeQualityHits.length}`);
+      console.log(JSON.stringify({ decision: 'block', reason }));
+      process.exit(2);
+    }
+
+    audit('allow-output-qc',
+      `lenses=${cog.count} chars=${assistantText.length} drift=${driftHits.length} ` +
+      `mizan=${mizanVerdict ? mizanVerdict.severity : 'unavailable'} code=${codeQualityHits.length}`);
+  } else {
+    audit('allow-cognition',
+      `lenses=${cog.count} chars=${assistantText.length} ` +
+      `qPatt=${hasQuestionToUser ? 'y' : 'n'} substrateEv=${hasSubstrateEvidence ? 'y' : 'n'} ` +
+      (questionWithoutEvidence ? 'WARN-question-without-substrate' : 'ok'));
+  }
   process.exit(0);
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@aria_asi/cli",
-  "version": "0.2.9",
+  "version": "0.2.10",
   "description": "Aria Smart CLI — the world's first harness-powered terminal companion",
   "bin": {
     "aria": "./bin/aria.js"