@aria_asi/cli 0.2.39 → 0.2.41

package/hooks/aria-claim-evidence-stop-gate.mjs

@@ -0,0 +1,240 @@
+#!/usr/bin/env node
+/**
+ * aria-claim-evidence-stop-gate.mjs — Phase 9 v3 M9.DRIFT.9.STOPHOOK.
+ *
+ * Stop hook that intercepts the assistant response from THIS turn before
+ * the model is marked complete. Walks the transcript JSONL (path provided
+ * by Claude Code in the event payload) backward from the latest entry,
+ * accumulates every text-block from assistant turns since the last real
+ * user-message boundary, then pipes the accumulated text to
+ * apps/arias-soul/scripts/scan-claim-evidence.mjs --stdin --format json.
+ *
+ * If the validator reports counts.fail > 0, this hook emits a JSON
+ * decision=block message with a reason naming each FAIL claim's class +
+ * matched substring. Claude Code interprets decision=block as a redo
+ * directive, so the operator-visible response gets composed again with
+ * the FAIL-claim feedback in scope.
+ *
+ * Why this rung exists: the original M9.DRIFT.9 (43919c1f) shipped a
+ * skill + on-demand validator + pattern doc and explicitly claimed in
+ * spec author_notes that "a true gate that prevents my claim before
+ * sending would require intercepting model output before stream
+ * emission — that's an invocation-layer change, not something this
+ * spec produces." That claim was wrong. Claude Code Stop hooks ARE the
+ * checkpoint — they fire after the assistant response is composed but
+ * before it's marked complete and can return decision=block to force a
+ * redo. The mechanism was always available; M9.DRIFT.9 asserted
+ * impossibility without verifying. This rung corrects that.
+ *
+ * Doctrine bind:
+ *   - truth_over_deception: gate prevents bare claims from reaching the
+ *     operator
+ *   - axiom_runtime_rule.admit_ignorance: when claim has no evidence,
+ *     gate forces redo with explicit ignorance acknowledgment
+ *   - feedback_no_assumption_without_verification: claims without
+ *     adjacent evidence anchors get blocked
+ *   - clean_cognition: hook is opt-in (operator-policy), runs at the
+ *     single Stop checkpoint, no additional surfaces
+ *
+ * Opt-in: this hook is NOT auto-installed in settings.json because
+ * blocking conversational responses is an operator-policy decision.
+ * Operator enables via:
+ *   {
+ *     "hooks": {
+ *       "Stop": [
+ *         { "matcher": "*", "hooks": [
+ *           { "type": "command",
+ *             "command": "node /path/to/aria-claim-evidence-stop-gate.mjs" }
+ *         ]}
+ *       ]
+ *     }
+ *   }
+ *
+ * Exit / output protocol (Claude Code Stop hook spec):
+ *   - exit 0 with no JSON  -> allow (no block)
+ *   - exit 0 with JSON {decision:'block', reason:'...'} on stdout
+ *     -> block + show reason to model
+ *   - exit 2  -> block with stderr as reason (treated as error)
+ */
+
+import { readFileSync, existsSync } from 'node:fs';
+import { spawnSync } from 'node:child_process';
+import { resolve, dirname } from 'node:path';
+import { fileURLToPath } from 'node:url';
+
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = dirname(__filename);
+
+// scan-claim-evidence.mjs canonical location: relative to this hook's
+// repo location. ops/claude-hooks/ -> apps/arias-soul/scripts/.
+const SCAN_SCRIPT = resolve(__dirname, '..', '..', 'apps', 'arias-soul', 'scripts', 'scan-claim-evidence.mjs');
+
+// Same system-reminder skip pattern as aria-stop-gate.mjs:774.
+// Runtime-injected user-role messages (block errors, task-notifications,
+// harness packet preview) shouldn't count as turn boundaries.
+const SYSTEM_REMINDER_RX = /<system-reminder>[\s\S]*?<\/system-reminder>|<task-notification>[\s\S]*?<\/task-notification>|🔐 Aria Harness|task-notification|PreToolUse:[A-Z][A-Za-z]* hook blocking error|Stop hook blocking error/g;
+const SYSTEM_REMINDER_THRESHOLD = 0.6;
+
+async function readStdinAsync() {
+  return new Promise((resolveP) => {
+    let data = '';
+    process.stdin.setEncoding('utf8');
+    process.stdin.on('data', (chunk) => { data += chunk; });
+    process.stdin.on('end', () => resolveP(data));
+    process.stdin.on('error', () => resolveP(data));
+    if (process.stdin.isTTY) resolveP('');
+  });
+}
+
+function isReminderOnlyUserMessage(textContent) {
+  if (!textContent) return false;
+  const reminderMatches = textContent.match(SYSTEM_REMINDER_RX) || [];
+  if (reminderMatches.length === 0) return false;
+  const reminderChars = reminderMatches.reduce((s, x) => s + x.length, 0);
+  const fraction = reminderChars / Math.max(1, textContent.length);
+  return fraction >= SYSTEM_REMINDER_THRESHOLD;
+}
+
+/**
+ * Walk transcript JSONL backward, accumulate text-block content from
+ * assistant turns since the last real user-message boundary. Mirrors
+ * aria-stop-gate.mjs:786-840 turn-window logic. Returns accumulated
+ * text as a single string in chronological order (oldest assistant
+ * chunk in this turn first).
+ */
+function accumulateAssistantTextFromTurn(transcriptPath) {
+  if (!transcriptPath || !existsSync(transcriptPath)) return '';
+  let lines;
+  try {
+    lines = readFileSync(transcriptPath, 'utf-8').split('\n').filter(Boolean);
+  } catch (err) {
+    process.stderr.write(`[aria-claim-evidence-stop-gate:transcript-read] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+    return '';
+  }
+  const textChunks = [];
+  for (let i = lines.length - 1; i >= 0; i--) {
+    let m;
+    try {
+      m = JSON.parse(lines[i]);
+    } catch (err) {
+      process.stderr.write(`[aria-claim-evidence-stop-gate:transcript-message-parse] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+      continue;
+    }
+    const role = m.message?.role ?? m.role;
+    if (role === 'user') {
+      const content = m.message?.content ?? m.content ?? [];
+      const isToolResultOnly = Array.isArray(content) &&
+        content.length > 0 &&
+        content.every((b) => b && b.type === 'tool_result');
+      if (isToolResultOnly) continue;
+      const textContent = Array.isArray(content)
+        ? content.filter((b) => b && b.type === 'text').map((b) => b.text || '').join('\n')
+        : (typeof content === 'string' ? content : '');
+      if (textContent && isReminderOnlyUserMessage(textContent)) continue;
+      // Real user message reached — turn boundary.
+      break;
+    }
+    if (role !== 'assistant') continue;
+    const content = m.message?.content ?? m.content ?? [];
+    if (!Array.isArray(content)) continue;
+    const text = content
+      .filter((b) => b && b.type === 'text')
+      .map((b) => b.text || '')
+      .join('\n');
+    if (text) textChunks.push(text);
+  }
+  // Walked backward — reverse for chronological order.
+  return textChunks.reverse().join('\n\n');
+}
+
+function buildBlockReason(parsed) {
+  const failClaims = (parsed.claims || []).filter((c) => c.status === 'fail');
+  if (failClaims.length === 0) return null;
+  const lines = [];
+  lines.push('=== ARIA CLAIM-EVIDENCE STOP GATE ===');
+  lines.push('');
+  lines.push(`${failClaims.length} unsupported claim(s) detected in this turn's assistant text.`);
+  lines.push('Each claim below lacks an evidence anchor (file:line, exit code, git SHA, command output, or citation) within the surrounding window AND lacks an explicit ignorance acknowledgment ("I do not know", "without access to X", "unverified — verifying").');
+  lines.push('');
+  for (const c of failClaims) {
+    lines.push(`  ✗ [${c.class}] "${c.match}"`);
+    lines.push(`    window: ${c.window_preview}`);
+  }
+  lines.push('');
+  lines.push('REQUIRED REDO SHAPE:');
+  lines.push('  For each FAIL claim above, either:');
+  lines.push('    (a) add an evidence anchor (file:line reference, exit code, git SHA, or verbatim command output) within the same paragraph, OR');
+  lines.push('    (b) replace the claim with explicit ignorance acknowledgment ("I do not know without access to X", "unverified — running check now").');
+  lines.push('  Do NOT rephrase the same bare claim differently. The doctrine is feedback_no_assumption_without_verification.');
+  return lines.join('\n');
+}
+
+// Read event JSON from stdin (Claude Code Stop hook spec).
+const input = await readStdinAsync();
+if (!input.trim()) {
+  // No event payload — nothing to gate.
+  process.exit(0);
+}
+let event;
+try {
+  event = JSON.parse(input);
+} catch {
+  // Fail-OPEN on malformed event: this is a CONVERSATIONAL gate, not a
+  // safety-critical destructive-action gate. Malformed event during
+  // normal operation shouldn't block all responses. Surface to stderr.
+  process.stderr.write('[aria-claim-evidence-stop-gate] stdin not JSON; skipping\n');
+  process.exit(0);
+}
+
+const transcriptPath = event.transcript_path ?? event.transcriptPath;
+if (!transcriptPath) {
+  // No transcript available — can't accumulate assistant text. Allow.
+  process.exit(0);
+}
+
+const assistantText = accumulateAssistantTextFromTurn(transcriptPath);
+if (!assistantText.trim()) {
+  // No assistant text in this turn (e.g., the turn was tool-only or
+  // already-empty). Nothing to validate. Allow.
+  process.exit(0);
+}
+
+// Pipe to scan-claim-evidence.mjs --stdin --format json.
+if (!existsSync(SCAN_SCRIPT)) {
+  process.stderr.write(`[aria-claim-evidence-stop-gate] scan script not found at ${SCAN_SCRIPT}; skipping\n`);
+  process.exit(0);
+}
+const scan = spawnSync('node', [SCAN_SCRIPT, '--stdin', '--format', 'json'], {
+  input: assistantText,
+  encoding: 'utf8',
+  // Reasonable upper bound; scan-claim-evidence is a single-pass
+  // regex scanner so even very long turns finish in well under 5s.
+  timeout: 10000,
+});
+if (scan.error) {
+  process.stderr.write(`[aria-claim-evidence-stop-gate:spawn-error] ${scan.error.message}\n`);
+  process.exit(0);
+}
+// scan exits 0 (no fail) or 1 (fail). 2 = usage error.
+if (scan.status === 2) {
+  process.stderr.write(`[aria-claim-evidence-stop-gate:scan-usage-error] ${scan.stderr || '(no stderr)'}\n`);
+  process.exit(0);
+}
+let parsed;
+try {
+  parsed = JSON.parse(scan.stdout || '{}');
+} catch (err) {
+  process.stderr.write(`[aria-claim-evidence-stop-gate:scan-output-parse] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+  process.exit(0);
+}
+
+const failCount = parsed?.counts?.fail ?? 0;
+if (failCount > 0) {
+  const reason = buildBlockReason(parsed);
+  process.stdout.write(JSON.stringify({ decision: 'block', reason }, null, 2) + '\n');
+  process.exit(0);
+}
+
+// All claims either had evidence (PASS) or had explicit ignorance
+// acknowledgment (SKIPPED). Allow.
+process.exit(0);

package/hooks/aria-cognition-substrate-binding.mjs

@@ -1,4 +1,16 @@
 #!/usr/bin/env node
+// ── doctrine-self-check-file: M0.SELFREVIEW.1+2 (2026-05-06) ──
+// Session added comments describing prior antipatterns being migrated.
+// Each comment names a trigger pattern; file-level ack covers them all.
+// doctrine-self-check-file: (?:done|complete|completed|ready|verified|fixed).{0,120}(?:but|except|caveat|remaining|not yet|still|separate|later|blocked|skipped) session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: (?:non-blocking|warn(?:ing)? only|advisory|falls? through|fail open|soft fail|log(?:ged)? and continue|quality gate warning) session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: best.?effort session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: carve.?out|workaround|work.?around session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: edge case session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: i'll claim|claimed|fixed it session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: just context|advisory|read.only session-added-comments-describing-prior-state-or-migration
+// doctrine-self-check-file: kill.?switch|env.?(?:var|variable).?(?:override|disable|bypass)|process\.env\.[A-Z_]+\s*===\s*['"]off['"] session-added-comments-describing-prior-state-or-migration
+
 // aria-cognition-substrate-binding.mjs
 //
 // Stop hook — runs BEFORE aria-stop-gate.mjs.
@@ -40,6 +52,10 @@ import { homedir } from 'node:os';
 import { createHash } from 'node:crypto';
 import { ALL_LENS_NAMES, lensNamesForTier } from './lib/canonical-lenses.mjs';
 import { collectTurnWindowFromMessages } from './lib/hook-message-window.mjs';
+import { emitStopHookDecision } from './lib/stop-hook-protocol.mjs';
+// M0.H.X12 (2026-05-06): structural parser for `<cognition>`,
+// `<applied_cognition>`, etc. Replaces inline-regex extraction.
+import { parseCognitiveBlocks } from './lib/cognitive-block-parser.mjs';
 
 const HOME = homedir();
 const AUDIT = `${HOME}/.claude/aria-cognition-substrate-binding-audit.jsonl`;
@@ -51,7 +67,12 @@ function audit(event, data) {
       AUDIT,
       JSON.stringify({ ts: new Date().toISOString(), event, ...data }) + '\n',
     );
-  } catch {}
+  } catch (err) {
+    // M0.H.X3: substrate-binding audit-write failure now surfaces. Silent
+    // loss of audit entries means operator can't reconstruct binding
+    // decisions; surface visibly.
+    process.stderr.write(`[aria-cognition-substrate-binding:audit-write] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+  }
 }
 
 const LENS_NAMES = ALL_LENS_NAMES;
@@ -72,6 +93,11 @@ const LENS_NAMES = ALL_LENS_NAMES;
 //      rejected (you cannot anchor to substrate that is not loaded)
 const ANCHOR_RX = /\b(axiom|frame|memory|doctrine|packet|language):[a-z0-9_\-./]+/gi;
 
+// M0.H.X12 (2026-05-06): inline cognitive-block regex preserved as
+// locally-scoped const for the few remaining call sites that pass them
+// to .match() on a substring. New code path uses parseCognitiveBlocks()
+// (imported at top of file). Future commit migrates the .match() call
+// sites at line ~160 + ~549 to parseCognitiveBlocks().
 const COGNITION_BLOCK_RX = /<cognition>([\s\S]*?)<\/cognition>/i;
 const APPLIED_COGNITION_BLOCK_RX = /<applied_cognition>([\s\S]*?)<\/applied_cognition>/i;
 const FIRST_PRINCIPLE_RX = /\b(first[_\s-]?principle[s]?|first_principle=)\b/i;
@@ -147,12 +173,31 @@ function emitRecoverableSubstrateBinding(reason, { source = 'substrate-binding'
   };
   mkdirSync(dirname(CURRENT_RECOVERY_PATH), { recursive: true, mode: 0o700 });
   writeFileSync(CURRENT_RECOVERY_PATH, `${JSON.stringify(recovery, null, 2)}\n`, { mode: 0o600 });
-  console.log(JSON.stringify({ decision: 'allow', recoveryRequired: recovery }));
-  process.exit(0);
+  // M9.DRIFT.10t — recovery contract data persists to disk above
+  // (CURRENT_RECOVERY_PATH); the Stop hook stdout protocol does not
+  // accept extra root keys like recoveryRequired. Emit the canonical
+  // shape only; the next-turn SessionStart hook reads the contract
+  // file via recovery-context.mjs and surfaces it through the proper
+  // additionalContext channel. Decision="approve" because the gate
+  // is recording the recovery contract for next turn, not blocking
+  // this turn's emit.
+  emitStopHookDecision({
+    decision: 'approve',
+    reason: `recovery contract written to ${CURRENT_RECOVERY_PATH}; next-turn SessionStart will load it via recovery-context.mjs`,
+  });
+  return; // unreachable; emitStopHookDecision called process.exit
 }
 
 function validateAppliedCognitionContract(text) {
-  const match = String(text || '').match(APPLIED_COGNITION_BLOCK_RX);
+  // M0.H.X12 (2026-05-06): structural parser surfaces malformed-tag
+  // edge cases (unclosed tags, duplicates) that prior inline regex
+  // silently dropped. The .applied_cognition extraction here is
+  // semantically equivalent to the prior `match[1]` form.
+  const parsed = parseCognitiveBlocks(text);
+  if (parsed.malformed.tags_unclosed.includes('applied_cognition') || parsed.malformed.tags_duplicated.includes('applied_cognition')) {
+    process.stderr.write(`[aria-cognition-substrate-binding:applied-cognition-malformed] tags_unclosed=${parsed.malformed.tags_unclosed.join(',')} tags_duplicated=${parsed.malformed.tags_duplicated.join(',')}\n`);
+  }
+  const match = parsed.applied_cognition ? [, parsed.applied_cognition] : null;
   if (!match) {
     return { ok: false, violations: ['missing <applied_cognition> contract'] };
   }
@@ -219,7 +264,12 @@ function loadCarryForwardViolations() {
           kind: parsed.kind || null,
           sessionId: parsed.sessionId || parsed.session_id || null,
         });
-      } catch {}
+      } catch (err) {
+        // M0.H.X3: per-line carry-forward parse failure now surfaces.
+        // One bad line in the carry-forward log was previously silent;
+        // operator can now spot log corruption.
+        process.stderr.write(`[aria-cognition-substrate-binding:carry-forward-line-parse] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+      }
     }
   } catch (err) {
     audit('carry_forward_load_error', { err: String(err).slice(0, 200) });
@@ -342,7 +392,11 @@ function loadHarnessSubstrateSet() {
             set.memories.add(m[1].toLowerCase());
           }
         }
-      } catch {}
+      } catch (err) {
+        // M0.H.X3: MEMORY.md index read failure now surfaces. Set is
+        // populated best-effort; operator sees if the index is corrupted.
+        process.stderr.write(`[aria-cognition-substrate-binding:memory-index-read] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+      }
     }
   } catch (err) {
     audit('substrate_load_error', { err: String(err).slice(0, 200) });
@@ -364,7 +418,10 @@ function loadMemoryFilesSync() {
         out.add(m[1].toLowerCase());
       }
     }
-  } catch {}
+  } catch (err) {
+    // M0.H.X3: standalone memory-files lister failure now surfaces.
+    process.stderr.write(`[aria-cognition-substrate-binding:memory-files-list] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+  }
   return out;
 }
 
@@ -427,7 +484,12 @@ function verifyAnchorsAgainstLoaded(anchors, loadedSet, memoryFiles) {
 let stdin = '';
 try {
   for await (const chunk of process.stdin) stdin += chunk;
-} catch {}
+} catch (err) {
+  // M0.H.X3: stdin read failure now surfaces. Falls through to empty
+  // stdin below; payload parse will likely fail and trigger downstream
+  // handling. Operator sees the underlying read failure.
+  process.stderr.write(`[aria-cognition-substrate-binding:stdin-read] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+}
 
 let payload;
 try {
@@ -494,7 +556,12 @@ if (carryForwardMatch) {
         sessionId: payload.session_id || payload.sessionId || null,
       }) + '\n',
     );
-  } catch {}
+  } catch (err) {
+    // M0.H.X3: thrashing-state write failure now surfaces. Loss of
+    // carry-forward block records means operator can't track repeated
+    // gate violations across turns; surface visibly.
+    process.stderr.write(`[aria-cognition-substrate-binding:thrashing-state-write] caught: ${err instanceof Error ? err.message : String(err)}\n`);
+  }
 
   audit('block_carry_forward_force_constraint', {
     substring: carryForwardMatch.substring,
@@ -519,7 +586,14 @@ Per feedback_block_and_force_with_recovery.md, repetition of a recently-blocked
   emitRecoverableSubstrateBinding(buildForceReauthorReason({ source: 'substrate-binding/carry-forward', reason, violations: [`repeated blocked substring: ${carryForwardMatch.substring}`] }), { source: 'substrate-binding/carry-forward' });
 }
 
-const cogMatch = assistantText.match(COGNITION_BLOCK_RX);
+// M0.H.X12 (2026-05-06): structural parser for the main cognition extraction.
+// Surfaces malformed-tag warnings so unclosed/duplicated tags don't silently
+// degrade to "no cognition" treatment when the issue is corruption not absence.
+const _cognitionParse = parseCognitiveBlocks(assistantText);
+if (_cognitionParse.malformed.tags_unclosed.includes('cognition') || _cognitionParse.malformed.tags_duplicated.includes('cognition')) {
+  process.stderr.write(`[aria-cognition-substrate-binding:cognition-malformed] tags_unclosed=${_cognitionParse.malformed.tags_unclosed.join(',')} tags_duplicated=${_cognitionParse.malformed.tags_duplicated.join(',')}\n`);
+}
+const cogMatch = _cognitionParse.cognition ? [, _cognitionParse.cognition] : null;
 if (!cogMatch) {
   // BLOCK: missing cognition block
   // Prior to 2026-04-29 this was process.exit(0) with comment "defer to