@aria-cli/tools 1.0.9 → 1.0.11

package/tests/executors/web-abort-vs-timeout.test.ts

@@ -1,213 +0,0 @@
-/**
- * @aria/tools - Web executor abort vs timeout tests (I5 fix)
- *
- * Verifies that web executors correctly distinguish between context
- * cancellation (abort signal) and timeout, reporting "cancelled" vs "timed out".
- */
-
-import { describe, it, expect, beforeEach, afterEach, vi } from "vitest";
-import * as fs from "node:fs/promises";
-import * as path from "node:path";
-import * as os from "node:os";
-import type { ToolContext } from "../../src/types.js";
-import { executeWebSearch, executeWebFetch, executeBrowse } from "../../src/executors/web.js";
-import { searchCache, fetchCache, browseCache } from "../../src/cache/web-cache.js";
-
-// Mock DNS globally to avoid real network lookups in all tests
-vi.mock("node:dns", async (importOriginal) => {
-  const actual = (await importOriginal()) as any;
-  return {
-    ...actual,
-    promises: {
-      ...actual.promises,
-      lookup: vi.fn().mockResolvedValue({ address: "93.184.216.34", family: 4 }),
-    },
-  };
-});
-
-vi.mock("../../src/security/dns-pinning.js", async (importOriginal) => {
-  const actual = await importOriginal<typeof import("../../src/security/dns-pinning.js")>();
-  const dnsModule = await import("node:dns");
-  const ssrfModule = await import("../../src/security/ssrf.js");
-  return {
-    ...actual,
-    fetchWithDnsPinning: vi.fn(async (url: string, init: RequestInit) => {
-      const parsed = new URL(url);
-      const lookupResult = await dnsModule.promises.lookup(parsed.hostname, {
-        all: true,
-        verbatim: true,
-      });
-      const addresses = Array.isArray(lookupResult)
-        ? lookupResult.map((entry) => entry.address)
-        : "address" in lookupResult && typeof lookupResult.address === "string"
-          ? [lookupResult.address]
-          : [];
-      const privateAddress = addresses.find((address) => ssrfModule.isPrivateAddress(address));
-      if (privateAddress) {
-        throw new Error(
-          `SSRF protection: ${parsed.hostname} resolves to private address ${privateAddress}`,
-        );
-      }
-      return global.fetch(url, init);
-    }),
-  };
-});
-
-const createTempDir = async (): Promise<string> => {
-  const tempDir = await fs.mkdtemp(path.join(os.tmpdir(), "aria-abort-test-"));
-  return fs.realpath(tempDir);
-};
-
-const cleanupTempDir = async (dir: string): Promise<void> => {
-  await fs.rm(dir, { recursive: true, force: true });
-};
-
-const createContext = (workingDir: string, env: Record<string, string> = {}): ToolContext => ({
-  workingDir,
-  env,
-});
-
-/** Creates a mock fetch that hangs until its signal is aborted */
-function createHangingFetchMock() {
-  return vi.fn().mockImplementation((_url: string, options?: RequestInit) => {
-    return new Promise((_resolve, reject) => {
-      const signal = options?.signal;
-      if (signal) {
-        if (signal.aborted) {
-          const abortError = new Error("The operation was aborted");
-          abortError.name = "AbortError";
-          reject(abortError);
-          return;
-        }
-        signal.addEventListener("abort", () => {
-          const abortError = new Error("The operation was aborted");
-          abortError.name = "AbortError";
-          reject(abortError);
-        });
-      }
-    });
-  });
-}
-
-describe("Web executor abort vs timeout (I5 fix)", () => {
-  let tempDir: string;
-  let ctx: ToolContext;
-  let originalFetch: typeof global.fetch;
-  let savedKey: string | undefined;
-
-  beforeEach(async () => {
-    tempDir = await createTempDir();
-    ctx = createContext(tempDir);
-    originalFetch = global.fetch;
-    savedKey = process.env.TAVILY_API_KEY;
-    delete process.env.TAVILY_API_KEY;
-    // Clear web caches between tests
-    searchCache.clear();
-    fetchCache.clear();
-    browseCache.clear();
-  });
-
-  afterEach(async () => {
-    await cleanupTempDir(tempDir);
-    global.fetch = originalFetch;
-    if (savedKey !== undefined) {
-      process.env.TAVILY_API_KEY = savedKey;
-    }
-  });
-
-  describe("context abort reports 'cancelled'", () => {
-    it("executeWebSearch: should report 'cancelled' on context abort, not 'timed out'", async () => {
-      const ac = new AbortController();
-      const ctxWithAbort = {
-        ...createContext(tempDir, { TAVILY_API_KEY: "test-key" }),
-        abortSignal: ac.signal,
-      };
-
-      vi.stubGlobal("fetch", createHangingFetchMock());
-
-      const resultPromise = executeWebSearch({ query: "test" }, ctxWithAbort);
-      // Abort immediately via context signal
-      ac.abort();
-      const result = await resultPromise;
-
-      expect(result.success).toBe(false);
-      expect(result.message).toContain("cancelled");
-      expect(result.message).not.toContain("timed out");
-    });
-
-    it("executeWebFetch: should report 'cancelled' on context abort, not 'timed out'", async () => {
-      const ac = new AbortController();
-      const ctxWithAbort = { ...ctx, abortSignal: ac.signal };
-
-      vi.stubGlobal("fetch", createHangingFetchMock());
-
-      const resultPromise = executeWebFetch({ url: "https://example.com/slow" }, ctxWithAbort);
-      // Small delay to let validateUrl() complete and event listener register
-      await new Promise((r) => setTimeout(r, 50));
-      ac.abort();
-      const result = await resultPromise;
-
-      expect(result.success).toBe(false);
-      expect(result.message).toContain("cancelled");
-      expect(result.message).not.toContain("timed out");
-    });
-
-    it("executeBrowse: should report 'cancelled' on context abort, not 'timed out'", async () => {
-      const ac = new AbortController();
-      const ctxWithAbort = { ...ctx, abortSignal: ac.signal };
-
-      vi.stubGlobal("fetch", createHangingFetchMock());
-
-      const resultPromise = executeBrowse({ url: "https://example.com/slow" }, ctxWithAbort);
-      // Small delay to let validateUrl() complete and event listener register
-      await new Promise((r) => setTimeout(r, 50));
-      ac.abort();
-      const result = await resultPromise;
-
-      expect(result.success).toBe(false);
-      expect(result.message).toContain("cancelled");
-      expect(result.message).not.toContain("timed out");
-    });
-  });
-
-  describe("timeout still reports 'timed out'", () => {
-    it("executeWebFetch: should report 'timed out' on timeout (no context abort)", async () => {
-      vi.stubGlobal("fetch", createHangingFetchMock());
-
-      // No ctx.abortSignal -- timeout is the only abort mechanism
-      const result = await executeWebFetch({ url: "https://example.com/slow", timeoutMs: 50 }, ctx);
-
-      expect(result.success).toBe(false);
-      expect(result.message).toContain("timed out");
-      expect(result.message).not.toContain("cancelled");
-    });
-
-    it("executeBrowse: should report 'timed out' on timeout (no context abort)", async () => {
-      vi.stubGlobal("fetch", createHangingFetchMock());
-
-      const result = await executeBrowse({ url: "https://example.com/slow", timeoutMs: 50 }, ctx);
-
-      expect(result.success).toBe(false);
-      expect(result.message).toContain("timed out");
-      expect(result.message).not.toContain("cancelled");
-    });
-
-    it("executeWebSearch: should report 'timed out' on timeout (no context abort)", async () => {
-      vi.stubGlobal("fetch", createHangingFetchMock());
-
-      const ctxWithKey = createContext(tempDir, { TAVILY_API_KEY: "test-key" });
-
-      // Web search uses a 30s default timeout; we can't override it easily.
-      // Instead, mock fetch to check the signal's timeout controller fires.
-      // The fetch mock never resolves, so the 30s timeout controller fires.
-      // But we can't wait 30s in a test. So instead, verify the cancellation
-      // path works correctly by checking a shorter scenario where we know
-      // the timeout fires the internal AbortController (not the ctx signal).
-      // We test this indirectly: when timeout fires but ctx.abortSignal is NOT
-      // set, the message should say "timed out".
-      // We'll use executeWebFetch with timeoutMs to test this pattern.
-      // The executeWebSearch test above already verified the cancel path.
-      // This test is a no-op placeholder to avoid waiting 30s.
-    });
-  });
-});