@argos-ci/playwright 3.1.1-alpha.0 → 3.3.0

package/dist/reporter.d.ts

@@ -1,15 +1,39 @@
 /// <reference types="node" />
 import { FullConfig, FullResult, Reporter, Suite, TestCase, TestResult } from "@playwright/test/reporter";
 import { UploadParameters } from "@argos-ci/core";
-type ArgosReporterOptions = Omit<UploadParameters, "files" | "root"> & {
+/**
+ * Dynamic build name.
+ * We require all values in order to ensure it works correctly in parallel mode.
+ */
+type DynamicBuildName<T extends readonly string[]> = {
+    /**
+     * The values that the build name can take.
+     * It is required to ensure Argos will always upload
+     * for each build name in order to work in sharding mode.
+     */
+    values: readonly [...T];
+    /**
+     * Get the build name for a test case.
+     * Returns any of the values in `values`.
+     */
+    get: (test: TestCase) => T[number];
+};
+type ArgosReporterOptions<T extends string[] = string[]> = Omit<UploadParameters, "files" | "root" | "buildName"> & {
     /**
      * Upload the report to Argos.
      * @default true
      */
     uploadToArgos?: boolean;
+    /**
+     * The name of the build in Argos.
+     * Can be a string or a function that receives the test case and returns the build name.
+     */
+    buildName?: string | DynamicBuildName<T> | null;
 };
+declare function createArgosReporterOptions<T extends string[]>(options: ArgosReporterOptions<T>): ArgosReporterOptions<T>;
 declare class ArgosReporter implements Reporter {
-    createUploadDirPromise: null | Promise<string>;
+    rootUploadDirectoryPromise: null | Promise<string>;
+    uploadDirectoryPromises: Map<string, Promise<string>>;
     config: ArgosReporterOptions;
     playwrightConfig: FullConfig;
     uploadToArgos: boolean;
@@ -36,11 +60,17 @@ declare class ArgosReporter implements Reporter {
      */
     copyTraceIfFound(result: TestResult, path: string): Promise<void>;
     getAutomaticScreenshotName(test: TestCase, result: TestResult): string;
-    getUploadDir(): Promise<string>;
+    /**
+     * Get the root upload directory (cached).
+     */
+    /**
+     * Get the root upload directory (cached).
+     */
+    getRootUploadDirectory(): Promise<string>;
     onBegin(config: FullConfig, _suite: Suite): void;
     onTestEnd(test: TestCase, result: TestResult): Promise<void>;
     onEnd(_result: FullResult): Promise<{
         status: "failed";
     } | undefined>;
 }
-export { ArgosReporter as default, ArgosReporterOptions };
+export { ArgosReporter as default, ArgosReporterOptions, createArgosReporterOptions };

package/dist/reporter.mjs

@@ -1,7 +1,7 @@
 import chalk from 'chalk';
 import { upload, readConfig } from '@argos-ci/core';
 import { randomBytes } from 'node:crypto';
-import { mkdir, writeFile, copyFile } from 'node:fs/promises';
+import { writeFile, copyFile, readdir, mkdir } from 'node:fs/promises';
 import { tmpdir } from 'node:os';
 import { relative, dirname, join } from 'node:path';
 import { getGitRepositoryPath, readVersionFromPackage } from '@argos-ci/util';
@@ -107,16 +107,38 @@ async function getMetadataFromTestCase(testCase, testResult) {
 const KEY = "@argos-ci/playwright";
 const debug = createDebug(KEY);
 
-async function createUploadDirectory() {
-    debug("Creating temporary directory for screenshots");
+const createDirectoryPromises = new Map();
+/**
+ * Create a directory if it doesn't exist.
+ */ async function createDirectory(pathname) {
+    let promise = createDirectoryPromises.get(pathname);
+    if (promise) {
+        return promise;
+    }
+    promise = mkdir(pathname, {
+        recursive: true
+    }).then(()=>{});
+    createDirectoryPromises.set(pathname, promise);
+    return promise;
+}
+/**
+ * Create temporary directory.
+ */ async function createTemporaryDirectory() {
+    debug("Creating temporary directory");
     const osTmpDirectory = tmpdir();
     const path = join(osTmpDirectory, "argos." + randomBytes(16).toString("hex"));
-    await mkdir(path, {
-        recursive: true
-    });
+    await createDirectory(path);
     debug(`Temporary directory created: ${path}`);
     return path;
 }
+/**
+ * Check if the build name is dynamic.
+ */ function checkIsDynamicBuildName(buildName) {
+    return Boolean(typeof buildName === "object" && buildName);
+}
+function createArgosReporterOptions(options) {
+    return options;
+}
 async function getParallelFromConfig(config) {
     if (!config.shard) return null;
     if (config.shard.total === 1) return null;
@@ -131,25 +153,21 @@ async function getParallelFromConfig(config) {
     };
 }
 class ArgosReporter {
-    createUploadDirPromise;
+    rootUploadDirectoryPromise;
+    uploadDirectoryPromises;
     config;
     playwrightConfig;
     uploadToArgos;
     constructor(config){
         this.config = config;
         this.uploadToArgos = config.uploadToArgos ?? true;
-        this.createUploadDirPromise = null;
+        this.rootUploadDirectoryPromise = null;
+        this.uploadDirectoryPromises = new Map();
     }
     /**
    * Write a file to the temporary directory.
    */ async writeFile(path, body) {
-        const uploadDir = await this.getUploadDir();
-        const dir = dirname(path);
-        if (dir !== uploadDir) {
-            await mkdir(dir, {
-                recursive: true
-            });
-        }
+        await createDirectory(dirname(path));
         debug(`Writing file to ${path}`);
         await writeFile(path, body);
         debug(`File written to ${path}`);
@@ -157,13 +175,7 @@ class ArgosReporter {
     /**
    * Copy a file to the temporary directory.
    */ async copyFile(from, to) {
-        const uploadDir = await this.getUploadDir();
-        const dir = dirname(to);
-        if (dir !== uploadDir) {
-            await mkdir(dir, {
-                recursive: true
-            });
-        }
+        await createDirectory(dirname(to));
         debug(`Copying file from ${from} to ${to}`);
         await copyFile(from, to);
         debug(`File copied from ${from} to ${to}`);
@@ -182,18 +194,25 @@ class ArgosReporter {
         name += result.status === "failed" || result.status === "timedOut" ? " (failed)" : "";
         return name;
     }
-    getUploadDir() {
-        if (!this.createUploadDirPromise) {
-            this.createUploadDirPromise = createUploadDirectory();
+    /**
+   * Get the root upload directory (cached).
+   */ getRootUploadDirectory() {
+        if (!this.rootUploadDirectoryPromise) {
+            this.rootUploadDirectoryPromise = createTemporaryDirectory();
         }
-        return this.createUploadDirPromise;
+        return this.rootUploadDirectoryPromise;
     }
     onBegin(config, _suite) {
         debug("ArgosReporter:onBegin");
         this.playwrightConfig = config;
     }
     async onTestEnd(test, result) {
-        const uploadDir = await this.getUploadDir();
+        const buildName = checkIsDynamicBuildName(this.config.buildName) ? this.config.buildName.get(test) : this.config.buildName;
+        if (buildName === "") {
+            throw new Error('Argos "buildName" cannot be an empty string.');
+        }
+        const rootUploadDir = await this.getRootUploadDirectory();
+        const uploadDir = buildName ? join(rootUploadDir, buildName) : rootUploadDir;
         debug("ArgosReporter:onTestEnd");
         await Promise.all(result.attachments.map(async (attachment)=>{
             if (checkIsArgosScreenshot(attachment) || checkIsArgosScreenshotMetadata(attachment)) {
@@ -220,10 +239,10 @@ class ArgosReporter {
     }
     async onEnd(_result) {
         debug("ArgosReporter:onEnd");
-        const uploadDir = await this.getUploadDir();
+        const rootUploadDir = await this.getRootUploadDirectory();
         if (!this.uploadToArgos) {
             debug("Not uploading to Argos because uploadToArgos is false.");
-            debug(`Upload directory: ${uploadDir}`);
+            debug(`Upload directory: ${rootUploadDir}`);
             return;
         }
         debug("Getting parallel from config");
@@ -233,17 +252,46 @@ class ArgosReporter {
         } else {
             debug("Non-parallel mode");
         }
+        const buildNameConfig = this.config.buildName;
+        const uploadOptions = {
+            files: [
+                "**/*.png"
+            ],
+            parallel: parallel ?? undefined,
+            ...this.config
+        };
         try {
-            debug("Uploading to Argos");
-            const res = await upload({
-                files: [
-                    "**/*.png"
-                ],
-                root: uploadDir,
-                parallel: parallel ?? undefined,
-                ...this.config
-            });
-            console.log(chalk.green(`✅ Argos build created: ${res.build.url}`));
+            if (checkIsDynamicBuildName(buildNameConfig)) {
+                debug(`Dynamic build names, uploading to Argos for each build name: ${buildNameConfig.values.join()}`);
+                const directories = await readdir(rootUploadDir);
+                // Check if the buildName.values are consistent with the directories created
+                if (directories.some((dir)=>!buildNameConfig.values.includes(dir))) {
+                    throw new Error(`The \`buildName.values\` (${buildNameConfig.values.join(", ")}) are inconsistent with the \`buildName.get\` returns values (${directories.join(", ")}). Please fix the configuration.`);
+                }
+                // In non-parallel mode, we iterate over the directories to avoid creating useless builds
+                const iteratesOnBuildNames = parallel ? buildNameConfig.values : directories;
+                // Iterate over each build name and upload the screenshots
+                for (const buildName of iteratesOnBuildNames){
+                    const uploadDir = join(rootUploadDir, buildName);
+                    await createDirectory(uploadDir);
+                    debug(`Uploading to Argos for build: ${buildName}`);
+                    const res = await upload({
+                        ...uploadOptions,
+                        root: uploadDir,
+                        buildName
+                    });
+                    console.log(chalk.green(`✅ Argos "${buildName}" build created: ${res.build.url}`));
+                }
+            } else {
+                debug("Uploading to Argos");
+                const uploadDir = buildNameConfig ? join(rootUploadDir, buildNameConfig) : rootUploadDir;
+                const res = await upload({
+                    ...uploadOptions,
+                    root: uploadDir,
+                    buildName: buildNameConfig ?? undefined
+                });
+                console.log(chalk.green(`✅ Argos build created: ${res.build.url}`));
+            }
         } catch (error) {
             console.error(error);
             return {
@@ -254,4 +302,4 @@ class ArgosReporter {
     }
 }
 
-export { ArgosReporter as default };
+export { createArgosReporterOptions, ArgosReporter as default };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@argos-ci/playwright",
   "description": "Visual testing solution to avoid visual regression. Playwright commands and utilities for Argos visual testing.",
-  "version": "3.1.1-alpha.0+d1a818a",
+  "version": "3.3.0",
   "author": "Smooth Code",
   "license": "MIT",
   "repository": {
@@ -43,13 +43,13 @@
   },
   "dependencies": {
     "@argos-ci/browser": "2.1.2",
-    "@argos-ci/core": "2.2.1-alpha.7+d1a818a",
+    "@argos-ci/core": "2.3.0",
     "@argos-ci/util": "2.0.0",
     "chalk": "^5.3.0",
     "debug": "^4.3.4"
   },
   "devDependencies": {
-    "@argos-ci/cli": "2.1.1-alpha.7+d1a818a",
+    "@argos-ci/cli": "2.2.0",
     "@argos-ci/playwright": "workspace:.",
     "@playwright/test": "^1.43.0",
     "@types/debug": "^4.1.12",
@@ -61,5 +61,5 @@
     "test": "pnpm exec -- playwright test",
     "e2e": "UPLOAD_TO_ARGOS=true pnpm run test"
   },
-  "gitHead": "d1a818aeee5bcba93c0492be43704f8c3682222e"
+  "gitHead": "5c09f1d861630af0d98200e52a0f44876bb7f891"
 }