@argos-ci/core 0.7.0 → 0.7.2

package/dist/index.mjs

@@ -1,6 +1,8 @@
 import convict from 'convict';
+import { execSync } from 'node:child_process';
+import { execSync as execSync$1 } from 'child_process';
+import createDebug from 'debug';
 import envCi from 'env-ci';
-import { execSync } from 'child_process';
 import { resolve } from 'node:path';
 import glob from 'fast-glob';
 import { promisify } from 'node:util';
@@ -10,7 +12,6 @@ import { createReadStream } from 'node:fs';
 import { createHash } from 'node:crypto';
 import axios from 'axios';
 import { readFile } from 'node:fs/promises';
-import createDebug from 'debug';
 
 const mustBeApiBaseUrl = (value)=>{
     const URL_REGEX = /https?:\/\/(www\.)?[-a-zA-Z0-9@:%._\+~#=]{1,256}\.[a-zA-Z0-9()]{1,6}\b([-a-zA-Z0-9()@:%_\+.~#?&//=]*)/;
@@ -41,14 +42,13 @@ const schema = {
     },
     commit: {
         env: "ARGOS_COMMIT",
-        default: "",
+        default: null,
         format: mustBeCommit
     },
     branch: {
         env: "ARGOS_BRANCH",
         default: null,
-        format: String,
-        nullable: true
+        format: String
     },
     token: {
         env: "ARGOS_TOKEN",
@@ -61,6 +61,12 @@ const schema = {
         format: String,
         nullable: true
     },
+    prNumber: {
+        env: "ARGOS_PR_NUMBER",
+        format: Number,
+        default: null,
+        nullable: true
+    },
     parallel: {
         env: "ARGOS_PARALLEL",
         default: false,
@@ -93,11 +99,6 @@ const schema = {
         default: null,
         nullable: true
     },
-    prNumber: {
-        format: Number,
-        default: null,
-        nullable: true
-    },
     owner: {
         format: String,
         default: null,
@@ -116,45 +117,54 @@ const createConfig = ()=>{
 };
 
 /**
- * Omit undefined properties from an object.
- */ const omitUndefined = (obj)=>{
-    const result = {};
-    Object.keys(obj).forEach((key)=>{
-        if (obj[key] !== undefined) {
-            result[key] = obj[key];
+ * Returns the head commit.
+ */ const head = ()=>{
+    try {
+        return execSync("git rev-parse HEAD").toString().trim();
+    } catch  {
+        return null;
+    }
+};
+/**
+ * Returns the current branch.
+ */ const branch = ()=>{
+    try {
+        const headRef = execSync("git rev-parse --abbrev-ref HEAD").toString().trim();
+        if (headRef === "HEAD") {
+            return null;
         }
-    });
-    return result;
+        return headRef;
+    } catch  {
+        return null;
+    }
 };
 
 const service$4 = {
+    name: "Buildkite",
     detect: ({ env  })=>Boolean(env.BUILDKITE),
     config: ({ env  })=>{
-        const ciProps = envCiDetection({
-            env
-        });
         return {
-            name: "Buildkite",
-            commit: ciProps?.commit || null,
-            branch: env.BUILDKITE_BRANCH || null,
+            // Buildkite doesn't work well so we fallback to git to ensure we have commit and branch
+            commit: env.BUILDKITE_COMMIT || head() || null,
+            branch: env.BUILDKITE_BRANCH || branch() || null,
             owner: env.BUILDKITE_ORGANIZATION_SLUG || null,
             repository: env.BUILDKITE_PROJECT_SLUG || null,
-            jobId: env.BUILDKITE_JOB_ID || null,
-            runId: ciProps?.runId || null,
+            jobId: null,
+            runId: null,
             prNumber: env.BUILDKITE_PULL_REQUEST ? Number(env.BUILDKITE_PULL_REQUEST) : null
         };
     }
 };
 
 const service$3 = {
+    name: "Heroku",
     detect: ({ env  })=>Boolean(env.HEROKU_TEST_RUN_ID),
     config: ({ env  })=>({
-            name: "Heroku",
             commit: env.HEROKU_TEST_RUN_COMMIT_VERSION || null,
             branch: env.HEROKU_TEST_RUN_BRANCH || null,
             owner: null,
             repository: null,
-            jobId: env.HEROKU_TEST_RUN_ID || null,
+            jobId: null,
             runId: null,
             prNumber: null
         })
@@ -164,7 +174,7 @@ const getSha = ({ env  })=>{
     const isPr = env.GITHUB_EVENT_NAME === "pull_request" || env.GITHUB_EVENT_NAME === "pull_request_target";
     if (isPr) {
         const mergeCommitRegex = /^[a-z0-9]{40} [a-z0-9]{40}$/;
-        const mergeCommitMessage = execSync("git show --no-patch --format=%P").toString().trim();
+        const mergeCommitMessage = execSync$1("git show --no-patch --format=%P").toString().trim();
         // console.log(
         //   `Handling PR with parent hash(es) '${mergeCommitMessage}' of current commit.`
         // );
@@ -193,22 +203,22 @@ Please run "actions/checkout" with "fetch-depth: 2". Example:
     }
     return process.env.GITHUB_SHA ?? null;
 };
-function getBranch({ env  }) {
+const getBranch = ({ env  })=>{
     if (env.GITHUB_HEAD_REF) {
         return env.GITHUB_HEAD_REF;
     }
     const branchRegex = /refs\/heads\/(.*)/;
-    const branchMatches = branchRegex.exec(env.GITHUB_REF || "");
-    if (branchMatches) {
-        return branchMatches[1];
+    const matches = branchRegex.exec(env.GITHUB_REF || "");
+    if (matches) {
+        return matches[1];
     }
     return null;
-}
-function getRepository({ env  }) {
+};
+const getRepository$1 = ({ env  })=>{
     if (!env.GITHUB_REPOSITORY) return null;
     return env.GITHUB_REPOSITORY.split("/")[1];
-}
-const getPrNumber$1 = ({ env  })=>{
+};
+const getPrNumber$2 = ({ env  })=>{
     const branchRegex = /refs\/pull\/(\d+)/;
     const branchMatches = branchRegex.exec(env.GITHUB_REF || "");
     if (branchMatches) {
@@ -217,9 +227,9 @@ const getPrNumber$1 = ({ env  })=>{
     return null;
 };
 const service$2 = {
+    name: "GitHub Actions",
     detect: ({ env  })=>Boolean(env.GITHUB_ACTIONS),
     config: ({ env  })=>({
-            name: "GitHub Actions",
             commit: getSha({
                 env
             }),
@@ -227,73 +237,75 @@ const service$2 = {
                 env
             }),
             owner: env.GITHUB_REPOSITORY_OWNER || null,
-            repository: getRepository({
+            repository: getRepository$1({
                 env
             }),
             jobId: env.GITHUB_JOB || null,
             runId: env.GITHUB_RUN_ID || null,
-            prNumber: getPrNumber$1({
+            prNumber: getPrNumber$2({
                 env
             })
         })
 };
 
-const getPrNumber = ({ env  })=>{
+const getPrNumber$1 = ({ env  })=>{
     const branchRegex = /pull\/(\d+)/;
-    const branchMatches = branchRegex.exec(env.CIRCLE_PULL_REQUEST || "");
-    if (branchMatches) {
-        return Number(branchMatches[1]);
+    const matches = branchRegex.exec(env.CIRCLE_PULL_REQUEST || "");
+    if (matches) {
+        return Number(matches[1]);
     }
     return null;
 };
 const service$1 = {
+    name: "CircleCI",
     detect: ({ env  })=>Boolean(env.CIRCLECI),
     config: ({ env  })=>{
-        const ciProps = envCiDetection({
-            env
-        });
         return {
-            name: "CircleCI",
-            commit: ciProps?.commit || null,
-            branch: ciProps?.branch || null,
-            owner: ciProps?.owner || null,
-            repository: ciProps?.repository || null,
-            jobId: ciProps?.jobId || null,
-            runId: ciProps?.runId || null,
-            prNumber: getPrNumber({
+            commit: env.CIRCLE_SHA1 || null,
+            branch: env.CIRCLE_BRANCH || null,
+            owner: env.CIRCLE_PROJECT_USERNAME || null,
+            repository: env.CIRCLE_PROJECT_REPONAME || null,
+            jobId: null,
+            runId: null,
+            prNumber: getPrNumber$1({
                 env
             })
         };
     }
 };
 
+const getOwner = ({ env  })=>{
+    if (!env.TRAVIS_REPO_SLUG) return null;
+    return env.TRAVIS_REPO_SLUG.split("/")[0] || null;
+};
+const getRepository = ({ env  })=>{
+    if (!env.TRAVIS_REPO_SLUG) return null;
+    return env.TRAVIS_REPO_SLUG.split("/")[1] || null;
+};
+const getPrNumber = ({ env  })=>{
+    if (env.TRAVIS_PULL_REQUEST) return Number(env.TRAVIS_PULL_REQUEST);
+    return null;
+};
 const service = {
+    name: "Travis CI",
     detect: ({ env  })=>Boolean(env.TRAVIS),
-    config: ({ env  })=>{
-        const ciProps = envCiDetection({
-            env
-        });
+    config: (ctx)=>{
+        const { env  } = ctx;
         return {
-            name: "Travis CI",
-            commit: ciProps?.commit || null,
-            branch: ciProps?.branch || null,
-            owner: ciProps?.owner || null,
-            repository: ciProps?.repository || null,
-            jobId: ciProps?.jobId || null,
-            runId: ciProps?.runId || null,
-            prNumber: env.TRAVIS_PULL_REQUEST ? Number(env.TRAVIS_PULL_REQUEST) : null
+            commit: env.TRAVIS_COMMIT || null,
+            branch: env.TRAVIS_BRANCH || null,
+            owner: getOwner(ctx),
+            repository: getRepository(ctx),
+            jobId: null,
+            runId: null,
+            prNumber: getPrNumber(ctx)
         };
     }
 };
 
-const services = [
-    service$3,
-    service$2,
-    service$1,
-    service,
-    service$4
-];
-const envCiDetection = (ctx)=>{
+const debug = createDebug("@argos-ci/core");
+
+const getCiEnvironmentFromEnvCi = (ctx)=>{
     const ciContext = envCi(ctx);
     const name = ciContext.isCi ? ciContext.name ?? null : ciContext.commit ? "Git" : null;
     const commit = ciContext.commit ?? null;
@@ -315,16 +327,38 @@ const envCiDetection = (ctx)=>{
         prNumber
     } : null;
 };
+
+const services = [
+    service$3,
+    service$2,
+    service$1,
+    service,
+    service$4
+];
 const getCiEnvironment = ({ env =process.env  } = {})=>{
     const ctx = {
         env
     };
+    debug("Detecting CI environment", {
+        env
+    });
     const service = services.find((service)=>service.detect(ctx));
-    // Internal service matched
+    // Service matched
     if (service) {
-        return service.config(ctx);
+        debug("Internal service matched", service.name);
+        const variables = service.config(ctx);
+        const ciEnvironment = {
+            name: service.name,
+            ...variables
+        };
+        debug("CI environment", ciEnvironment);
+        return ciEnvironment;
     }
-    return envCiDetection(ctx);
+    // We fallback on "env-ci" library, not very good but it's better than nothing
+    debug("Falling back on env-ci");
+    const ciEnvironment1 = getCiEnvironmentFromEnvCi(ctx);
+    debug("CI environment", ciEnvironment1);
+    return ciEnvironment1;
 };
 
 const discoverScreenshots = async (patterns, { root =process.cwd() , ignore  } = {})=>{
@@ -395,11 +429,20 @@ const createArgosApiClient = (options)=>{
     });
     const call = async (method, path, data)=>{
         try {
+            debug("Sending request", {
+                method,
+                path,
+                data
+            });
             const response = await axiosInstance.request({
                 method,
                 url: path,
                 data
             });
+            debug("Getting response", {
+                status: response.status,
+                data: response.data
+            });
             return response.data;
         } catch (error) {
             if (error?.response?.data?.error?.message) {
@@ -434,45 +477,42 @@ const upload$1 = async (input)=>{
     });
 };
 
-const debug = createDebug("@argos-ci/core");
-
 const getConfigFromOptions = (options)=>{
     const config = createConfig();
     const ciEnv = getCiEnvironment();
-    if (ciEnv) {
-        config.load(omitUndefined({
-            commit: ciEnv.commit,
-            branch: ciEnv.branch,
-            ciService: ciEnv.name,
-            owner: ciEnv.owner,
-            repository: ciEnv.repository,
-            jobId: ciEnv.jobId,
-            runId: ciEnv.runId,
-            prNumber: ciEnv.prNumber
-        }));
+    config.load({
+        apiBaseUrl: config.get("apiBaseUrl") ?? options.apiBaseUrl,
+        commit: config.get("commit") ?? options.commit ?? ciEnv?.commit ?? null,
+        branch: config.get("branch") ?? options.branch ?? ciEnv?.branch ?? null,
+        token: config.get("token") ?? options.token ?? null,
+        buildName: config.get("buildName") ?? options.buildName ?? null,
+        prNumber: config.get("prNumber") ?? options.prNumber ?? ciEnv?.prNumber ?? null,
+        ciService: ciEnv?.name ?? null,
+        owner: ciEnv?.owner ?? null,
+        repository: ciEnv?.repository ?? null,
+        jobId: ciEnv?.jobId ?? null,
+        runId: ciEnv?.runId ?? null
+    });
+    if (options.parallel) {
+        config.load({
+            parallel: Boolean(options.parallel),
+            parallelNonce: options.parallel ? options.parallel.nonce : null,
+            parallelTotal: options.parallel ? options.parallel.total : null
+        });
     }
-    config.load(omitUndefined({
-        apiBaseUrl: options.apiBaseUrl,
-        commit: options.commit,
-        branch: options.branch,
-        token: options.token,
-        prNumber: options.prNumber,
-        buildName: options.buildName,
-        parallel: Boolean(options.parallel),
-        parallelNonce: options.parallel ? options.parallel.nonce : null,
-        parallelTotal: options.parallel ? options.parallel.total : null
-    }));
     config.validate();
     return config.get();
 };
 /**
  * Upload screenshots to argos-ci.com.
  */ const upload = async (params)=>{
+    debug("Starting upload with params", params);
     // Read config
     const config = getConfigFromOptions(params);
     const files = params.files ?? [
         "**/*.{png,jpg,jpeg}"
     ];
+    debug("Using config and files", config, files);
     const apiClient = createArgosApiClient({
         baseUrl: config.apiBaseUrl,
         bearerToken: getBearerToken(config)
@@ -482,6 +522,7 @@ const getConfigFromOptions = (options)=>{
         root: params.root,
         ignore: params.ignore
     });
+    debug("Found screenshots", foundScreenshots);
     // Optimize & compute hashes
     const screenshots = await Promise.all(foundScreenshots.map(async (screenshot)=>{
         const optimizedPath = await optimizeScreenshot(screenshot.path);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@argos-ci/core",
   "description": "Visual testing solution to avoid visual regression. The core component of Argos SDK that handles build creation.",
-  "version": "0.7.0",
+  "version": "0.7.2",
   "scripts": {
     "prebuild": "rm -rf dist",
     "build": "rollup -c",
@@ -60,5 +60,5 @@
     "rollup-plugin-dts": "^4.2.3",
     "rollup-plugin-swc3": "^0.6.0"
   },
-  "gitHead": "a7603beaf95ec4be8be9405450a445bfe94a6a12"
+  "gitHead": "7adf2cb62ceb13887c7ddf675f4d19e2bd2572b9"
 }