@argonprotocol/testing 1.4.6 → 1.4.7-dev.6c827619

package/lib/index.d.cts

@@ -234,7 +234,6 @@ type EthereumGatewayUpdateBatch = {
     argonApprovalsNonce: bigint;
     argonApprovalsHash: Hex;
     paused: boolean;
-    pendingClearOutQueueNonces: bigint[];
     firstQueueNonce?: bigint;
     lastQueueNonce?: bigint;
     updates: MintingGatewayGatewayUpdate[];

package/lib/index.d.ts

@@ -234,7 +234,6 @@ type EthereumGatewayUpdateBatch = {
     argonApprovalsNonce: bigint;
     argonApprovalsHash: Hex;
     paused: boolean;
-    pendingClearOutQueueNonces: bigint[];
     firstQueueNonce?: bigint;
     lastQueueNonce?: bigint;
     updates: MintingGatewayGatewayUpdate[];

package/lib/index.js

@@ -1342,7 +1342,6 @@ var {
   encodeMintingGatewayMintingAuthorityDeactivateTarget,
   hashMintingGatewayActivateMintingAuthority,
   hashMintingGatewayGatewayUpdateApproval,
-  hashMintingGatewayMintingAuthorityDeactivation,
   mintingGatewayAbi,
   MINTING_GATEWAY_UPDATE_KINDS
 } = EvmContracts2;
@@ -1394,7 +1393,6 @@ async function getReadyEthereumGatewayUpdates(client, gatewayClient, options = {
   const argonApprovalsNonce = rawArgonApprovalsNonce;
   const argonApprovalsHash = rawArgonApprovalsHash;
   const paused = rawPaused;
-  const pendingClearOutQueueNonces = [];
   const candidateUpdates = [];
   let expectedPreviousApprovalHash = argonApprovalsHash;
   let readyQueueEntriesScanned = 0;
@@ -1409,14 +1407,8 @@ async function getReadyEthereumGatewayUpdates(client, gatewayClient, options = {
       }
       const entry = entryOption.unwrap();
       const approvingCouncilHash = toHexValue(entry.approvingCouncilHash);
-      if (!await queueEntryIsReady(
-        client,
-        entry,
-        approvingCouncilHash,
-        councilCache,
-        hashContext,
-        queueNonce
-      )) {
+      const approvingCouncil = await loadCouncilByHash(client, approvingCouncilHash, councilCache);
+      if (!queueEntryHasQuorum(entry, approvingCouncil)) {
         break;
       }
       readyQueueEntriesScanned += 1;
@@ -1433,10 +1425,15 @@ async function getReadyEthereumGatewayUpdates(client, gatewayClient, options = {
       expectedPreviousApprovalHash = toHexValue(entry.approvalHash);
     }
   }
-  while (candidateUpdates.length > 0 && candidateUpdates[candidateUpdates.length - 1]?.kind === MINTING_GATEWAY_UPDATE_KINDS.mintingAuthorityDeactivate) {
-    pendingClearOutQueueNonces.unshift(candidateUpdates.pop().queueNonce);
-  }
   const updates = candidateUpdates;
+  for (let index = 0; index < updates.length; index += 1) {
+    const isBorder = updates[index].kind === MINTING_GATEWAY_UPDATE_KINDS.globalIssuanceCouncilRotate || index === updates.length - 1;
+    if (isBorder || updates[index].signatures.length === 0) continue;
+    updates[index] = {
+      ...updates[index],
+      signatures: []
+    };
+  }
   const firstQueueNonce = updates[0]?.queueNonce;
   const lastQueueNonce = updates[updates.length - 1]?.queueNonce;
   return {
@@ -1448,7 +1445,6 @@ async function getReadyEthereumGatewayUpdates(client, gatewayClient, options = {
     argonApprovalsNonce,
     argonApprovalsHash,
     paused,
-    pendingClearOutQueueNonces,
     ...firstQueueNonce !== void 0 ? { firstQueueNonce, lastQueueNonce } : {},
     updates
   };
@@ -1476,7 +1472,7 @@ async function buildGatewayUpdate(client, destinationChain, hashContext, queueNo
       signingKey
     };
     const payload = encodeMintingGatewayMintingAuthorityActivationTarget(target);
-    const targetPayloadHash = payloadHashFromActivationPayload(hashContext, target);
+    const targetPayloadHash = hashMintingGatewayActivateMintingAuthority(hashContext, target);
     const approvalHash = hashMintingGatewayGatewayUpdateApproval(hashContext, {
       queueNonce,
       approvingCouncilHash,
@@ -1501,17 +1497,30 @@ async function buildGatewayUpdate(client, destinationChain, hashContext, queueNo
     };
   }
   if (entry.target.isMintingAuthorityDeactivation) {
-    const { payload, signatures } = validateDeactivationEntry(
-      hashContext,
+    const signingKey = getAddress2(toHexValue(entry.target.asMintingAuthorityDeactivation));
+    const payload = encodeMintingGatewayMintingAuthorityDeactivateTarget({ signingKey });
+    const targetPayloadHash = keccak256(payload);
+    const approvalHash = hashMintingGatewayGatewayUpdateApproval(hashContext, {
       queueNonce,
-      entry,
-      approvingCouncilHash
-    );
+      approvingCouncilHash,
+      kind: MINTING_GATEWAY_UPDATE_KINDS.mintingAuthorityDeactivate,
+      targetId: signingKeyTargetId(signingKey),
+      targetPayloadHash,
+      previousUpdateHash: toHexValue(entry.previousApprovalHash)
+    });
+    if (toHexValue(entry.targetPayloadHash) !== targetPayloadHash) {
+      throw new Error(`Queue nonce ${queueNonce} target payload hash does not match deactivation`);
+    }
+    if (toHexValue(entry.approvalHash) !== approvalHash) {
+      throw new Error(
+        `Queue nonce ${queueNonce} approval hash does not match deactivation: actual=${toHexValue(entry.approvalHash)} expected=${approvalHash} previous=${toHexValue(entry.previousApprovalHash)} council=${approvingCouncilHash}`
+      );
+    }
     return {
       queueNonce,
       kind: MINTING_GATEWAY_UPDATE_KINDS.mintingAuthorityDeactivate,
       payload,
-      signatures
+      signatures: getSortedSignatures(entry.signatures)
     };
   }
   throw new Error(`Unsupported approval queue target ${entry.target.type}`);
@@ -1537,23 +1546,20 @@ async function loadCouncilByHash(client, councilHash, cache) {
   return loaded;
 }
 function queueEntryHasQuorum(entry, council) {
-  const signedWeight = [...entry.signatures.entries()].reduce((total, [signer]) => {
+  let signedWeight = 0n;
+  for (const [signer] of entry.signatures.entries()) {
     const signerAddress = getAddress2(toHexValue(signer));
     const member = council.members.find((x) => x.signer === signerAddress);
     if (!member) {
       throw new Error(`Signature submitted by ${signerAddress}, which is not in the council`);
     }
-    return total + member.weight;
-  }, 0n);
-  return signedWeight * 2n > council.totalWeight;
-}
-async function queueEntryIsReady(client, entry, approvingCouncilHash, councilCache, hashContext, queueNonce) {
-  if (entry.target.isMintingAuthorityDeactivation) {
-    validateDeactivationEntry(hashContext, queueNonce, entry, approvingCouncilHash);
+    signedWeight += member.weight;
+  }
+  if (signedWeight * 100n >= council.totalWeight * 90n) {
     return true;
   }
-  const approvingCouncil = await loadCouncilByHash(client, approvingCouncilHash, councilCache);
-  return queueEntryHasQuorum(entry, approvingCouncil);
+  const unsignedMemberCount = council.members.length - entry.signatures.size;
+  return unsignedMemberCount <= 2 && signedWeight * 100n >= council.totalWeight * 80n;
 }
 function councilToSnapshot(council) {
   return {
@@ -1561,46 +1567,8 @@ function councilToSnapshot(council) {
     weights: council.members.map((member) => member.weight)
   };
 }
-function payloadHashFromActivationPayload(hashContext, target) {
-  return hashMintingGatewayActivateMintingAuthority(hashContext, target);
-}
-function payloadHashFromDeactivationPayload(target) {
-  return keccak256(encodeMintingGatewayMintingAuthorityDeactivateTarget(target));
-}
-function validateDeactivationEntry(hashContext, queueNonce, entry, approvingCouncilHash) {
-  const signingKey = getAddress2(toHexValue(entry.target.asMintingAuthorityDeactivation));
-  const target = { signingKey };
-  const payload = encodeMintingGatewayMintingAuthorityDeactivateTarget(target);
-  const targetPayloadHash = payloadHashFromDeactivationPayload(target);
-  const approvalHash = hashMintingGatewayMintingAuthorityDeactivation(hashContext, {
-    queueNonce,
-    target,
-    previousUpdateHash: toHexValue(entry.previousApprovalHash)
-  });
-  if (toHexValue(entry.targetPayloadHash) !== targetPayloadHash) {
-    throw new Error(`Queue nonce ${queueNonce} target payload hash does not match deactivation`);
-  }
-  if (toHexValue(entry.approvalHash) !== approvalHash) {
-    throw new Error(
-      `Queue nonce ${queueNonce} approval hash does not match deactivation: actual=${toHexValue(entry.approvalHash)} expected=${approvalHash} previous=${toHexValue(entry.previousApprovalHash)} council=${approvingCouncilHash}`
-    );
-  }
-  const deactivationSignatures = [...entry.signatures.entries()];
-  if (deactivationSignatures.length !== 1) {
-    throw new Error(
-      `Queue nonce ${queueNonce} expected exactly one deactivation signature, received ${deactivationSignatures.length}`
-    );
-  }
-  const [signer] = deactivationSignatures[0];
-  if (getAddress2(toHexValue(signer)) !== signingKey) {
-    throw new Error(
-      `Queue nonce ${queueNonce} deactivation signature was submitted by ${getAddress2(toHexValue(signer))}, expected ${signingKey}`
-    );
-  }
-  return {
-    payload,
-    signatures: getSortedSignatures(entry.signatures)
-  };
+function signingKeyTargetId(signingKey) {
+  return `0x${signingKey.slice(2).padStart(64, "0").toLowerCase()}`;
 }
 function getSortedSignatures(signatures) {
   return [...signatures.entries()].sort(