@arghajit/dummy 0.3.34 → 0.3.37

package/dist/reporter/playwright-pulse-reporter.d.ts

@@ -4,6 +4,7 @@ export declare class PlaywrightPulseReporter implements Reporter {
     private config;
     private suite;
     private results;
+    private _pendingTestEnds;
     private runStartTime;
     private options;
     private outputDir;
@@ -21,12 +22,28 @@ export declare class PlaywrightPulseReporter implements Reporter {
     private getBrowserDetails;
     private processStep;
     onTestEnd(test: TestCase, result: PwTestResult): Promise<void>;
+    private _processTestEnd;
     private _getFinalizedResults;
     onError(error: any): void;
     private _getEnvDetails;
     private _writeShardResults;
     private _mergeShardResults;
     private _cleanupTemporaryFiles;
+    /**
+     * Removes all individual run JSON files from the `pulse-results/` directory
+     * that were left over from previous test sessions.
+     *
+     * When `resetOnEachRun: false`, each run writes its own timestamped JSON to
+     * `pulse-results/` and then `_mergeAllRunReports()` merges them all. However,
+     * if files from *older* sessions accumulate there (e.g. because a previous run
+     * was interrupted before the post-merge cleanup, or because the user ran tests
+     * on a previous day), `_getFinalizedResults()` de-duplicates by `test.id` and
+     * collapses results from both sessions into a single entry — producing a
+     * `totalTests` count lower than the actual number of tests that ran.
+     *
+     * Cleaning up at `onBegin` time guarantees each run starts with a fresh slate.
+     */
+    private _cleanupStaleRunReports;
     private _ensureDirExists;
     onEnd(result: FullResult): Promise<void>;
     private _mergeAllRunReports;

package/dist/reporter/playwright-pulse-reporter.js

@@ -69,6 +69,7 @@ class PlaywrightPulseReporter {
     constructor(options = {}) {
         var _a, _b, _c;
         this.results = [];
+        this._pendingTestEnds = [];
         this.baseOutputFile = "playwright-pulse-report.json";
         this.isSharded = false;
         this.shardIndex = undefined;
@@ -99,14 +100,21 @@ class PlaywrightPulseReporter {
             ? this.config.shard.current - 1
             : undefined;
         this._ensureDirExists(this.outputDir)
-            .then(() => {
+            .then(async () => {
             if (this.printsToStdio()) {
                 console.log(`PlaywrightPulseReporter: Starting test run with ${suite.allTests().length} tests${this.isSharded ? ` across ${totalShards} shards` : ""}. Pulse outputting to ${this.outputDir}`);
                 if (this.shardIndex === undefined ||
                     (this.isSharded && this.shardIndex === 0)) {
-                    return this._cleanupTemporaryFiles();
+                    await this._cleanupTemporaryFiles();
                 }
             }
+            // When not resetting on each run, clear stale individual run files
+            // from previous sessions. Without this, _mergeAllRunReports() reads
+            // ALL accumulated files and de-duplicates by test.id, which collapses
+            // results from different sessions into fewer entries than expected.
+            if (!this.resetOnEachRun) {
+                await this._cleanupStaleRunReports();
+            }
         })
             .catch((err) => console.error("Pulse Reporter: Error during initialization:", err));
     }
@@ -120,19 +128,19 @@ class PlaywrightPulseReporter {
     extractCodeSnippet(filePath, targetLine, targetColumn) {
         var _a;
         try {
-            const fsSync = require('fs');
+            const fsSync = require("fs");
             if (!fsSync.existsSync(filePath)) {
-                return '';
+                return "";
             }
-            const content = fsSync.readFileSync(filePath, 'utf8');
-            const lines = content.split('\n');
+            const content = fsSync.readFileSync(filePath, "utf8");
+            const lines = content.split("\n");
             if (targetLine < 1 || targetLine > lines.length) {
-                return '';
+                return "";
             }
-            return ((_a = lines[targetLine - 1]) === null || _a === void 0 ? void 0 : _a.trim()) || '';
+            return ((_a = lines[targetLine - 1]) === null || _a === void 0 ? void 0 : _a.trim()) || "";
         }
         catch (e) {
-            return '';
+            return "";
         }
     }
     getBrowserDetails(test) {
@@ -199,7 +207,7 @@ class PlaywrightPulseReporter {
         const startTime = new Date(step.startTime);
         const endTime = new Date(startTime.getTime() + Math.max(0, duration));
         let codeLocation = "";
-        let codeSnippet = '';
+        let codeSnippet = "";
         if (step.location) {
             codeLocation = `${path.relative(this.config.rootDir, step.location.file)}:${step.location.line}:${step.location.column}`;
             codeSnippet = this.extractCodeSnippet(step.location.file, step.location.line, step.location.column);
@@ -226,9 +234,19 @@ class PlaywrightPulseReporter {
         };
     }
     async onTestEnd(test, result) {
+        // Track this async call so onEnd() can wait for all in-flight processing
+        // before it reads this.results. This prevents the race condition where
+        // onEnd() fires before an interrupted test's onTestEnd() has finished
+        // its async attachment I/O and pushed to this.results.
+        const p = this._processTestEnd(test, result);
+        this._pendingTestEnds.push(p);
+        await p;
+    }
+    async _processTestEnd(test, result) {
         var _a, _b, _c, _d, _e, _f, _g, _h, _j, _k, _l, _m, _o, _p;
         const project = (_a = test.parent) === null || _a === void 0 ? void 0 : _a.project();
         const browserDetails = this.getBrowserDetails(test);
+        const uniqueTestId = `${(project === null || project === void 0 ? void 0 : project.name) || "default"}-${test.id}`;
         // Captured outcome from Playwright
         const outcome = test.outcome();
         // Calculate final status based on the last result (Last-Run-Wins)
@@ -239,15 +257,15 @@ class PlaywrightPulseReporter {
         // Existing behavior: fail if flaky (implied by user request "existing status field should remain failed")
         // If outcome is flaky, status should be 'failed' to indicate initial failure, but final_status is 'passed'
         let testStatus = finalStatus;
-        if (outcome === 'flaky') {
-            testStatus = 'flaky';
+        if (outcome === "flaky") {
+            testStatus = "flaky";
         }
         const startTime = new Date(result.startTime);
         const endTime = new Date(startTime.getTime() + result.duration);
         const processAllSteps = async (steps) => {
             let processed = [];
             for (const step of steps) {
-                const processedStep = await this.processStep(step, pulseResult.id, browserDetails, test);
+                const processedStep = await this.processStep(step, uniqueTestId, browserDetails, test);
                 processed.push(processedStep);
                 if (step.steps && step.steps.length > 0) {
                     processedStep.steps = await processAllSteps(step.steps);
@@ -255,7 +273,7 @@ class PlaywrightPulseReporter {
             }
             return processed;
         };
-        let codeSnippet = '';
+        let codeSnippet = "";
         if (((_b = test.location) === null || _b === void 0 ? void 0 : _b.file) && ((_c = test.location) === null || _c === void 0 ? void 0 : _c.line) && ((_d = test.location) === null || _d === void 0 ? void 0 : _d.column)) {
             codeSnippet = this.extractCodeSnippet(test.location.file, test.location.line, test.location.column);
         }
@@ -284,7 +302,7 @@ class PlaywrightPulseReporter {
                 : undefined,
         };
         const pulseResult = {
-            id: `${(project === null || project === void 0 ? void 0 : project.name) || "default"}-${test.id}`,
+            id: uniqueTestId,
             runId: "TBD",
             describe: describeBlockName,
             spec_file: specFileName,
@@ -318,7 +336,7 @@ class PlaywrightPulseReporter {
             if (!attachment.path)
                 continue;
             try {
-                const testSubfolder = pulseResult.id.replace(/[^a-zA-Z0-9_-]/g, "_");
+                const testSubfolder = uniqueTestId.replace(/[^a-zA-Z0-9_-]/g, "_");
                 const safeAttachmentName = path
                     .basename(attachment.path)
                     .replace(/[^a-zA-Z0-9_.-]/g, "_");
@@ -487,6 +505,39 @@ class PlaywrightPulseReporter {
             }
         }
     }
+    /**
+     * Removes all individual run JSON files from the `pulse-results/` directory
+     * that were left over from previous test sessions.
+     *
+     * When `resetOnEachRun: false`, each run writes its own timestamped JSON to
+     * `pulse-results/` and then `_mergeAllRunReports()` merges them all. However,
+     * if files from *older* sessions accumulate there (e.g. because a previous run
+     * was interrupted before the post-merge cleanup, or because the user ran tests
+     * on a previous day), `_getFinalizedResults()` de-duplicates by `test.id` and
+     * collapses results from both sessions into a single entry — producing a
+     * `totalTests` count lower than the actual number of tests that ran.
+     *
+     * Cleaning up at `onBegin` time guarantees each run starts with a fresh slate.
+     */
+    async _cleanupStaleRunReports() {
+        const pulseResultsDir = path.join(this.outputDir, INDIVIDUAL_REPORTS_SUBDIR);
+        try {
+            const files = await fs.readdir(pulseResultsDir);
+            const staleFiles = files.filter((f) => f.startsWith("playwright-pulse-report-") && f.endsWith(".json"));
+            if (staleFiles.length > 0) {
+                await Promise.all(staleFiles.map((f) => fs.unlink(path.join(pulseResultsDir, f))));
+                if (this.printsToStdio()) {
+                    console.log(`PlaywrightPulseReporter: Cleaned up ${staleFiles.length} stale run report(s) from ${pulseResultsDir}`);
+                }
+            }
+        }
+        catch (error) {
+            // ENOENT simply means no previous runs exist — that's fine
+            if ((error === null || error === void 0 ? void 0 : error.code) !== "ENOENT") {
+                console.warn("Pulse Reporter: Warning during cleanup of stale run reports:", error.message);
+            }
+        }
+    }
     async _ensureDirExists(dirPath) {
         try {
             await fs.mkdir(dirPath, { recursive: true });
@@ -499,6 +550,11 @@ class PlaywrightPulseReporter {
         }
     }
     async onEnd(result) {
+        // Wait for ALL in-flight onTestEnd calls to finish before reading this.results.
+        // This guards against Playwright calling onEnd() concurrently with (or just
+        // before) the last onTestEnd() finishing its async attachment I/O — which
+        // would cause that test to be silently dropped from the report.
+        await Promise.allSettled(this._pendingTestEnds);
         if (this.shardIndex !== undefined) {
             await this._writeShardResults();
             return;
@@ -659,6 +715,16 @@ class PlaywrightPulseReporter {
             if (this.printsToStdio()) {
                 console.log(`PlaywrightPulseReporter: ✅ Merged report with ${finalMergedResults.length} total results saved to ${finalOutputPath}`);
             }
+            // Clean up the pulse-results directory after a successful merge
+            try {
+                await fs.rm(pulseResultsDir, { recursive: true, force: true });
+                if (this.printsToStdio()) {
+                    console.log(`PlaywrightPulseReporter: Cleaned up individual reports directory at ${pulseResultsDir}`);
+                }
+            }
+            catch (cleanupErr) {
+                console.warn(`Pulse Reporter: Could not clean up individual reports directory. Error: ${cleanupErr.message}`);
+            }
         }
         catch (err) {
             console.error(`Pulse Reporter: Failed to write final merged report to ${finalOutputPath}. Error: ${err.message}`);

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "@arghajit/dummy",
   "author": "Arghajit Singha",
-  "version": "0.3.34",
+  "version": "0.3.37",
   "description": "A Playwright reporter and dashboard for visualizing test results.",
   "homepage": "https://arghajit47.github.io/playwright-pulse/",
   "repository": {