@ardennguyen/zalo-agent-cli 2.5.6 → 2.5.7

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@ardennguyen/zalo-agent-cli",
-    "version": "2.5.6",
+    "version": "2.5.7",
     "description": "CLI tool for Zalo automation — multi-account, proxy, bank transfers, QR payments, Official Account API v3.0",
     "type": "module",
     "bin": {

package/src/commands/sync.js

@@ -1259,7 +1259,18 @@ function reportRestore(res, win, ctx = {}) {
         return { status: "ok", reason: "phone confirmed: nothing missed in this window" };
     }
     if (res.reason === "partial" || res.reason === "socket-lost") {
-        const how = res.reason === "socket-lost" ? "the connection dropped" : "the run was cut short";
+        const how =
+            res.reason === "socket-lost"
+                ? "the connection dropped"
+                : res.rowErrors
+                  ? "some messages could not be written"
+                  : "the run was cut short";
+        if (res.rowErrors) {
+            warning(
+                `${res.rowErrors} message(s) could not be written to the local cache (${res.firstRowError ?? "unknown error"}). ` +
+                    "Re-run with --force once the cause is gone.",
+            );
+        }
         warning(
             `Partial restore: ${res.messagesSaved} message(s) from ${res.conversations} conversation(s) before ${how}.`,
         );

package/src/core/sync-v2/index.js

@@ -384,6 +384,7 @@ export function createShardSchedule(shardCount, opts = {}) {
  * @param {number} st.total - shards requested
  * @param {number} [st.resumes=0] - reconnects used
  * @param {number} [st.waitMs] - the budget, for the timeout wording
+ * @param {number} [st.rowErrors] - rows that could not be written to the cache
  * @returns {{reason: string, error: string|null}}
  */
 export function describeRestoreOutcome(st) {
@@ -410,6 +411,8 @@ export function describeRestoreOutcome(st) {
         };
     }
     if (st.finished < st.total) return { reason: st.socketDied ? "socket-lost" : "partial", error: null };
+    // Every shard came back, but a row did not reach the cache: a hole is not complete.
+    if (st.rowErrors > 0) return { reason: "partial", error: null };
     return { reason: "complete", error: null };
 }
 
@@ -874,7 +877,10 @@ export class SyncV2 {
         const ik = zproto.generateKeyPair();
         let conversations = 0,
             messagesSaved = 0,
-            attachmentsSaved = 0;
+            attachmentsSaved = 0,
+            rowErrors = 0;
+        /** The first reason a row could not be written, for the report. */
+        let firstRowError = null;
         const mappedThreads = new Set(),
             unmappedThreads = new Set();
         /** type name -> count, for the command's summary line. */
@@ -892,6 +898,8 @@ export class SyncV2 {
                 confirmed,
                 ...resumeInfo,
                 attachmentsSaved,
+                rowErrors,
+                firstRowError,
                 typeCounts: { ...typeCounts },
                 // Every threadId the conversation round accounted for. Anything
                 // cached outside this list is orphaned.
@@ -1253,8 +1261,12 @@ export class SyncV2 {
                                         messagesSaved++;
                                         if (info.hasAttachment) attachmentsSaved++;
                                         typeCounts[info.type] = (typeCounts[info.type] || 0) + 1;
-                                    } catch {
-                                        /* dedupe/constraint — keep going */
+                                    } catch (e) {
+                                        // Keep going with the rest of the chunk, but never silently: a row that cannot
+                                        // be written (a full disk, a locked file) leaves a hole, so the run does not
+                                        // call itself complete.
+                                        rowErrors++;
+                                        firstRowError ??= e?.message ?? String(e);
                                     }
                                 }
                             }
@@ -1314,6 +1326,7 @@ export class SyncV2 {
                 timedOut,
                 confirmed,
                 messagesSaved,
+                rowErrors,
                 finished,
                 total: shards.length,
                 resumes: schedule.resumes(),

package/src/core/zalo-client.js

@@ -8,7 +8,7 @@ import { basename } from "node:path";
 import { imageSizeFromFile } from "image-size/fromFile";
 import { Zalo } from "zca-js";
 import { HttpsProxyAgent } from "https-proxy-agent";
-import { ProxyAgent } from "undici";
+import { ProxyAgent, fetch as undiciFetch } from "undici";
 import { getActive } from "./accounts.js";
 import { loadCredentials } from "./credentials.js";
 import { info } from "../utils/output.js";
@@ -100,10 +100,14 @@ export function isLoggedIn() {
 /**
  * Create a proxy-aware fetch that uses undici ProxyAgent dispatcher.
  * Native Node.js fetch ignores the `agent` option — must use `dispatcher`.
+ *
+ * The fetch is undici's own, not the global one: Node bundles its own undici and the package here is another, and a
+ * dispatcher from one handed to the fetch of the other fails every request with "invalid onRequestStart method". A
+ * proxied account could not log in at all.
  */
-function createProxyFetch(proxyUrl) {
+export function createProxyFetch(proxyUrl) {
     const dispatcher = new ProxyAgent(proxyUrl);
-    return (url, init = {}) => fetch(url, { ...init, dispatcher });
+    return (url, init = {}) => undiciFetch(url, { ...init, dispatcher });
 }
 
 /**