@arcgis/lumina 4.34.0-next.2 → 4.34.0-next.21

package/dist/controllers/accessor/index.js

@@ -22,6 +22,7 @@ class AccessorController extends GenericController {
   constructor(component, createInstance) {
     super(component);
     this.Y = /* @__PURE__ */ new Map();
+    this.A = void 0;
     this.#exportsObservable = createObservable();
     const that = this;
     that.#createInstance = createInstance;
@@ -107,9 +108,12 @@ const makeBinderProxy = (component, accessorControllerRef, accessorControllerInd
     ) {
       return value;
     }
+    const accessorController = component.M[accessorControllerIndex];
+    accessorController.A = propertyName;
     return trackKey(
       component,
       (resolved) => {
+        accessorController.A = void 0;
         if (resolved !== void 0) {
           const propName = resolved.key;
           boundProperties.set(propertyName, propName);
@@ -120,15 +124,15 @@ const makeBinderProxy = (component, accessorControllerRef, accessorControllerInd
             if (!(propertyName in instance)) {
               throw new Error(`"${propertyName}" does not exist on the accessor instance`);
             }
-            const accessorController = component.M[accessorControllerIndex];
+            const accessorController2 = component.M[accessorControllerIndex];
             if (descriptor.i !== void 0 && descriptor.i !== accessorControllerIndex) {
-              console.error(component.M[descriptor.i], accessorController);
+              console.error(component.M[descriptor.i], accessorController2);
               throw Error(
                 `Expected property "${propName}" to be bound to the controller at index ${descriptor.i}, but tried to bind it to a controller at index ${accessorControllerIndex}. Double check whether you are calling useAccessor() conditionally in a way that is not supported.`
               );
             }
-            if (accessorController !== accessorControllerRef.deref()) {
-              console.error(accessorController);
+            if (accessorController2 !== accessorControllerRef.deref()) {
+              console.error(accessorController2);
               throw Error(
                 `Expected controller at index ${accessorControllerIndex} to be instance of useAccessor but it is not.`
               );
@@ -156,13 +160,6 @@ const makeBinderProxy = (component, accessorControllerRef, accessorControllerInd
       },
       value
     );
-  },
-  set(_target, propertyName, newValue) {
-    if (boundProperties.has(propertyName) || // But some properties may be never bound, yet set in the constructor - let them through
-    newValue !== (instance[propertyName] ?? void 0)) {
-      instance[propertyName] = newValue;
-    }
-    return true;
   }
 });
 const watchBoundProperty = (controllerRef, descriptor, propertyName, propName, shouldFlipBoolean, _handle) => _handle = watch(
@@ -199,7 +196,10 @@ const bindPropToProperty = (descriptor, accessorControllerIndex, propertyName, s
     return shouldFlipBoolean ? !value : value;
   };
   descriptor.d.set = function(newValue) {
-    this.M[accessorControllerIndex].exports[propertyName] = shouldFlipBoolean ? !newValue : newValue;
+    const accessorController = this.M[accessorControllerIndex];
+    if (accessorController.A !== propertyName) {
+      accessorController.exports[propertyName] = shouldFlipBoolean ? !newValue : newValue;
+    }
   };
 };
 const getAccessorControllerBoundProperties = (controller) => controller.Y;
@@ -212,10 +212,15 @@ const reCreateAccessor = (instance, component) => {
     console.error("Unable to resolve the useAccessor controller from the provided value");
   }
 };
-const createStore = (defaultValues) => {
+const createStore = (initializer) => {
   const SubClass = class extends Accessor {
   };
-  Object.entries(defaultValues).forEach(([name, value]) => property({ value })(SubClass.prototype, name));
+  const defaultValues = typeof initializer === "function" ? initializer() : initializer;
+  const descriptors = Object.getOwnPropertyDescriptors(defaultValues);
+  for (const [key, descriptor] of Object.entries(descriptors)) {
+    Object.defineProperty(SubClass.prototype, key, descriptor);
+    property()(SubClass.prototype, key);
+  }
   const State = subclass()(SubClass);
   return new State();
 };

package/dist/controllers/accessor/store.d.ts

@@ -2,7 +2,7 @@ import { default as Accessor } from '@arcgis/core/core/Accessor.js';
 /**
  * See https://qawebgis.esri.com/components/lumina/controllers/useAccessor#createstore-utility
  */
-export declare const createStore: <T extends Record<string, unknown>>(defaultValues: T | (() => T)) => __esri.Accessor & T;
+export declare const createStore: <T extends Record<string, unknown>>(initializer: T | (() => T)) => __esri.Accessor & T;
 /** @deprecated Use {@link createStore} instead */
 export declare const createLegacyStore: <T extends Record<string, unknown>>(defaultState: T | (() => T)) => ObservableMap<T>;
 /** @deprecated Use {@link createStore} instead */

package/dist/controllers/accessor/useAccessor.d.ts

@@ -1,4 +1,4 @@
-import { Controller, GenericController } from '../Controller';
+import { GenericController } from '../Controller';
 import { LitElement } from '../../LitElement';
 type Requires<Props, Accessor extends __esri.Accessor, OmitProps extends string = never> = LitElement & Omit<Pick<Accessor, keyof Accessor & keyof Props>, AlwaysOmit | OmitProps> & {
     autoDestroyDisabled: boolean;
@@ -46,6 +46,8 @@ export declare class AccessorController<Props, Accessor extends __esri.Accessor,
      * @private
      */
     _boundAccessorProperties: Map<string & keyof Accessor, string>;
+    /** @private */
+    _currentlyBindingPropertyName?: string;
     /**
      * (development only) Allow these props to mismatch the name of the Accessor's
      * property to avoid collisions
@@ -61,8 +63,11 @@ export declare class AccessorController<Props, Accessor extends __esri.Accessor,
     hostConnected(): void;
     hostDestroy(): void;
 }
-export declare const makeBinderProxy: (component: LitElement, accessorControllerRef: WeakRef<Pick<Controller<__esri.Accessor>, "component" | "exports"> & {
-    constructor: (typeof __esri.Accessor)["constructor"] & {
+type MinimalAccessorController = Pick<AccessorController<never, __esri.Accessor>, "_currentlyBindingPropertyName" | "exports"> & {
+    component: LitElement;
+};
+export declare const makeBinderProxy: (component: LitElement, accessorControllerRef: WeakRef<MinimalAccessorController & {
+    constructor: MinimalAccessorController["constructor"] & {
         devOnly$allowedPropNameMismatches?: ReadonlySet<string>;
     };
 }>, accessorControllerIndex: number, instance: __esri.Accessor, boundProperties: Map<string, string>) => unknown;

package/dist/controllers/index.js

@@ -127,7 +127,7 @@ const useDirection = () => makeController((component, controller) => {
       (resolved) => {
         if (resolved?.key === "dir") {
           throw new Error(
-            `Do not assign this controller to a prop called \`dir\` as that will overwrite the \`dir\` attribute on the host element - component should not be setting the \`dir\` attribute on itself. Instead, assign this controller to a property called \`direction\`.`
+            "Do not assign this controller to a prop called `dir` as that will overwrite the HTMLElement's built-in `dir` attribute - component should not be setting the `dir` attribute on itself. Instead, assign this controller to a property called `direction`."
           );
         }
       },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/lumina",
-  "version": "4.34.0-next.2",
+  "version": "4.34.0-next.21",
   "type": "module",
   "main": "dist/index.cjs",
   "module": "dist/index.js",
@@ -22,7 +22,7 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/components-utils": "4.34.0-next.2",
+    "@arcgis/components-utils": "4.34.0-next.21",
     "@lit-labs/ssr": "^3.2.2",
     "@lit-labs/ssr-client": "^1.1.7",
     "@lit/context": "^1.1.5",