@arcgis/lumina-compiler 4.34.0-next.2 → 4.34.0-next.21

package/dist/index.js

@@ -2584,11 +2584,13 @@ class Je extends gs {
         docsTags: [
           {
             name: "example",
-            text: `const ${c} = document.createElement("${s.tagName}");
+            text: `\`\`\`js
+const ${c} = document.createElement("${s.tagName}");
 document.body.append(${c});
 ${c}.componentOnReady().then(() => {
   console.log("${s.tagName} is ready to go!");
-});`
+});
+\`\`\``
           }
         ]
       });
@@ -4968,7 +4970,7 @@ function Kc(e, t) {
     // Start loading from reactiveUtils the modules we need to enable integration.
     // Store the promise on the runtime object so that the lazy loader awaits
     // this before beginning hydration.
-    'r.p=a.t(m=>{r.t=m.trackAccess;r.o=m.createObservable;r.c=m.createTrackingTarget;r.r=m.runTracked},"applications/Components/reactiveUtils")}',
+    'r.p=a.t(([m])=>{r.t=m.trackAccess;r.o=m.createObservable;r.c=m.createTrackingTarget;r.r=m.runTracked},"applications/Components/reactiveUtils")}',
     // We use `a` variable as a shorter alias to `$arcgis` to save bytes.
     // We pass runtime as an argument rather than access it directly inside the
     // closure to avoid possible collisions (in case runtime variable was
@@ -5208,18 +5210,21 @@ async function Te(e) {
   return e._loadersCache ??= Zc(e), await e._loadersCache;
 }
 async function Zc(e) {
-  const t = e.viteCommand === "build" ? "cdn" : "lazyNpm", i = e.viteConfig.base, n = async (c) => (await Promise.all(
-    c.map(
-      async (l, d) => l.type === "stencil" ? await Vc(i, l, t, d) : l.type === "@arcgis/lumina" ? await Xc(i, l, t, d) : void 0
-    )
-  )).filter(j).flat(), s = await Promise.all([
+  const t = e.viteCommand === "build" ? "cdn" : "lazyNpm", i = e.viteConfig.base;
+  let n = 0;
+  const s = async (l) => (await Promise.all(
+    l.map(async (d) => {
+      const p = n++;
+      return d.type === "stencil" ? await Vc(i, d, t, p) : d.type === "@arcgis/lumina" ? await Xc(i, d, t, p) : void 0;
+    })
+  )).filter(j).flat(), r = await Promise.all([
     // This may contain an import map so must be first
     xc(i, t),
-    ve.then(n),
-    Qn(e).then(n)
-  ]), r = u.join(e.dir.src, "loader.ts");
+    ve.then(s),
+    Qn(e).then(s)
+  ]), a = u.join(e.dir.src, "loader.ts");
   return [
-    ...s.flat(),
+    ...r.flat(),
     {
       optimizableImports: [
         /**
@@ -5228,7 +5233,7 @@ async function Zc(e) {
          */
       ],
       javascriptCode: [
-        `import { defineCustomElements } from "${r}";`,
+        `import { defineCustomElements } from "${a}";`,
         "globalThis.devOnly$ownTagNames = new Set();",
         `defineCustomElements(${t === "cdn" ? `{resourcesUrl:"./${e.options.build?.cdn?.namespace ?? Dt}/"}` : ""});`
       ]
@@ -5711,19 +5716,21 @@ const dt = "@arcgis/lumina:printTotalBuildSize", dl = (e) => ({
        * used by a package from outside the monorepo (eg @arcgis/lumina is used
        * inside the package, and by Calcite outside the package).
        */
-      exclude: S ? [
-        "@arcgis/lumina",
-        "@arcgis/components-controllers",
-        "@arcgis/components-utils",
-        "@arcgis/core-adapter",
-        "@arcgis/map-components",
-        "@arcgis/common-components",
-        "@arcgis/charts-components",
-        "@arcgis/embeddable-components",
-        "@arcgis/imagery-components",
-        "@arcgis/map-config-components",
-        "@arcgis/portal-components",
-        // By excluding Lumina, we also disable discovery of packages
+      exclude: [
+        ...S ? [
+          "@arcgis/lumina",
+          "@arcgis/components-controllers",
+          "@arcgis/components-utils",
+          "@arcgis/core-adapter",
+          "@arcgis/map-components",
+          "@arcgis/common-components",
+          "@arcgis/charts-components",
+          "@arcgis/embeddable-components",
+          "@arcgis/imagery-components",
+          "@arcgis/map-config-components",
+          "@arcgis/portal-components"
+        ] : [],
+        // By excluding Lumina above, we also disable discovery of packages
         // used by it (Lit), which are then discovered at runtime and cause
         // dev-server reload. We could manually include all Lit packages,
         // but because Lit has so many entry points and barrel files,
@@ -5731,6 +5738,12 @@ const dt = "@arcgis/lumina:printTotalBuildSize", dl = (e) => ({
         // rather than decrease them (620 vs 621)), defeating the point of
         // dependency optimization. Add to it that debugging is easier for
         // non-optimized dependencies, so we exclude it.
+        //
+        // For users outside the monorepo, we choose to exclude Lit for similar
+        // reasons - the benefits of pre-bundling are nil. Otherwise, we would
+        // have to explicitly include the Lit imports that are added dynamically
+        // by the JSX to lit-html transformation
+        //
         // Even though lit/ is a barrel package, we still need to explicitly
         // exclude the sub-packages to prevent them from being optimized at
         // runtime.
@@ -5739,7 +5752,7 @@ const dt = "@arcgis/lumina:printTotalBuildSize", dl = (e) => ({
         "lit-element",
         "@lit/reactive-element",
         "@lit/context"
-      ] : void 0
+      ]
     };
     if (typeof l.setupFiles == "string" ? l.setupFiles = [...lt, l.setupFiles] : Array.isArray(l.setupFiles) ? l.setupFiles = [...lt, ...l.setupFiles] : l.setupFiles = [...lt], e.isInPuppeteerTestBackEnd) {
       if (p?.enabled === !0)
@@ -5864,10 +5877,11 @@ const pe = {
 };
 async function as(e, t, i, n, s = R()) {
   const r = Sl(e, i, n, s), a = u.join(t, "lumina.ts"), l = await U(a) ? await J(a, "utf8") : "";
-  if (l === r)
+  if (l.trim().replaceAll(`\r
+`, `
+`) === r.trim())
     return !1;
-  if (process.env.CI) {
-    const d = (p) => Array.from(p, (m) => m.codePointAt(0).toString(16).padStart(4, "0")).join(",");
+  if (process.env.CI)
     throw Error(
       w(
         "@arcgis/lumina:updateLuminaTs",
@@ -5877,12 +5891,9 @@ ${r}
 
 Current content:
 
-${l}
-Hex new content: ${d(r)}
-Hex current content: ${d(l)}`
+${l}`
       )
     );
-  }
   return Wi(a, r), !0;
 }
 function Sl(e, t, i, n = R()) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/lumina-compiler",
-  "version": "4.34.0-next.2",
+  "version": "4.34.0-next.21",
   "type": "module",
   "main": "dist/index.js",
   "module": "dist/index.js",
@@ -18,9 +18,9 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/api-extractor": "4.34.0-next.2",
-    "@arcgis/components-build-utils": "4.34.0-next.2",
-    "@arcgis/components-utils": "4.34.0-next.2",
+    "@arcgis/api-extractor": "4.34.0-next.21",
+    "@arcgis/components-build-utils": "4.34.0-next.21",
+    "@arcgis/components-utils": "4.34.0-next.21",
     "chalk": "^5.3.0",
     "esbuild": "^0.25.4",
     "glob": "^11.0.0",
@@ -37,6 +37,6 @@
     "vitest-fail-on-console": "^0.7.1"
   },
   "peerDependencies": {
-    "@arcgis/lumina": "~4.34.0-next.2"
+    "@arcgis/lumina": "~4.34.0-next.21"
   }
 }