@arcgis/lumina-compiler 4.33.0-next.29 → 4.33.0-next.30

package/dist/plugins/buildCdn.d.ts

@@ -12,10 +12,76 @@ export declare const defaultNamespace = "cdn";
  * are assumed to be defined in the environment separately)
  */
 export declare function buildCdn(context: CompilerContext): Plugin | undefined;
-declare function transformAsyncCoreImports(code: string): string;
-declare function transformSyncCoreImports(code: string): string;
+type Chunk = {
+    code: string;
+    isAsync: boolean | undefined;
+};
+/**
+ * Transform each core-importing chunk to use $arcgis.t for loading core in
+ * order to be both ESM and AMD CDN compatible.
+ *
+ * Previous solution
+ * (https://devtopia.esri.com/WebGIS/arcgis-web-components/pull/2995) relied on
+ * top-level await. However, due to a Safari bug
+ * (see https://devtopia.esri.com/WebGIS/arcgis-web-components/issues/3933
+ * and https://bugs.webkit.org/show_bug.cgi?id=242740), we are no longer using
+ * top-level await.
+ *
+ * Instead, we insert a top-level await polyfill - a promise called $$ is
+ * exported by core-containing modules - such promise needs to be awaited by the
+ * consuming modules before the imported variables are available.
+ *
+ * List of other solutions considered:
+ * https://devtopia.esri.com/WebGIS/arcgis-web-components/discussions/3999
+ *
+ * @example
+ * ```js
+ * /// BEFORE
+ * import { b } from "./U7MU7PMX.js";
+ * import { when as M } from "@arcgis/core/core/reactiveUtils.js";
+ * var s = class extends v {
+ *   // ...
+ * };
+ * export { s as ArcgisNavigationToggle };
+ *
+ * /// AFTER
+ * // $$ is a promise we need to await before imports from that module are available
+ * import { $$ as _0, b } from "./U7MU7PMX.js";
+ * var _1,
+ *   $$ = $arcgis.t(
+ *     ([{ when: M }]) => {
+ *       // The "meat" of the file is kept unchanged by the transform
+ *       // (we only touch the imports, and the very last export line)
+ *         s = class extends v {
+ *           // ...
+ *         };
+ *       // Assign exported variables to global scope variables
+ *       _1 = s;
+ *     },
+ *     "core/reactiveUtils",
+ *     _0,
+ *   );
+ * // _1 will only be assigned once $$ resolves
+ * export { $$, _1 as ArcgisNavigationToggle };
+ * ```
+ */
+declare function transformChunk(chunk: Chunk, chunks: Map<string, Chunk>): void;
+/**
+ * @example Dynamic core import
+ * ```diff
+ * - import("core/Handles");
+ * + $arcgis.t(_=>_[0],"core/Handles")
+ * ```
+ *
+ * @example Dynamic import of a chunk with top-level await
+ * ```diff
+ * - import("./chunk.js");
+ * + import("./chunk.js").then(m=>m.$$.then(_=>m))
+ * ```
+ */
+declare function transformDynamicCoreImports(code: string, chunks: Map<string, Chunk>): string;
 export declare const exportsForTests: {
-    transformAsyncCoreImports: typeof transformAsyncCoreImports;
-    transformSyncCoreImports: typeof transformSyncCoreImports;
+    transformDynamicCoreImports: typeof transformDynamicCoreImports;
+    transformChunk: typeof transformChunk;
 };
 export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/lumina-compiler",
-  "version": "4.33.0-next.29",
+  "version": "4.33.0-next.30",
   "type": "module",
   "main": "dist/index.js",
   "module": "dist/index.js",
@@ -18,9 +18,9 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/api-extractor": "4.33.0-next.29",
-    "@arcgis/components-build-utils": "4.33.0-next.29",
-    "@arcgis/components-utils": "4.33.0-next.29",
+    "@arcgis/api-extractor": "4.33.0-next.30",
+    "@arcgis/components-build-utils": "4.33.0-next.30",
+    "@arcgis/components-utils": "4.33.0-next.30",
     "chalk": "^5.3.0",
     "esbuild": "^0.24.0",
     "js-beautify": "^1.15.1",
@@ -36,6 +36,6 @@
     "vitest-fail-on-console": "^0.7.1"
   },
   "peerDependencies": {
-    "@arcgis/lumina": "~4.33.0-next.29"
+    "@arcgis/lumina": "~4.33.0-next.30"
   }
 }