@arcgis/eslint-config 6.0.0-next.13 → 6.0.0-next.15

package/dist/chunks/imports.js

@@ -0,0 +1,31 @@
+import { AST_NODE_TYPES, ASTUtils, TSESLint } from "@typescript-eslint/utils";
+function isImportedSymbol(node, sourceCode, moduleName, names) {
+  const identifier = node.type === AST_NODE_TYPES.MemberExpression ? node.object : node;
+  if (identifier.type !== AST_NODE_TYPES.Identifier) {
+    return false;
+  }
+  const variable = ASTUtils.findVariable(sourceCode.getScope(identifier), identifier.name);
+  const definition = variable?.defs[0];
+  if (definition?.type !== TSESLint.Scope.DefinitionType.ImportBinding || definition.parent.type !== AST_NODE_TYPES.ImportDeclaration || definition.parent.source.value !== moduleName || definition.parent.importKind === "type") {
+    return false;
+  }
+  const specifier = definition.node;
+  if (node.type === AST_NODE_TYPES.MemberExpression) {
+    return specifier.type === AST_NODE_TYPES.ImportNamespaceSpecifier && names.includes(propertyName(node) ?? "");
+  }
+  if (specifier.type !== AST_NODE_TYPES.ImportSpecifier || specifier.importKind === "type") {
+    return false;
+  }
+  const imported = specifier.imported;
+  return names.includes(imported.type === AST_NODE_TYPES.Identifier ? imported.name : imported.value);
+}
+function propertyName(node) {
+  if (!node.computed && node.property.type === AST_NODE_TYPES.Identifier) {
+    return node.property.name;
+  }
+  return node.property.type === AST_NODE_TYPES.Literal && typeof node.property.value === "string" ? node.property.value : void 0;
+}
+export {
+  isImportedSymbol as i,
+  propertyName as p
+};

package/dist/config/core.js

@@ -814,6 +814,14 @@ const eslintConfigCore = [
           message: "Avoid adding has flags manually. Instead use the suite/test-level options to set has flags."
         }
       ],
+      "webgis/no-unsafe-fake-timers": [
+        "error",
+        {
+          fakeTimerHelpers: [
+            { module: "test-support/schedulingUtils", names: ["useFakeTimers", "useFastForwardTimers"] }
+          ]
+        }
+      ],
       // Require awaiting assert.screenshot() in tests
       "webgis/require-await-for-async-screenshot-assert": "error"
     }
@@ -822,7 +830,7 @@ const eslintConfigCore = [
     files: ["packages/core-packages/core/tests/**/*.{ts,tsx}"],
     ignores: ["packages/core-packages/core/tests/support/schedulingUtils.ts"],
     rules: {
-      "core/no-unsafe-fake-timers": "error"
+      "core/require-managed-timers": "error"
     }
   }
 ];

package/dist/plugins/core/index.js

@@ -5,6 +5,7 @@ import path, { relative, win32, posix, normalize } from "path";
 import { dirname, join } from "node:path";
 import { existsSync } from "node:fs";
 import { execSync } from "child_process";
+import { p as propertyName, i as isImportedSymbol } from "../../chunks/imports.js";
 const plugin = makeEslintPlugin(
   "core",
   (rule) => `https://devtopia.esri.com/WebGIS/webgis-sdk/tree/main/packages/support-packages/eslint-config/src/plugins/core/rules/${rule}.ts`
@@ -483,103 +484,6 @@ function getDeclaredClass(filename) {
   const relativePath = relative(root, filename).replaceAll(win32.sep, ".").replaceAll(posix.sep, ".").replace(/^src\./u, "esri.").replace(/\.[^/.]+$/u, "");
   return relativePath;
 }
-const timerHelpers = /* @__PURE__ */ new Set(["useFakeTimers", "useFastForwardTimers"]);
-const timerGlobals = /* @__PURE__ */ new Set([
-  "setTimeout",
-  "clearTimeout",
-  "setInterval",
-  "clearInterval",
-  "requestAnimationFrame",
-  "cancelAnimationFrame",
-  "requestIdleCallback",
-  "cancelIdleCallback",
-  "queueMicrotask",
-  "Date"
-]);
-plugin.createRule({
-  name: "no-unsafe-fake-timers",
-  meta: {
-    docs: {
-      description: "Use core's managed timer helpers and do not mix fake timers with global timer spies.",
-      defaultLevel: "error",
-      isTypeChecked: false
-    },
-    messages: {
-      managedTimers: "Use useFakeTimers or useFastForwardTimers from test-support/schedulingUtils. They restore timers on disposal and test completion.",
-      timerSpy: "Do not mix fake timers with global timer spies in the same file. Vitest can reinstall fake timers when restoring disposed spies. Use vi.getTimerCount() or observe timer callbacks instead."
-    },
-    schema: [],
-    type: "problem"
-  },
-  defaultOptions: [],
-  create(context) {
-    const vitestNames = /* @__PURE__ */ new Set();
-    const vitestNamespaces = /* @__PURE__ */ new Set();
-    const helperNames = /* @__PURE__ */ new Set();
-    const helperNamespaces = /* @__PURE__ */ new Set();
-    const timerSpies = [];
-    let usesFakeTimers = false;
-    function isVitest(node) {
-      return node.type === AST_NODE_TYPES.Identifier && vitestNames.has(node.name) || node.type === AST_NODE_TYPES.MemberExpression && node.object.type === AST_NODE_TYPES.Identifier && vitestNamespaces.has(node.object.name) && ["vi", "vitest"].includes(propertyName(node) ?? "");
-    }
-    return {
-      "ImportDeclaration"(node) {
-        const isVitestImport = node.source.value === "vitest";
-        if (!isVitestImport && node.source.value !== "test-support/schedulingUtils") {
-          return;
-        }
-        for (const specifier of node.specifiers) {
-          if (specifier.type === AST_NODE_TYPES.ImportNamespaceSpecifier) {
-            (isVitestImport ? vitestNamespaces : helperNamespaces).add(specifier.local.name);
-          } else if (specifier.type === AST_NODE_TYPES.ImportSpecifier) {
-            const imported = specifier.imported.type === AST_NODE_TYPES.Identifier ? specifier.imported.name : specifier.imported.value;
-            if (isVitestImport ? imported === "vi" || imported === "vitest" : timerHelpers.has(imported)) {
-              (isVitestImport ? vitestNames : helperNames).add(specifier.local.name);
-            }
-          }
-        }
-      },
-      "CallExpression"(node) {
-        const callee = node.callee;
-        if (callee.type === AST_NODE_TYPES.Identifier && helperNames.has(callee.name)) {
-          usesFakeTimers = true;
-        }
-        if (callee.type !== AST_NODE_TYPES.MemberExpression) {
-          return;
-        }
-        const method = propertyName(callee);
-        if (callee.object.type === AST_NODE_TYPES.Identifier && helperNamespaces.has(callee.object.name) && method != null && timerHelpers.has(method)) {
-          usesFakeTimers = true;
-        }
-        if (!isVitest(callee.object)) {
-          return;
-        }
-        if (method === "useFakeTimers" || method === "useRealTimers") {
-          usesFakeTimers ||= method === "useFakeTimers";
-          context.report({ node, messageId: "managedTimers" });
-        } else if (method === "spyOn") {
-          const [target, property] = node.arguments;
-          if (target?.type === AST_NODE_TYPES.Identifier && ["globalThis", "window", "global", "self"].includes(target.name) && property?.type === AST_NODE_TYPES.Literal && typeof property.value === "string" && timerGlobals.has(property.value)) {
-            timerSpies.push(node);
-          }
-        }
-      },
-      "Program:exit"() {
-        if (usesFakeTimers) {
-          for (const node of timerSpies) {
-            context.report({ node, messageId: "timerSpy" });
-          }
-        }
-      }
-    };
-  }
-});
-function propertyName(node) {
-  if (!node.computed && node.property.type === AST_NODE_TYPES.Identifier) {
-    return node.property.name;
-  }
-  return node.property.type === AST_NODE_TYPES.Literal && typeof node.property.value === "string" ? node.property.value : void 0;
-}
 const tsRe = /\.tsx?$/u;
 let gitIndexFiles;
 function getGitIndexFiles(cwd) {
@@ -773,6 +677,32 @@ plugin.createRule({
     };
   }
 });
+plugin.createRule({
+  name: "require-managed-timers",
+  meta: {
+    docs: {
+      description: "Use core's managed timer helpers instead of direct Vitest timer setup and restoration.",
+      defaultLevel: "error",
+      isTypeChecked: false
+    },
+    messages: {
+      managedTimers: "Use useFakeTimers or useFastForwardTimers from test-support/schedulingUtils. They restore timers on disposal and test completion."
+    },
+    schema: [],
+    type: "problem"
+  },
+  defaultOptions: [],
+  create(context) {
+    return {
+      CallExpression(node) {
+        const callee = node.callee;
+        if (callee.type === AST_NODE_TYPES.MemberExpression && ["useFakeTimers", "useRealTimers"].includes(propertyName(callee) ?? "") && isImportedSymbol(callee.object, context.sourceCode, "vitest", ["vi", "vitest"])) {
+          context.report({ node, messageId: "managedTimers" });
+        }
+      }
+    };
+  }
+});
 plugin.createRule({
   name: "spec-suite-filename",
   meta: {

package/dist/plugins/webgis/index.js

@@ -1,9 +1,10 @@
 import { m as makeEslintPlugin } from "../../chunks/makePlugin.js";
-import { TSESTree, AST_TOKEN_TYPES, AST_NODE_TYPES, TSESLint } from "@typescript-eslint/utils";
+import { TSESTree, AST_TOKEN_TYPES, AST_NODE_TYPES, TSESLint, ASTUtils } from "@typescript-eslint/utils";
 import path from "node:path";
 import { resolve } from "path/posix";
 import globals from "globals";
 import { uncapitalize, kebabToPascal } from "@arcgis/toolkit/string";
+import { i as isImportedSymbol, p as propertyName } from "../../chunks/imports.js";
 import { e as extractDeclareElementsInterface, k as getComponentDeclaration } from "../../chunks/estree.js";
 const plugin = makeEslintPlugin(
   "webgis",
@@ -907,6 +908,86 @@ plugin.createRule({
   }
 });
 const reTouchingJsDoc = /\*\/\s+\/\*\*/gu;
+const timerGlobals = /* @__PURE__ */ new Set([
+  "setTimeout",
+  "clearTimeout",
+  "setInterval",
+  "clearInterval",
+  "setImmediate",
+  "clearImmediate",
+  "requestAnimationFrame",
+  "cancelAnimationFrame",
+  "requestIdleCallback",
+  "cancelIdleCallback",
+  "queueMicrotask",
+  "Date"
+]);
+plugin.createRule({
+  name: "no-unsafe-fake-timers",
+  meta: {
+    docs: {
+      description: "Do not mix fake timers with global timer spies, even across tests in the same file.",
+      defaultLevel: "error",
+      isTypeChecked: false
+    },
+    messages: {
+      timerSpy: "Do not mix fake timers with global timer spies in the same file. Even disposed spies can corrupt timers during later mock cleanup. Use vi.getTimerCount() or observe timer callbacks instead."
+    },
+    schema: [
+      {
+        type: "object",
+        properties: {
+          fakeTimerHelpers: {
+            type: "array",
+            items: {
+              type: "object",
+              properties: {
+                module: { type: "string" },
+                names: { type: "array", items: { type: "string" }, minItems: 1, uniqueItems: true }
+              },
+              required: ["module", "names"],
+              additionalProperties: false
+            }
+          }
+        },
+        additionalProperties: false
+      }
+    ],
+    type: "problem"
+  },
+  defaultOptions: [{}],
+  create(context, [{ fakeTimerHelpers = [] }]) {
+    const timerSpies = [];
+    let usesFakeTimers = false;
+    return {
+      "CallExpression"(node) {
+        const callee = node.callee;
+        usesFakeTimers ||= fakeTimerHelpers.some(
+          ({ module, names }) => isImportedSymbol(callee, context.sourceCode, module, names)
+        );
+        if (callee.type !== AST_NODE_TYPES.MemberExpression || !isImportedSymbol(callee.object, context.sourceCode, "vitest", ["vi", "vitest"])) {
+          return;
+        }
+        const method = propertyName(callee);
+        if (method === "useFakeTimers") {
+          usesFakeTimers = true;
+        } else if (method === "spyOn") {
+          const [target, property] = node.arguments;
+          if (target?.type === AST_NODE_TYPES.Identifier && ["globalThis", "window", "global", "self"].includes(target.name) && property?.type === AST_NODE_TYPES.Literal && typeof property.value === "string" && timerGlobals.has(property.value) && !ASTUtils.findVariable(context.sourceCode.getScope(target), target.name)?.defs.length) {
+            timerSpies.push(node);
+          }
+        }
+      },
+      "Program:exit"() {
+        if (usesFakeTimers) {
+          for (const node of timerSpies) {
+            context.report({ node, messageId: "timerSpy" });
+          }
+        }
+      }
+    };
+  }
+});
 const description$1 = `Do not use links like [](#something) as they are not portable across .d.ts, and are not validated at build time. Use {@link } syntax, or absolute links. See https://webgis.esri.com/references/api-extractor/tags-reference#link)`;
 plugin.createRule({
   name: "no-unsafe-hash-links",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "6.0.0-next.13",
+  "version": "6.0.0-next.15",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "exports": {
@@ -21,7 +21,7 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/toolkit": "6.0.0-next.13",
+    "@arcgis/toolkit": "6.0.0-next.15",
     "@eslint/markdown": "^8.0.3",
     "@types/confusing-browser-globals": "^1.0.3",
     "@typescript-eslint/utils": "^8.63.0",