@arcgis/eslint-config 6.0.0-next.11 → 6.0.0-next.13

package/dist/config/core.js

@@ -817,6 +817,13 @@ const eslintConfigCore = [
       // Require awaiting assert.screenshot() in tests
       "webgis/require-await-for-async-screenshot-assert": "error"
     }
+  },
+  {
+    files: ["packages/core-packages/core/tests/**/*.{ts,tsx}"],
+    ignores: ["packages/core-packages/core/tests/support/schedulingUtils.ts"],
+    rules: {
+      "core/no-unsafe-fake-timers": "error"
+    }
   }
 ];
 export {

package/dist/plugins/core/index.js

@@ -483,6 +483,103 @@ function getDeclaredClass(filename) {
   const relativePath = relative(root, filename).replaceAll(win32.sep, ".").replaceAll(posix.sep, ".").replace(/^src\./u, "esri.").replace(/\.[^/.]+$/u, "");
   return relativePath;
 }
+const timerHelpers = /* @__PURE__ */ new Set(["useFakeTimers", "useFastForwardTimers"]);
+const timerGlobals = /* @__PURE__ */ new Set([
+  "setTimeout",
+  "clearTimeout",
+  "setInterval",
+  "clearInterval",
+  "requestAnimationFrame",
+  "cancelAnimationFrame",
+  "requestIdleCallback",
+  "cancelIdleCallback",
+  "queueMicrotask",
+  "Date"
+]);
+plugin.createRule({
+  name: "no-unsafe-fake-timers",
+  meta: {
+    docs: {
+      description: "Use core's managed timer helpers and do not mix fake timers with global timer spies.",
+      defaultLevel: "error",
+      isTypeChecked: false
+    },
+    messages: {
+      managedTimers: "Use useFakeTimers or useFastForwardTimers from test-support/schedulingUtils. They restore timers on disposal and test completion.",
+      timerSpy: "Do not mix fake timers with global timer spies in the same file. Vitest can reinstall fake timers when restoring disposed spies. Use vi.getTimerCount() or observe timer callbacks instead."
+    },
+    schema: [],
+    type: "problem"
+  },
+  defaultOptions: [],
+  create(context) {
+    const vitestNames = /* @__PURE__ */ new Set();
+    const vitestNamespaces = /* @__PURE__ */ new Set();
+    const helperNames = /* @__PURE__ */ new Set();
+    const helperNamespaces = /* @__PURE__ */ new Set();
+    const timerSpies = [];
+    let usesFakeTimers = false;
+    function isVitest(node) {
+      return node.type === AST_NODE_TYPES.Identifier && vitestNames.has(node.name) || node.type === AST_NODE_TYPES.MemberExpression && node.object.type === AST_NODE_TYPES.Identifier && vitestNamespaces.has(node.object.name) && ["vi", "vitest"].includes(propertyName(node) ?? "");
+    }
+    return {
+      "ImportDeclaration"(node) {
+        const isVitestImport = node.source.value === "vitest";
+        if (!isVitestImport && node.source.value !== "test-support/schedulingUtils") {
+          return;
+        }
+        for (const specifier of node.specifiers) {
+          if (specifier.type === AST_NODE_TYPES.ImportNamespaceSpecifier) {
+            (isVitestImport ? vitestNamespaces : helperNamespaces).add(specifier.local.name);
+          } else if (specifier.type === AST_NODE_TYPES.ImportSpecifier) {
+            const imported = specifier.imported.type === AST_NODE_TYPES.Identifier ? specifier.imported.name : specifier.imported.value;
+            if (isVitestImport ? imported === "vi" || imported === "vitest" : timerHelpers.has(imported)) {
+              (isVitestImport ? vitestNames : helperNames).add(specifier.local.name);
+            }
+          }
+        }
+      },
+      "CallExpression"(node) {
+        const callee = node.callee;
+        if (callee.type === AST_NODE_TYPES.Identifier && helperNames.has(callee.name)) {
+          usesFakeTimers = true;
+        }
+        if (callee.type !== AST_NODE_TYPES.MemberExpression) {
+          return;
+        }
+        const method = propertyName(callee);
+        if (callee.object.type === AST_NODE_TYPES.Identifier && helperNamespaces.has(callee.object.name) && method != null && timerHelpers.has(method)) {
+          usesFakeTimers = true;
+        }
+        if (!isVitest(callee.object)) {
+          return;
+        }
+        if (method === "useFakeTimers" || method === "useRealTimers") {
+          usesFakeTimers ||= method === "useFakeTimers";
+          context.report({ node, messageId: "managedTimers" });
+        } else if (method === "spyOn") {
+          const [target, property] = node.arguments;
+          if (target?.type === AST_NODE_TYPES.Identifier && ["globalThis", "window", "global", "self"].includes(target.name) && property?.type === AST_NODE_TYPES.Literal && typeof property.value === "string" && timerGlobals.has(property.value)) {
+            timerSpies.push(node);
+          }
+        }
+      },
+      "Program:exit"() {
+        if (usesFakeTimers) {
+          for (const node of timerSpies) {
+            context.report({ node, messageId: "timerSpy" });
+          }
+        }
+      }
+    };
+  }
+});
+function propertyName(node) {
+  if (!node.computed && node.property.type === AST_NODE_TYPES.Identifier) {
+    return node.property.name;
+  }
+  return node.property.type === AST_NODE_TYPES.Literal && typeof node.property.value === "string" ? node.property.value : void 0;
+}
 const tsRe = /\.tsx?$/u;
 let gitIndexFiles;
 function getGitIndexFiles(cwd) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "6.0.0-next.11",
+  "version": "6.0.0-next.13",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "exports": {
@@ -21,7 +21,7 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/toolkit": "6.0.0-next.11",
+    "@arcgis/toolkit": "6.0.0-next.13",
     "@eslint/markdown": "^8.0.3",
     "@types/confusing-browser-globals": "^1.0.3",
     "@typescript-eslint/utils": "^8.63.0",