@arcgis/eslint-config 5.2.0-next.90 → 5.2.0-next.93

package/dist/config/core.js

@@ -215,7 +215,6 @@ const eslintConfigCore = [
       "no-unreachable-loop": "off",
       "no-unsafe-negation": "off",
       "no-useless-call": "off",
-      "no-useless-computed-key": "off",
       "no-useless-concat": "off",
       "no-warning-comments": "off",
       "prefer-arrow-callback": "off",

package/dist/config/index.js

@@ -176,7 +176,8 @@ const config = [
       // Not an error as some external APIs require calling "new" even if we don't
       // care about the retune time. Controllers also use this pattern
       "no-new": "off",
-      "no-useless-computed-key": ["warn", { enforceForClassMembers: true }],
+      // See https://devtopia.esri.com/WebGIS/webgis-sdk/pull/14943#discussion_r1661089
+      "no-useless-computed-key": "off",
       "no-useless-concat": "error",
       "no-unneeded-ternary": "warn",
       "no-useless-call": "error",

package/dist/{estree-5iKU4xoP.js → estree-Ern7-L05.js}

@@ -73,6 +73,8 @@ function isGetterWithoutSetter(node) {
 function getName(node) {
   if (node.key.type === AST_NODE_TYPES.Identifier) {
     return node.key.name;
+  } else if (node.key.type === AST_NODE_TYPES.PrivateIdentifier) {
+    return `#${node.key.name}`;
   } else if (node.key.type === AST_NODE_TYPES.Literal && typeof node.key.value === "string") {
     return node.key.value;
   } else {

package/dist/{makePlugin-NTi-Ntj5.js → makePlugin-DzbLPNPV.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "5.2.0-next.90";
+const version = "5.2.0-next.93";
 const packageJson = {
   version
 };

package/dist/plugins/core/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-NTi-Ntj5.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DzbLPNPV.js";
 import { generateDifferences, showInvisibles } from "prettier-linter-helpers";
 import { AST_NODE_TYPES, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import path, { relative, win32, posix, normalize } from "path";

package/dist/plugins/lumina/index.js

@@ -1,6 +1,6 @@
-import { m as makeEslintPlugin } from "../../makePlugin-NTi-Ntj5.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DzbLPNPV.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
-import { l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, g as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, c as isCreateEvent, h as hasDecorator, d as getName, f as checkForLuminaJsx, j as isBindThisCallee, k as getComponentDeclaration, u as unwrapExpression } from "../../estree-5iKU4xoP.js";
+import { l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, g as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, c as isCreateEvent, h as hasDecorator, d as getName, f as checkForLuminaJsx, j as isBindThisCallee, k as getComponentDeclaration, u as unwrapExpression } from "../../estree-Ern7-L05.js";
 import ts from "typescript";
 import { camelToKebab } from "@arcgis/toolkit/string";
 const plugin = makeEslintPlugin(
@@ -770,6 +770,10 @@ plugin.createRule({
   }
 });
 const ordering = [
+  /**
+   * Special well-known members that do not exist at runtime.
+   */
+  "Type-only metadata members",
   /*
    * Putting static before instance members is a common OOP convention.
    * Static members are always evaluated before instance members.
@@ -826,12 +830,13 @@ const getWireframe = () => new Map(ordering.map((region) => [region, []]));
 const entries = Object.entries;
 const regionMatchers = entries({
   "Static Members": (node) => node.type === AST_NODE_TYPES.StaticBlock || "static" in node && node.static,
+  "Type-only metadata members": (node) => node.type === AST_NODE_TYPES.PropertyDefinition && node.definite && node.override && node.key.type === AST_NODE_TYPES.Literal && node.key.value?.startsWith?.("@") === true,
   "Lifecycle": (_node, name) => lifecyclesSet.has(name),
   "Public Methods": (node) => "decorators" in node && hasDecorator(node, "method"),
   "Public Properties": (node) => "decorators" in node && hasDecorator(node, "property"),
   "State Properties": (node) => "decorators" in node && hasDecorator(node, "state"),
   "Events": isEvent,
-  "Rendering": (_node, name) => name.startsWith("render") || name.startsWith("_render"),
+  "Rendering": (_node, name) => name.startsWith("render") || name.startsWith("_render") || name.startsWith("#render"),
   "Private Properties": (node) => node.type === AST_NODE_TYPES.PropertyDefinition || // We don't yet support public accessor properties
   node.type === AST_NODE_TYPES.AccessorProperty || node.type === AST_NODE_TYPES.MethodDefinition && (node.kind === "get" || node.kind === "set"),
   "Private Methods": () => true

package/dist/plugins/webgis/index.js

@@ -1,10 +1,10 @@
-import { m as makeEslintPlugin } from "../../makePlugin-NTi-Ntj5.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DzbLPNPV.js";
 import { TSESTree, AST_TOKEN_TYPES, AST_NODE_TYPES, TSESLint } from "@typescript-eslint/utils";
 import path from "node:path";
 import { resolve } from "path/posix";
 import globals from "globals";
 import { uncapitalize, kebabToPascal } from "@arcgis/toolkit/string";
-import { e as extractDeclareElementsInterface, k as getComponentDeclaration } from "../../estree-5iKU4xoP.js";
+import { e as extractDeclareElementsInterface, k as getComponentDeclaration } from "../../estree-Ern7-L05.js";
 const plugin = makeEslintPlugin(
   "webgis",
   (rule) => `https://devtopia.esri.com/WebGIS/webgis-sdk/tree/main/packages/support-packages/eslint-config/src/plugins/webgis/rules/${rule}.ts`

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "5.2.0-next.90",
+  "version": "5.2.0-next.93",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "exports": {
@@ -21,7 +21,7 @@
   ],
   "license": "SEE LICENSE IN LICENSE.md",
   "dependencies": {
-    "@arcgis/toolkit": "5.2.0-next.90",
+    "@arcgis/toolkit": "5.2.0-next.93",
     "@eslint/js": "^10.0.1",
     "@eslint/markdown": "^8.0.3",
     "@types/confusing-browser-globals": "^1.0.3",