@arcgis/eslint-config 5.2.0-next.58 → 5.2.0-next.59

package/dist/config/core.js

@@ -5,6 +5,7 @@ import reactJsxPlugin from "eslint-plugin-react-jsx";
 import regexpPlugin from "eslint-plugin-regexp";
 import unicornPlugin from "eslint-plugin-unicorn";
 import { join } from "node:path";
+import tsEslint from "typescript-eslint";
 import { corePlugin } from "../plugins/core/index.js";
 const noRestrictedSyntax = [
   "error",
@@ -38,6 +39,20 @@ const noRestrictedSyntax = [
 const disabledMarkdownRules = Object.fromEntries(
   Object.keys(markdown.rules).map((ruleName) => [`markdown/${ruleName}`, "off"])
 );
+const coreTypedRulesIgnoredFiles = [
+  // We didn't run typed rules on these files before
+  "packages/core-packages/core/*.{ts,tsx}",
+  "packages/core-packages/core/{.github,build,scripts,tasks,test-apps,typings}/**/*.{ts,tsx}",
+  // This folder runs in node, so uses a separate tsconfig.json
+  "packages/core-packages/core/tests/support/vitest/node/**/*.ts"
+];
+const coreTypeCheckedRuleNames = new Set(Object.keys(tsEslint.configs.disableTypeChecked.rules ?? {})).union(
+  corePlugin.meta.typeCheckedRules
+);
+coreTypeCheckedRuleNames.delete("@typescript-eslint/naming-convention");
+const disabledCoreTypeCheckedRules = Object.fromEntries(
+  Array.from(coreTypeCheckedRuleNames, (ruleName) => [ruleName, "off"])
+);
 const eslintConfigCore = [
   {
     files: ["packages/core-packages/**/*.{ts,tsx}"],
@@ -516,8 +531,7 @@ const eslintConfigCore = [
   {
     // Type-aware rules
     files: ["packages/core-packages/**/*.{ts,tsx}"],
-    // This folder runs in node, so uses a separate tsconfig.json
-    ignores: ["packages/core-packages/core/tests/support/vitest/node/**/*.ts"],
+    ignores: [...coreTypedRulesIgnoredFiles],
     rules: {
       // Disabled until https://github.com/typescript-eslint/typescript-eslint/pull/11267 is available.
       "@typescript-eslint/await-thenable": "off",
@@ -534,6 +548,18 @@ const eslintConfigCore = [
       "@typescript-eslint/return-await": ["error", "error-handling-correctness-only"]
     }
   },
+  {
+    // The base config enables typed rules for all .ts files.
+    // Core has .ts files that are not typed rules ready.
+    // Disable the typed rules for those.
+    files: [...coreTypedRulesIgnoredFiles],
+    languageOptions: {
+      parserOptions: {
+        projectService: false
+      }
+    },
+    rules: disabledCoreTypeCheckedRules
+  },
   {
     files: ["packages/core-packages/**/*.tsx"],
     plugins: {

package/dist/{makePlugin-epAxL-HZ.js → makePlugin-bHvUvBdT.js}

@@ -1,10 +1,11 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "5.2.0-next.58";
+const version = "5.2.0-next.59";
 const packageJson = {
   version
 };
 function makeEslintPlugin(pluginName, urlCreator) {
   const rules = [];
+  const typeCheckedRules = /* @__PURE__ */ new Set();
   const creator = ESLintUtils.RuleCreator(urlCreator);
   return {
     // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
@@ -13,6 +14,9 @@ function makeEslintPlugin(pluginName, urlCreator) {
       const docs = { ...meta.docs, name };
       const ruleModule = creator({ ...rest, meta: { ...meta, docs }, name });
       rules.push(ruleModule);
+      if (meta.docs.isTypeChecked) {
+        typeCheckedRules.add(`${pluginName}/${name}`);
+      }
       return ruleModule;
     },
     // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
@@ -23,7 +27,7 @@ function makeEslintPlugin(pluginName, urlCreator) {
         )
       };
       const plugin = {
-        meta: { name: `@arcgis/eslint-plugin-${pluginName}`, version: packageJson.version },
+        meta: { name: `@arcgis/eslint-plugin-${pluginName}`, version: packageJson.version, typeCheckedRules },
         configs: {
           recommended: config
         },

package/dist/plugins/core/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-epAxL-HZ.js";
+import { m as makeEslintPlugin } from "../../makePlugin-bHvUvBdT.js";
 import { AST_NODE_TYPES, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import { generateDifferences, showInvisibles } from "prettier-linter-helpers";
 import path, { relative, win32, posix, normalize } from "path";
@@ -14,7 +14,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks that glsl tagged template strings don't have extra whitespace.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       delete: "Delete `{{ deleteText }}`",
@@ -95,30 +96,26 @@ function removeLeadingBlankLines(text) {
 function removeTrailingBlankLines(text) {
   return text.replace(/(\r?\n)(\r?\n)*([ \t]*)`$/gu, "$1$3`");
 }
+const projectMarker = "/src/";
+let projectRoot = void 0;
 function findProjectRoot(filename) {
   const normalized = filename.replaceAll("\\", "/");
-  let minimumIndex = Number.POSITIVE_INFINITY;
-  for (const marker of ["src/", "tests/", "test-apps/", "esri/", ".github/"]) {
-    const index = normalized.indexOf(marker);
-    if (index === 0) {
-      return ".";
-    } else if (index > 0 && normalized.charCodeAt(index - 1) === slashCharCode) {
-      minimumIndex = Math.min(minimumIndex, index);
-    }
-  }
-  if (minimumIndex !== Number.POSITIVE_INFINITY) {
-    return normalized.slice(0, minimumIndex);
+  const isProjectFile = normalized.includes(projectMarker);
+  if (isProjectFile && projectRoot) {
+    return projectRoot;
   }
   const fileToFind = "package.json";
   for (let root = dirname(filename), previousRoot = filename; root !== previousRoot; previousRoot = root, root = dirname(root)) {
     const filepath = join(root, fileToFind);
     if (existsSync(filepath)) {
+      if (isProjectFile) {
+        projectRoot = root;
+      }
       return root;
     }
   }
   return;
 }
-const slashCharCode = 47;
 const isWindows = process.platform === "win32";
 const collator = new Intl.Collator("en-US");
 plugin.createRule({
@@ -126,7 +123,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks that imports are sorted and grouped",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       importFormat: "Imports are incorrectly sorted and/or grouped",
@@ -353,7 +351,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks for duplicate comments before the first import declaration.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: { duplicate: "Delete duplicate comment" },
     schema: [],
@@ -395,7 +394,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks for `todo` JSDoc tags with missing descriptions.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: { empty: "JSDoc `todo` tag description required" },
     schema: [],
@@ -420,7 +420,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Enforces the declared class name passed to the @subclass() decorator",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       invalidPath: "Invalid path passed to @subclass(). It should be a string literal matching the file path, without the extension and with path separators replaced with `.`"
@@ -503,7 +504,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks that files redundant to TypeScript implementation files are not checked in.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       js: "Redundant JavaScript file detected. Please `git rm -f {{file}}`",
@@ -519,16 +521,16 @@ plugin.createRule({
     return {
       Program(node) {
         if (!filePath.endsWith(".d.ts") && tsRe.test(filePath)) {
-          const projectRoot = findProjectRoot(filePath);
-          if (!projectRoot) {
+          const projectRoot2 = findProjectRoot(filePath);
+          if (!projectRoot2) {
             context.report({ node, messageId: "missingProjectRoot" });
             return;
           }
-          const gitIndexFiles2 = getGitIndexFiles(projectRoot);
+          const gitIndexFiles2 = getGitIndexFiles(projectRoot2);
           if (!gitIndexFiles2) {
             return;
           }
-          filePath = relative(projectRoot, filePath);
+          filePath = relative(projectRoot2, filePath);
           const jsFilename = filePath.replace(tsRe, ".js");
           if (gitIndexFiles2.has(jsFilename)) {
             context.report({ node, messageId: "js", data: { file: jsFilename } });
@@ -547,7 +549,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks that whenever possible import and export paths are relative instead of absolute.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       importFormat: 'Prefer relative ("{{relPath}}") over absolute path',
@@ -625,7 +628,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Checks that the corresponding calcite component import exists for each calcite component tag used.  It also checks that there are no extra unnecessary imports.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       missingImport: 'Import missing: import("@esri/calcite-components/dist/components/{{tag}}")',
@@ -674,7 +678,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "Enforce filenames to be part of spec (test) top-level suites.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       name: "Suite name must be the name of the spec file",

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-epAxL-HZ.js";
+import { m as makeEslintPlugin } from "../../makePlugin-bHvUvBdT.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import { l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, d as isCreateEvent, h as hasDecorator, f as getName, j as checkForLuminaJsx, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-CDc-die8.js";
 import ts from "typescript";
@@ -14,7 +14,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$m,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       addMissingJsxImport: description$m
@@ -80,7 +81,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$l,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: true
     },
     messages: {
       addType: `This property is of {{ type }} type, yet the type is not trivially inferrable from the AST without type-checking. Such properties require a { type: {{ type }} } annotation.
@@ -249,7 +251,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "This rule helps ban or warn against listened event types",
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: {
       default: "{{message}}"
@@ -319,7 +322,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$k,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       fileFolderNameMismatch: "Lumina component must be declared in a file whose name (without extension) matches the parent folder name.\n\nCreating components in nested folders is supported as long as the file name matches the immediate parent folder name.",
@@ -369,7 +373,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$j,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       eventNamespaceError: `Custom event name must start with one of the following prefixes: {{ prefixes }}.
@@ -476,7 +481,8 @@ plugin.createRule({
     docs: {
       description: description$i,
       // TODO: enable this by default
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: {
       consistentNullabilityError: `For consistency, use {{propertyName}}?:{{newType}} to denote property as optional, rather than {{propertyName}}:{{oldType}}.`,
@@ -556,7 +562,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$h,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       publicApiMustBePublic: `@property(), @method() and createEvent() members must not have private or protected modifier.
@@ -664,7 +671,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$g,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: true
     },
     messages: {
       explicitSetterType: description$g,
@@ -1051,7 +1059,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: baseDescription$2,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       memberOrdering: "Component member ordering is not consistent. Run ESLint autofix to sort members.",
@@ -1173,7 +1182,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: "This rule ensures that components are not created with `document.createElement()` to ensure imports are tracked by the compiler.",
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     fixable: "code",
     messages: {
@@ -1219,7 +1229,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$f,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       noIgnoreJsDocTag: description$f
@@ -1257,7 +1268,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$e,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: true
     },
     messages: {
       incorrectDynamicTagName: `This is using incorrect dynamic tag name syntax. See documentation on how to use dynamic tag in Lumina's JSX: https://webgis.esri.com/references/lumina/jsx#dynamic-tag-name`
@@ -1307,7 +1319,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$d,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       errorInlineArrow: description$d
@@ -1342,7 +1355,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$c,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       inlineExposure: description$c
@@ -1387,7 +1401,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$b,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       noJsDocXrefLinks: description$b
@@ -1430,7 +1445,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$a,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       noInvalidDirectivesProp: description$a
@@ -1476,7 +1492,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$9,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       noJsxSpread: description$9
@@ -1521,7 +1538,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: baseDescription$1,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       errorListenInConnectedCallback: description$8
@@ -1565,7 +1583,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$7,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       noNonComponentExports: description$7,
@@ -1654,7 +1673,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$6,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       noPropertyNameStartWithOn: description$6
@@ -1699,7 +1719,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: baseDescription,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: true
     },
     messages: {
       errorFalseRendered: description$5
@@ -1750,7 +1771,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$4,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       needlessInlineJsxEventTypeAnnotation: "There is no need for this type annotation as JSX types already define event types.",
@@ -1840,7 +1862,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$3,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       noUnnecessaryAttributeName: description$3
@@ -1893,7 +1916,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$2,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       noUnnecessaryBindThis: description$2
@@ -1956,7 +1980,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$1,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       noUnnecessaryKey: description$1
@@ -2022,7 +2047,8 @@ plugin.createRule({
   meta: {
     docs: {
       description,
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       requireNamespace: "Custom element tag names in this project must start with one of the following namespaces: {{namespaces}}",

package/dist/plugins/utils/makePlugin.d.ts

@@ -2,10 +2,22 @@ import type { RuleModule } from "@typescript-eslint/utils/ts-eslint";
 import type { TSESLint } from "@typescript-eslint/utils";
 
 export interface EslintPlugin extends TSESLint.FlatConfig.Plugin {
+  meta: EslintPluginMeta;
   configs: { recommended: TSESLint.FlatConfig.Config; };
   rules: Record<string, RuleModule<string, readonly unknown[], CommonDocs>>;
 }
 
+export interface EslintPluginMeta extends TSESLint.FlatConfig.PluginMeta {
+  /**
+   * A set of rule names from current plugin that require type information.
+   *
+   * Generally, type checked rules are much slower as they need type checking.
+   * But once the first typed rule does the type checking, the other type
+   * checked rules don't add as much overhead.
+   */
+  typeCheckedRules: ReadonlySet<string>;
+}
+
 export type CommonDocs = {
   /** Rule description */
   description: string;
@@ -13,4 +25,9 @@ export type CommonDocs = {
   defaultLevel: "error" | "off" | "warn";
   /** Short rule name - inherited from the createRule`s name property */
   name: string;
+  /**
+   * Whether the rule needs type information (whether it calls
+   * ESLintUtils.getParserServices).
+   */
+  isTypeChecked: boolean;
 };

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-epAxL-HZ.js";
+import { m as makeEslintPlugin } from "../../makePlugin-bHvUvBdT.js";
 import { TSESTree, AST_TOKEN_TYPES, AST_NODE_TYPES, TSESLint } from "@typescript-eslint/utils";
 import path from "node:path";
 import { resolve } from "path/posix";
@@ -27,7 +27,8 @@ plugin.createRule({
       // Disabled by default because the rule is most relevant for autocasting
       // and only on public classes. We are discouraging autocasting in new
       // code.
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: {
       name: `By convention, the first parameter on an Accessor-based class must be called "properties". This is needed for autocasting - https://webgis.esri.com/references/api-extractor/api-node-kinds#constructor. If your class has constructors overloads, at least one of them must have a "properties" parameter.`,
@@ -111,13 +112,14 @@ If you wish to use a loose type like any/object, create a type alias \`type {{ e
     };
   }
 });
-const description$6 = `Enforce consistent logging so that ArcGIS developers can easily debug errors or warnings logged by our web components, which may lack a meaningful context in compiled code. See [our documentation on @arcgis/toolkit/log](https://webgis.esri.com/references/toolkit/log).`;
+const description$7 = `Enforce consistent logging so that ArcGIS developers can easily debug errors or warnings logged by our web components, which may lack a meaningful context in compiled code. See [our documentation on @arcgis/toolkit/log](https://webgis.esri.com/references/toolkit/log).`;
 plugin.createRule({
   name: "consistent-logging",
   meta: {
     docs: {
-      description: description$6,
-      defaultLevel: "off"
+      description: description$7,
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: {
       consistentLoggingWarning: `For consistency, use the log utility from @arcgis/toolkit/log instead of console.{{logMethodName}}.`
@@ -155,7 +157,8 @@ plugin.createRule({
       description: "Enforce consistent mixin pattern. See https://webgis.esri.com/sdk/contributing/core/core/mixins",
       // Enabled by default because the rule targets a very specific pattern
       // and that pattern is tricky to get right without this rule.
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
       updateMixinCode: "Mixin typings need to be updated.",
@@ -480,17 +483,18 @@ function expressionToTypeString(expression, context, asConst) {
   }
   return;
 }
-const description$5 = "Using .d.ts files is discouraged. Prefer .ts files instead, as they are type-checked and not in global scope.";
+const description$6 = "Using .d.ts files is discouraged. Prefer .ts files instead, as they are type-checked and not in global scope.";
 const allowedNames = /* @__PURE__ */ new Set(["vite-env.d.ts", "components.d.ts"]);
 plugin.createRule({
   name: "no-dts-files",
   meta: {
     docs: {
-      description: description$5,
-      defaultLevel: "warn"
+      description: description$6,
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
-      avoidDtsFiles: description$5
+      avoidDtsFiles: description$6
     },
     type: "suggestion",
     schema: []
@@ -526,7 +530,8 @@ plugin.createRule({
     docs: {
       description: "Disallow empty catch calls since empty catch calls in a promise chain don't catch any exceptions",
       // Enabled by default because this caught real bugs and has autofix
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: { emptyCatch: "no empty catch calls" },
     schema: [],
@@ -547,16 +552,17 @@ plugin.createRule({
     };
   }
 });
-const description$4 = `Imports of files outside the src/ folder are not-portable and likely to break for consumers of this package.`;
+const description$5 = `Imports of files outside the src/ folder are not-portable and likely to break for consumers of this package.`;
 plugin.createRule({
   name: "no-import-outside-src",
   meta: {
     docs: {
-      description: description$4,
-      defaultLevel: "error"
+      description: description$5,
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: {
-      noImportOutsideSrc: description$4
+      noImportOutsideSrc: description$5
     },
     type: "problem",
     schema: []
@@ -598,7 +604,8 @@ plugin.createRule({
       // Disabling by default because this matters for
       // lower-level libraries more than higher-level libraries or applications.
       // Also, many false-positives.
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     schema: [
       {
@@ -684,6 +691,59 @@ function isClassDefinition(definition) {
   }
   return variableNode.init?.type === AST_NODE_TYPES.ClassExpression;
 }
+const description$4 = "For Node.js compatibility, when TypeScript file imports another TypeScript file, use .ts extension over .js";
+plugin.createRule({
+  name: "no-js-in-ts-imports",
+  meta: {
+    docs: {
+      description: description$4,
+      defaultLevel: "off",
+      isTypeChecked: false
+    },
+    messages: {
+      noJsInTsImports: description$4
+    },
+    type: "problem",
+    fixable: "code",
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    if (!/\.tsx?$/u.test(context.filename)) {
+      return {};
+    }
+    function checkSpecifier(node) {
+      const specifier = node.value;
+      if (!(specifier.startsWith("./") || specifier.startsWith("../")) || !specifier.endsWith(".js")) {
+        return;
+      }
+      context.report({
+        node,
+        messageId: "noJsInTsImports",
+        data: { specifier },
+        fix: (fixer) => fixer.replaceTextRange([node.range[1] - 3, node.range[1] - 1], "ts")
+      });
+    }
+    return {
+      ImportDeclaration(node) {
+        checkSpecifier(node.source);
+      },
+      ImportExpression(node) {
+        if (node.source.type === AST_NODE_TYPES.Literal && typeof node.source.value === "string") {
+          checkSpecifier(node.source);
+        }
+      },
+      ExportAllDeclaration(node) {
+        checkSpecifier(node.source);
+      },
+      ExportNamedDeclaration(node) {
+        if (node.source) {
+          checkSpecifier(node.source);
+        }
+      }
+    };
+  }
+});
 plugin.createRule({
   name: "no-kebab-case-props",
   meta: {
@@ -692,7 +752,8 @@ plugin.createRule({
       // Off by default till
       // https://devtopia.esri.com/WebGIS/arcgis-web-components/issues/5364#issuecomment-6321339
       // is resolved
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: {
       kebab: "JSX props should use camelCase instead of kebab-case, except for data- or aria- attributes"
@@ -749,7 +810,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$3,
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: {
       noStoryRenderArgsTypeAnnotation: "Do not annotate `render(args)` in stories. Type the story with `Meta<T>` or `StoryObj<T>` and let `args` infer from that."
@@ -790,7 +852,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$2,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       noTouchingJsDoc: description$2
@@ -835,7 +898,8 @@ plugin.createRule({
   meta: {
     docs: {
       description: description$1,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       error: description$1
@@ -890,7 +954,8 @@ plugin.createRule({
     docs: {
       description: "Async tests must await a screenshot assertion.",
       // Enabled by default because it targets a specific pattern and has autofix
-      defaultLevel: "error"
+      defaultLevel: "error",
+      isTypeChecked: false
     },
     messages: { asyncAssert: "Async tests must await a screenshot assertion." },
     schema: [],
@@ -923,7 +988,8 @@ plugin.createRule({
       // presumably work correctly today) so enabling it is a bit too disruptive.
       // We should coordinate enabling it with enabling other lint rules to
       // announce at once.
-      defaultLevel: "off"
+      defaultLevel: "off",
+      isTypeChecked: false
     },
     messages: { missingType: "An explicit type attribute is required on buttons" },
     schema: [],
@@ -952,7 +1018,8 @@ plugin.createRule({
   meta: {
     docs: {
       description,
-      defaultLevel: "warn"
+      defaultLevel: "warn",
+      isTypeChecked: false
     },
     messages: {
       requireJsInImports: description

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "5.2.0-next.58",
+  "version": "5.2.0-next.59",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "exports": {
@@ -41,7 +41,7 @@
     "tslib": "^2.8.1",
     "typescript": "~6.0.3",
     "typescript-eslint": "^8.63.0",
-    "@arcgis/toolkit": "5.2.0-next.58"
+    "@arcgis/toolkit": "5.2.0-next.59"
   },
   "peerDependencies": {
     "eslint": "^10.6.0"