@arcgis/eslint-config 5.2.0-next.50 → 5.2.0-next.52

package/README.md

@@ -8,5 +8,5 @@ It is not intended to be used directly, but rather used as a dependency by other
 
 ## License
 
-This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package, and at https://js.arcgis.com/5.1/LICENSE.txt.
-For third party notices, see https://js.arcgis.com/5.1/third-party-notices.txt.
+This package is licensed under the terms described in the `LICENSE.md` file, located in the root of the package, and at https://js.arcgis.com/5.2/LICENSE.txt.
+For third party notices, see https://js.arcgis.com/5.2/third-party-notices.txt.

package/dist/config/applications.js

@@ -28,8 +28,6 @@ const config = [
       "func-names": "off",
       // This rule is for consistency between library developers - less important for monolith apps.
       "id-denylist": "off",
-      // Some cases actually require sequential async loops
-      "no-await-in-loop": "off",
       // More important for library-exposed symbols than apps
       "symbol-description": "off"
     }

package/dist/config/core.js

@@ -0,0 +1,621 @@
+import markdown from "@eslint/markdown";
+import jsdocPlugin from "eslint-plugin-jsdoc";
+import perfectionistPlugin from "eslint-plugin-perfectionist";
+import reactJsxPlugin from "eslint-plugin-react-jsx";
+import regexpPlugin from "eslint-plugin-regexp";
+import unicornPlugin from "eslint-plugin-unicorn";
+import { join } from "node:path";
+import { corePlugin } from "../plugins/core/index.js";
+const noRestrictedSyntax = [
+  "error",
+  "AccessorProperty",
+  "PrivateIdentifier",
+  {
+    selector: "CallExpression[callee.property.name='concat'][arguments.length=0]",
+    message: "Use slice() instead of concat()."
+  },
+  {
+    selector: "CallExpression[callee.property.name='slice'][arguments.length=1] > .arguments[value=0]",
+    message: "Use slice() instead of slice(0)."
+  },
+  {
+    selector: "TSAbstractPropertyDefinition[decorators.length>0]",
+    message: "Decorators are not supported on abstract properties."
+  },
+  {
+    selector: "TSEnumDeclaration:not([const=true])",
+    message: "Don't declare non-const enums. Use `const enum` instead, or an object with `as const`. See https://www.typescriptlang.org/docs/handbook/enums.html#objects-vs-enums"
+  },
+  {
+    selector: "VariableDeclarator > CallExpression > MemberExpression[property.name='getLogger']",
+    message: "Get a logger as needed instead of assigning it for future use."
+  },
+  {
+    selector: "TSModuleDeclaration[id.type='Identifier']",
+    message: "Use const objects or static classes instead. See https://devtopia.esri.com/WebGIS/arcgis-js-api/discussions/72194"
+  }
+];
+const disabledMarkdownRules = Object.fromEntries(
+  Object.keys(markdown.rules).map((ruleName) => [`markdown/${ruleName}`, "off"])
+);
+const eslintConfigCore = [
+  {
+    files: ["packages/core-packages/**/*.{ts,tsx}"],
+    linterOptions: {
+      reportUnusedDisableDirectives: "off"
+    },
+    plugins: {
+      core: corePlugin,
+      jsdoc: jsdocPlugin,
+      regexp: regexpPlugin,
+      unicorn: unicornPlugin
+    },
+    settings: {
+      jsdoc: {
+        tagNamePreference: {
+          // Our tags
+          "public": "public",
+          "copyDoc": "copyDoc",
+          // Flags
+          "beta": "beta",
+          "experimental": "experimental",
+          "readonly": "readonly",
+          // Metadata
+          "deprecated": "deprecated",
+          "default": "default",
+          "since": "since",
+          "param": "param",
+          "returns": "returns",
+          "see": "see",
+          "esriCompatibilityName": "esriCompatibilityName",
+          // Long descriptions
+          "example": "example",
+          "privateRemarks": "privateRemarks",
+          // Legacy replacements
+          "const": "readonly",
+          "constant": "readonly",
+          "defaultvalue": "default",
+          "return": "returns",
+          // Obsolete tags. Do not use in new code. These are retained for
+          // compatibility with existing non-public Core JSDoc.
+          "amdalias": "amdalias",
+          "autocast": "autocast",
+          "noautocast": "noautocast",
+          "constructonly": "constructonly",
+          "tag constructor": "constructor",
+          "deprecatedParameters": "deprecatedParameters",
+          "deprecatedProperties": "deprecatedProperties",
+          "esmimport": "esmimport",
+          "extends": "extends",
+          "method": "method",
+          "moduletype": "moduletype",
+          "ignoreNilOnly": "ignoreNilOnly"
+        }
+      }
+    },
+    rules: {
+      //#region Temporary Disable monorepo-exclusive rules
+      "@typescript-eslint/adjacent-overload-signatures": "off",
+      "@typescript-eslint/array-type": "off",
+      "@typescript-eslint/await-thenable": "off",
+      "@typescript-eslint/consistent-generic-constructors": "off",
+      "@typescript-eslint/consistent-indexed-object-style": "off",
+      "@typescript-eslint/consistent-type-assertions": "off",
+      "@typescript-eslint/consistent-type-exports": "off",
+      "@typescript-eslint/dot-notation": "off",
+      "@typescript-eslint/max-params": "off",
+      "@typescript-eslint/method-signature-style": "off",
+      "@typescript-eslint/no-confusing-non-null-assertion": "off",
+      "@typescript-eslint/no-deprecated": "off",
+      "@typescript-eslint/no-duplicate-type-constituents": "off",
+      "@typescript-eslint/no-dynamic-delete": "off",
+      "@typescript-eslint/no-empty-function": "off",
+      "@typescript-eslint/no-empty-object-type": "off",
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-extra-non-null-assertion": "off",
+      "@typescript-eslint/no-extraneous-class": "off",
+      "@typescript-eslint/no-implied-eval": "off",
+      "@typescript-eslint/no-inferrable-types": "off",
+      "@typescript-eslint/no-misused-new": "off",
+      "@typescript-eslint/no-misused-spread": "off",
+      "@typescript-eslint/no-non-null-asserted-nullish-coalescing": "off",
+      "@typescript-eslint/no-non-null-asserted-optional-chain": "off",
+      "@typescript-eslint/no-redundant-type-constituents": "off",
+      "@typescript-eslint/no-unnecessary-boolean-literal-compare": "off",
+      "@typescript-eslint/no-unnecessary-condition": "off",
+      "@typescript-eslint/no-unnecessary-template-expression": "off",
+      "@typescript-eslint/no-unnecessary-type-assertion": "off",
+      "@typescript-eslint/no-unnecessary-type-constraint": "off",
+      "@typescript-eslint/no-unnecessary-type-conversion": "off",
+      "@typescript-eslint/no-unsafe-argument": "off",
+      "@typescript-eslint/no-unsafe-assignment": "off",
+      "@typescript-eslint/no-unsafe-call": "off",
+      "@typescript-eslint/no-unsafe-enum-comparison": "off",
+      "@typescript-eslint/no-unsafe-function-type": "off",
+      "@typescript-eslint/no-unsafe-member-access": "off",
+      "@typescript-eslint/no-useless-empty-export": "off",
+      "@typescript-eslint/no-wrapper-object-types": "off",
+      "@typescript-eslint/non-nullable-type-assertion-style": "off",
+      "@typescript-eslint/only-throw-error": "off",
+      "@typescript-eslint/prefer-as-const": "off",
+      "@typescript-eslint/prefer-function-type": "off",
+      "@typescript-eslint/prefer-promise-reject-errors": "off",
+      "@typescript-eslint/prefer-reduce-type-parameter": "off",
+      "@typescript-eslint/prefer-return-this-type": "off",
+      "@typescript-eslint/promise-function-async": "off",
+      "@typescript-eslint/related-getter-setter-pairs": "off",
+      "@typescript-eslint/require-array-sort-compare": "off",
+      "@typescript-eslint/require-await": "off",
+      "@typescript-eslint/restrict-plus-operands": "off",
+      "@typescript-eslint/restrict-template-expressions": "off",
+      "@typescript-eslint/sort-type-constituents": "off",
+      "@typescript-eslint/switch-exhaustiveness-check": "off",
+      "@typescript-eslint/triple-slash-reference": "off",
+      "@typescript-eslint/unified-signatures": "off",
+      "array-callback-return": "off",
+      "default-case-last": "off",
+      "func-names": "off",
+      "func-style": "off",
+      "grouped-accessor-pairs": "off",
+      "id-denylist": "off",
+      "lumina/add-missing-jsx-import": "off",
+      "lumina/auto-add-type": "off",
+      "lumina/component-placement-rules": "off",
+      "lumina/consistent-event-naming": "off",
+      "lumina/consistent-nullability": "off",
+      "lumina/decorators-context": "off",
+      "lumina/explicit-setter-type": "off",
+      "lumina/member-ordering": "off",
+      "lumina/no-create-element-component": "off",
+      "lumina/no-ignore-jsdoc-tag": "off",
+      "lumina/no-incorrect-dynamic-tag-name": "off",
+      "lumina/no-inline-arrow-in-ref": "off",
+      "lumina/no-inline-exposure-jsdoc-tag": "off",
+      "lumina/no-invalid-directives-prop": "off",
+      "lumina/no-jsdoc-xref-links": "off",
+      "lumina/no-jsx-spread": "off",
+      "lumina/no-listen-in-connected-callback": "off",
+      "lumina/no-non-component-exports": "off",
+      "lumina/no-property-name-start-with-on": "off",
+      "lumina/no-render-false": "off",
+      "lumina/no-unnecessary-assertion-on-event": "off",
+      "lumina/no-unnecessary-attribute-name": "off",
+      "lumina/no-unnecessary-bind-this": "off",
+      "lumina/no-unnecessary-key": "off",
+      "lumina/tag-name-rules": "off",
+      "no-alert": "off",
+      "no-await-in-loop": "off",
+      "no-constructor-return": "off",
+      "no-extend-native": "off",
+      "no-extra-bind": "off",
+      "no-loss-of-precision": "off",
+      "no-multi-assign": "off",
+      "no-object-constructor": "off",
+      "no-restricted-syntax": "off",
+      "no-return-assign": "off",
+      "no-script-url": "off",
+      "no-self-compare": "off",
+      "no-sequences": "off",
+      "no-unneeded-ternary": "off",
+      "no-unreachable-loop": "off",
+      "no-unsafe-negation": "off",
+      "no-useless-call": "off",
+      "no-useless-computed-key": "off",
+      "no-useless-concat": "off",
+      "no-warning-comments": "off",
+      "prefer-arrow-callback": "off",
+      "prefer-numeric-literals": "off",
+      "prefer-object-has-own": "off",
+      "prefer-object-spread": "off",
+      "prefer-regex-literals": "off",
+      "prefer-rest-params": "off",
+      "prefer-spread": "off",
+      "prefer-template": "off",
+      "require-atomic-updates": "off",
+      "require-unicode-regexp": "off",
+      "strict": "off",
+      "symbol-description": "off",
+      "unicode-bom": "off",
+      "unicorn/number-literal-case": "off",
+      "webgis/consistent-logging": "off",
+      "webgis/no-dts-files": "off",
+      "webgis/no-import-outside-src": "off",
+      "webgis/no-touching-jsdoc": "off",
+      "webgis/no-unsafe-hash-links": "off",
+      "webgis/require-await-for-async-screenshot-assert": "off",
+      "webgis/require-js-in-imports": "off",
+      "yoda": "off",
+      //#endregion
+      //#region Temporary enable core-exclusive rules
+      "@typescript-eslint/ban-ts-comment": ["error", { "ts-expect-error": false, "ts-nocheck": false }],
+      "@typescript-eslint/consistent-type-definitions": ["error", "interface"],
+      "@typescript-eslint/explicit-function-return-type": ["error", { allowExpressions: true }],
+      "@typescript-eslint/explicit-member-accessibility": ["error", { accessibility: "no-public" }],
+      "@typescript-eslint/naming-convention": [
+        "error",
+        { selector: ["typeLike"], format: ["PascalCase"] },
+        {
+          selector: ["function", "classMethod", "classProperty", "typeMethod"],
+          format: ["camelCase"],
+          leadingUnderscore: "allow"
+        },
+        {
+          selector: ["memberLike", "classProperty"],
+          modifiers: ["private"],
+          format: ["camelCase"],
+          leadingUnderscore: "require"
+        },
+        {
+          selector: ["classProperty"],
+          modifiers: ["static"],
+          format: ["UPPER_CASE", "PascalCase", "camelCase"],
+          leadingUnderscore: "allow"
+        },
+        {
+          selector: ["classProperty"],
+          modifiers: ["private", "static"],
+          format: ["UPPER_CASE", "PascalCase", "camelCase"],
+          leadingUnderscore: "allow"
+        }
+      ],
+      "@typescript-eslint/no-array-constructor": "error",
+      "@typescript-eslint/no-import-type-side-effects": "error",
+      "@typescript-eslint/no-redeclare": "off",
+      // turn on when this doesn't error on mixins
+      "@typescript-eslint/no-require-imports": "error",
+      "@typescript-eslint/no-restricted-imports": [
+        "error",
+        {
+          paths: [
+            { name: "esri/identity/IdentityManager", message: "Use `esri/kernel.id` or the `authMode` option." },
+            {
+              name: "esri/layers/support/rasterFunctionUtils",
+              message: "Import raster function creators directly instead."
+            },
+            {
+              name: "esri/TimeExtent",
+              message: "Use `esri/time/TimeExtent` instead. See https://devtopia.esri.com/WebGIS/arcgis-js-api/issues/49223."
+            },
+            {
+              name: "esri/TimeInterval",
+              message: "Use `esri/time/TimeInterval` instead. See https://devtopia.esri.com/WebGIS/arcgis-js-api/issues/49223."
+            },
+            { name: "esri/rest/geometryService", message: "Import geometry services directly instead" },
+            { name: "esri/rest/geoprocessor", message: "Import geoprocessor exports directly instead" },
+            { name: "esri/rest/locator", message: "Import locator exports directly instead" },
+            { name: "esri/rest/query", message: "use individual files instead" }
+          ],
+          patterns: [
+            {
+              group: ["@esri/calcite-components/dist/components/*"],
+              message: "Pass a dynamic import to `loadCalciteComponents` inside `loadDependencies` instead.",
+              allowTypeImports: true
+            }
+          ]
+        }
+      ],
+      "@typescript-eslint/no-unnecessary-parameter-property-assignment": "error",
+      "@typescript-eslint/no-unused-expressions": ["error", { allowShortCircuit: true, allowTernary: true }],
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          args: "all",
+          argsIgnorePattern: "^_",
+          caughtErrors: "none",
+          destructuredArrayIgnorePattern: "^_",
+          varsIgnorePattern: "^_|^tsx",
+          ignoreRestSiblings: true,
+          enableAutofixRemoval: { imports: true }
+        }
+      ],
+      "@typescript-eslint/prefer-namespace-keyword": "error",
+      "arrow-body-style": "error",
+      "core/glsl-whitespace": "error",
+      "core/imports-format": "error",
+      "core/no-duplicate-import-comments": "error",
+      "core/no-empty-jsdoc-todo": "error",
+      "core/no-redundant-checked-in-files": "error",
+      "core/prefer-relative-imports": "error",
+      "core/require-calcite-import": "error",
+      "curly": "error",
+      "eqeqeq": ["error", "smart"],
+      "import-x/no-duplicates": "error",
+      "import-x/no-dynamic-require": ["error", { esmodule: true }],
+      "import-x/no-restricted-paths": [
+        "error",
+        {
+          // This is temporary. Once most of this config is merged with the
+          // root @arcgis/eslint-config, the core-specific rules can be moved
+          // into @webgis/monorepo-config
+          basePath: join(import.meta.dirname, "../../../../core-packages/core"),
+          zones: [
+            {
+              target: "src",
+              from: "src/identity/IdentityManager.ts",
+              message: "Use `kernel.id` or the `authMode` request option."
+            },
+            {
+              target: "src",
+              from: "src/layers/support/rasterFunctionUtils.ts",
+              message: "Import raster function creators directly instead."
+            },
+            {
+              target: "src",
+              from: "src/rest/geometryService.ts",
+              message: "Import the `geometryService` exports directly instead."
+            },
+            {
+              target: "src",
+              from: "src/rest/geoprocessor.ts",
+              message: "Import the geoprocessor exports directly instead."
+            },
+            {
+              target: "src",
+              from: "src/rest/locator.ts",
+              message: "Import the locator exports directly instead."
+            },
+            {
+              target: "src",
+              from: "src/rest/query.ts",
+              message: "Import the query exports directly instead"
+            },
+            {
+              target: "src",
+              from: "tests",
+              message: "Modules in /src should not import modules in /tests."
+            }
+          ]
+        }
+      ],
+      "import-x/no-useless-path-segments": "error",
+      "jsdoc/check-tag-names": [
+        "error",
+        { definedTags: ["tstype", "ignoreNilOnly", "noautocast", "collectionItemType"] }
+      ],
+      "jsdoc/check-types": "error",
+      // Ensure @readonly and @public is used without any content
+      "jsdoc/empty-tags": "error",
+      // Avoid /**\n ** something */
+      "jsdoc/no-multi-asterisks": ["error", { allowWhitespace: true }],
+      // Enforce each JSDoc line starts with *
+      "jsdoc/require-asterisk-prefix": "error",
+      // Enforce @param has param name
+      "jsdoc/require-param-name": "error",
+      "no-array-constructor": "off",
+      "no-async-promise-executor": "error",
+      "no-caller": "error",
+      "no-case-declarations": "error",
+      "no-cond-assign": "error",
+      "no-constant-binary-expression": "error",
+      "no-control-regex": "error",
+      "no-debugger": "error",
+      "no-duplicate-case": "error",
+      "no-else-return": "error",
+      "no-eval": "error",
+      "no-fallthrough": ["error", { reportUnusedFallthroughComment: false }],
+      "no-implied-eval": "error",
+      "no-inner-declarations": "error",
+      "no-labels": ["error", { allowLoop: true, allowSwitch: true }],
+      "no-new-func": "error",
+      "no-new-wrappers": "error",
+      "no-redeclare": "off",
+      "no-regex-spaces": "error",
+      "no-restricted-globals": ["error", "event", "name", "origin"],
+      "no-shadow-restricted-names": "error",
+      "no-throw-literal": "error",
+      "no-unsafe-finally": "error",
+      "no-unsafe-optional-chaining": "error",
+      "no-unused-expressions": "off",
+      "no-unused-vars": "off",
+      "no-useless-escape": "error",
+      "no-useless-rename": "error",
+      "no-var": "error",
+      "object-shorthand": "error",
+      "one-var": ["error", { initialized: "never" }],
+      "prefer-const": ["error", { destructuring: "all" }],
+      "prefer-exponentiation-operator": "error",
+      "radix": "error",
+      "regexp/control-character-escape": "error",
+      "regexp/no-dupe-characters-character-class": "error",
+      "regexp/no-dupe-disjunctions": "error",
+      "regexp/no-empty-alternative": "error",
+      "regexp/no-empty-capturing-group": "error",
+      "regexp/no-empty-character-class": "error",
+      "regexp/no-empty-group": "error",
+      "regexp/no-empty-lookarounds-assertion": "error",
+      "regexp/no-escape-backspace": "error",
+      "regexp/no-extra-lookaround-assertions": "error",
+      "regexp/no-invalid-regexp": "error",
+      "regexp/no-invisible-character": "error",
+      "regexp/no-lazy-ends": "error",
+      "regexp/no-misleading-unicode-character": "error",
+      "regexp/no-missing-g-flag": "error",
+      "regexp/no-obscure-range": "error",
+      "regexp/no-optional-assertion": "error",
+      "regexp/no-trivially-nested-assertion": "error",
+      "regexp/no-trivially-nested-quantifier": "error",
+      "regexp/no-useless-assertions": "error",
+      "regexp/no-useless-backreference": "error",
+      "regexp/no-useless-character-class": "error",
+      "regexp/no-useless-dollar-replacements": "error",
+      "regexp/no-useless-escape": "error",
+      // adds auto-fix and additional checks compared to `no-useless-escape`
+      "regexp/no-useless-lazy": "error",
+      "regexp/no-useless-quantifier": "error",
+      "regexp/no-useless-range": "error",
+      "regexp/no-useless-set-operand": "error",
+      "regexp/no-useless-string-literal": "error",
+      "regexp/no-useless-two-nums-quantifier": "error",
+      "regexp/optimal-quantifier-concatenation": "error",
+      "regexp/prefer-predefined-assertion": "error",
+      "regexp/prefer-range": "error",
+      "regexp/prefer-set-operation": "error",
+      "unicorn/consistent-date-clone": "error",
+      "unicorn/consistent-empty-array-spread": "error",
+      "unicorn/no-abusive-eslint-disable": "error",
+      "unicorn/no-accessor-recursion": "error",
+      "unicorn/no-await-in-promise-methods": "error",
+      "unicorn/no-instanceof-builtins": "error",
+      "unicorn/no-invalid-remove-event-listener": "error",
+      "unicorn/no-negation-in-equality-check": "error",
+      "unicorn/no-single-promise-in-promise-methods": "error",
+      "unicorn/no-typeof-undefined": "error",
+      "unicorn/no-unnecessary-array-flat-depth": "error",
+      "unicorn/no-unnecessary-array-splice-count": "error",
+      "unicorn/no-unnecessary-slice-end": "error",
+      "unicorn/no-useless-fallback-in-spread": "error",
+      "unicorn/no-useless-length-check": "error",
+      "unicorn/no-useless-promise-resolve-reject": "error",
+      "unicorn/no-useless-spread": "error",
+      "unicorn/no-useless-undefined": ["error", { checkArguments: false, checkArrowFunctionBody: false }],
+      "unicorn/prefer-array-find": "error",
+      "unicorn/prefer-array-flat": "error",
+      "unicorn/prefer-array-flat-map": "error",
+      "unicorn/prefer-array-index-of": "error",
+      "unicorn/prefer-array-some": "error",
+      "unicorn/prefer-blob-reading-methods": "error",
+      "unicorn/prefer-date-now": "error",
+      "unicorn/prefer-default-parameters": "error",
+      "unicorn/prefer-includes": "error",
+      "unicorn/prefer-logical-operator-over-ternary": "error",
+      "unicorn/prefer-negative-index": "error",
+      "unicorn/prefer-node-protocol": "error",
+      "unicorn/prefer-regexp-test": "error",
+      "unicorn/prefer-set-has": "error",
+      "unicorn/prefer-set-size": "error",
+      "unicorn/prefer-string-replace-all": "error",
+      "unicorn/prefer-string-slice": "error",
+      "unicorn/prefer-string-starts-ends-with": "error",
+      "unicorn/throw-new-error": "error",
+      "webgis/consistent-constructor-arguments": "error",
+      "webgis/consistent-mixin-syntax": "error",
+      "webgis/no-empty-catch": "error",
+      "webgis/no-kebab-case-props": "error",
+      "webgis/require-button-type": "error"
+      //#endregion
+    }
+  },
+  {
+    files: ["packages/core-packages/**/*.md"],
+    rules: disabledMarkdownRules
+  },
+  {
+    files: ["packages/core-packages/core/package.json"],
+    rules: {
+      // @typescript/native-preview temporarily uses the `beta` tag rather than a semver range.
+      "package-json/valid-devDependencies": "off"
+    }
+  },
+  {
+    files: ["packages/core-packages/**/*.d.ts"],
+    rules: {
+      "@typescript-eslint/naming-convention": "off"
+      // we can't enforce names in libraries
+    }
+  },
+  {
+    // Type-aware rules
+    files: ["packages/core-packages/**/*.{ts,tsx}"],
+    // This folder runs in node, so uses a separate tsconfig.json
+    ignores: ["packages/core-packages/core/tests/support/vitest/node/**/*.ts"],
+    rules: {
+      // Disabled until https://github.com/typescript-eslint/typescript-eslint/pull/11267 is available.
+      "@typescript-eslint/await-thenable": "off",
+      "@typescript-eslint/no-array-delete": "error",
+      "@typescript-eslint/no-floating-promises": "error",
+      "@typescript-eslint/no-for-in-array": "error",
+      "@typescript-eslint/no-meaningless-void-operator": "error",
+      "@typescript-eslint/no-misused-promises": ["error", { checksVoidReturn: false }],
+      "@typescript-eslint/no-unsafe-unary-minus": "error",
+      "@typescript-eslint/prefer-find": "error",
+      "@typescript-eslint/prefer-includes": "error",
+      "@typescript-eslint/prefer-optional-chain": ["error", { requireNullish: true }],
+      "@typescript-eslint/prefer-string-starts-ends-with": "error",
+      "@typescript-eslint/return-await": ["error", "error-handling-correctness-only"]
+    }
+  },
+  {
+    files: ["packages/core-packages/**/*.tsx"],
+    plugins: {
+      "perfectionist": perfectionistPlugin,
+      "react-jsx": reactJsxPlugin
+    },
+    rules: {
+      "perfectionist/sort-jsx-props": [
+        "error",
+        {
+          groups: ["unknown", "callback"],
+          customGroups: [{ groupName: "callback", elementNamePattern: "^on.+" }]
+        }
+      ],
+      "react-jsx/no-children-prop": "error",
+      "react-jsx/no-comment-textnodes": "error",
+      "react-jsx/no-useless-fragment": "error"
+    }
+  },
+  {
+    files: ["packages/core-packages/core/src/**/*.{ts,tsx}"],
+    rules: {
+      "core/no-invalid-declared-class": "error"
+    }
+  },
+  {
+    files: ["packages/core-packages/core/src/**/*.{ts,tsx}"],
+    ignores: ["packages/core-packages/core/src/**/*.d.ts"],
+    rules: {
+      "no-restricted-syntax": noRestrictedSyntax
+    }
+  },
+  {
+    files: ["packages/core-packages/core/src/**/*.{ts,tsx}"],
+    ignores: ["packages/core-packages/core/src/arcade/**", "packages/core-packages/core/src/widgets/**"],
+    rules: {
+      "webgis/no-instanceof": "error"
+    }
+  },
+  {
+    files: ["packages/core-packages/core/tests/**/*.{ts,tsx}"],
+    rules: {
+      "webgis/no-instanceof": "off",
+      "@typescript-eslint/no-restricted-imports": [
+        "error",
+        {
+          patterns: [
+            {
+              group: ["*.spec", "*.spec.*", "**/*.spec", "**/*.spec.*"],
+              message: "Do not import test suites (.spec) from other tests. Move shared helpers to tests/support (use the test-support/* alias)."
+            }
+          ]
+        }
+      ],
+      "core/spec-suite-filename": "error",
+      "no-restricted-syntax": [
+        ...noRestrictedSyntax,
+        {
+          message: "The { only: true } test option may be used during local testing, but can not be committed.",
+          selector: "CallExpression ObjectExpression Property[key.name='only'][value.value='true']"
+        },
+        {
+          message: "test.only may be used during local testing, but can not be committed.",
+          selector: "CallExpression[callee.type='MemberExpression'][callee.object.name='test'] > MemberExpression.callee > Identifier.property[name='only']"
+        },
+        {
+          message: "The { repeatUntilFailure: true } test option may be used during local testing, but can not be committed.",
+          selector: "CallExpression ObjectExpression Property[key.name='repeatUntilFailure'][value.value='true']"
+        },
+        {
+          message: "test.repeatUntilFailure may be used during local testing, but can not be committed.",
+          selector: "CallExpression[callee.type='MemberExpression'][callee.object.name='test'] > MemberExpression.callee > Identifier.property[name='repeatUntilFailure']"
+        },
+        {
+          selector: "CallExpression MemberExpression[object.name='has'][property.name='add']",
+          message: "Avoid adding has flags manually. Instead use the suite/test-level options to set has flags."
+        }
+      ],
+      "webgis/require-await-for-async-screenshot-assert": "error"
+    }
+  }
+];
+export {
+  eslintConfigCore as default
+};

package/dist/config/index.js

@@ -7,9 +7,12 @@ import { globalIgnores } from "eslint/config";
 import markdown from "@eslint/markdown";
 import packageJson from "eslint-plugin-package-json";
 import { importX } from "eslint-plugin-import-x";
+import { createTypeScriptImportResolver } from "eslint-import-resolver-typescript";
 const packageJsonSortableCollections = packageJson.rules["sort-collections"].meta.defaultOptions[0].filter(
   (collection) => !["scripts", "exports"].includes(collection)
 ) ?? [];
+const importXTypeScriptSettings = { ...importX.flatConfigs.typescript.settings };
+delete importXTypeScriptSettings["import-x/resolver"];
 const config = [
   globalIgnores(["**/www", "**/dist", "**/assets", "**/coverage", "**/.docs"]),
   {
@@ -24,7 +27,13 @@ const config = [
     ...webgisPlugin.configs.recommended,
     files: ["**/*.ts", "**/*.tsx"]
   },
-  importX.flatConfigs.typescript,
+  {
+    ...importX.flatConfigs.typescript,
+    settings: {
+      ...importXTypeScriptSettings,
+      "import-x/resolver-next": [createTypeScriptImportResolver()]
+    }
+  },
   {
     files: ["**/*.ts", "**/*.tsx"],
     linterOptions: {
@@ -145,8 +154,10 @@ const config = [
        * consider refactoring to less confusing syntax instead
        *
        */
-      // Might be intentional, so only a warning
-      "no-await-in-loop": "warn",
+      // Too many false positives. Some cases require sequential execution of
+      // async code for correctness, cleaner output, or to avoid performance
+      // constraints
+      "no-await-in-loop": "off",
       "no-constructor-return": "warn",
       "no-fallthrough": ["error", { reportUnusedFallthroughComment: true }],
       // This mis-fires for anonymous functions when not wrapped in {}
@@ -464,7 +475,10 @@ const config = [
       // rule - give it more time to catch the bug cases. Also, this rule
       // changes runtime behavior, and may lead to breaking changes.
       "@typescript-eslint/no-useless-default-assignment": "off",
-      "@typescript-eslint/no-unnecessary-type-assertion": ["warn"],
+      // Since https://devtopia.esri.com/WebGIS/arcgis-web-components/pull/17821,
+      // this rule has more true positives, but also many more false positives.
+      // The autofix often causes TypeScript errors, and new ESLint errors
+      "@typescript-eslint/no-unnecessary-type-assertion": "off",
       "@typescript-eslint/prefer-includes": ["warn"],
       "@typescript-eslint/prefer-reduce-type-parameter": ["warn"],
       "@typescript-eslint/prefer-return-this-type": ["warn"],

package/dist/{makePlugin-CI0e_JK0.js → makePlugin-CErhRqFB.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "5.2.0-next.50";
+const version = "5.2.0-next.52";
 const packageJson = {
   version
 };

package/dist/plugins/core/index.js

@@ -1,7 +1,9 @@
-import { m as makeEslintPlugin } from "../../makePlugin-CI0e_JK0.js";
+import { m as makeEslintPlugin } from "../../makePlugin-CErhRqFB.js";
 import { AST_NODE_TYPES, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import { generateDifferences, showInvisibles } from "prettier-linter-helpers";
 import path, { relative, win32, posix, normalize } from "path";
+import { dirname, join } from "node:path";
+import { existsSync } from "node:fs";
 import { execSync } from "child_process";
 const plugin = makeEslintPlugin(
   "core",
@@ -96,7 +98,7 @@ function removeTrailingBlankLines(text) {
 function findProjectRoot(filename) {
   const normalized = filename.replaceAll("\\", "/");
   let minimumIndex = Number.POSITIVE_INFINITY;
-  for (const marker of ["src/", "tests/", "test-apps/", "esri/"]) {
+  for (const marker of ["src/", "tests/", "test-apps/", "esri/", ".github/"]) {
     const index = normalized.indexOf(marker);
     if (index === 0) {
       return ".";
@@ -104,7 +106,17 @@ function findProjectRoot(filename) {
       minimumIndex = Math.min(minimumIndex, index);
     }
   }
-  return minimumIndex === Number.POSITIVE_INFINITY ? void 0 : normalized.slice(0, minimumIndex);
+  if (minimumIndex !== Number.POSITIVE_INFINITY) {
+    return normalized.slice(0, minimumIndex);
+  }
+  const fileToFind = "package.json";
+  for (let root = dirname(filename), previousRoot = filename; root !== previousRoot; previousRoot = root, root = dirname(root)) {
+    const filepath = join(root, fileToFind);
+    if (existsSync(filepath)) {
+      return root;
+    }
+  }
+  return;
 }
 const slashCharCode = 47;
 const isWindows = process.platform === "win32";
@@ -577,8 +589,15 @@ plugin.createRule({
   }
 });
 function pathRoot(p) {
-  const dirName = path.dirname(p);
-  return dirName === "." ? p : pathRoot(dirName);
+  const pathImplementation = win32.isAbsolute(p) && !posix.isAbsolute(p) ? win32 : path;
+  let root = p;
+  while (true) {
+    const parent = pathImplementation.dirname(root);
+    if (parent === "." || parent === root) {
+      return root;
+    }
+    root = parent;
+  }
 }
 function verifyRelativeImport(context, node, absImportPath, basePath, importRoot) {
   const modulePath = node.value;

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-CI0e_JK0.js";
+import { m as makeEslintPlugin } from "../../makePlugin-CErhRqFB.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import { l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, d as isCreateEvent, h as hasDecorator, f as getName, j as checkForLuminaJsx, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-CDc-die8.js";
 import ts from "typescript";

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-CI0e_JK0.js";
+import { m as makeEslintPlugin } from "../../makePlugin-CErhRqFB.js";
 import { TSESTree, AST_TOKEN_TYPES, AST_NODE_TYPES, TSESLint } from "@typescript-eslint/utils";
 import path from "node:path";
 import { resolve } from "path/posix";

package/dist/utils/disableRules.d.ts

@@ -4,7 +4,8 @@ import type { TSESLint } from "@typescript-eslint/utils";
  * A utility for temporary running ESLint with only specific rules enabled.
  *
  * @param config - flat config
- * @param enabledRules - exceptions
+ * @param enabledRules - exceptions. Set a rule to `true` to preserve existing
+ * configuration
  * @param disableTypeChecking - make ESLint much faster by temporary disabling
  * type-aware linting.
  * @returns a new flat config array where every rule is disabled,
@@ -21,4 +22,4 @@ import type { TSESLint } from "@typescript-eslint/utils";
  *   true,
  * );
  */
-export function disableAllRulesExcept(config: TSESLint.FlatConfig.ConfigArray, enabledRules: Record<string, TSESLint.FlatConfig.RuleLevel>, disableTypeChecking: boolean): TSESLint.FlatConfig.ConfigArray;
+export function disableAllRulesExcept(config: TSESLint.FlatConfig.ConfigArray, enabledRules: Partial<Record<string, TSESLint.FlatConfig.RuleEntry | true>>, disableTypeChecking: boolean): TSESLint.FlatConfig.ConfigArray;

package/dist/utils/disableRules.js

@@ -10,7 +10,7 @@ function applyRulesAndOptions(entry, enabledRules, disableTypeChecking) {
     rules: Object.fromEntries(
       Object.keys(entry.rules).map((ruleName) => {
         const override = enabledRules[ruleName];
-        return [ruleName, override ?? "off"];
+        return [ruleName, override === true ? entry.rules[ruleName] : override ?? "off"];
       })
     )
   } : entry;

package/package.json

@@ -1,11 +1,12 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "5.2.0-next.50",
+  "version": "5.2.0-next.52",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "exports": {
     ".": "./dist/config/index.js",
     "./application": "./dist/config/applications.js",
+    "./core": "./dist/config/core.js",
     "./extra": "./dist/config/extra.js",
     "./lumina": "./dist/config/lumina.js",
     "./plugins/core": "./dist/plugins/core/index.js",
@@ -27,15 +28,20 @@
     "confusing-browser-globals": "^1.0.11",
     "eslint-import-resolver-typescript": "^4.4.5",
     "eslint-plugin-import-x": "^4.17.1",
+    "eslint-plugin-jsdoc": "~63.0.13",
     "eslint-plugin-package-json": "~0.91.1",
+    "eslint-plugin-perfectionist": "~5.10.0",
+    "eslint-plugin-react-jsx": "~5.11.2",
+    "eslint-plugin-regexp": "~3.1.1",
     "eslint-plugin-storybook": "^10.3.4",
+    "eslint-plugin-unicorn": "~64.0.0",
     "globals": "^16.5.0",
     "jsonc-eslint-parser": "^3.1.0",
     "prettier-linter-helpers": "^1.0.1",
     "tslib": "^2.8.1",
     "typescript": "~6.0.3",
     "typescript-eslint": "^8.63.0",
-    "@arcgis/toolkit": "5.2.0-next.50"
+    "@arcgis/toolkit": "5.2.0-next.52"
   },
   "peerDependencies": {
     "eslint": "^10.6.0"