@arcgis/eslint-config 5.2.0-next.50 → 5.2.0-next.51

package/dist/config/applications.js

@@ -28,8 +28,6 @@ const config = [
       "func-names": "off",
       // This rule is for consistency between library developers - less important for monolith apps.
       "id-denylist": "off",
-      // Some cases actually require sequential async loops
-      "no-await-in-loop": "off",
       // More important for library-exposed symbols than apps
       "symbol-description": "off"
     }

package/dist/config/index.js

@@ -145,8 +145,10 @@ const config = [
        * consider refactoring to less confusing syntax instead
        *
        */
-      // Might be intentional, so only a warning
-      "no-await-in-loop": "warn",
+      // Too many false positives. Some cases require sequential execution of
+      // async code for correctness, cleaner output, or to avoid performance
+      // constraints
+      "no-await-in-loop": "off",
       "no-constructor-return": "warn",
       "no-fallthrough": ["error", { reportUnusedFallthroughComment: true }],
       // This mis-fires for anonymous functions when not wrapped in {}
@@ -464,7 +466,10 @@ const config = [
       // rule - give it more time to catch the bug cases. Also, this rule
       // changes runtime behavior, and may lead to breaking changes.
       "@typescript-eslint/no-useless-default-assignment": "off",
-      "@typescript-eslint/no-unnecessary-type-assertion": ["warn"],
+      // Since https://devtopia.esri.com/WebGIS/arcgis-web-components/pull/17821,
+      // this rule has more true positives, but also many more false positives.
+      // The autofix often causes TypeScript errors, and new ESLint errors
+      "@typescript-eslint/no-unnecessary-type-assertion": "off",
       "@typescript-eslint/prefer-includes": ["warn"],
       "@typescript-eslint/prefer-reduce-type-parameter": ["warn"],
       "@typescript-eslint/prefer-return-this-type": ["warn"],

package/dist/{makePlugin-CI0e_JK0.js → makePlugin-DwtvWDJv.js}

@@ -1,5 +1,5 @@
 import { ESLintUtils } from "@typescript-eslint/utils";
-const version = "5.2.0-next.50";
+const version = "5.2.0-next.51";
 const packageJson = {
   version
 };

package/dist/plugins/core/index.js

@@ -1,7 +1,9 @@
-import { m as makeEslintPlugin } from "../../makePlugin-CI0e_JK0.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DwtvWDJv.js";
 import { AST_NODE_TYPES, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import { generateDifferences, showInvisibles } from "prettier-linter-helpers";
 import path, { relative, win32, posix, normalize } from "path";
+import { dirname, join } from "node:path";
+import { existsSync } from "node:fs";
 import { execSync } from "child_process";
 const plugin = makeEslintPlugin(
   "core",
@@ -96,7 +98,7 @@ function removeTrailingBlankLines(text) {
 function findProjectRoot(filename) {
   const normalized = filename.replaceAll("\\", "/");
   let minimumIndex = Number.POSITIVE_INFINITY;
-  for (const marker of ["src/", "tests/", "test-apps/", "esri/"]) {
+  for (const marker of ["src/", "tests/", "test-apps/", "esri/", ".github/"]) {
     const index = normalized.indexOf(marker);
     if (index === 0) {
       return ".";
@@ -104,7 +106,17 @@ function findProjectRoot(filename) {
       minimumIndex = Math.min(minimumIndex, index);
     }
   }
-  return minimumIndex === Number.POSITIVE_INFINITY ? void 0 : normalized.slice(0, minimumIndex);
+  if (minimumIndex !== Number.POSITIVE_INFINITY) {
+    return normalized.slice(0, minimumIndex);
+  }
+  const fileToFind = "package.json";
+  for (let root = dirname(filename), previousRoot = filename; root !== previousRoot; previousRoot = root, root = dirname(root)) {
+    const filepath = join(root, fileToFind);
+    if (existsSync(filepath)) {
+      return root;
+    }
+  }
+  return;
 }
 const slashCharCode = 47;
 const isWindows = process.platform === "win32";

package/dist/plugins/lumina/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-CI0e_JK0.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DwtvWDJv.js";
 import { AST_NODE_TYPES, ESLintUtils, AST_TOKEN_TYPES } from "@typescript-eslint/utils";
 import { l as luminaJsxExportName, a as luminaEntrypointName, b as luminaTestEntrypointName, s as sourceCodeDeclaresComponent, p as parsePropertyDecorator, c as getProperty, i as isGetterWithoutSetter, e as extractDeclareElementsInterface, d as isCreateEvent, h as hasDecorator, f as getName, j as checkForLuminaJsx, k as isBindThisCallee, g as getComponentDeclaration, u as unwrapExpression } from "../../estree-CDc-die8.js";
 import ts from "typescript";

package/dist/plugins/webgis/index.js

@@ -1,4 +1,4 @@
-import { m as makeEslintPlugin } from "../../makePlugin-CI0e_JK0.js";
+import { m as makeEslintPlugin } from "../../makePlugin-DwtvWDJv.js";
 import { TSESTree, AST_TOKEN_TYPES, AST_NODE_TYPES, TSESLint } from "@typescript-eslint/utils";
 import path from "node:path";
 import { resolve } from "path/posix";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@arcgis/eslint-config",
-  "version": "5.2.0-next.50",
+  "version": "5.2.0-next.51",
   "description": "ESLint configuration for WebGIS SDK",
   "type": "module",
   "exports": {
@@ -35,7 +35,7 @@
     "tslib": "^2.8.1",
     "typescript": "~6.0.3",
     "typescript-eslint": "^8.63.0",
-    "@arcgis/toolkit": "5.2.0-next.50"
+    "@arcgis/toolkit": "5.2.0-next.51"
   },
   "peerDependencies": {
     "eslint": "^10.6.0"