@arcgis/eslint-config 5.2.0-next.5 → 5.2.0-next.51

package/dist/config/applications.d.ts

@@ -1,3 +1,4 @@
-import { TSESLint } from '@typescript-eslint/utils';
-declare const _default: TSESLint.FlatConfig.Config[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/applications.js

@@ -1,6 +1,6 @@
-import config from "./index.js";
-const applications = [
-  ...config,
+import config$1 from "./index.js";
+const config = [
+  ...config$1,
   {
     rules: {
       // Not autofixable. Can be annoying
@@ -28,13 +28,11 @@ const applications = [
       "func-names": "off",
       // This rule is for consistency between library developers - less important for monolith apps.
       "id-denylist": "off",
-      // Some cases actually require sequential async loops
-      "no-await-in-loop": "off",
       // More important for library-exposed symbols than apps
       "symbol-description": "off"
     }
   }
 ];
 export {
-  applications as default
+  config as default
 };

package/dist/config/extra.d.ts

@@ -1,24 +1,4 @@
-/**
- * In addition to the main config (index.js), which contains the recommended
- * rules that should be enabled all the time, these are some additional rules
- * that can be run from time to time. These are not always on either because
- * they have too many false positives or are too slow.
- */
-declare const _default: {
-    files: string[];
-    rules: {
-        "@typescript-eslint/no-unsafe-return": "warn";
-        "@typescript-eslint/unbound-method": "warn";
-        "class-methods-use-this": "off";
-        "@typescript-eslint/class-methods-use-this": ["warn", {
-            ignoreOverrideMethods: boolean;
-            ignoreClassesThatImplementAnInterface: string;
-        }];
-        /**
-         * False positive when constructor exists to improve typing/narrow down the
-         * type
-         */
-        "@typescript-eslint/no-useless-constructor": "warn";
-    };
-}[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/extra.js

@@ -1,4 +1,4 @@
-const extra = [
+const config = [
   {
     files: ["**/*.ts", "**/*.tsx"],
     rules: {
@@ -31,5 +31,5 @@ const extra = [
   }
 ];
 export {
-  extra as default
+  config as default
 };

package/dist/config/index.d.ts

@@ -1,3 +1,4 @@
-import { TSESLint } from '@typescript-eslint/utils';
+import type { TSESLint } from "@typescript-eslint/utils";
+
 declare const config: TSESLint.FlatConfig.ConfigArray;
-export default config;
+export default config;

package/dist/config/index.js

@@ -145,8 +145,10 @@ const config = [
        * consider refactoring to less confusing syntax instead
        *
        */
-      // Might be intentional, so only a warning
-      "no-await-in-loop": "warn",
+      // Too many false positives. Some cases require sequential execution of
+      // async code for correctness, cleaner output, or to avoid performance
+      // constraints
+      "no-await-in-loop": "off",
       "no-constructor-return": "warn",
       "no-fallthrough": ["error", { reportUnusedFallthroughComment: true }],
       // This mis-fires for anonymous functions when not wrapped in {}
@@ -181,11 +183,11 @@ const config = [
         "index",
         {
           name: "isNaN",
-          message: "Use Number.isNaN instead as it has more predictable behavior. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN#description"
+          message: "Use Number.isNaN instead as it has more predictable behavior. See https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/isNaN#description"
         },
         {
           name: "isFinite",
-          message: "Use Number.isFinite instead as it has more predictable behavior. See https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/isNaN#description (same applies to isFinite)"
+          message: "Use Number.isFinite instead as it has more predictable behavior. See https://developer.mozilla.org/docs/Web/JavaScript/Reference/Global_Objects/isNaN#description (same applies to isFinite)"
         },
         {
           name: "parseInt",
@@ -464,7 +466,10 @@ const config = [
       // rule - give it more time to catch the bug cases. Also, this rule
       // changes runtime behavior, and may lead to breaking changes.
       "@typescript-eslint/no-useless-default-assignment": "off",
-      "@typescript-eslint/no-unnecessary-type-assertion": ["warn"],
+      // Since https://devtopia.esri.com/WebGIS/arcgis-web-components/pull/17821,
+      // this rule has more true positives, but also many more false positives.
+      // The autofix often causes TypeScript errors, and new ESLint errors
+      "@typescript-eslint/no-unnecessary-type-assertion": "off",
       "@typescript-eslint/prefer-includes": ["warn"],
       "@typescript-eslint/prefer-reduce-type-parameter": ["warn"],
       "@typescript-eslint/prefer-return-this-type": ["warn"],

package/dist/config/lumina.d.ts

@@ -1,3 +1,4 @@
-import { TSESLint } from '@typescript-eslint/utils';
-declare const _default: TSESLint.FlatConfig.Config[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/lumina.js

@@ -4,16 +4,16 @@ const storybookConfig = [
   {
     ignores: ["**/storybook-static*"]
   },
-  ...eslintPluginStorybook.configs["flat/recommended"].map((config) => ({
-    ...config,
+  ...eslintPluginStorybook.configs["flat/recommended"].map((config2) => ({
+    ...config2,
     files: ["**/*.stories.@(ts|tsx)"]
   })),
-  ...eslintPluginStorybook.configs["flat/addon-interactions"].map((config) => ({
-    ...config,
+  ...eslintPluginStorybook.configs["flat/addon-interactions"].map((config2) => ({
+    ...config2,
     files: ["**/*.stories.@(ts|tsx)"]
   })),
-  ...eslintPluginStorybook.configs["flat/csf-strict"].map((config) => ({
-    ...config,
+  ...eslintPluginStorybook.configs["flat/csf-strict"].map((config2) => ({
+    ...config2,
     files: ["**/*.stories.@(ts|tsx)"]
   })),
   {
@@ -42,7 +42,7 @@ const storybookConfig = [
     }
   }
 ];
-const lumina = [
+const config = [
   ...storybookConfig,
   {
     ...luminaPlugin.configs.recommended,
@@ -218,5 +218,5 @@ declare global {
   },*/
 ];
 export {
-  lumina as default
+  config as default
 };

package/dist/{estree-C35TbJCf.js → estree-CDc-die8.js}

@@ -1,41 +1,4 @@
-import { ESLintUtils, AST_NODE_TYPES } from "@typescript-eslint/utils";
-const version = "5.2.0-next.5";
-const packageJson = {
-  version
-};
-function makeEslintPlugin(pluginName, urlCreator) {
-  const rules = [];
-  const creator = ESLintUtils.RuleCreator(urlCreator);
-  return {
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
-    createRule(rule) {
-      const { meta, name, ...rest } = rule;
-      const docs = { ...meta.docs, name };
-      const ruleModule = creator({ ...rest, meta: { ...meta, docs }, name });
-      rules.push(ruleModule);
-      return ruleModule;
-    },
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
-    finalize() {
-      const config = {
-        rules: Object.fromEntries(
-          rules.map((rule) => [`${pluginName}/${rule.meta.docs.name}`, rule.meta.docs.defaultLevel])
-        )
-      };
-      const plugin = {
-        meta: { name: `@arcgis/eslint-plugin-${pluginName}`, version: packageJson.version },
-        configs: {
-          recommended: config
-        },
-        rules: Object.fromEntries(rules.map((rule) => [rule.meta.docs.name, rule]))
-      };
-      config.plugins = {
-        [pluginName]: plugin
-      };
-      return plugin;
-    }
-  };
-}
+import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const unwrapExpression = (expression) => expression.type === AST_NODE_TYPES.TSAsExpression || expression.type === AST_NODE_TYPES.TSNonNullExpression || expression.type === AST_NODE_TYPES.TSSatisfiesExpression ? unwrapExpression(expression.expression) : expression;
 const luminaEntrypointName = "@arcgis/lumina";
 const luminaTestEntrypointName = "@arcgis/lumina-compiler/testing";
@@ -154,7 +117,6 @@ export {
   checkForLuminaJsx as j,
   isBindThisCallee as k,
   luminaJsxExportName as l,
-  makeEslintPlugin as m,
   parsePropertyDecorator as p,
   sourceCodeDeclaresComponent as s,
   unwrapExpression as u

package/dist/makePlugin-DwtvWDJv.js

@@ -0,0 +1,41 @@
+import { ESLintUtils } from "@typescript-eslint/utils";
+const version = "5.2.0-next.51";
+const packageJson = {
+  version
+};
+function makeEslintPlugin(pluginName, urlCreator) {
+  const rules = [];
+  const creator = ESLintUtils.RuleCreator(urlCreator);
+  return {
+    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+    createRule(rule) {
+      const { meta, name, ...rest } = rule;
+      const docs = { ...meta.docs, name };
+      const ruleModule = creator({ ...rest, meta: { ...meta, docs }, name });
+      rules.push(ruleModule);
+      return ruleModule;
+    },
+    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+    finalize() {
+      const config = {
+        rules: Object.fromEntries(
+          rules.map((rule) => [`${pluginName}/${rule.meta.docs.name}`, rule.meta.docs.defaultLevel])
+        )
+      };
+      const plugin = {
+        meta: { name: `@arcgis/eslint-plugin-${pluginName}`, version: packageJson.version },
+        configs: {
+          recommended: config
+        },
+        rules: Object.fromEntries(rules.map((rule) => [rule.meta.docs.name, rule]))
+      };
+      config.plugins = {
+        [pluginName]: plugin
+      };
+      return plugin;
+    }
+  };
+}
+export {
+  makeEslintPlugin as m
+};

package/dist/plugins/core/index.d.ts

@@ -0,0 +1,4 @@
+import type { EslintPlugin } from "../utils/makePlugin.js";
+
+/** Rules specific to \@arcgis/core */
+export const corePlugin: EslintPlugin;