@arcgis/eslint-config 5.2.0-next.0 → 5.2.0-next.10

package/dist/config/applications.d.ts

@@ -1,10 +1,4 @@
-/**
- * While the main index.js config strives to be comprehensive, this config
- * disables rules that are less important for applications compared to libraries.
- */
-declare const _default: (import('eslint/config').Config | {
-    files: string[];
-    name?: string;
-    rules?: object;
-})[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/applications.js

@@ -1,6 +1,6 @@
-import defaultConfig from "./index.js";
-const applications = [
-  ...defaultConfig,
+import config$1 from "./index.js";
+const config = [
+  ...config$1,
   {
     rules: {
       // Not autofixable. Can be annoying
@@ -36,5 +36,5 @@ const applications = [
   }
 ];
 export {
-  applications as default
+  config as default
 };

package/dist/config/extra.d.ts

@@ -1,24 +1,4 @@
-/**
- * In addition to the main config (index.js), which contains the recommended
- * rules that should be enabled all the time, these are some additional rules
- * that can be run from time to time. These are not always on either because
- * they have too many false positives or are too slow.
- */
-declare const _default: {
-    files: string[];
-    rules: {
-        "@typescript-eslint/no-unsafe-return": "warn";
-        "@typescript-eslint/unbound-method": "warn";
-        "class-methods-use-this": "off";
-        "@typescript-eslint/class-methods-use-this": ["warn", {
-            ignoreOverrideMethods: boolean;
-            ignoreClassesThatImplementAnInterface: string;
-        }];
-        /**
-         * False positive when constructor exists to improve typing/narrow down the
-         * type
-         */
-        "@typescript-eslint/no-useless-constructor": "warn";
-    };
-}[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/extra.js

@@ -1,4 +1,4 @@
-const extra = [
+const config = [
   {
     files: ["**/*.ts", "**/*.tsx"],
     rules: {
@@ -31,5 +31,5 @@ const extra = [
   }
 ];
 export {
-  extra as default
+  config as default
 };

package/dist/config/index.d.ts

@@ -1,23 +1,4 @@
-/**
- * See setup documentation & rationale behind ESLint:
- * https://webgis.esri.com/references/support-packages/eslint
- *
- * Some advice on editing rules:
- * - prioritize autofixable rules to make adoption in existing codebases easier
- * - disable redundant rules (rules redundant with TypeScript, or each other),
- *   to reduce noise and performance impact
- * - if rule is always auto-fixable, it may be a good idea to emit it as a
- *   warning instead of an error to be less disruptive when the developer is
- *   typing code
- * - emit rules that have a lot of false positives as warnings instead of errors
- * - provide justification for enabling opinionated rules
- * - provide justification for disabling default rules
- * - if rule is disabled because it's buggy, describe how so
- *   (code sample, GitHub issue, permalink to file, etc)
- */
-declare const _default: (import('eslint/config').Config | {
-    files: string[];
-    name?: string;
-    rules?: object;
-})[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/index.js

@@ -6,23 +6,25 @@ import { webgisPlugin } from "../plugins/webgis/index.js";
 import { globalIgnores } from "eslint/config";
 import markdown from "@eslint/markdown";
 import packageJson from "eslint-plugin-package-json";
+import { importX } from "eslint-plugin-import-x";
 const packageJsonSortableCollections = packageJson.rules["sort-collections"].meta.defaultOptions[0].filter(
   (collection) => !["scripts", "exports"].includes(collection)
 ) ?? [];
-const defaultConfig = [
+const config = [
   globalIgnores(["**/www", "**/dist", "**/assets", "**/coverage", "**/.docs"]),
   {
     files: ["**/*.js", "**/*.mjs", "**/*.cjs"],
     ...eslint.configs.recommended
   },
-  ...[...tsEslint.configs.strictTypeChecked, ...tsEslint.configs.stylisticTypeChecked].map((config) => ({
-    ...config,
+  ...[...tsEslint.configs.strictTypeChecked, ...tsEslint.configs.stylisticTypeChecked].map((config2) => ({
+    ...config2,
     files: ["**/*.ts", "**/*.tsx"]
   })),
   {
     ...webgisPlugin.configs.recommended,
     files: ["**/*.ts", "**/*.tsx"]
   },
+  importX.flatConfigs.typescript,
   {
     files: ["**/*.ts", "**/*.tsx"],
     linterOptions: {
@@ -353,17 +355,14 @@ const defaultConfig = [
        */
       "@typescript-eslint/no-this-alias": "off",
       "no-warning-comments": [
-        // TODO: consider forbidding TODO in favor of BUG, HACK, REFACTOR, FEATURE,
-        //   LOW, TEST, PERF. Then can configure IDE to assign different colors to
-        //   each of those
         "error",
         {
-          // By emitting error for these TODOs, you can use them for things you
-          // want to do in the current commit (since they will be reported as
-          // an error by pre-commit hook). Convenient for not-forgetting to do
-          // something
+          // This will error for // ME: comments. This is convenient to write
+          // temporary TODOs that ESLint will remind you to resolve before the
+          // pull request is merged.
           terms: ["ME"],
-          location: "anywhere"
+          location: "start",
+          decoration: ["/", "*", ">"]
         }
       ],
       // Autofixable, so warn to be less disruptive
@@ -653,5 +652,5 @@ const defaultConfig = [
   }
 ];
 export {
-  defaultConfig as default
+  config as default
 };

package/dist/config/lumina.d.ts

@@ -1,3 +1,4 @@
-import { TSESLint } from '@typescript-eslint/utils';
-declare const _default: TSESLint.FlatConfig.Config[];
-export default _default;
+import type { TSESLint } from "@typescript-eslint/utils";
+
+declare const config: TSESLint.FlatConfig.ConfigArray;
+export default config;

package/dist/config/lumina.js

@@ -4,16 +4,16 @@ const storybookConfig = [
   {
     ignores: ["**/storybook-static*"]
   },
-  ...eslintPluginStorybook.configs["flat/recommended"].map((config) => ({
-    ...config,
+  ...eslintPluginStorybook.configs["flat/recommended"].map((config2) => ({
+    ...config2,
     files: ["**/*.stories.@(ts|tsx)"]
   })),
-  ...eslintPluginStorybook.configs["flat/addon-interactions"].map((config) => ({
-    ...config,
+  ...eslintPluginStorybook.configs["flat/addon-interactions"].map((config2) => ({
+    ...config2,
     files: ["**/*.stories.@(ts|tsx)"]
   })),
-  ...eslintPluginStorybook.configs["flat/csf-strict"].map((config) => ({
-    ...config,
+  ...eslintPluginStorybook.configs["flat/csf-strict"].map((config2) => ({
+    ...config2,
     files: ["**/*.stories.@(ts|tsx)"]
   })),
   {
@@ -42,7 +42,7 @@ const storybookConfig = [
     }
   }
 ];
-const lumina = [
+const config = [
   ...storybookConfig,
   {
     ...luminaPlugin.configs.recommended,
@@ -218,5 +218,5 @@ declare global {
   },*/
 ];
 export {
-  lumina as default
+  config as default
 };

package/dist/{estree-D4NC8KvY.js → estree-CDc-die8.js}

@@ -1,41 +1,4 @@
-import { ESLintUtils, AST_NODE_TYPES } from "@typescript-eslint/utils";
-const version = "5.2.0-next.0";
-const packageJson = {
-  version
-};
-function makeEslintPlugin(pluginName, urlCreator) {
-  const rules = [];
-  const creator = ESLintUtils.RuleCreator(urlCreator);
-  return {
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
-    createRule(rule) {
-      const { meta, name, ...rest } = rule;
-      const docs = { ...meta.docs, name };
-      const ruleModule = creator({ ...rest, meta: { ...meta, docs }, name });
-      rules.push(ruleModule);
-      return ruleModule;
-    },
-    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
-    finalize() {
-      const config = {
-        rules: Object.fromEntries(
-          rules.map((rule) => [`${pluginName}/${rule.meta.docs.name}`, rule.meta.docs.defaultLevel])
-        )
-      };
-      const plugin = {
-        meta: { name: `@arcgis/eslint-plugin-${pluginName}`, version: packageJson.version },
-        configs: {
-          recommended: config
-        },
-        rules: Object.fromEntries(rules.map((rule) => [rule.meta.docs.name, rule]))
-      };
-      config.plugins = {
-        [pluginName]: plugin
-      };
-      return plugin;
-    }
-  };
-}
+import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 const unwrapExpression = (expression) => expression.type === AST_NODE_TYPES.TSAsExpression || expression.type === AST_NODE_TYPES.TSNonNullExpression || expression.type === AST_NODE_TYPES.TSSatisfiesExpression ? unwrapExpression(expression.expression) : expression;
 const luminaEntrypointName = "@arcgis/lumina";
 const luminaTestEntrypointName = "@arcgis/lumina-compiler/testing";
@@ -154,7 +117,6 @@ export {
   checkForLuminaJsx as j,
   isBindThisCallee as k,
   luminaJsxExportName as l,
-  makeEslintPlugin as m,
   parsePropertyDecorator as p,
   sourceCodeDeclaresComponent as s,
   unwrapExpression as u

package/dist/makePlugin-CrKnVbDO.js

@@ -0,0 +1,41 @@
+import { ESLintUtils } from "@typescript-eslint/utils";
+const version = "5.2.0-next.10";
+const packageJson = {
+  version
+};
+function makeEslintPlugin(pluginName, urlCreator) {
+  const rules = [];
+  const creator = ESLintUtils.RuleCreator(urlCreator);
+  return {
+    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+    createRule(rule) {
+      const { meta, name, ...rest } = rule;
+      const docs = { ...meta.docs, name };
+      const ruleModule = creator({ ...rest, meta: { ...meta, docs }, name });
+      rules.push(ruleModule);
+      return ruleModule;
+    },
+    // eslint-disable-next-line @typescript-eslint/explicit-function-return-type
+    finalize() {
+      const config = {
+        rules: Object.fromEntries(
+          rules.map((rule) => [`${pluginName}/${rule.meta.docs.name}`, rule.meta.docs.defaultLevel])
+        )
+      };
+      const plugin = {
+        meta: { name: `@arcgis/eslint-plugin-${pluginName}`, version: packageJson.version },
+        configs: {
+          recommended: config
+        },
+        rules: Object.fromEntries(rules.map((rule) => [rule.meta.docs.name, rule]))
+      };
+      config.plugins = {
+        [pluginName]: plugin
+      };
+      return plugin;
+    }
+  };
+}
+export {
+  makeEslintPlugin as m
+};

package/dist/plugins/core/index.d.ts

@@ -0,0 +1,4 @@
+import type { EslintPlugin } from "../utils/makePlugin.js";
+
+/** Rules specific to \@arcgis/core */
+export const corePlugin: EslintPlugin;